GitLab

He's changing teams :'(

NOTRY=true
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/391293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/399433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283619 0039d316-1c4b-4281-b951-d872f2087c98

TBR=earthdok@chromium.org
BUG=340752

Review URL: https://codereview.chromium.org/398053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283615 0039d316-1c4b-4281-b951-d872f2087c98

Blech: Stuff fails. Shockingly.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/27268/steps/mojo_shell_tests/logs/stdio

> Mojo: Enable mojo_shell_tests on Windows (on the bots).
> 
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/398023002

TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/398253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283610 0039d316-1c4b-4281-b951-d872f2087c98

ASan failure (use-after-free) looks like it's due to this change):

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

E.g.:

@@@STEP_LOG_LINE@ReloadEmbedder@SUMMARY: AddressSanitizer: heap-use-after-free content/renderer/render_frame_proxy.cc:168 content::RenderFrameProxy::OnMessageReceived(IPC::Message const&)@@@j

> Changes to RenderFrameProxy:
> 
> - Add accessors: web_frame(), routing_id(), render_view().
> - Remove accessor: render_frame(). Where we do need to touch the
>   RenderFrame, we'll look it up by its routing ID.
> - Small change to the CompositingHelper to use the new getters.
> - Add a map to allow finding a RenderFrameProxy by its associated
>   blink::WebFrame.
> - Introduce a second factory function and differentiate the two
>   factory functions according to the two ways RenderFrameProxies will
>   be created. The first is for when an extant local RenderFrame is
>   being swapped out and replaced with a new RenderFrameProxy. The
>   second is for when a RenderFrameProxy needs to be created without
>   displacing an existing RenderFrame, as shall occur once we mirror
>   the frame tree.
> - This second factory function, which is uncalled at the moment, will
>   create WebRemoteFrames. Also there is stubbed out code in the first
>   factory function to create WebRemoteFrames. This code is in
>   preparation for eliminating the RenderFrame (and its attendant
>   WebLocalFrame) and having instead just a RenderFrameProxy.
> - Add some defensive checks to prepare for when the render frame may
>   not exist, as will happen once the second factory function
>   enters use.
> - Add an Init function so that code can be shared between the two
>   factory functions.
> 
> As an adminstrative note, this patch is a chunk of nasko's 
> larger "use RenderFrameProxyHost" effor (issue 241223002)
> 
> BUG=357747
> TEST=browsertests, http://csreis.github.io/tests/cross-site-iframe.html renders after going cross-site under --site-per-process
> 
> Review URL: https://codereview.chromium.org/357043006

TBR=nick@chromium.org

Review URL: https://codereview.chromium.org/397103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283608 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally left this out from r283441.

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/394263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283606 0039d316-1c4b-4281-b951-d872f2087c98

Per review comment from https://codereview.chromium.org/398553002/. Note
that I'm keeping the |pass| and deleting the redundant assignment (so
now the |pass| is required). The alternative would be to nest the other
|if|s inside an |if ... is not None|, but I find that harder to read.

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/396243006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283605 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/395243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283601 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/395203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283600 0039d316-1c4b-4281-b951-d872f2087c98

The PrerenderOmniboxAbandon test fails with a command line that is too long
for the windows RegisterApplicationRestart API.

TBR=mmenke@chromium.org,gavinp@chromium.org

NOTRY=true

BUG=394592

Review URL: https://codereview.chromium.org/400493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283599 0039d316-1c4b-4281-b951-d872f2087c98

Some files were compiled for both remoting_host and remoting_core. Also
moved some files to remoting_host so that they don't need to be listed
multiple times for different platforms

Review URL: https://codereview.chromium.org/393073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393388
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/396063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283595 0039d316-1c4b-4281-b951-d872f2087c98

oobe-skip-postlogin has been overloaded and it does a lot more than just suppress the postlogin screens.

We need session restore/merge and enrollment for gaia login, but not for fake telemetry login.

BUG=393011
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/384973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283594 0039d316-1c4b-4281-b951-d872f2087c98

Previously, infobars were shown at the bottom of the screen on phones,
but at the top of the screen on tablets.

BUG=375379
NOTRY=true

Review URL: https://codereview.chromium.org/396863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283593 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283592 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 283542.

This broke the WebView Android build.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283591 0039d316-1c4b-4281-b951-d872f2087c98

namespace WebCore became namespace blink in blink's r178289
(http://src.chromium.org/viewvc/blink?view=revision&revision=178289)

WebKit DEPS have now rolled, this updates the suppressions to catch up.
All replacements done via a single command:
    grep -rl 'fun:_ZN7WebCore' tools/valgrind/memcheck |\
    xargs sed -i 's/fun:_ZN7WebCore/fun:_ZN5blink/'

BUG=none
TBR=thestig@chromium.org, abarth@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/396413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394454
TEST=fyi cros perf bot
NOTRY=True

Review URL: https://codereview.chromium.org/398083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394558
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/398193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Run something.
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/395133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283583 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/375243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283580 0039d316-1c4b-4281-b951-d872f2087c98

Not inlining schema nodes for availability finder causes data to go missing and
availability to not be found. Inlining schema nodes means that availability data
gets messed up when a node is no longer inlined, because inlined nodes are
deleted from the schema. Solution: Inline nodes, but do not remove them from the
schema when used in availability_finder.py. This provides all the necessary data,
and doesn't interfere with availability data generation when a node is no longer
inlined because it will be still be present in the schema graphs.

BUG=233982
NOTRY=True

Review URL: https://codereview.chromium.org/385703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283579 0039d316-1c4b-4281-b951-d872f2087c98

The Stop() process is already synchronous. This CL folds the Stop() call into
the dtor which simplifies a lot of code.

TBR=bbudge@chromium.org
BUG=349211
TEST=Current unittests pass.

Review URL: https://codereview.chromium.org/395703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394460
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/395253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283577 0039d316-1c4b-4281-b951-d872f2087c98

The manifest spec doc was missing the extra dictionary for "portable".
Spotted by Brad. Thanks!

BUG=none
NOTRY=true
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/394283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305852

Review URL: https://codereview.chromium.org/396933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283575 0039d316-1c4b-4281-b951-d872f2087c98

When an extension is updated, the imported module of the extension could be changed in the new version. If the imported modules are removed in the new version, we need check and remove the shared modules if necessary.

BUG=393232

Review URL: https://codereview.chromium.org/386033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283574 0039d316-1c4b-4281-b951-d872f2087c98

Most of the WindowTreeHost functionality is actually implemented by the
platform window, so there's not much in WindowTreeHostOzone aside from
forwarding calls to and from the platform part.
    
Should be no functional change for in-tree platforms. To accomplish
that, this adds a transitional class PlatformWindowCompat that
implements PlatformWindow functions as WindowTreeHostOzone did before.
As a followup, we'll convert each platform to use the new PlatformWindow
natively & then remove PlatformWindowCompat.

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran all platforms.
NOTRY=true
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/375053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283573 0039d316-1c4b-4281-b951-d872f2087c98

- Add accessors: web_frame(), routing_id(), render_view().
- Remove accessor: render_frame(). Where we do need to touch the
  RenderFrame, we'll look it up by its routing ID.
- Small change to the CompositingHelper to use the new getters.
- Add a map to allow finding a RenderFrameProxy by its associated
  blink::WebFrame.
- Introduce a second factory function and differentiate the two
  factory functions according to the two ways RenderFrameProxies will
  be created. The first is for when an extant local RenderFrame is
  being swapped out and replaced with a new RenderFrameProxy. The
  second is for when a RenderFrameProxy needs to be created without
  displacing an existing RenderFrame, as shall occur once we mirror
  the frame tree.
- This second factory function, which is uncalled at the moment, will
  create WebRemoteFrames. Also there is stubbed out code in the first
  factory function to create WebRemoteFrames. This code is in
  preparation for eliminating the RenderFrame (and its attendant
  WebLocalFrame) and having instead just a RenderFrameProxy.
- Add some defensive checks to prepare for when the render frame may
  not exist, as will happen once the second factory function
  enters use.
- Add an Init function so that code can be shared between the two
  factory functions.

As an adminstrative note, this patch is a chunk of nasko's 
larger "use RenderFrameProxyHost" effor (issue 241223002)

BUG=357747
TEST=browsertests, http://csreis.github.io/tests/cross-site-iframe.html renders after going cross-site under --site-per-process

Review URL: https://codereview.chromium.org/357043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283572 0039d316-1c4b-4281-b951-d872f2087c98

I've gone through the enterprise UMA enums and compared them to their C++
counterparts.  There was a mismatch for EnterpriseDeviceManagementStatus which
is corrected by this CL.  To prevent this kind of error in the future, this CL
adds comments and numeric ids to the C++ enums.

BUG=none

Review URL: https://codereview.chromium.org/375903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283571 0039d316-1c4b-4281-b951-d872f2087c98

member so we can free channel_id_key_ after we're finished with it.

This fixes a TODO in https://codereview.chromium.org/355293003/.

R=rch@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/397803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283569 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283568 0039d316-1c4b-4281-b951-d872f2087c98

The android-chrome-shell browser is an upstream browser, so should
be using a target platform of 'android' not 'android-chrome'.

BUG=394324
NOTRY=true

Review URL: https://codereview.chromium.org/392323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283567 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178278:178288&mode=html
TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/398083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283566 0039d316-1c4b-4281-b951-d872f2087c98

Revert of athena: Add a minimized state for the home-card. (https://codereview.chromium.org/394043002/)

Reason for revert:
it broke "athena_unittests,steps" on "Linux ChromiumOS Tests (1)":
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45720.

Original issue's description:
> athena: Add a minimized state for the home-card.
> 
> The home-card can be in a minimized state. In this state, only a narrow line
> is displayed at the bottom of the screen, and dragging it up shows the overview
> mode. When a window is selected in the overview mode, the home-card is minimized
> again.
> 
> BUG=381224
> R=mukai@chromium.org, oshima@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283539

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381224

Review URL: https://codereview.chromium.org/391383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283564 0039d316-1c4b-4281-b951-d872f2087c98

Revert of mac: Fix tab dragging visual bug in Yosemite. (reland) (https://codereview.chromium.org/393933003/)

Reason for revert:
Broke TestActivate and TestFullscreen on Mac 10.6 Tests (http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/builds/53658)

Original issue's description:
> mac: Fix tab dragging visual bug in Yosemite. (reland)
> 
> -----------------Reland Description------------------
> Core animation was turned on in M35. The fullscreen window was not layer
> backed, but should have been. This original CL exposed this bug.
> 
> -----------------Original Description------------------
> In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
> views (like the tab strip and the profile icon) are placed on top of the title
> bar and require special treatment. All other views are added as subviews of
> 'chromeContentView' in TabWindowController. This allows tab dragging and
> fullscreen logic to easily move the views that don't need special treatment.
> 
> This CL also removes the instances where a VersionIndependentWindow's
> contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
> gets passed around as a subview. This allows VersionIndependentWindow to remove
> another of its internal hacks.
> 
> Original CL link: https://codereview.chromium.org/379293003/
> BUG=392239
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283456

TBR=andresantoso@chromium.org,shess@chromium.org,erikchen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392239

Review URL: https://codereview.chromium.org/398903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283563 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/398023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283562 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/392253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283561 0039d316-1c4b-4281-b951-d872f2087c98

Add flags from debian/rules, and disable assembly modules.

BUG=344505, 313751, 389216
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/393023010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283560 0039d316-1c4b-4281-b951-d872f2087c98