- 10 Oct, 2019 40 commits
-
-
Henrique Nakashima authored
Handle null urls inside FaviconUtils.getIconDrawableWithFilter(). All callers have this behavior already, so centralize it. Change-Id: Ic3d56468dbfb42ab079903902144eb788142f676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850781 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#704787}
-
Patrick Monette authored
Bug: 943303 Change-Id: Ifb96f74daef4b0f168da8c1509998d7184af8219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853946 Commit-Queue: Patrick Monette <pmonette@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#704786}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4b97a1108114..1ff0c181bb37 git log 4b97a1108114..1ff0c181bb37 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 cepheus@frii.com Fix #1924: Emit SPV_EXT_physical_storage_buffer, not the KHR form. Created with: gclient setdep -r src/third_party/glslang/src@1ff0c181bb37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I1bbc767068622b1a0bb4a3c5d268f9641b34ce39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704785}
-
Michael Montvelishsky authored
Required for latency critical processing, for example volume Up/Down/Max control audiolization. Bug: 132990071 Test: on device Change-Id: I19b283d4de44c2586f132dfd014910f26d9608b8 Merge-With: eureka-internal/323757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851125 Commit-Queue: Michael Montvelishsky <mont@chromium.org> Auto-Submit: Michael Montvelishsky <mont@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#704784}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f17976d01993..9e70f3614347 git log f17976d01993..9e70f3614347 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 651f5a29..a1c9c889 (704530:704650) Created with: gclient setdep -r src/third_party/webrtc@9e70f3614347 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I751fb89b19b45d75054c0021186179293d253543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853567Reviewed-by:
-
Max Moroz authored
The length limit was selected by trying different limits on the existing corpus. 8KB appears to be the smallest limit that lets the fuzz target to be fast and efficient, without losing any edge coverage reachable with the existing corpus that we have on ClusterFuzz. The seed corpus was generated by patching |ParseDomainASCII| function in http://crrev.com/c/1850791/4/net/dns/dns_config_service_win.cc, running the DNS unittests, and then minimizing the files dumped on disk using libFuzzer's |-merge=1| option. Bug: 1004729 Change-Id: Ife871dc47e6203e4f1574db03db823661e9e0ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850791Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704782}
-
Guido Urdaneta authored
Some enterprise security systems or configurations can interfere with the audio sandbox and render audio unavailable. This policy allows enterprises to enable or disable the sandbox, which gives them flexibility to update their security setup without disrupting audio. Inspired by crrev.com/c/1465172 In addition, this CL enforces that running the APM in the audio service is possible only if the service is running in a sandboxed untility process. If the service runs in the browser, or in an unsandboxed utility process, the APM will run in the renderer process. The APM has never been configured to run unsandboxed, but it was possible to do it by explicitly setting the feature flags. Since the new policy provides another way to set flags, it is better to enforce that the APM always runs sandboxed no matter what the flag values are. Bug: 1009332 Change-Id: I09405d3058b7bf9b6f61e44583284ceaa8f0ed27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831763 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#704781}
-
Dominic Mazzoni authored
Bug: 1013183 Change-Id: I15fc977a86773fca393a6ebd9ab09a1d52ab2934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853125 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#704780}
-
Long Cheng authored
Record UMA status for time to load icon image from file. Add to record to check if we need take further action. Bug: 1010311 Change-Id: Id48d6a15faa90c7b34eaec94ebc2da5c2e27e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846079 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#704779}
-
Cammie Smith Barnes authored
It is a known limitation that http cache lookup based on a push will not be supported when split cache is enabled because the network isolation key (top frame origin, frame origin) is not available for such a request. We add an early return to the following three previously failing tests in the suite HttpCacheLookupManagerTest*: ServerPushHitCache ServerPushLookupOnUrl ServerPushPendingLookup Bug: 1009619 Change-Id: I48b3e5d89c3b6228d189da9daa4e5714ad1e1602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853825Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#704778}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82019e80..5697a837 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e2574363a4dc5276024b318f3e421fdfbffe2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853504Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704777}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6e6539816196..d200a77a22cf git log 6e6539816196..d200a77a22cf --date=short --no-merges --format='%ad %ae %s' 2019-10-10 lehoangq@gmail.com Metal backend skeleton implementation. 2019-10-10 ianelliott@google.com Generate GLES 3.2 entry points Created with: gclient setdep -r src/third_party/angle@d200a77a22cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I9a7fb02b3009b3ecea2405b6342c04790cb4f8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852196Reviewed-by:
-
Christopher Thompson authored
This caches the results of IsTLSDeprecationConfigControlSite() in SecurityStateTabHelper, ensuring that all callers get a consistent result for |is_legacy_tls_control_site| for the duration of the page visit. Bug: 1011089 Change-Id: I7564e54c509ab927d0e3a3212859444ae4b02804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838302 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704775}
-
Doug Arnett authored
Records PreviewsEligibilityReason in UKM for detected redirect loop cycle and for deny list match. Bug: 1012852 Change-Id: I8b0dc745a4ef5757d07383ed866e846839bc954d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852193Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#704774}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/df24b8a36099..51c8a7860a5a git log df24b8a36099..51c8a7860a5a --date=short --no-merges --format='%ad %ae %s' 2019-10-10 dproy@chromium.org Use chromium build for dev server tests Created with: gclient setdep -r src/third_party/catapult@51c8a7860a5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:973847 Change-Id: I21e276938c000b42c021c87d19572fa84da94c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853568Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/74dbc8af75f9..9fa72471b87d git log 74dbc8af75f9..9fa72471b87d --date=short --no-merges --format='%ad %ae %s' 2019-10-10 thestig@chromium.org Add some unit tests for fx_date_helpers.h. 2019-10-10 awscreen@chromium.org [lcms] Clusterfuzz - avoid secondary integer overflow Created with: gclient setdep -r src/third_party/pdfium@9fa72471b87d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1009235 Change-Id: I08347b6354cfd7d4ac31e5aa568ed46727b5f2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853288Reviewed-by:
-
Kevin McNee authored
There's nothing in these tests that is blink specific, so we make them web platform tests. Bug: None Change-Id: I88a17bcfa7e97f890d9331bdd79857e70f6c6ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853485Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#704771}
-
Matthew Mourgos authored
As shown in spec, this change keeps the size of control buttons between in-app and home the same. Also, the space between the shelf navigation buttons is reduced to zero when in-app. These changes improve the look of the home button's in-app <-> home animation. Bug: 1012040 Change-Id: I01c35851e20da71f88d59246088230d1ee94efe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846181 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#704770}
-
Will Cassella authored
Previously, frame data management and scheduling responsibilities were somewhat split between the XR and XRFrameProvider classes. This CL moves all of those responsibilities into XRFrameProvider, leaving XR with the more high-level session management responsibilities. It also allows each session to have a different frame data provider instead of trying to reuse the same provider for all inline-local sessions (which is not the way the browser process sees things). Finally, it makes VROrientationDevice suspend the sensor once all inline-local sessions have been closed, and resume it once another is created. Bug: 1004008, 970854 Change-Id: Ia87ac5883ee179aa964522fc955c36add43d1370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849098 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#704769}
-
Andrew Grieve authored
Change-Id: I6bb984f42c077dc07fcaa14d66ddee936599f862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848856 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704768}
-
Xiaohan Wang authored
This adds fuzzing coverate on json web key related parsing code. Test: New fuzzer added Change-Id: I392b3e6496353e4be68a01d36ba09be3cb1aadf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852410Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704767}
-
Alex Moshchuk authored
This appears to be a remnant of top document isolation, which was removed a while ago. Also remove the SetIsNeverSuitableForReuse() plumbing which was only used in this class. Bug: 884842 Change-Id: I5bc7f1242bed0a69095355c23d8ab34dab4b7231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849140Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704766}
-
liberato@chromium.org authored
Previously, destroying a LearningTaskController would cancel any in- flight observations. However, it's convenient to sometimes specify a default value to complete them with if, for example, a browser tab is closed while an observation is pending. This CL adds an optional TargetValue to BeginObservation that will be used to complete the observation if the controller is destroyed. While it might make more sense to include it only on the mojo client, instead of the base interface, it turns out to be easier just to put it there. Change-Id: I9ed7ebf089be123a905265a780e427d0b11dfa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841248 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#704765}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b484e7ce24c9..2d8a95ee71b5 git log b484e7ce24c9..2d8a95ee71b5 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 robertphillips@google.com Add "meshCount" to GrProgramInfo Created with: gclient setdep -r src/third_party/skia@2d8a95ee71b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I2a7d45d32b92785bb7b14d62be0f1c51d69e8c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853167Reviewed-by:
-
Daniel Hosseinian authored
Currently, the scaling settings are stored in booleans. Instead, store the scaling as enum values. |fitToPage| and |customScaling| are accordingly replaced with |scalingType| and |scalingTypePdf| in the settings. In doing so, the declaration of the Scaling type enum is moved from ui/scaling_settings.js to data/scaling.js. Later, the scaling will be passed to the printing backend in another CL. Furthermore, information about whether the printed document is a PDF is passed to the print-preview-scaling-settings element, and the logic to determine the availability of scaling values is handled in the element script. Bug: 989978 Change-Id: Ic8835bfbed88700981ec86df944069706d3cba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828287 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#704763}
-
liberato@chromium.org authored
Cross-origin redirects for downloads aren't allowed, but media elements didn't notice. This CL causes them to fail rather than download or navigate. It replaces LocalFrameClient::CrossOriginRedirects with the pre-existing network::mojom::RedirectMode, which includes the option kError. We use that to indicate that no cross-origin redirect should be followed. Last, this CL partially addresses a TODO in parallel_job_download to fail redirects, but failing cross-origin redirects. Change-Id: I10d11962cdc175ae818a0e3f19e4aeaa5a68b959 Bug: 990867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779320 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704762}
-
Collin Baker authored
Change-Id: I186dd89725086a71f0d9973a38a6e2c4a6813eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849435 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704761}
-
Francois Beaufort authored
Setting the FLAG_READER_NO_PLATFORM_SOUNDS flag allows us to prevent Android from playing sounds when it discovers a tag. Vibration still occurs though with same duration as Android (200ms). Change-Id: If39b880a0b7a69da1a8917fd643ec0846119a47f Bug: 1011325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840611Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#704760}
-
Christopher Cameron authored
Bug: 952063, 988964 Change-Id: Ie78e8c7b264dd5f713949cc4acbc6ad5df657f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849982 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704759}
-
Hazem Ashmawy authored
Applying AndroidXPlugin to fix issues with signing project builds when it's mirrored to AndroidX repo. Bug: https://issuetracker.google.com/issues/142394338 Test: manually cherry-pick change to //external and run gradlew :webkit:assembleRelease and gradlew :webview-support-interfaces:assembleRelease Change-Id: I4156549137c43128087b94307d14284d5b08414e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853265 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Aurimas Liutikas <aurimas@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704758}
-
Clark DuVall authored
The safe redirect checking logic in NavigationURLLoaderImpl was changed in http://crrev.com/c/1779310 to remove the check for web accessible extensions resources. There was similar logic in the WebRequest proxy that should be removed to match. This was causing the network_service_web_request_proxy_browser_tests to fail on the Mojo Linux bot. These tests run with a WebRequest proxy forced on to test the logic: https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Linux/40022 Bug: 442579 Change-Id: I47a208d0586e0dc6389bb8bd4aeae2b3a61c78a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853133 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Ian Struiksma authored
Since we moved away from checking for paint events to watching the render_frame_count, we no longer need to be hooked into the WebContentsObserver. Additionally, it is better to always go with tab_strip_model->GetActiveWebContents instead of loading from frame before possible navigation. For those 2 reasons, removing the PageActivityObserver and moving that logic into the TestRecipeReplayer. Also refactored the WaitTillPageIsIdle into 2 steps to ensure we don't navigate the page with an active RenderFrameSubmissionObserver. This fixes intermittent issue crbug.com\1003044 that was occurring on multiple sites and always on wiley.com. Also fixes another flaky situation that was occurring on some sites with render frame observing Enables autofill tests for sites: davidsbridal coach findmeagift neiman_marcus north_face wiley fender pets_mart Bug: 1003044,984664 Change-Id: Ib7732eed8a82395f25de3bacad0f30e440bc18ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842675 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#704756}
-
Sertay Sener authored
This CL ports the Blob related IndexedDB Web Tests to WPT tests. Bug: 866164 Change-Id: Ie2b1b6ddc0c1ddbbb92478a2d5c81bd669c30e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807963Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Sertay Sener <sesener@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704755}
-
Shakti Sahu authored
Change-Id: I6d6fa7aed8164314611e547ad4f96891db259933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852175Reviewed-by:
-
Aaron Krajeski authored
We use both throughout the code base but heavily lean towards 2D. Make it 2D throughout. Change-Id: Ia9f3af6592ffade92c80c6dc04749a915dd7b1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847893 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704753}
-
danakj authored
This value is part of ScreenInfo which will be once again locally scoped to each local root RenderFrame/RenderWidget. A RenderView without a local main frame won't know the DeviceScaleFactor. R=avi@chromium.org TBR=thestig, rdevlin.cronin Bug: 419087 Change-Id: Ife3bf17d3d80a8f19e817ed270c9dbfe954a8a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852949Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Emircan Uysaler authored
This CL checks the current state before creating SkSurfaceCharacterization to properly set protected param. Bug: fuchsia:38284 Change-Id: Ie570cff987427f4667289a60b858c48ad307cd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849149Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704751}
-
Yun Liu authored
Also fixed a bug to create directory if host directory doesn't exist, otherwise pull command will pull file to "host directory" as a file. Bug: 985574 Change-Id: I158acdf39a90a3e014a88ffb42d520fc6abf8d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839351 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#704750}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within miscellaneous Content browser tests as well as Chrome tests related to site islation. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Idf6fcaabc37d09b49acb70ad3bd177985bed91cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850736 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Maks Orlovich authored
It should be treated as a 1st party context, not 3rd party one. Bug: 1012742 Change-Id: Ic8ceb0c7f2e60e15b4517550c50ab67c637b492c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853044 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#704748}
-
