- 13 Aug, 2020 40 commits
-
-
Kyle Horimoto authored
This class tracks whether notification access has been granted by the user on their phone. Because notification access is a sensitive permission, this requires the user completing a special setup flow and is not included with the rest of Phone Hub opt-in. Note that currently, this class defaults to "false" (i.e., has not yet granted access). A future CL will set this value based on whether the phone has sent a message indicating that access has been granted. Bug: 1106937 Change-Id: Ice4968ef684b96f090ee566013aa39dc8224e4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353709 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797757}
-
Leonid Baraz authored
(where they should have been from the beginning; placed in Chrome by mistake). Bug: b:153649905 Change-Id: Iea5a43b7ea4dc553d544977f62177e0a01200eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354532 Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#797756}
-
Andrew Grieve authored
Bug: 1114678 Change-Id: I4880e93b9d0e3b0339cba52e5b50000e9a2c8432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354516 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797755}
-
John Abd-El-Malek authored
Bug: 1114946 Change-Id: Id73c5537ab2de1912af57e3235e88adcdb52016c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343770 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797754}
-
Mugdha Lakhani authored
This adds various entrypoints to Prerender code in WebLayer, now that all the delegate interfaces have implementations and all factories are in place. Please see the following spreadsheet to see corresponding chrome entrypoints and my reasoning for the chrome entrypoints I have left out of WebLayer: https://docs.google.com/spreadsheets/d/1u13bzBQiBqibXzDDmkB4Kbvm29DslTQmXmY91864gOU/edit#gid=299677236 Bug: 1096088 Change-Id: I62549bf3a8f6dbd5a5334c87048b197d75fc4001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346349 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797753}
-
jongdeok.kim authored
In this CL, EffectNode holds a flag to determine whether the node and ancestor has filters. So that disallowing LCD text for filters can apply to descendants. Bug: 1114504 Change-Id: I7059f396aac83bfb686e86cc1c6cf4145da0a975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352569Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797752}
-
Nina Satragno authored
These are errors that pop up when running `git cl lint`. Bug: none Change-Id: I7f105d13ab65ca48a478e4abf3acb4d171cfec15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352528 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#797751}
-
Caitlin Fischer authored
Bug: 1102747 Change-Id: I4ec074babd58d5de2e6e5880ddafbb81b9a60879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354409Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#797750}
-
Friedrich Horschig authored
By making CompromisedCredential implement Parcelable and provide a static CREATOR, it can be serialized and used in Bundles. This enables to pass it as extra when: * Saving the instance state if an activity is recreated * Starting fragments that need a compromised credential as extra Bug: 1114720, 1092444 Change-Id: Ice45d321488794083f59217fc60c72a11f893e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352879Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797749}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I7f1f5af0efd13e16d6ec066ed4a02e95b81562ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353490Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797748}
-
Mariam Ali authored
This CL adds a new create shortcut feature guarded by a feature flag for incognito mode on windows. - created a new string value. - created a new button in the incognito view menu. - added UMA metrics to the create shortcut button. Old Incognito Menu https://screenshot.googleplex.com/s69MjunQKMx New Incognito Menu https://screenshot.googleplex.com/oy0e7GywXMt Design Deck: go/add2desktop Bug: 1113162 Change-Id: I6b336045d4e423d63d11d52cf75d84eb69e6eb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341132 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#797747}
-
Rouslan Solomakhin authored
Before this patch, the test environment for an ARC PaymentAppService unit test was being setup inside of the only PaymentAppService unit test, which prevented sharing this environment among multiple unit test files. This patch separates the ARC PaymentAppService test environment into its own test support file. After this patch, it's possible to share the setup code for ARC PaymentAppService test environment among multiple unit test files; Bug: 1061503 Change-Id: If8271d7d277823dc53630bcdc4f6097bc9a6a2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248749 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797746}
-
David Roger authored
Bug: 1076880 Change-Id: I9931707d9f15ac3013195592f78a95e7579bca38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352812Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797745}
-
Robert Ma authored
This reverts commit ef93a320. Reason for revert: suspected to be the root cause of crbug.com/1115767 Original change's description: > Add an iOS port to blinkpy > > This adds an iOS port to blinkpy to allow sharing logic for running > WPTs using 'wpt run'. In particular, the goal is to share logic for > managing expectations and for running tests on a bot. > > Change-Id: I6e9b5bddc1f20494b7d9124a7027777c53e38e93 > Bug: 673423 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739390 > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Ali Juma <ajuma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684770} TBR=ajuma@chromium.org,robertma@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115767, 673423 Change-Id: Ib1dba6a03a77160fc2641b565676d8809004827a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354273 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#797744}
-
Miguel Casas authored
crrev.com/c/2340365 recently landed a DCHECK() in VaapiWrapper ctor, but erroneously used |decoder_task_runner| ISO |decoder_task_runner_|. This CL fixes that. Bug: b:162962069 Change-Id: I374a42b61ca9c182915baab909006a70991df6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354590 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#797743}
-
Yann Dago authored
This reverts commit 70cab0ca. Reason for revert: setup_install_details_unittest.cc compilation error Original change's description: > Handle "--channel" switch in chrome setup to allow channel switching > > In order to support channel switching on the main installation of > the browser, A switch flag "--channel" that specifies which channel of > the browser is about to be installed is added to the setup's command > line. This flag will be used to store the right channel value in the > registry so the browser knows which channel is running. > The supported values are {stable|dev|beta}. This new switch will be > ignored for if any of "--chrome-beta", "--chrome-dev" and "--chrome-sxs" > is found in the command line. > > Bug: 1102927 > Change-Id: Ib7bd622e906f8f4af067307c90d0caffc73afc24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172210 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797688} TBR=grt@chromium.org,ydago@chromium.org Change-Id: I383a82cedfa209a1570cc3743982e87cc2818702 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354673Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#797742}
-
adoneria authored
Bug: 1109373 Change-Id: Id5b4251253c97884384ed4bdf4d10b38a5bd4d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353553Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#797741}
-
Takumi Fujimoto authored
Has been flaky on linux-chromeos-chrome. TBR=achuith@chromium.org Bug: 1116058 Change-Id: Id1f75d2118efac23db9ed07fa6957ebb6d34f649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354227Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#797740}
-
Kramer Ge authored
In tab dragging, when dragged window snaps to a tab strip, the corresponding WaylandWindow is destroyed. The corresponding buffer queue in gpu process is expected to be destroyed soon, so omit upcoming overlay commits should be safe. Change-Id: I38923f461e9c1eb3ac63d72237989194b2f887d5 Bug: 1114767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353554Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#797739}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic3c997f2166da4668308a2d0a242fd79bf787e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797738}
-
Charlie Hu authored
|layout_size| behaves differently depending on platform: - Win/Linux: |layout_size| already factors in device pixel ratio. - Mac: |layout_size| does not factor in device pixel ratio. This CL solves this platform difference for oversized images policy downscale ratio calculation. Web test document-policy-oversized-images-edge-cases.html is modified to verify that the fix works. Bug: 1112784 Change-Id: Ie21445bcc63d1b0624e305e14720a8f3a835fe99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316621 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#797737}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008130800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/fX1CZHk_Z55AAvLsAiH1mQ6Dr6f33Mf7P1iCopozfbEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159964708 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib773515ba26f737d1359d535daff0affcb756262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797736}
-
Kyle Horimoto authored
Bug: 1106937 Change-Id: If91dfd2c87abee709d61176f36a8751c0062fd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353526 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797735}
-
Justin Cohen authored
Bug: 11160121 Change-Id: I8f09af4ca2310d68f296eab1a4ccee1e8329880c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354410 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#797734}
-
Alexander Alekseev authored
This Cl permanently exposes HUD controls and adds tabbed controls as a preparation to adding more data. Tabbed UI: https://screenshot.googleplex.com/uQSuqEps8s8.png - First tab active. https://screenshot.googleplex.com/YdMcrG74OiP.png - Second tab active. https://screenshot.googleplex.com/7t5ZSVU2fWB.png - Third tab active. https://screenshot.googleplex.com/MtoB750fA4C.png - Settings UI. Bug: 1075612 Change-Id: Ic5101f302b071e060ab54de6f8fb6b510e0250ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348337 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#797733}
-
Lan Wei authored
AddressViewControllerTestCase/ testAddressesViewControllerContainsManageAddressesAction fails on ios-simulator-full-configs, https://ci.chromium.org/p/chromium/builders/ci/ ios-simulator-full-configs/b8872074450009779120 disable it for now until it is fixed. TBR= javierrobles@chromium.org Bug: 1116043 Change-Id: I76372c15e5031b4c4d8d5a1681eb0dfc1f041e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354413Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797732}
-
Guillaume Jenkins authored
Adds two new experimental settings to help manual testing of CBCM on iOS: 1) EnableChromeBrowserCloudManagement to force enable CBCM infra 2) CloudManagementEnrollmentToken to provide an enrollment token This change also creates a new "Enterprise Settings" section in the experimental settings, since there are now three Enterprise-related experimental settings. Bug: 1066495 Change-Id: I8b88c408c5866cb130373712af6201269be39c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353394 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#797731}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bca9dcdf05aa..35492ebf6ba2 2020-08-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-13 bpastene@chromium.org deploy_chrome: Deprecate '--to' and replace it with '--device'. 2020-08-13 sidereal@google.com packages: Allow for stable and unstable ebuilds in VM uprev handlers 2020-08-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-13 yupingso@chromium.org cros flash-ap: Add puff configs 2020-08-12 cjmcdonald@chromium.org cbuildbot: Disable 'separatedebug' in all stages 2020-08-12 kevinruvalcaba@google.com Added script to extract data for the DepVisualizer class 2020-08-12 kevinruvalcaba@google.com Corrected design of the DepVisualizer class 2020-08-12 mikenichols@chromium.org chromeos_config: Remove references to Release and CQ 2020-08-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-12 erikchen@chromium.org Fix a bug in deploy_chrome.py where ui is not started. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib3ccea537512ae5cc35cf03652aa405c6d8b231c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797730}
-
Mason Freed authored
See [1] for context. This CL adds the shadowRoot attribute to ElementInternals, which allows custom elements to access their own shadow roots, including in the case that the shadowRoot is closed. Without this capability, custom elements that use closed declarative shadow roots would have no ability to retrieve the contents of their own shadow root. Bug: 1042130 [1] https://github.com/w3c/webcomponents/issues/871#issuecomment-672082936 Change-Id: I33606144bec3c27600d2e67f108d0344f7696dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350739 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797729}
-
Robert Sesek authored
Bug: 1116003 Change-Id: I00455a78b94ac614ee5015a2be68f8c8bc5e855e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354152Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797728}
-
Adithya Srinivasan authored
Currently, we reset the DevTools session before portal activation and create a new session with the activated portal's WebContents. We dispatch the portalactivate event and run any event handlers in the interim while there are no agents active, and as a result, existing breakpoints do not work. This CL waits for DevTools to point at the portal WebContents before actually swapping the WebContents, thus making sure that the portalactivate is dispatched after the main target has been reattached. Bug: 1025761 Change-Id: I930d5f7ec361cd594c60bcece0bd9450a94994e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295080Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#797727}
-
Marc Treib authored
This CL adds the recording logic for AccountPasswordsConsent to the SigninReauthUI. This requires: * Collecting the relevant strings in JS and sending them back to C++. * Maintaining a mapping between strings and GRD IDs in C++, to convert the strings from JS back into IDs. * Putting the IDs into a AccountPasswordsConsent proto and sending that to the ConsentAuditor. Bug: 1111252 Change-Id: Ic06533fdb361b415398923b12fbc3c289a47e989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352789 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797726}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b19e07ebf92c..78d7b4b8250e 2020-08-13 treehugger-gerrit@google.com Merge "[RELAND] tp: move thread state implementation to trace processor" 2020-08-13 fmayer@google.com Remove deobfuscation from HeapGraphTracker. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:159987908 Tbr: perfetto-bugs@google.com Change-Id: Ibf5ef6ffee3e187de9585a518938fae7faf83f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797725}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/31e5a5d45d5d..07ae53f59079 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from b60e067b4374 to d253278f9865 (1 revision) 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 13a65b1aee42 to df859f77dab3 (7 revisions) 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e930c45863c6 to 6b0de7007af5 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibd4343c141db9c3619c203add09b83875f3d8928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797724}
-
Rouslan Solomakhin authored
TBR=harringtond@chromium.org Bug: 1115137 Change-Id: I212b3279f81948a0964de8985d8c9ccea1fa4e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354416Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#797723}
-
chrome://managementTina Wang authored
- Add enterprise icon to the page. - Adjust text color, font size and line height. Bug: 1108981 Change-Id: Iefac85146019f3a4b5a60fcc8812340cae5ddfb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352526Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797722}
-
Yicheng Li authored
In the in-session auth dialog, show PIN view only if PIN is set, and show fingerprint view only if fingerprint is set. icon are not shown. Delete PIN, verify that PIN pad is not shown. Bug: b:156258540 Test: On Nami, delete fingerprint, verify that fingerprint prompt and Change-Id: I55604aeb9e66f04a2f49ffbb5e5160b6158a40d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351120 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797721}
-
Andrew Grieve authored
This reverts commit 5e31951c. Reason for revert: Broke monochrome_apk_checker on android-pie-arm64-rel Original change's description: > Restore CQ coverage for proguard, errorprone and lint > > * Removes these from android-pie-arm64-rel (currently offline). > * Adds proguard to android-marshmallow-arm64-rel > * Adds errorprone & lint to android-lollipop-arm-rel > > Spread across two different bots to share the load. > > Bug: 1111436 > Change-Id: Ieac924ccae06aa4bc01b52bf795d1a174616a799 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342575 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796688} TBR=agrieve@chromium.org,bpastene@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111436, 1115164 Change-Id: I81ee42d31410176e157be2edced7b5eb4fb25025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354449Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797720}
-
Mohamed Heikal authored
It is usually not clear what exactly is failing when this script fails. This CL improves the error messages to be verbose about the problem. Change-Id: I1fa6f41520cfac8cdc4180f66d84d4dcff5e48b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354512 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797719}
-
Torne (Richard Coles) authored
Bug: 1038002 Change-Id: Ib53fe65d5a36af3146ad1f0c61cefbe9afcd8dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354151 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#797718}
-