- 14 Feb, 2020 3 commits
-
-
Noel Gordon authored
The directory-tree/splitter-bar has no border in files-ng. Remove it. Bug: 992819, 1002790 Change-Id: Id85c3c1d6649e54275d05ea713a93f1c8af703f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055944Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741265}
-
Alex Danilo authored
Bug: 992823 Change-Id: I7de99801293d1fe2b25ba8e5a7f072f6f5014e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053647 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741264}
-
Andrey Kosyakov authored
Make sure history navigation actually started before pausing the virtual time, as LocalFrameClient::NavigateBackForward() may cancel the navigation. Bug: b/149431317 Change-Id: Ie5ff73d3bc6bc042d381e9f496aea6c8c4c9243a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055559 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#741263}
-
- 13 Feb, 2020 37 commits
-
-
Avery Musbach authored
You shall not be able to end overview by pressing the overview button with one finger, while dragging the split view divider with another finger. It causes a DCHECK failure. Test: manual Change-Id: Ie48e19a9fe9a21e45313e16cc5a353adb9eada64 Fixed: 1052163 Bug: 1052163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055886 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#741262}
-
Alex Danilo authored
Bug: 992823 Change-Id: I5ef0685d012e02080d72c00a98b6be444de8ac26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053466 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741261}
-
Peng Huang authored
BeginWriteSkia() call is not cheap, moving it out of the criticl code path can improve DrawToSwapUs metric about 700us for poster circle page. Bug: None Change-Id: Ib905694983703b2ffff2f4deadf777546c4bae23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053292Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741260}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/951c1df3ce7d..07a952baa2fe git log 951c1df3ce7d..07a952baa2fe --date=short --first-parent --format='%ad %ae %s' 2020-02-13 thestig@chromium.org Remove spurious calls to GetPDFPage(). 2020-02-13 thestig@chromium.org Assert CPDFSDK_Annot::GetPageView() never returns nullptr. 2020-02-13 thestig@chromium.org Delete unneeded cruft from fpdfsdk/cpdfsdk_annot.h. 2020-02-13 tsepez@chromium.org No need to buffer CSS comments 2020-02-13 thestig@chromium.org Use UnownedPtr in |CPDFSDK_InteractiveForm::m_Map|. 2020-02-13 thestig@chromium.org Convert IPDFSDK_AnnotHandler::NewAnnot() to return std::unique_ptr. 2020-02-13 thestig@chromium.org Remove a redundant call to GetRadioButtonAppStream(). Created with: gclient setdep -r src/third_party/pdfium@07a952baa2fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ib0edf10a5e093b5498c9af9567d02fd11647df46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055488Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741259}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ee86e5a4697..ca1907e58b82 git log 9ee86e5a4697..ca1907e58b82 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 ehmaldonado@chromium.org Revert "gerrit-util: Fix GCE check from behind proxy." Created with: gclient setdep -r src/third_party/depot_tools@ca1907e58b82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050380 Tbr: agable@chromium.org Change-Id: I71c79073915baa8fe677964a312c474c6b7d3f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741258}
-
Jinsuk Kim authored
This CL adds new metric EphemeralTab.OpenInNewTab/NavigateLink. Also make sure the UI for the feature OpenInNewTab won't appear if it cannot be activated. Bug: 1046619 Change-Id: Id42dba33f5f5fb28304fdfda0fcd77d93bb79221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045692Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#741257}
-
Chris Blume authored
Right now, users of PaintImage need to do some roundabout work to determine if a PaintImage is sRGB or not. This CL makes it just a tad friendlier to do that work. Bug: 955158 Change-Id: Iac22e880463b812988db72c281ffaa5c529e2726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055416Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#741256}
-
Steven Bennetts authored
This addresses a minor issues related to IP config (see bug) and includes some cleanup to improve type checking. Bug: 1051905 Change-Id: I1eec648b814ba64fdd044d9adfb1587b4ebcd8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055403Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741255}
-
Christian Biesinger authored
The CSSWG has approved a resolution to update the spec; these tests match that resolution: https://github.com/w3c/csswg-drafts/issues/4531 R=vmpstr@chromium.org Bug: 991096 Change-Id: I021e5fb2b14eb5049cf7077e06c79810fd60e622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055740Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741254}
-
Rayan Kanso authored
Currently the minimum size matches the ideal size. Make the minimum size in px equal to half the the ideal size. Change-Id: Ib5a68f5e0073ced276afa095ded61ce7c264573d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055103 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#741253}
-
Darwin Huang authored
- Split Raw Clipboard functionality out into a separate mojo interface. - Check this new interface for permission in the browser process. - Adjust Clipboard API plumbing to pass ExecutionContext instead of clipboard hosts. Raw/Unsanitized clipboard access has significantly higher security and privacy implications than sanitized clipboard access. A separate mojo interface this distinction clear, and makes it easier to check for this permission in the browser process, in case of compromised renderers invalidating the renderer-side check. Bug: 897289, 1034023 Change-Id: I68b4781ccb3e29d38c344f2b2c1919c7d674e052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016200 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741252}
-
Joey Arhar authored
This reverts commit 07d811aa. The change this reverts fixed http://crbug.com/773680 which was intended to fire change events for detached radio and checkbox input elements when using input.dispatchEvent(new MouseEvent('click')), but also caused input.click() to fire change events. Although these may seem to be the same thing, firefox actually fires change events on input.dispatchEvent but not input.click(). WebKit, and chrome before the patch this reverts fire change events in neither of these cases. I will file an html spec issue to address this compat issue. For now, it seems important to stop firing these change events because it is getting more attention than the lack of change events. Bug: 773680, 1051482 Change-Id: Ia8217d34bf9a20c50ce008630e748a7dbda52c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055590Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741251}
-
Isabella Scalzi authored
Bug: 803259 Change-Id: I990bad26b03e290a04da305933dc0d223502ea4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055943 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741250}
-
Avery Musbach authored
OverviewWindowDragController::ActivateDraggedWindow relies on the fact that kMinimumDragDistanceDp is less than or equal to kWindowMargin. If either or both constants were modified so that this condition is not met, then there would be an obscure bug where you drag an overview item from a display where split view mode is active, and you drag to another display but by a distance of less than kMinimumDragDistanceDp. Then the window would be snapped on the destination display, but the check for snappability would be with respect to the source display, and so you could trigger a DCHECK failure by snapping a window on a display where it is not snappable. Bug: 961170 Change-Id: I0fbf16b50ae2cb5dbd9a5dbefd8317cc9f1e9a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055349 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#741249}
-
Brian Salomon authored
Bug: 1052146 Change-Id: I5cd71b39de03ab1b7c0e303080f9ab81cecd4b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055557 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#741248}
-
Xianzhu Wang authored
PaintChunk::bounds includes bounds non-drawable display items. Add PaintChunk::drawable_bounds to include drawable display items only, and use it in paint chunk raster invalidation. This is a preparation for crbug.com/937573 which will create more non-drawable display items, to avoid unnecessary raster invalidation. Bug: 937573 Change-Id: Ib54ff89fff091fae1701e636808043b8cbfffe69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052254Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741247}
-
Andrew Xu authored
There are two issues in the current code: (1) ScrollableShelfView::GetTargetScreenBoundsOfItemIcon is used to calculate the target bounds of the animation. However, that function assumes that shelf is horizontally aligned. (2) ScrollableShelfView::drag_icon_ is created when moving an icon to a different shelf page. There is an edge case that the user drags an icon from AppListView and meanwhile drags it to a different page. In this case, |drag_icon_| is created but never destructed. This CL fixes the above two issues. Bug:1052123 Change-Id: I463bb5a672ed309ee674618c36ae743711927739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053150Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741246}
-
Alan Cutter authored
This is a reland of 41647287 When is_chrome_branded build flag is true the kPassiveMixedContentWarning runtime flag is disabled. Original change's description: > Instantiate missing hosted_app_browsertests > > This CL fixes the following warnings thrown by browser_tests: > [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<HostedAppTestWithAutoupgradesDisabled> > [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<HostedAppPWAOnlyTestWithAutoupgradesDisabled> > > Change-Id: Iebf53094d7909a16ccd07e9e6150d600203ba5c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053225 > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740919} Change-Id: I661cfc1b2cefb6f3622e9b19f5dc5bdf328204ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053679 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#741245}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fbbf981a3401..6f95788326bb git log fbbf981a3401..6f95788326bb --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tmathmeyer@chromium.org Fix scrolling bugs by switching to plain DataGrid Created with: gclient setdep -r src/third_party/devtools-frontend/src@6f95788326bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051517 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8070756b5976d7107ea71803527ce5a954ba3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741244}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eceeb201f72b..e90568eeef90 git log eceeb201f72b..e90568eeef90 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 bclayton@google.com Update Marl to a047dd0bb Created with: gclient setdep -r src/third_party/swiftshader@e90568eeef90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifd821e45eeec7b2badbf0db98b3516308b69860d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741243}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e61ca55caf34..0b15317ba70c git log e61ca55caf34..0b15317ba70c --date=short --first-parent --format='%ad %ae %s' 2020-02-13 rmhasan@google.com [Typ] Add setter for lineno in Expectation instance Created with: gclient setdep -r src/third_party/catapult@0b15317ba70c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986447 Tbr: skyostil@google.com Change-Id: I425b8914f4f570ec63d88eb333dcb024a5c8f560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741242}
-
Oriol Brufau authored
This reverts commit 7b72bfb4. Reason for revert: not web compatible, too much breakage Original change's description: > [css-grid] Accommodate spanning items crossing flexible tracks > > The specification added a step to increase sizes to accommodate spanning > items crossing flexible tracks instead of ignoring their contents > completely. This is done after handling all grid items that don't cross > such tracks, and this time items are considered together, not grouped by > their span size. > > This is a reland of r705228, which was reverted due to a performance > regression. The main problem was that non-spanning items in flex tracks > have to be handled with a variant of the algorithm for arbitrary spans, > which was much slower. But now that has been greatly improved by > r714511 and r715665. I have also refactored the patch to avoid worsening > the performance of spanning items that don't cross flex tracks. > > However, the algorithm for arbitrary spans is still a bit slower than > the one for span of 1. Therefore the nested-grid perf test will decrease > by ~5%. This is expected since it has lots of non-spanning items in > flexible tracks, that will now be handled with the arbitrary span algo. > > Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items > > BUG=935102 > > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html > > Change-Id: I4dfae4a0293aea611b04b59738cfced5e4fe8d44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913406 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Sergio Villar <svillar@igalia.com> > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#719104} TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,obrufau@igalia.com Bug: 1051039, 935102 Change-Id: I6f1fd18fd8f0f1e43acbac9bb47a6d2925b7c2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055623Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#741241}
-
Luciano Pacheco authored
Change column header to: 1. Text elide with ellipsis. 2. Remove some additional width from the resize dragger. 3. Remove additional margin for the size column which aligns right. These fix the issue where the sorting arrow icon background was being cut by the dragger icon. Bug: 992821 Change-Id: Ie3582d2e5f446104d9defb40626b609030730984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053651 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741240}
-
Daniel Rubery authored
We should be reporting unscannedFileEvents for all statuses that indicate the file was not scanned. We also should report unscannedFileEvents if the status is correct, but the response proto indicates failure. Bug: 1045986 Change-Id: I7a725dd16795f875ec509a183ff452577f7058cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050963Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#741239}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bee77f5..e3ebc4f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I06dff4c4dca83311a40be5dc0147f1fd85e8d328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055703Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741238}
-
Gil Dekel authored
Certain chromebooks now come with panels that have integrated privacy screens on them. This CL introduces user and device policies for the now supported privacy screen feature. Bug: b:146234183, b:138397511 Change-Id: Id0aae80535524fea5d3470b9f66065911ab5a7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045158 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#741237}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b79b57e047bb..ef599fb0f431 git log b79b57e047bb..ef599fb0f431 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 cclao@google.com Vulkan: Fold glClear into draw call when command graph is disabled 2020-02-13 cnorthrop@google.com Capture/Replay: Track and restore mapped buffer data Created with: gclient setdep -r src/third_party/angle@ef599fb0f431 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ic2c8252fc7a9e476c1d8bb9896ef6e43e867f959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055484Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741236}
-
Wez authored
--test-launcher-jobs should normally only be passed on the test command- line if it was specified on the runner-script's command-line. However, if the test has |enable_test_server| set then the number of test jobs and test server instances must match, so in that case we assume that the test uses the TestLauncher, and set --test-launcher-jobs based on either the number of CPU cores specified for QEMU to emulate, or on a fixed default concurrency level if running on a device. Change-Id: Ic8e226b1ad832463471da051aaac6f8aaf38b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052125 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741235}
-
Darwin Huang authored
Mention where to find fuzzing coverage of sqlite tools, which are especially helpful right after importing new sqlite releases into Chrome. sqlite Fuzzing coverage tools should be more easily discoverable by Chrome's sqlite maintainers with this called out specifically in the sqlite/fuzz/README.md. Change-Id: I5b876e2fe486719aae8190eef48f34c22b13b6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053767 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741234}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0ffd42151c6..04a7136fd704 Created with: gclient setdep -r src-internal@04a7136fd704 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iecad1f90fcd13b1ba644e9ddd08406b15405575d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055487Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741233}
-
Daniel Clark authored
Prior to this CL, when changing the displayed month in datetime-local/date/week via the month switcher menu or the prev/next month buttons, the selection did not update. This caused an issue for keyboard selection: if the user changes the month via keyboard and then tries to adjust the selected day, the calendar will jump back to the old month because the selection is still in the old month. This change fixes the issue by moving the selection to the new month whenever the month is changed. This change also fixes the 'm'/'y'/'d' hotkeys, which were not pushing updates to the in-page control. The (benign) accessibility tree changes are due to the addition of the click handler to the popup document's body element. Bug: 1047439 Change-Id: I420833cc4036a5215674dab7cec269218672193d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040550Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741232}
-
Sven Zheng authored
Now Skia Gold can make comments on gerrit, so it's time to move this out of fyi. Bug: 958242 Change-Id: I1274cc5da4feb7e9904bf788b9d9d7633dfeac5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053803Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#741231}
-
Dave Tapuska authored
Use ui/gfx's typemapping directly there is now no need for blink to override it. Change-Id: I948329f32637dfefe2920535fd8bb3e808092a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055345 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741230}
-
Avery Musbach authored
You shall not be able to enter overview by pressing the overview button with one finger, while dragging the split view divider with another finger. See the video linked on Monorail. Test: manual Change-Id: I779e20fcc951d44355ee4c05d71e5bac1c83024f Fixed: 1051758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055735Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#741229}
-
Lei Zhang authored
Add end-to-end tests to make sure printing PDFs with line caps and line joins to PostScript printers on Windows works correctly. Bug: 1049410 Change-Id: I92e2b22f49ad7e70660d34252b8224031ef03583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044996Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#741228}
-
Sam Bowen authored
We will use these types from both blink and //content and from code inside //components. This patch affects Clank downstream and will be submitted together with a patch in that repo to avoid breakage. Clank CL: https://crrev.com/i/2545991 See discussion in design doc: https://docs.google.com/document/d/1ZA-1EMq4d40K5qfsZoeMIhJmZA6-AXaSibD3SsqZjfU/edit# Bug: 1044252 Change-Id: Id658caa422bedbcb6d2275a8ccdd76f73bf955c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051363Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#741227}
-
Robert Sesek authored
Bug: 710376, 778317 Change-Id: Ifc5cd2a0d961c3503a7732252398cdd24f30fcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053929Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#741226}
-