- 19 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/d09e8315591b..49f3394d7a53 git log d09e8315591b..49f3394d7a53 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 nikolaus.waxweiler@daltonmaag.com [autofit] Add support for Hanifi Rohingya script. 2020-02-19 wl@gnu.org Require HarfBuzz 1.8. Created with: gclient setdep -r src/third_party/freetype/src@49f3394d7a53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I5723f1b651de1f878380a27175008b23c80c0e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064878Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#742835}
-
Jose Dapena Paz authored
As base::Optional move assignment operator is not constexpr, the setters using it cannot be constexpr either. Bug: 819294 Change-Id: I0c6e0325728f05ff9d6d892a3508ebb1b21a85c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041611Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#742834}
-
Esmael El-Moslimany authored
Also dismissing cr-toast in ntp-most-visited when undo shortcut is invoked. Bug: 1052828 Change-Id: Ibdafb3cb03da25a82a681d9fb1a8a56e662cd6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062922 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742833}
-
Elly Fong-Jones authored
When the tab list in the desktop media picker has keyboard focus, it interprets a Return key press as meaning "accept selected source", but table views don't always have a selection. This can cause a crash in DesktopMediaPickerViews itself, which assumes that its Accept method can only be called with a source selected. To fix that, have DesktopMediaListController reject calls to AcceptSource when there is not actually a selected source. Also, add a unit test for this case. Bug: 1042976 Change-Id: I840cf4353f59f33a6950b580196f34a60d04c448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063044 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#742832}
-
Jose Lopes authored
The callback is repeating because it can be executed in the following locations: * https://cs.chromium.org/chromium/src/media/gpu/android/codec_image.cc?rcl=ab462b5f5bc23b9366999cd94ea044e61e898660&l=170 * https://cs.chromium.org/chromium/src/media/gpu/android/codec_image.cc?rcl=ab462b5f5bc23b9366999cd94ea044e61e898660&l=176 invoked by a for loop in: * https://cs.chromium.org/chromium/src/components/viz/service/display/overlay_processor_on_gpu.cc?rcl=ab462b5f5bc23b9366999cd94ea044e61e898660&l=56 * https://cs.chromium.org/chromium/src/components/viz/service/display/overlay_processor_on_gpu.cc?rcl=ab462b5f5bc23b9366999cd94ea044e61e898660&l=74 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Iad9fb48caa4f49a32a730a0d72881605d1dd9f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058813 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742831}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/920836be70be..22b9a1c0f1f7 Created with: gclient setdep -r src-internal@22b9a1c0f1f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094 Tbr: jbudorick@google.com Change-Id: I0f7767fa60657b76e2442b6425cf6a7228d9ce9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063399Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742830}
-
Clark DuVall authored
This required moving a few other classes: - NotificationPermissionUiSelector - PermissionPrompt - MockPermission* The GetDisplayNameOrOrigin() method which used to be part of PermissionPrompt::Delegate was moved to PermissionPromptBubbleView since that is the only place it's used. A set of unit tests was left in chrome which tests chrome-specific behavior of the PermissionRequestManager. The rest of the tests were moved into the component. Bug: 1025609 Change-Id: Ib4420a4322adeccfa0fe42c6197a9111d9a100a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057965 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742829}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9508452e18f1..f1be7b5948f8 git log 9508452e18f1..f1be7b5948f8 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 crouleau@chromium.org [Catapult] Remove Charlie from OWNERS files. Created with: gclient setdep -r src/third_party/catapult@f1be7b5948f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:949246 Tbr: crouleau@google.com Change-Id: Id358ea6bdf896643138dc6e1377f547f6b12e52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064989Reviewed-by:
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: Ibe17c2309d86cd74e55876dab8997df4ca8b0037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063848 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#742827}
-
Michael Sun authored
Unlike most keyboards, which have a single Play/Pause toggle key, Bluetooth devices with AVRCP (Audio/Video Remote Control Profile) generate separate Play and Pause key events based on the media status. This patch adds handling for the Pause media key. BUG=b/147364135 Change-Id: I0ee0eebf28411377dc7050e534abf1f4edb832d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063418 Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#742826}
-
Trevor Perrier authored
All ByteOrderMarks are now removed during grit translation since https://crrev.com/c/2039342. The ByteOrderMark suppression is no longer needed. Bug: 1033305 Change-Id: I587d4c272a84ea3d8013d296d370d814d99f77c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064466Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#742825}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10e0e6d6c19a..68e5c907add4 git log 10e0e6d6c19a..68e5c907add4 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@68e5c907add4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I61617dc295029a49b36840d0a0e0eb5aed1da1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064445Reviewed-by:
-
wutao authored
This is a reland of 84408458 Original change's description: > ambient: Use backdrop APIs > > This cl adds a framework to use backdrop APIs to fetch photos etc for > Ambient mode. > > Bug: b/148483925 > Test: manual > Change-Id: I777b9269148c5317a18e763e911e4893e7ecbe2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026258 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740069} Bug: b/148483925 Change-Id: I6a6b6d25feeb181e00a207d5e58518533a8e263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053038 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742823}
-
Brandon Maslen authored
Recently updating the WebSchedulerTrackedFeature histogram enum it was noticed that the current labels are out of sync. This change adds a new presubmit check to help warn committers to keep the value up to date. In addition the current labels have been updated to reflect the current in-code values being reported. Change-Id: I8e3fb6dd452454f4efa0aecf65348bcce4517c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063359Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Brandon Maslen <brandm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742822}
-
Nico Weber authored
Undoes the code change in https://codereview.chromium.org/819083005/ Bug: 445618,1053958 Change-Id: I6e097dba93010c245cb6b6c376d2f161b9e15f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062622 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742821}
-
Brandon Wylie authored
Bug: 1053930 Change-Id: I0824edd19864686b0f9e48210dc61d8a821602ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064788Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#742820}
-
Toni Barzic authored
Fixes kHalf and kClosed app list view position on secondary screens with non-zero y coordinate. BUG=1041506 Change-Id: Idb4826d7b3b0296a1d7d62597ebafee8d98f6350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061976Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742819}
-
Michael Thiessen authored
The downstream usage of this function has been removed, so we can delete it. Bug: 783819 Change-Id: I41309bdb93b7f0fde005cd313494f06c209cfa30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062581Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#742818}
-
S. Ganesh authored
This is a part of the effort to move the Updater core functionality into a singleton service. The updater core, which is the process managing the installed application set and containing the calls to update_client, needs to run as a singleton COM service on Windows so that it can be reached by multiple clients, such as on-demand, metainstallers, etc. BUG=1048653 Change-Id: Ic2f7f26dea04e7d427f76853cf011c5965bf93fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051612 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742817}
-
Regan Hsu authored
This CL adds user action recordSettingChange() calls in instances in OS settings related to the bluetooth page settings that the user can change. Change-Id: Id394d94dd7bb8f29de8dcadbfae0a5f6f2146c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064607Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742816}
-
Kramer Ge authored
To reduce Gpu memory on low end device, GrContext and associated resources should be released. Abandoning GrContext directly results in resources associated to theVkDevice becoming lost. It's preferable to destroy entire vulkan context during background cleanup and re-initialize when chrome is foregrounded. Bug: 1048692 Change-Id: I6bb0740edee72413f0ac083d847d06e4427133ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047828 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742815}
-
Mason Freed authored
With this CL, the Enable Experimental Web Platform Features flag will enable declarative Shadow DOM. This makes it easier to test. Bug: 1042130 Change-Id: Ib18a9f39e9c3cb3e4a1fb35af95ba469360ab334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064465 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742814}
-
Kyle Horimoto authored
Add all //chrome/browser/resources/settings/chromeos owners as owners of this directory as well; also update bug component. Change-Id: I55d54ed10afd418f92d52498c67a6eb5b4b6569b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065113 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#742813}
-
Sean Gilhuly authored
This mojo call was added for crbug.com/811945 to fix a Windows-specific bug. Restrict it to only be enabled on Windows. Bug: 1042259 Change-Id: I52f1f348e1de52e2d09a376e80852e1b8ae84d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063417Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#742812}
-
Jesse McKenna authored
crrev.com/c/2062275 recently marked webkit_layout_tests test events_referenceSpace_reset_inline.https.html as flaky on Mac10.12. Flaky timeouts were later seen on Mac10.10, .11, .12, and .13, as well as Win7, Win10, and Linux. This change expands on the previous change to include timeouts and all platforms. Recent flake occurrences: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZAsSBUZsYWtlIlljaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3dlYnhyL2V2ZW50c19yZWZlcmVuY2VTcGFjZV9yZXNldF9pbmxpbmUuaHR0cHMuaHRtbAw TBR=alcooper@chromium.org Bug: 1053903 Change-Id: Iadd595c835d73083dfeb660010a7be5e1f086b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062583Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#742811}
-
Brandon Maslen authored
During another change/need to iterate over all storage partitions it was noticed that other places in Chromium have the same requirement. This change exposts a GetStoragePartitionCount method off of having to iterate over the collection of partitions to achieve the same result. In addition the existing call site of this method has been updated to call the BrowserContext version. content: :BrowserContext in order to avoid other classes Change-Id: Ie60b726841f6955f7df5128cbe89955ea0e3a98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057808 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742810}
-
Nico Weber authored
They were apparently used by some old code coverage system long ago. https://chromium-review.googlesource.com/c/chromium/src/+/764949/ removed tools/code_coverage/croc.py well over 2 years ago, so we probably don't need these files either. Bug: 784464 Change-Id: I2cb1c7ee973c26b673a225659967516f5bf922d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036804 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742809}
-
Peng Huang authored
We will start finching vulkan on Linux and Android soon. We still need the flag. Bug: None Change-Id: I6d760c537a1767416bd354c8d87be25ba51ef0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062578 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742808}
-
Sahel Sharify authored
The DCHECK happens when PaymentRequestState::OnDoneCreatingPaymentApps() gets called after the merchant has called Abort(), and no supported method exists. This is because the supported method callback which gets called inside OnDoneCreatingPaymentApps() tries to set a NotShownReason after the Abort() call which has already set the AbortReason. In this cl the state_ gets notified about Abort() calls, and clears the pending (if any) supported method call back on abort. A test will be added in a follow up cl to test abort() call before OnDoneCreatingPaymentApps() once cross platform payment app factory is ready (crbug.com/1054115) Bug: 1040194 Change-Id: I8985fd805df05e656b271e4dac4bb4d20a7fb045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065049Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742807}
-
Aaron Leventhal authored
This is temporary until we have a proper fix. Bug: 1052334,1050598 Change-Id: I6e9370dbac191acea5543d3d015b19f75554e48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062878 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#742806}
-
Khushal authored
R=ellyjones@chromium.org Change-Id: I042268169b55fe23d3d22933d49a44919cd8653f Bug: 976583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065051 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#742805}
-
gogerald authored
Bug: 1051226 Change-Id: Ieee0fcb41ff6f3d1282b709cffd23ed381102687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050754Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#742804}
-
John Smith authored
Bug: 1052427 This follows up http://crrev.com/c/1941064. The hue shift, with certain accent colors could cause unexpected changes like a red accent titlebar turning to blue when inactive. This change is to remove the hue shift so the color overall stays in the same space but to still maintain as close to the kGoogleGrey900 (0x20, 0x21, 0x24) -> kGoogleGrey800 (0x3C, 0x40, 0x43) as possible. With kGoogleGrey900 as the input, this code outputs (0x3B, 0x3E, 0x44). I chose this one because it was very close to (0x3C, 0x40, 0x43) and kept the overall color biased towards the green and blue channels. Some other options considered were: return {-1, 0.53, 0.567}; #3C3E43 return {-1, -1, 0.57}; #3F4043 return {-1, -1, 0.569}; #3F4042 return {-1, -1, 0.572}; #404144 return {-1, -1, 0.568}; #3E3F42 return {-1, 0.55, 0.567}; #3B3D44 return {-1, 0.54, 0.567}; #3B3E44 return {-1, 0.54, 0.57}; #3D3F45 Boosting the red channel and losing the green were resulting in slightly warm and faded colors that didn't feel like they fit in the Chromium color set. Tested against the default Windows set of accent colors and saw differentiation between active and inactive windows without unexpected color shifts. As a note on existing behavior, the colors of the new tab button and background tab text can switch between active/inactive window states. Change-Id: Ib67d11c720c58036cb255aee743916d6a8f2bab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063737 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742803}
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of separating the strings into specific files. Strings used by both Chrome OS and Chrome browser settings sync control subpage and settings signout subpage are removed from setting_strings.grdp and added into shared_settings_strings.grdp. This effort was started in parent 2042733. Bug: 967883 Change-Id: I2c41bd3589f357bd5b2496f4eaeecccae2e00ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044478 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Ella Ge authored
TBR=sahel@chromium.org No-try: true Bug: 1054103 Change-Id: I609442d233fdca819d1070087b2fec9a54b61edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064473Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#742801}
-
Ahmed Fakhry authored
TBR=oshima@chromium.org BUG=none Change-Id: I2b483d216edc3d12c8b64a926d0e68de6efdfab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064814 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742800}
-
Daniel Murphy authored
For the histograms: WebCore.IndexedDB.BackingStore.DeleteDatabaseStatus WebCore.IndexedDB.BackingStore.OpenFirstTryResult The data is good, I just have the wrong enum specified. This change fixes that. R=mpearson@chromium.org Bug: 1026889 Change-Id: I7213c6b576e9a94c50e875c856721181d7efb1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064817Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#742799}
-
Travis Skare authored
This is towards servicification. Bug: 1050259 Change-Id: Ia32c670da08b2026b46b8e64030e1f2054a19a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045136 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#742798}
-
Ella Ge authored
test is flaky. TBR=sahel@chromium.org No-try: true Bug: 1054062 Change-Id: I761b165af9cfa93747cedd55ba96416c5c96a810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064825Reviewed-by:
-
Ella Ge authored
test is flaky TBR=rouslan@chromium.org No-try: true Bug: 1054058 Change-Id: I5cde06091075615d5d879455154bf20c7cf288db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065134Reviewed-by:
-
