- 07 Nov, 2019 40 commits
-
-
Jun Mukai authored
Sometimes the screen width can be odd numbered, and the current logic will end up with a slight gap between the snapped bounds. This CL fixes the logic, the width will be based on the mid point of the work area. Bug: 1020351 Test: the new test case Change-Id: I8d4e3a7cac6ecf5ab4b18e5f6f5404223e88c9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902766Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#713501}
-
Monica Basta authored
We never show the profile name if it is equal to GAIA name, e.g. Matt (Matt), in that case the profile name will be the GAIA name: Matt. In case of ambiguity, we prefer showing 'Person n' over showing redundancy. Bug: 1022438 Change-Id: I8f5e6a959a70ded588b435000a69e59bf7e2a762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904189Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#713500}
-
Yue Zhang authored
Bug: 1019101 Change-Id: Ie59028544a1953282a683f8740efc5fcc41e6d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895161Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713499}
-
Abhijeet Kandalkar authored
While migrating code to new mojo type it is noticed that files versioning_apptest.cc and versioning_test_service.cc are not used by any platform. This CL removes unwanted code from codebase. Bug: 955171, 978694 Change-Id: Ifcbdb7d6bb4970ff960d31129cc0bd3dc159bf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903244Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#713498}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLScriptElement> and DynamicTo<HTMLScriptElement> as new downcast helper 2. Use IsA<HTMLScriptElement>(element) in place of IsHTMLScriptElement(element) Bug: 891908 Change-Id: I7d041de56e0bfc57ba61a1b49f14f6f26d78f5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899638Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#713497}
-
Mike Pennisi authored
Use an object with a null prototype for the internal mapping of names to cached values. This reduces the likelihood of unintended interaction with the environment (e.g. when new enumerable prototypes are defined on the Object prototype). Update the testing code so that this change is verifiable. Bug: 1014780 Change-Id: Ifbdc8d09c1049d0ec07f7a0099d774579423cdb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894707Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713496}
-
Mark Cogan authored
When closing the last incognito tab, the tab grid pauses briefly before scrolling to the regular tabs page. With VoiceOver enabled, the text on the Incognito page gets focused before this scrolling happens, which causes the scroll view to stay on the regular tabs page. (See the bug for more details). This CL removes the delay in scrolling when VoiceOver is enabled, immediately scrolling to the regular tabs page when the last incognito tab is closed. This prevents the timing issues that cause the text focus error. Bug: 980844 Change-Id: Idee32ce9863579372de9383644b3f24d02342960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899995 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Auto-Submit: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#713495}
-
Lucas Furukawa Gadani authored
The browser process will now notify the renderer to report a content security policy violation. Bug: 759184 Change-Id: I1a4f8fc82d522c67d7587c0dd9b65550c9354ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857202Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713494}
-
Peter Boström authored
This accounts for additional internal padding which is present for leading/trailing buttons when maximized / in fullscreen. Bug: None Change-Id: If6841101172316174d2bce5b6091d2f31e9f197b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903652 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#713493}
-
Brian Salomon authored
Change-Id: I7fedc818b6fad5c08f37c8002268c65eefdf57a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757345 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#713492}
-
Etienne Bergeron authored
The CL is fixing a bug when the rewriting loop iterate through the input text. If the codepoint is updated with a larger codepoint, the next_offset was not updated properly and was pointing in the middle of the surrogate pair. This was not happening since only the PUA codepoints were producing larger characters. Change-Id: I4c6eea9a1a02374d04a0271bd4d6140e123069ba Bug: 4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903808Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713491}
-
Christopher Cameron authored
A few issues here: First, actually wire up NativeWidgetNSWindowBridge as a DisplayObserver. In the past, it didn't matter that this code was missing, because we were getting notified via windowDidChangeBackingProperties. In Catalina, that call is happening at a different time, resulting us using an invalid cached version (which is the second issue). Second, change GetDisplayNearestWindow to call UpdateDisplaysIfNeeded. There was a bug here wherein we would return displays_[0], even if we knew (because of displays_require_update_) that that value was out of date. Thid, make GetCachedDisplayForScreen be robust to getting a surprise NSScreen* that we didn't know about. On Catalina, it happens that we can read -[NSScreen screens] and see that it has changed, before having received any notifications that such a change would happen (!). Fourth, listen for NSApplicationDidChangeScreenParametersNotification notifications. Just because it sounds like a healthy thing to be doing. Bug: 1021340 Change-Id: Ibe5a6469d9e2c39cd81d0fb19ee2cfe3aedb1488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902508Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#713490}
-
Roger Tawa authored
Bug: 1021949 Change-Id: I0b3ae7dcb2c53902f010820f839f8a85414f888d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903950Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#713489}
-
Dmitry Torokhov authored
The dispatcher state will reside in daemon store/cryptohome instead of global stateful to avoid cross-user information disclosure, so it needs to know cryptohome ID of the session owner in order to bind-mount the right state directory. Bug: b:143443446 Change-Id: Id29b10f2981fe9e919fe41d3e0f4c3832bde1654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899838Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#713488}
-
Jonathan Ross authored
A few tests were timing out on Linux + Intel bots. However they pass when the timeout is increased. Marking these tests as slow on Linux to address this. TBR=backer@chromium.org Test=vulkan_native_blink_web_tests Bug: 1018884 Change-Id: Ib2c0197e5f163ced2f76b7ba929f7c589f973de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900553Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#713487}
-
Etienne Bergeron authored
This CL is writing the invalid codepoint by the replacement characters. See https://unicode.org/reports/tr44/ """ Noncharacter_Code_Point : Code points permanently reserved for internal use. """ Bug: 1011818 Change-Id: Id39b42f52a8c36887fabcd81e794f46ebedec089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902772Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713486}
-
Sylvain Defresne authored
The class OCMockComplexTypeHelper does not really need any of the behaviour coming from GTMLightweightProxy, so reimplement it as a subclass of NSProxy directly. Bug: none Change-Id: If66eca04df012853d0e619c44ca3f5bc18f5ffdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903135 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#713485}
-
Demetrios Papadopoulos authored
This is in preparation of turning on such PRESUBMIT checks for src/components. Bug: 1019312 Change-Id: I352cf547b8ea51cb6eba3a8715122c2129948cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902065 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#713484}
-
Elly Fong-Jones authored
Some unit tests need access to the footnote view of a dialog. This change adds a method to DialogDelegate to get the footnote view, and changes a test suite (BookmarkBubbleTest) to use it. Bug: 1011446 Change-Id: Ica62c0512a36b6f58c26b3ad8e9694e6a7c2cbad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900363 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713483}
-
Mei Liang authored
Change-Id: Ibc533ed36bdb3d9d14c1bc538ebd8705f72f48eb Bug: 983170, 1022200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902064 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713482}
-
Joshua Pawlicki authored
We are still removing profile statistics, as it turns out... Bug: 988772 Change-Id: Ibb1bb81ea309f101371983d9ca3d7763620e0db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900251 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#713481}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dcd90b1f880a..62a814392cf5 git log dcd90b1f880a..62a814392cf5 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 treehugger-gerrit@google.com Merge "TrackEvent: Add support for interned state" Created with: gclient setdep -r src/third_party/perfetto@62a814392cf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Icea7bb0f927b970cec332536d304510620ccf17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713480}
-
Hongchan Choi authored
This reverts commit b2af1539. Reason for revert: Compile error. Tree closer. Original change's description: > Fix crash when exiting mirror mode on tablet > > Attempting to create ShelfWidget while shelf is in-app is causing > a crash because ShelfWidget::DelegateView::UpdateOpaqueBackground is > called before the widget is initialized. > > Moving that call from ShelfWidget::DelegateView constructor into > ShelfWidget::DelegateView::OnWidgetInitialized. > > Added a unit test. > > Bug: 1021662 > Test: manual, DisplayManagerTest.ExitMirrorModeInTabletMode > Change-Id: I32a5f91c834d673b109ab518bc2600908d8dea5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902273 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713464} TBR=kaznacheev@chromium.org,oshima@chromium.org,manucornet@chromium.org Change-Id: I5d10ed4db037ddc3cde303cdaf5771dd7d818d62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904329Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713479}
-
Juan Antonio Navarro Perez authored
These tests just want to know whether a Chrome trace has been recorded or not. The implementation prior to this CL used to verify whether a serialized trace.html was recorded after finishing running the story; but this will no longer be the case after serialization is handed over to results processor. Bug: 981349 Change-Id: I39dec39db349cdce6334d950b392fff0d66a001a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903145 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#713478}
-
evliu authored
This CL contains the changes to the watch time recorder and media metrics provider to save media playback data to the media history store. Bug: 997813 Change-Id: I141671b6695f37a1e23fcb446d7153fa9cacd9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885027Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#713477}
-
Peter Kasting authored
This reduces memory and CPU use during browser startup and more than eliminates the perf regression from r706189. Bug: 1021323 Change-Id: I10b4cf053d73fc0b38c89a35f7786635b06986ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900403 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#713476}
-
Scott Violet authored
This reverts commit 0b9effbc. Reason for revert: looks like this broke try bots, see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8897429937364092048/+/steps/compile__with_patch_/0/stdout Original change's description: > weblayer: fixs enum conversions > > These got lost in the rename. > > BUG=none > TEST=none > > Change-Id: Ifea2d13329f4a2c739657d918ae93c929ede5499 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902708 > Auto-Submit: Scott Violet <sky@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713455} TBR=sky@chromium.org,jam@chromium.org Change-Id: Ib68648d7601f6d940dc6a8d509ac32535940fcb2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904327Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713475}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/075cc4c355a6..652dbfc63e70 git log 075cc4c355a6..652dbfc63e70 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 jmadill@chromium.org Init Blend State color mask defaults. 2019-11-07 lehoangq@gmail.com Metal backend pt3: shader translator 2019-11-07 jmadill@chromium.org Capture/Replay: Introduce capture index file. 2019-11-07 jmadill@chromium.org Capture/Replay: Pass gl::State to capture functions. Created with: gclient setdep -r src/third_party/angle@652dbfc63e70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I91538a1b755b8d2f78a7dca60af0ccc22a7e0706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713474}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d6b9a1ca930..f9004ee81c43 git log 6d6b9a1ca930..f9004ee81c43 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 perezju@chromium.org Revert "[Telemetry] Hand over trace aggregation to Results Processor" 2019-11-07 perezju@chromium.org [Telemetry] Hand over trace aggregation to Results Processor Created with: gclient setdep -r src/third_party/catapult@f9004ee81c43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:981349,chromium:981349 Change-Id: I6a18ee6ead5fd36657b2da8c809adf84c54ac6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903673Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713473}
-
Jeremy Roman authored
Revert "Reland "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map."" This reverts commit 21cf7ca9. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1019839#c39 Original change's description: > Reland "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." > > This reverts commit bdc5aa8e. > > Reason for revert: Crasher has been stealth-fixed, see https://crbug.com/1021171. > > Original change's description: > > Revert "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." > > > > This reverts commit 481fb0c1. > > > > Reason for revert: speculative revert for crbug.com/1019839 > > > > Original change's description: > > > Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map. > > > > > > Change-Id: I6ef8b0098a795dc550037306e7b972ea907b0fc1 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884285 > > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#710616} > > > > TBR=jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: Iba339b519f2aa602773ceb79c95948c1cffdcbdb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893282 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711289} > > TBR=ulan@chromium.org,jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Iae455af51181d191f08e7af16cd8a1413aea2b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899783 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712945} TBR=ulan@chromium.org,jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ibac7d4ca203761eb2d472cd40364529976e688bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903608Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713472}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df4d2ded..efd8b7f5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb846f242e998671b66b0f6a78c2765017f6d143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902436Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713471}
-
Sebastien Marchand authored
TabLifecycleUnit are only created once their WebContents gets added to the tab strip, which can lead to some inconsistencies for the PageNode properties mirrored in the TLCU class if they change before it happens. Change-Id: I701b60195ec145d1dfd0febd5384bab2519cdef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898106 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#713470}
-
Yoav Weiss authored
Feature Policy control over Client Hints in 3rd party contexts currently only works (behind a flag) for subresources. This CL applies that control also over 3rd party iframe navigation requests. On top of that, in order to make this testable with WPTs, this CL also adds a ContentShell persistency layer for Client Hints. Bug: 989898 Binary-Size: Virtual ForTesting method Change-Id: I17ce2af93c9b2f9a3f10972b6b4e0ed8161f9381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728577Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#713469}
-
nancy authored
Design doc: go/app-service-instance-registry-design-doc go/appservice-for-per-app-time-limit-design-doc This CL adds the App Service Instance classes: Instance InstanceUpdate InstanceRegistry InstanceRegistry depends on Instance and InstanceUpdate to calculate the instance updates to notify the client. BUG=1011235 Change-Id: Ia4f41304f1034bd33000c9a6235633054a1baeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902172Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713468}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/23247b993215..9ab047e78be3 git log 23247b993215..9ab047e78be3 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 jaspercb@chromium.org [tricium] Add string_view to list of C++ headers Created with: gclient setdep -r src/third_party/depot_tools@9ab047e78be3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I037deddd2a51ea5ed38df5ebd08af46357e47119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713467}
-
Andrew Grieve authored
annotationProcessorConfig is now unused and provides no value over buildCompile FALLBACK_PROPERTIES: * Fix overrides being ignored for Java and Android deps. * Added isShipped override. Bug: 693079 Change-Id: I67da37bfdd03e04e39dc0cb293b861aff339a9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903829Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713466}
-
Hongchan Choi authored
This reverts commit ded13f7d. Reason for revert: Build Failure (Tree Closer) Original change's description: > Followup cleanup for ProfileSyncServiceUsesTaskScheduler experiment code. > > 1) Remove sync_thread_ from the ProfileSyncService interface to avoid > accidental use. > 2) Enable experiment in tests to provide coverage. > 3) Add some ScopedAllowBaseSyncPrimitives in code that needed it. > > Bug: 1014464 > Change-Id: I79393edac048a2960b4f2bc7593be326f5d27419 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895797 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713459} TBR=fdoray@chromium.org,mastiz@chromium.org,olivierli@chromium.org Change-Id: I40c10c06af767261b7e8173db77d8a5b6224e297 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903833Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713465}
-
Vladislav Kaznacheev authored
Attempting to create ShelfWidget while shelf is in-app is causing a crash because ShelfWidget::DelegateView::UpdateOpaqueBackground is called before the widget is initialized. Moving that call from ShelfWidget::DelegateView constructor into ShelfWidget::DelegateView::OnWidgetInitialized. Added a unit test. Bug: 1021662 Test: manual, DisplayManagerTest.ExitMirrorModeInTabletMode Change-Id: I32a5f91c834d673b109ab518bc2600908d8dea5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902273Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#713464}
-
Andrew Grieve authored
Change-Id: I07460e38136338fd944adee6dabd837380b6df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903960 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713463}
-
Andrew Grieve authored
Change-Id: I293c4ea85a90edbfcb28cbcf7bd3f1201550f3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902912Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713462}
-