- 19 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d25c77940d2..889563cbeb36 2020-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fa3d64bf72d6 to c81f0b7b921f (6 revisions) 2020-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7a1d99d0be42 to eb6824408d08 (3 revisions) 2020-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2adbb514 to 4a914f21 (507 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1096510 Tbr: djsollen@google.com Test: Test: Test: angle_perftests --gtest_filter="*Trace*" Change-Id: I1a8fe09803d08e91f185ea5495720f1576a37eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780208}
-
Alexander Dunaev authored
The drag handler delegate should receive the resulting drag and drop operation via its OnDragFinished, but the Ozone/X11 implementation returned 0 always. This CL fixes that. Bug: 1014860 Change-Id: Ie339b7c7beb374bc58d08a332c2b817b8dc0b04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253738Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#780207}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. By this CL, HistoryManager uses IdentityServicesProvider functions with the profile generated regarding to isIncognito parameter from the constructor. Bug: 1041781, 1075562 Change-Id: I04c0a14b5f9e912cda7fb34a581bea4d18023518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242078Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#780206}
-
Tal Pressman authored
For now, the only active strategy is a "no-op" strategy that has no effect on scheduling behavior. This CL also includes 2 implementations of strategies that (i) disables or (ii) de-prioritzes timer queues for non-main agents, if there are still main frames waiting for FMP. This CL also fixes a UAF bug exposed in frame_scheduler_impl_unittest: frame_scheduler_ was reset after delegate_, but could still access the "old" delegate. Now, the new delegate is created first, passed to the new (reset) frame_scheduler_, and finally delegate_ is reset. Change-Id: Ibd24fc742de5b048495af924122e2a095462f4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206301 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#780205}
-
Matt Falkenhagen authored
This adds initial support for doing full prefetching of subresources, beyond preconnecting to their hosts. The code is gated behind a feature flag kLoadingPredictorPrefetch. The PrefetchManager logic is strongly based on the PreconnectManager. But splitting them into two separate classes seemed cleaner overall. Bug: 1092329 Change-Id: I26b244105d59e8765fc24c109ec165b7def39f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235192 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780204}
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: Ibd0c765f6a6af28ae91eccdc69997bc53ee4abfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249400 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
calamity authored
Bug: 1096670 TBR=ntfschr@chromium.org Change-Id: Id46aea904a83e918c0a819d604f24db4654723f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251782Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#780202}
-
Christopher Lam authored
This CL refactors the model to more closely match the data. In particular, the model used to be colors[mode][name] and is now colors[name][mode], which matches the data. This is in preparation for implementing opacities, a 'generate-dark-mode-only' mode, and dark-mode-agnostic properties. Other minor changes: - BaseGenerator.colors is now BaseGenerator.model[VariableType.COLOR] - ModeVariables now has methods that let it be used more like a dict() Bug: 1018654 Change-Id: I5422178053434b49ac64a6290983092cbbbf0ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245968 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#780201}
-
Tal Pressman authored
Change-Id: I9689fd0a2501e810e0ea1ac91d8042e697b5f422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253599 Commit-Queue: Tal Pressman <talp@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
This adds settings page to Ash HUD and makes HUT semi-transparent. Just the HUD: https://screenshot.googleplex.com/ZBqYnQDomH5.png With the settings button: https://screenshot.googleplex.com/pNCfTAw9J92.png With settings UI displayed: https://screenshot.googleplex.com/SwyNb0xVDbc.png Bug: 1075612 Change-Id: I9f26e8b99f03e0d638f854312820f10ec25ee6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223974 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#780199}
-
Lingqi Chi authored
This CL replaces "whitelist" with "allowlist" in IgnoreErrorsCertVerifier. Bug: 842296 Change-Id: I501b451fbb76dc48e5977b2a855913ee79028462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247947 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#780198}
-
Louis Collard authored
These still seem pretty relevant given the recent issues DA lockout. Bug: 1089292 Change-Id: If8c21536a30b3d57cc035c59a9669c1b9ffc81a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241056 Commit-Queue: Louis Collard <louiscollard@chromium.org> Auto-Submit: Louis Collard <louiscollard@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#780197}
-
Callistus authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/tpCFs6vz-vM58hBheqFjcjl6XHXroSgYifCz3f5OmjsC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202006180800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I384a64a1ec217ee6d7148e8e2f1b2ae9527345f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251522Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#780196}
-
calamity authored
TBR=wjmaclean@chromium.org Bug: 1092915 Change-Id: Ic2a2b55c695126547e1e11385adf4e235d627c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253484 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ec44eb332577..dd945dd1c033 2020-06-19 rwkeane@google.com Discovery: Add support for non-cyclic SRV pointers 2020-06-19 rwkeane@google.com DNS-SD: Update DnsDataGraph 2020-06-19 rwkeane@google.com Discovery: Add support for subtypes to the public headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I017657733b50b9d8e899d62bd8754edb8b8aa5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253233Reviewed-by:
-
Louis Collard authored
There is no data and no mention of it in the codebase. Bug: 1089292 Change-Id: I11ac83d0243248887d19524026ed05dbe90ab595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241055 Commit-Queue: Louis Collard <louiscollard@chromium.org> Auto-Submit: Louis Collard <louiscollard@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Instead of "Ignore", use "Keep it". Bug: 1079364 Tbr: treib@chromium.org (per offline discussion) Change-Id: I8905d3576b129a064d124007fa1ed9317c280ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253367Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780192}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d610c751569a..3d25c77940d2 2020-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 3f4f35661151 to 581c407cd20b (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Id64378920af5d7df7add8db5d33af06f3c622f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253010Reviewed-by:
-
David Bertoni authored
This CL moves the test to the interactive_ui_tests test suite. This fixes the flakiness with the test since the main window needs focus for the test to work properly. Bug: 477691 Change-Id: I0d8ab99a80a47c11ed9cc676a5fde23fa21b4c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252600Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780190}
-
Henrik Boström authored
The ThermalResource reports kOveruse or kUnderuse every 10 seconds while it has a registered listener and the DeviceThermalMeasurement is known. Because OnThermalMeasurement() only happens when the thermal state changes, repeated kOveruse is needed to adapt multiple steps. Based on [1] and manual observations, we do not want to adapt if thermals are kNominal or kFair so we map these to kUnderuse. But if thermals are kSerious or kCritical this is a strong signal from the OS that "corrective action" or "immediate corrective action" is needed. It can easily take a minute before the thermal state changes after load distribution has changed, so the effects of ThermalResource is likely to result in either maximally adapted or not adapted at all. The repeated interval of 10 seconds was somewhat arbitrarily chosen but was chosen as a tradeoff between giving the OS time to measure the new load and not making the resource too spammy. This CL implements and tests the resource, but does not wire it up to the webrtc::PeerConnection or RTCPeerConnectionHandler::OnThermalMeasurement(). This will be done in a separate CL. [1] https://developer.apple.com/library/archive/documentation/Performance/Conceptual/power_efficiency_guidelines_osx/RespondToThermalStateChanges.html Bug: chromium:1094844 Change-Id: I7dee0842ba786babbacb7e9d19acb58a1c9daa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247769Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#780189}
-
Sophey Dong authored
Bug: 1079467 Change-Id: I492cd2771ddac88710a9219b8335eafdccf707c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246146 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#780188}
-
Robbie Gibson authored
This adds CacheStorage blocking to the list of other storage methods blocked as part of the cookie blocking process on iOS. To more closely emulate desktop, it returns a rejected promise with the same error message. Bug: 1085123 Change-Id: If6ceed88e601b594c74c2580c26f8a183c9fba7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247883Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#780187}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I372835fba2738adaef15f3324a471870c338649d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253211Reviewed-by:
-
calamity authored
This reverts commit f248d2a2. Reason for revert: Suspected of causing failures for AuraWindowVideoCaptureDeviceBrowserTest.* https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19215 Original change's description: > When Serializing the CopyOutputRequest use the threadpool for expensive copies. > > Currently when Chrome requests a screenshot we send a CopyOutputRequest > from the browser. However while taking this screenshot we need to > transfer it over a mojo pipe. This serialization takes 100-200 ms an > example traces in the linked bug on the VizCompositor thread and then > another 100-200 ms to deserialize it on the CrBrowserMain. This can > block high priority tasks which delay input handling causing visible > jank to users. > > We fix this by doing the expensive copies on the ThreadPool, most other > copy tasks only take a couple ms so this removes most of the pain > relatively easily. > > Tests had to be updated to know to wait for > CopyOutputResult::SendResult to complete async. > > > Bug: internal b/152858656 > Change-Id: I114d65894c80742309bc2a02fdd2a0a7ad56dae7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201762 > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Mitsuru Oshima (slow:gardening) <oshima@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779930} TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,eseckler@chromium.org,nuskos@chromium.org Change-Id: I7c3a2011728b442580dd2c2da4816c0426649a4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: internal b/152858656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253678Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c6db4598. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ib68cda916467447de5f5371f59c757b42e312a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252881Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780184}
-
Thanh Nguyen authored
If a token is skipped during matching process, consider it as no match Bug: 990684 Change-Id: Ib9850afdf542c48d37202ddb085f39c6fa711fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249264 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#780183}
-
Hiroki Sato authored
CL:2244656 resolved old dependencies and specific include rule for this directory is no longer needed. Test: No pre-upload warnings. build passes. Change-Id: Id70a2cb1886bc2e881b4896fc7b04efbdf74b002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249262 Auto-Submit: Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#780182}
-
John Abd-El-Malek authored
Bug: 1096390 Change-Id: I83d9062895cdc29c6f21b815105123b376472085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251054 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780181}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1cdd473e5bca..ec44eb332577 2020-06-19 rwkeane@google.com mDNS: Add new OPT record type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I68e242aed351d24fd3716c3dbc20218727877919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253519Reviewed-by:
-
Joel Hockey authored
Change-Id: Ieab59bdd9f9568977b570aa108b50759f881a787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251572 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#780179}
-
Joel Hockey authored
Bug: b/158509828 Change-Id: Ic900dd5381396f7fc6e93c7e77ddf506f2eacfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251863 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
-
Joel Hockey authored
CrostiniApps is currently registering all the pvm apps which are showing up in the launcher under Linux files folder. We don't want this to happen. Bug: b/158617133 Change-Id: I92a4ca77be9d2996365be3b5ca1455e9ec76124e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251571 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1ca66dca905..4c137c524b78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085525,chromium:773403 Tbr: calamity@google.com Change-Id: I663cf465cfc3129606924719f789352182fc7bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253226Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780176}
-
Yoshifumi Inoue authored
This patch changes |DragController::CanProcessDrag()| to pass point in frame to |HitTestResult::IsSelected(point_in_frame)| instead of point in root, because |HitTestResult::IsSelected()| calls |LayoutView::HitTest()| which takes point in frame. The change of "fast/lists/drag-into-marker.html" verifies this code change. Change-Id: Ic95b16692fa73ea42ce62acac1fc868efd54a436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251607 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780175}
-
Kent Tamura authored
This CL fixes a regression caused by crrev.com/745230. Bug details: Suppose that |select.innerHTML = '<option selected>Option1' + '<option selected>Option2'| runs. Before crrev.com/745230, 1. Option1 is appended to the SELECT. 2. HTMLOptionElement::InsertedInto() and |HTMLSelectElement:: OptionInserted()| are called for Option1. 3. SelectOption(Option1) is called. 4. DeselectItemsWithoutValidation(Option1) is called 5. Option2 is appended to the SELECT. 6. HTMLOptionElement::InsertedInto() and |HTMLSelectElement:: OptionInserted()| are called for Option2. 7. SelectOption(Option2) is called. 8. DeselectItemsWithoutValidation(Option2) is called. Option1's selected state is cleared. Since crrev.com/745230, 1. Option1 is appended to the SELECT. 2. Option2 is appended to the SELECT. 3. HTMLSelectElement::ChildrenChanged() and |HTMLSelectElement:: OptionInserted()| are called for Option1. 4. SelectOption(Option1) is called. 5. DeselectItemsWithoutValidation(Option1) is called. Option2's selected state is cleared. 6. HTMLSelectElement::ChildrenChanged() and |HTMLSelectElement:: OptionInserted()| are called for Option2. 7. SelectOption(Option2) is NOT called because Option2's selected state was cleared. Fix: DeselectItemsWithoutValidation() should not update 'selected' state of OPTIONs for which OptionInserted() is not called yet. This CL adds a boolean flag to HTMLOptionElement, it represents whether OptionInserted() is called or not, and DeselectItemsWithoutValidation() checks the flag before updating 'selected' state. Bug: 1095725 Change-Id: If19b28c3edb877549ca498b661647466d03e6d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253260 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780174}
-
Christopher Lam authored
This CL fixes a bug where Validate() wouldn't catch that a color wasn't defined for the default mode. It also adds some tests. Bug: 1018654 Change-Id: I226124d6a4fc51020b96e85309fda42a98132abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251126Reviewed-by:
-
calamity authored
Bug: 1096911 TBR=ellyjones@chromium.org Change-Id: Ib791c12d6fb737766bf614aca41dbc131054ff97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253482Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/72e8dbac26a8..b76d781b4f8f 2020-06-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaa8013143f22dc5b8fcdba5fc25375130e55a51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253228Reviewed-by:
-
Lachlan Ford authored
On Windows Core OS systems, the character limit for the app container name is 50 characters. Chromium currently supplies app container names > 50 characters. This change shortens the sandbox process names. Change-Id: Id64d511bd2eefeceeb89c52dbf6fde87ce7f82fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234995Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I15704fa86d635972d483ef1b681b083c7ea4f6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253462Reviewed-by:
-
