GitLab

R=pkasting@chromium.org

Bug: 1045684
Change-Id: If2cd41468f23949b2b42dda35ebee99a9297ec76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023346
Auto-Submit: Stephen Lin <stephenlin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736209}

- Previously we appended the license to the os-credits page URL.
- This is incorrect as we need to create the URL with the license
  as a reference fragment. eg. chrome://os-credits/#license
- Update tests to reflect this.

Bug: 1044646
Test: unit + browser tests
Change-Id: I0bbb8067cbffdbcd14ab1ff4b37014c8ef7424ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015674
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736208}

After r735931, Mac web_tests run with smooth scrolling enabled like
other platforms. However, this makes some web_tests flaky. These are
proving difficult to find so I'm marking them flaky for now rather than
constantly revert/relanding the code changes.

TBR=flackr@chromium.org

Bug: 944583
Change-Id: Ifdf21c5550bf0982d5d8d4f83a29cff22865f3a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026754Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736207}

R=yigu@chromium.org

Bug: 1043465
Test: run 100 times and no flaky
Change-Id: I64aef46f8f61a5bde32d678a91301f9ea9304b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026508Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima (slow in TOK) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736206}

This CL adds the metrics which indicate whether the drag on window
from shelf ends normally or gets canceled.

Bug: 1041609
Change-Id: Ibbbce1b3523558340fe299e3e4ecc139573bba4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023852Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736205}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6148d3266a2..b8692a1901e0


Created with:
  gclient setdep -r src-internal@b8692a1901e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1012975,chromium:1023913,chromium:1034774,chromium:1039877,chromium:1045987,chromium:927262
Tbr: jbudorick@google.com
Change-Id: Iabf5f8a43f7e5040fca0e16ed9d954141582196f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026171Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736204}

When shelf is under gesture scroll, the scroll animation to adjust the
scroll offset triggered by bounds change may conflict with the scroll
gesture. As a result, user will feel hard to scroll the shelf during
bounds animation. This CL prevents scroll animation from being started
if shelf is under gesture scroll along the main axis.

Bug: 1046568
Change-Id: Ib5d00c457e442e657d928046a4f03a43093f0a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026173
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736203}

I've also added jiameng@ as an owner to the metrics while I'm here.

Bug: 881215
Change-Id: Ia14c2314775d2e3eaff84334f0aca4edab986757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010597
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736202}

TODO: handle context menus for extensions opened in windows.

BUG=1038487

Change-Id: I88607aef9465bff272362acb96e17ee370e72607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022585Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736201}

Suspected culprit CL: https://crrev.com/c/2006485

TBR=lazzzis@google.com

Bug: 1046317, 1046316, 1045729
Change-Id: I44124aeb3d9729bda8eac714998a2ef24de9ad79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026255Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736200}

Bug: 1036490
Change-Id: Ib8bec196e208c0bbb86ec670ba48a7b2c859d565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025914Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736199}

This is a preparation work for adding support for renaming desks.

BUG=1040980
TEST=Manual, no change in functionality.

Change-Id: Ic5f846a0ef1f8fa6c975ec06a22263ce99107846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026692Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736198}

This adds a new interstitial page for the legacy TLS warning. It
generally follows the SSL interstitial, but with different strings and
a different icon (the (i) info icon).

The test interstitial is available at chrome://interstitials/legacy-tls

Screenshot: https://drive.google.com/file/d/1MkWCqWKtQwo7k-ybYjKotYJDjTzRwcd0/view

This also refactors the legacy TLS browsertest classes slightly, basing
them on SSLUITest rather than CertVerifierBrowserTest, brings in the
mock cert verifier explicitly. It also adds a SetPolicy() method to
SSLUITestBase (to complement the EnablePolicy() method, but for policies
that take base::Value types, in this case for the SSLVersionMin policy).
Overall, this makes for a slightly simpler class structure and lets us
reuse all of the infrastructure setup by SSLUITest (since
CertVerifierBrowserTest is fairly simple in comparison).

The new cert error is introduced in https://crrev.com/c/1894616. Support
for the control site list will be added in https://crrev.com/c/1906779.

Bug: 896013, 1039756
Change-Id: Ic3242178239ac8c68d02fe0a2a21a52638146580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940707
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736197}

In the function ‘Tab:OnMouseReleased’, fix the tab to close only if the mouse event is a middle click.

Bug: 947613
Change-Id: I7248b014f9774fe33f49de7f8c8f1ef08cc9d862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024134Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736196}

Enables OpenXR as a default VR backend.

Change-Id: I620c01a7a674c32874a83d2551f4b1c94663b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001581Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Lachlan Ford <laford@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#736195}

Defaults to 1.

Bug: 1023485
Change-Id: Ia76fe2e0150b60f3a4e15b5bcdb674de63899c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025570
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736194}

We are not settings these parameters, and have no plans to set them.

Bug: 1044139
Change-Id: I7c024b5bf01fafc8771ea2cd3f511ead085360ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012885Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736193}

The "RequestSession" flow for a typical VR Session requires bouncing
calls through a few asynchronous API's via callbacks. Currently there
are four pieces of data which get constantly passed through these
callbacks, as they needed at various stages of the request flow.

Unfortunately, since a second "RequestSession" request may come in
during this asynchronous work, this data cannot just be cached on the
VRService class.

This change cleans up some of the pattern to make this more readable by
creating a struct to hold this data, so that only one object needs to
be consistently forwarded around by the code.

Bug: 1045130
Change-Id: I4a64eaba2944ddfe4304a20e023acc0100c834f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024267
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736192}

This CL adds a test that ensures that a disallowed WebUI Mojo Interface
request crashes the renderer. It also adds a sanity check test that
accesses 2 Mojo Interfaces.

Bug: 936482
Change-Id: I3ad90958cf004e3ea14d08034dd2200a3012f469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981245
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736191}

Bug: 1038368
Change-Id: If6d1831cbda98084e9dfc7ee9387f0b77c96208f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984474
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736190}

Follow up on previous CL by improving comments quality.

R=rjkroege

Bug: 979788
Change-Id: I110404464582bdf6490100fb601dda39ee0aca73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023481
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736189}

Rebaseline of following directories: html, paint, svg, tables

TBR=wangxianzhu@chromium.org

Bug: 1028242
Change-Id: Ieed3a8868fc567633bd8216eade45438ace995b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026367Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736188}

* Assume building with a macOS SDK newer than 10.8
* Assume C++11 strong enums
* Assume 64-bit compilation

Bug: 1044838
Change-Id: I5a21aa1dbd00c5d6999d67ae80f18979c1c49607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025988
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736187}

https://skia.googlesource.com/skia.git/+log/ba9da466cca5..ad9110026bee

git log ba9da466cca5..ad9110026bee --date=short --first-parent --format='%ad %ae %s'
2020-01-29 fmalita@chromium.org [skottie] Separate text resize options
2020-01-28 mtklein@google.com partial strength reduction for bit ops
2020-01-28 egdaniel@google.com Remove create function in proxyProvider that takes a raster SkImage.
2020-01-28 mtklein@google.com tweak grading in gm/skbug_9819 for G8
2020-01-28 mtklein@google.com skvm sweep gradients
2020-01-28 reed@google.com improvements to shaper_ct
2020-01-28 bsalomon@google.com Fix asyncRescaleAndReadPixelsYUV420 fallback w/out GL_EXT_texture_rg.

Created with:
  gclient setdep -r src/third_party/skia@ad9110026bee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: Ie3b608f6804f8a15eee65baa4c0397f57bc667a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026412Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736186}

Change-Id: Id3345773ded119aac8950b7a367ac176b3ef86df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021185Reviewed-by: Simon Que <sque@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736185}

A screenshot of the layout with these updates is here: https://drive.google.com/open?id=1-FooiiizmrwZSq9B_SXrkhdOiVhSZT_K

Bug: 1040661
Change-Id: I7b5579d9d44807b979484e58dcb273507c3e3c0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024067
Commit-Queue: Josh Simmons <jds@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736184}

Bug: 1041576
PRD: go/roti-prd
Doc: go/roti-chrome-design
Change-Id: Id5e547f922ce7939563e7a475654a55396954070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999157
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736183}

`entityTypes` are marked as unstable in WebXR Hit Test Module draft spec
and are not to be implemented yet - hide them behind blink flag.

Specification can be found here (note the unstable sections):
https://immersive-web.github.io/hit-test/#hit-test-trackable-type-enum
Introduced by PR https://github.com/immersive-web/hit-test/pull/76

Change-Id: I8041db8c7e0b25f197dfd49c3ceb1b0541004ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023288Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736182}

This reverts commit ecd023d3.

Reason for revert: crbug.com/1046604

Original change's description:
> android: Use DisplayAndroid in media
> 
> Bug: 1042063
> Change-Id: I8b61a7ccdbf50703115a0e6b971a02623771756d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019603
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736028}

TBR=dalecurtis@chromium.org,miu@chromium.org,boliu@chromium.org

Change-Id: Iaabe3c76552436d93d0906ef7b047a0030578647
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026354Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736181}

Debugging them took more time than I hoped for, though I may suddenly have
a lead on the SiteForCookies one... but probably need a whee bit more time.

Change-Id: I9126dc57220193bceca04060da6219c7fcfc3bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022927Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736180}

BUG=1012814

Change-Id: I9a35abc722be0e534569cc0c3aae3bbcb28ef29e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025080
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736179}

BrowserAccessibilityComWin inherits IAccessibleText from 2 sources :
- IAccessibleHypertext
- AXPlatformNodeWin

A snippet of the inheritance hierarchy looks like this :
     ______IAccessibleText______
    |                           |
    V                           V
IAccessibleHypertext      AXPlatformNodeWin
    |                           |
    |___________________________|
                |
                V
     BrowserAccessibilityComWin


Because of this, BrowserAccessibilityComWin (BAComWin) must override
IAccessibleText methods even though it only calls the inherited
implementation from AXPlatformNodeWin.

To simplify the inheritance hierarchy and allow BAComWin to only
override what is necessary, AXPlatformNodeWin should inherit
IAccessibleHypertext and return E_NOTIMPL for the hypertext methods
until hypertext implementation can be migrated out of BAComWin.

Bug: 1038767
Change-Id: Ie8b47cbac2de791700852f3298e609b0791e818c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985172
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736178}

Remove leftovers from:
  https://chromium-review.googlesource.com/c/chromium/src/+/1981857

R=pkasting@chromium.org

Bug: 1025561
Change-Id: Ice6d630c82d2513cb4b8823e93db0b5cac695253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025987
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736177}

CHROMEOS macro is defined in third_party/webrtc.
This CL replaces it with more appropriate macro.

Bug: None
Change-Id: I0587d5958963eb38b44372837d8098db774214fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021788Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736176}

https://webrtc.googlesource.com/src.git/+log/ed9a401f277b..b6bf0b2546f3

git log ed9a401f277b..b6bf0b2546f3 --date=short --first-parent --format='%ad %ae %s'
2020-01-28 danilchap@webrtc.org Pass picture_id from generic packetizer through codec-specific field
2020-01-28 steveanton@webrtc.org Remove iceRegatherIntervalRange

Created with:
  gclient setdep -r src/third_party/webrtc@b6bf0b2546f3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I56ab0ee773b04cf97de1b7cc09eed515b1781589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026175Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736175}

This reverts commit d6979edd.

Reason for revert: Caused compile failures.

Sample failed build: https://ci.chromium.org/p/chromium/builders/ci/linux-ozone-rel/108130

Original change's description:
> Move external protocol dialog to intent handling metrics.
> 
> The external protocol dialog class recorded metrics that fall under
> the purview of the intent handling metrics class, so it has been
> moved to be under that class structure.
> 
> BUG=1044710
> TEST=ran IntentHandlingMetrics.* unit tests.
> 
> Change-Id: I156617bb999ca6072c744e117306b48287144c28
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024388
> Reviewed-by: David Jacobo <djacobo@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Commit-Queue: Alex Linker <ajlinker@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736173}

TBR=djacobo@chromium.org,dominickn@chromium.org,ajlinker@chromium.org

Change-Id: I979e53ee6bf23ae8f80cac4eaac7e6c1792d878d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1044710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026888Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736174}

The external protocol dialog class recorded metrics that fall under
the purview of the intent handling metrics class, so it has been
moved to be under that class structure.

BUG=1044710
TEST=ran IntentHandlingMetrics.* unit tests.

Change-Id: I156617bb999ca6072c744e117306b48287144c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024388Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alex Linker <ajlinker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736173}

This CL should expose enough to allow a sort of hello world example,
but is missing critical pieces. This is because the design is not yet
finalized and to try to avoid unnecessary churn.

Bug: 1046069
Change-Id: I330222affdfe547685cfec5981f438b0e4ab4922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023849
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736172}

Reporting of interstitials shown was done in
SafeBrowsingBlockPage::ShowBlockingPage, but when committed interstitials
is enabled, this function is never called. So this CL adds a call to
report interstitials shown by the SafeBrowsingNavigationThrottle, which
will trigger when committed interstitials is enabled.

Bug: 1046525
Change-Id: I06e94f7ecd145352e3be55b3170931479604adf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025930Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736171}

A whole slew of unrelated small changes:

* Use =default more
* Shorten code
* Better use of idioms like GetMainAxis(), ClampToRange(), StrCat(), etc.
* Attempt to improve comments (clearer, briefer, etc.)
* Change some {} constructions to constructor syntax.  Improves compliance
  with
  https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#variable-initialization
  and makes the type in question clearer.
* More use of pass-by-value-and-move where callee always copies.
* Reorder declarations to match definitions
* Eliminate default arg to AllocateFlexSpace(), which just decreased
  clarity slightly
* Remove unnecessary conditionals
* Eliminate else after return
* Declare variables as close to first use as possible
* Implement some equality checks with std::tie() (not required style,
  but mentioned in totw/43 and tends to reduce maintenance hassle when
  more fields are added; is also more consistent with how we already used
  it for some inequalities of these types)
* Fix badly-copy-and-pasted param names
* Remove unreachable code that also defeats warn-if-unhandled-enum-added

Bug: none
Change-Id: Ia0b22e1bc8981a3efc601d48c43180de4fd43f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021293
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736170}