GitLab

NotifyMainFrameSwappedFromRenderManager was added in
https://codereview.chromium.org/950223006, but given its usage (and
its name), it should be only called for main frames.  Calling it on
subframes can lead to incorrectly dispatching RenderViewHostChanged
for a change to a subframe's RVH, which may be a swapped-out RVH for
an OOPIF.  RenderViewHostChanged should only be be dispatched for a
main frame's visible RenderViewHost.

Bug: 817606
Change-Id: Ia47e6a8fe188866f9f26a205c42ad27ff9ff2b23
Reviewed-on: https://chromium-review.googlesource.com/c/1260489Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596770}

Bug: None
Change-Id: Id6d3f0166185246f63e4c6ed1364a3fe8eb37572
Reviewed-on: https://chromium-review.googlesource.com/c/1262036Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596769}

Bug: 801585
Change-Id: I956c90e6e6d6f966a294263da8392bf12da4914f
Reviewed-on: https://chromium-review.googlesource.com/c/1260486Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596768}

This matches the non-iOS behavior from:
https://chromium-review.googlesource.com/c/chromium/src/+/807347

BUG=792662

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5f45059c4f874911d667187d48ea3848e62060cb
Reviewed-on: https://chromium-review.googlesource.com/c/1130472
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596767}

Use old instrumentation on Mac because of PC Table mismatch with 8-bit
counters.
Also fix comment misstating default value of sanitizer_coverage_flags.

TBR=mmoroz@chromium.org

Bug: 892167
Change-Id: I8c69911dd88630dcb382891b4b7e7ed885fced4b
Reviewed-on: https://chromium-review.googlesource.com/c/1262077
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596766}

Bug: None
Test: Local build
Change-Id: I69cab07f639ec7ae0bb1c848c78ad6cb7c19bdd8
Reviewed-on: https://chromium-review.googlesource.com/c/1260490Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596765}

Bug: 891980
Change-Id: I0cf05a9dfd9eccce9765cdfa5ed238bc990bd636
Reviewed-on: https://chromium-review.googlesource.com/c/1260512
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596764}

This also add a login helper for tumblr and updates credentials.json

Bug: 878390
Change-Id: Iba56faf550cb638692899326b217347e04be9932
Reviewed-on: https://chromium-review.googlesource.com/c/1256883Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596763}

when there isn't an explicit ALLOW permission.

Bug: 886896
Change-Id: I25250b65b9ea2a7fb5b3c0d43a4ebafe566b4ce1
Reviewed-on: https://chromium-review.googlesource.com/c/1255162
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596762}

Update the presubmit check to use clang-format instead of gjslint
which is deprecated.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I13b58f6d3c72a67fc58ee52c351a196b68953742
Reviewed-on: https://chromium-review.googlesource.com/c/1261720
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596761}

When an SVG image has animations, SVGImage::ServiceAnimations is called
which updates animations via DocumentAnimations::UpdateAnimations. For
blink generated property trees (BGPT), this is done during paint (see:
LocalFrameView::RunPaintLifecyclePhase) and, because paint is skipped
when updating svg image animations, it must be explicitly invoked for
svg animations. (For non-BGPT, this is done as part of the compositing
step which precedes paint). Updating animations may invalidate the SVG
image's paint layers.

Before this patch, the paint layer invalidations were cleared which
caused the later svg image paint to incorrectly use stale paint data.

Bug: 884240
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If21335672f55db0b937505c6475f55def0be14ac
Reviewed-on: https://chromium-review.googlesource.com/c/1261718Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596760}

These histograms are recorded only in suffixed forms: appending
"WarmStartup" and "ColdStartup". This tiny change would avoid suggesting
the base name in the UMA dashboard.

Bug: None
Change-Id: I3d59ddfed562049e7caa7c54bc82be07bc6907c0
Reviewed-on: https://chromium-review.googlesource.com/c/1261983
Commit-Queue: Egor Pasko <pasko@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596759}

Bug: 814405
Change-Id: I05c8e2d36ff5a5e0328921917e4cd5c55427d54a
Reviewed-on: https://chromium-review.googlesource.com/c/1261915Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596758}

Bug: 890639
Change-Id: Icb2be76982816119a30925fa92121445b5ca5141
Reviewed-on: https://chromium-review.googlesource.com/c/1253023Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596757}

This is part of a patch series where we leverage the recently introduced
layer that allows integrating legacy SyncableService implementations
within the newest architecture, USS.

SEARCH_ENGINES is the first datatype where the legacy controller
(SearchEngineDataTypeController) implements logic to make sure no
interactions with the SyncableService can occur before
TemplateURLService is fully loaded.

Implementing similar logic in pseudo-USS is nontrivial because:
1. ModelTypeController doesn't support it because it is designed for
   full-blown USS, where such logic is usually implemented in the bridge
   itself.

2. SyncableService doesn't support it, because in the legacy
   architecture the controllers took care (AsyncDirectoryTypeController).

For pseudo-USS, this being the first datatype, the least intrusive
solution is proposed, which involves a dedicated
ModelTypeControllerDelegate. We may change this in the future if more
datatypes have similar needs (e.g. ArcPackageSyncDataTypeController).

Bug: 870624
Change-Id: I28bb028de99d98608bdf07a06db1883221b8161e
Reviewed-on: https://chromium-review.googlesource.com/c/1261435
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596756}

Re-enabling the following already passing tests:
CrSettingsDevicePageTest.KeyboardTest
CrSettingsDevicePageTest.PointersTest

Fixing and re-enabling the following failing tests:
CrSettingsDevicePageTest.DisplayTest
CrSettingsDevicePageTest.PowerTest

Bug: 875454
Change-Id: Ie641b828b4076e9aaed6e0faf2adcd7b9bce3477
Reviewed-on: https://chromium-review.googlesource.com/c/1260497Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596755}

BUG=860825

Change-Id: I2605a041908a610cf08f419d6b983a34e468c3f7
Reviewed-on: https://chromium-review.googlesource.com/c/1260307
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596754}

When in Omnibox, Shift+Up/Down should behave like other input fields.

Bug: 863543

Change-Id: I477752ebf08b3ae0065e141cc63c4c0c87f6f181
Reviewed-on: https://chromium-review.googlesource.com/c/1228576Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Max Mathieu <maxmathieu@google.com>
Cr-Commit-Position: refs/heads/master@{#596753}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib698ae75b6a3253be7975be934ce71243729915e
Reviewed-on: https://chromium-review.googlesource.com/c/1262092Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596752}

Since these are separate components, they should not be using the
ui/gfx component's macros.

R=thakis@chromium.org

Change-Id: Icd90066e0dd8fb96c8ece4ed03f4a10e1bc40c27
Reviewed-on: https://chromium-review.googlesource.com/c/1259242
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596751}

With child-initiated synchronization throttling, it's possible for
frames from a given client to activate out-of-order.

For example, a child-initiated synchronization that is blocked on the
parent may be superceded by a parent-initiated synchronization.

That parent-inititaed surface will activate first, before the child-
initiated one, causing surfaces to activate out of order.

That's okay! This CL fixes some CHECKs and marks older surfaces
at activation time as candidates for garbage collection.

Bug: 672962, 879207
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I19c033c6400f467b29658c706556a99c5eaf0791
Reviewed-on: https://chromium-review.googlesource.com/c/1260019Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596750}

These two routines do the same thing, so let's kill one off.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3bb6d19f0acf325f4921b54740b86d794cb4d314
Reviewed-on: https://chromium-review.googlesource.com/c/1261818Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596749}

This reverts commit 581a728b.

Reason for revert: Causing significant test flakiness in telemetry.internal.actions.scroll_unittest.ScrollActionTest.testScrollDistanceSlowWheel.

Original change's description:
> synthetic gesture: Allow high-frequency dispatch.
> 
> For synthesized scroll/drag/pinch gestures, dispatch the events
> at a high frequency (120Hz) so that there's at least one event in
> each frame. Dispatching events at a lower frequency (60Hz) means
> the timer can go out of sync with begin-frame, and so there can
> be frames where there was to event dispatch. Our telemetry code
> reports this as jank, which is incorrect. Dispatching at a higher
> frequency for the scroll/drag/pinch gestures resolves this issue.
> 
> BUG=783034
> 
> Change-Id: I1102f76ed743231cbb10fdb872e8c66f895fa223
> Reviewed-on: https://chromium-review.googlesource.com/c/1255152
> Reviewed-by: Victor Miura <vmiura@chromium.org>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596507}

TBR=sadrul@chromium.org,vmiura@chromium.org,lanwei@chromium.org,nzolghadr@chromium.org

Change-Id: I1e4d64dfc3b98a547c38f8f82a2dcd45141fd66b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 783034, 892036
Reviewed-on: https://chromium-review.googlesource.com/c/1261972Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596748}

NG needs to produce a rectangle with the block-axis offset relatively to
block-start of the container, just like legacy does. Using purely
physical coordinates is wrong.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9989628dcc339c71d850818498538aafa142ed29
Reviewed-on: https://chromium-review.googlesource.com/c/1261698Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596747}

Using wpt-import in Chromium 07bad289.
With Chromium commits locally applied on WPT:
92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default."
65d72632 "Make DTMF tone change more deterministic"
4e530051 "[LayoutNG] Correct clip-path reference box calculation."
5b32660c "[LayoutNG] Correct getClientRects for inlines in vertical-rl."
deba13d3 "Trusted Types: Implement "trusted-types *" and reserved names."
1936977a "Add offsetLeft/offsetTop tests for non-atomic inlines."
a2068f8c "Fixed object-src tests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25813

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I5b3232da2bc8f80a459275c05032d2d781064312
Reviewed-on: https://chromium-review.googlesource.com/c/1262076
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596746}

Both SkColorSpace::toXYZD50() routines return the same information, but
the out-parameter version gives more flexibility in how SkColorSpace
represents that gamut matrix internally.  As is, there's no way around
storing an SkMatrix44.

Change-Id: I8459f4e611890114bace574df098040441e698f8
Reviewed-on: https://chromium-review.googlesource.com/c/1261397Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596745}

Change-Id: I1bdc2587b00ede2528688125498130bab25cd5cd
Reviewed-on: https://chromium-review.googlesource.com/c/1261406Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596744}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I0700f9aee7794211c330816c163a96ff932b7505
Reviewed-on: https://chromium-review.googlesource.com/c/1262138Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596743}

The AppCacheDiskCacheInterface is a mostly-abstract base class for
AppCacheDiskCache. AppCacheDiskCacheInterface::Entry is an abstract base
class for AppCacheDiskCache::EntryImpl.

Removing them makes the code clearer, for the following reasons.

1) Both AppCacheDiskCacheInterface and its subclass AppCacheDiskCache
   have base::WeakPtrFactory instances and (non-virtual) GetWeakPtr() methods.
   This is a receipe for UaF headaches.
2) AppCacheDiskCacheInterface and AppCacheDiskCacheInterface::Entry have
   no subclasses other than the ones mentioned above.
3) After this refactoring, AppCacheDiskCache's uma_name_ becomes const,
   instead of being re-assigned in the ServiceWorkerDiskCache
   constructor.

Change-Id: I33b325f266bbc666f632f847e517ff82ec4f2aac
Reviewed-on: https://chromium-review.googlesource.com/c/1260212Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596742}

Bug: 878390
Change-Id: I51d46f052b632183c18581ce27a82f84dc832805
Reviewed-on: https://chromium-review.googlesource.com/c/1261438Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596741}

We are working on a pilot for desktop IPH as part of Project
Navi. This creates a subdirectory for this to live in.

Bug: 887991
Change-Id: I110dd629f3a89e7c898e4258937a287875ca586d
Reviewed-on: https://chromium-review.googlesource.com/c/1260010Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596740}

Bug: 890602
Change-Id: I7c271882ec632670caf555316e53d9baeba45294
Reviewed-on: https://chromium-review.googlesource.com/c/1260513
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596739}

The LockRequestImpl::Granted/Failed methods unregister the request
from the LockManager, which breaks the wrapper tracing path and can
lead to the request's callback being collected before it can be
invoked. Hold a local v8 reference to the callback for the duration of
the method.

Bug: 888907
Change-Id: I24a9d1029462f71d528e14d8b188e1719f74406c
Reviewed-on: https://chromium-review.googlesource.com/c/1257682
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596738}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/573561bf..4e482566

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I75f33d574440b25eb3772e83c935d6645b67e53f
Reviewed-on: https://chromium-review.googlesource.com/c/1261597Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596737}

The Captured Sites Automation Framework uses mouse click to trigger
the Chrome Autofill popup. Before mouse clicking the element, the
framework must first bring the element into view by calling
the 'element.scrollIntoView()' method. By default, scrollIntoView
scrolls an element to the top of the view port.

Some websites have a persistent top banner that covers all other page
elements. On these sites, scrollIntoView will position the target input
element behind the persistent top banner, where the framework will be
unable to interact with the element via mouse click.

This fix adds additional parameters to the scrollIntoView call, so that
the method scrolls the element into the center of the page, where there
is unlikely to be any page UI to interfere with mouse interactions.

Bug: 847905
Change-Id: Ib2c59ad417d4452b752646c2e1f9bc60cd76dcdb
Reviewed-on: https://chromium-review.googlesource.com/c/1260004Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Cr-Commit-Position: refs/heads/master@{#596736}

Currently incognito downloads are showing up on the download shelf for
normal profile.We need to initialize the DownloadManagerDelegate and
DownloadShelfController for incognito.  Also we need to filter out the
updates for the right profile in the controller since aggregator sends
updates for all profiles.

Bug: 881499
Change-Id: I309d1673e87de44b870d4efaca606390dd46345e
Reviewed-on: https://chromium-review.googlesource.com/c/1257003Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596735}

This is a step towards removing ListPopupWindow and using a vanilla
Popup to deal with styling issues.

BUG=800033

Change-Id: I79506cdd7c3e840e13e9ebbabce39948a9fa5936
Reviewed-on: https://chromium-review.googlesource.com/c/1259480
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596734}

Adds the ability to use a mock keyboard during VR instrumentation tests,
which allows arbitrary text input without having to actually click the
keys on the keyboard. This is achieved in a similar way to the mock
controller input, where the keyboard delegate is swapped to the mock
one when necessary.

Also automates one manual test for navigation on URL entry that uses
the new functionality.

Bug: 887523
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia1130df87a154a6771038182883521ede209be99
Reviewed-on: https://chromium-review.googlesource.com/c/1257665Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596733}

Use wtf_size_t when dealing with WTF types.
Add RefVector iterators.

BUG=879657

Change-Id: I748ab38b1c9f66b3e5405c1fa75f981c5d5f0a14
Reviewed-on: https://chromium-review.googlesource.com/c/1259496
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596732}

This reverts commit e0ffa06d.

Reason for revert: <INSERT REASONING HERE>
Bug: 891889

Original change's description:
> Remove unnecessary call to EnableFileSystemInGuestMode
> 
> This call makes no sense. There's no reason that loading the
> speech synthesis component extension should trigger enabling
> the filesystem in guest mode for a related, but entirely different,
> extension (ChromeVox).
> 
> If ChromeVox needs EnableFileSystemInGuestMode, we should be calling
> this from code that loads the ChromeVox component extension, but I suspect
> that it doesn't need it at all.
> 
> As far as I can tell this was accidentally added here as part of a
> refactoring:
>   https://codereview.chromium.org/1162283002
> 
> Note that OnceClosure() would be better, but that'd require a big cleanup
> of many other functions, so I don't want to do that as part of the same
> change.
> 
> Bug: none
> Change-Id: I1f67b78548048fffa9194083b10e0ff5c5aaa863
> Reviewed-on: https://chromium-review.googlesource.com/1246364
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594463}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: If18c5fcbdbc6be5b6ce8235afa612597792127ff
Reviewed-on: https://chromium-review.googlesource.com/c/1261960Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596731}