GitLab

Certain interfaces in sync had signatures that included vectors of raw
pointers to ModelSafeWorkers.  The use of raw pointers to refcounted
objects looks a lot like a bug waiting to happen.

This CL replaces any use of std::vector<ModelSafeWorker*> with
std::vector<scoped_refptr<ModelSafeWorker> >.  This is not expected to
alter sync behavior in any significant way.

BUG=332251

Review URL: https://codereview.chromium.org/130193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330235

Review URL: https://codereview.chromium.org/113963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244328 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244327 0039d316-1c4b-4281-b951-d872f2087c98

Pulls in the following patches:
172513a Linux: upstream Gentoo Linux patches:
cfe978e Remove trailing periods from rule messages.

BUG=none
TEST=none
TBR=thakis

Review URL: https://codereview.chromium.org/134333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244326 0039d316-1c4b-4281-b951-d872f2087c98

We were using GetOobe to figure out if the oobe page existed. This creates an InspectorBackend, which creates an InspectorPage, which calls _EnablePageNotifications, which calls SyncRequest with a timeout of 60 sec. If the page goes away right before SyncRequest is called, we could end up waiting 60 sec.

In general, GetOobe is too expensive if all we're interested in is checking the existence of oobe, so fix all instances of such checks to use OobeExists instead.

BUG=331940
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/134043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244325 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/134043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244322 0039d316-1c4b-4281-b951-d872f2087c98

We'll use this in-tree fontconfig when "embedded=1" is set in GYP_DEFINES.

This was reverted pending license checker changes (landed as r127213003).

Relanding with the following changes from the third_party HOWTO:
  - Added OWNERS file
  - Updated .gitignore

BUG=318315

Review URL: https://codereview.chromium.org/133903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333179

Review URL: https://codereview.chromium.org/133623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244317 0039d316-1c4b-4281-b951-d872f2087c98

The code only works as is because GRIT does not properly respect an 'is_win' conditional.

Review URL: https://codereview.chromium.org/133563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244316 0039d316-1c4b-4281-b951-d872f2087c98

Some Linux file managers will set both URI list representation and the
plain text representation when dragging files. Chrome interprets this as
a chunk of text and a file, and offers both to the renderer. This broke
the javascript on the Dropbox website.

This ports the hack in WebDragDestGtk::OnDragDataReceived() to
linux_aura. This hack prevents us from offering the String type when we
also have a URI list.

BUG=318796

Review URL: https://codereview.chromium.org/133053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244315 0039d316-1c4b-4281-b951-d872f2087c98

 Touch UI has been removed long time ago, and this CL removes
the code that used to load resources for Touch UI.

 I'll remove the assets in separate CL.

BUG=none
R=girard@chromium.org

Review URL: https://codereview.chromium.org/133053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244314 0039d316-1c4b-4281-b951-d872f2087c98

fgets was refactored to read because fdopen was returning null in glibc.
These tests were disabled for glibc without explanation, so working around this
bug loses no coverage.

BUG=154400

Review URL: https://codereview.chromium.org/133033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244313 0039d316-1c4b-4281-b951-d872f2087c98

This replaces uses of blink's WebGraphicsContext3D.h typedefs for GL numeric
types with the types from the khronos headers.

BUG=181120

Review URL: https://codereview.chromium.org/133023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/132983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318450

Review URL: https://codereview.chromium.org/103283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244310 0039d316-1c4b-4281-b951-d872f2087c98

Some of these tests need to be fixed and others should probably stay disabled.

BUG=331940
TEST=manual

Review URL: https://codereview.chromium.org/132923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244307 0039d316-1c4b-4281-b951-d872f2087c98

Allows OSX to handle remapping channels according to a user's
preferences instead of forcing us to handle it.

BUG=266674
TEST=Multichannel users report proper output.
NOTRY=true

Review URL: https://codereview.chromium.org/132873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496

Review URL: https://codereview.chromium.org/132583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244305 0039d316-1c4b-4281-b951-d872f2087c98

Some of the ifndef's were missing GL_.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/107543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244304 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/132473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143619
R=erg@chromium.org

Review URL: https://codereview.chromium.org/132183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244302 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170921
TEST=everything still works

Review URL: https://codereview.chromium.org/129743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170921
TEST=everything still works

Review URL: https://codereview.chromium.org/126613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244300 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that trackpad and trackpoint scrolling works on Windows desktop Aura with legacy trackpad drivers.

Legacy trackpad drivers like the older synaptics drivers have bugs where in they don't generate the WM_MOUSEWHEEL
messages for applications unless there is an entry for the application with the class name of the window in their
config file. If an entry does not exist here, these drivers expect the window to have the WS_VSCROLL/WS_HSCROLL style
to generate the legacy WM_VSCROLL/WM_HSCROLL messages.

This patch adds these styles to top level windows for Windows Aura. To ensure that Windows does not draw these
scrollbars, we hide them when the window size changes and readd them in a posted task which works correctly in our
testing.

Changes in this patch are as below:-
1. Add handlers to the HWNDMessageHandler class for the WM_VSCROLL/WM_HSCROLL messages.
2. Forward the scroll events to the HWNDMessageHandlerDelegate which then forwards it off to its delegate.
3. Miscellaneous fixes in the events code to allow the WM_VSCROLL/WM_HSCROLL messages to go through.

BUG=320849
R=cpu@chromium.org, sky@chromium.org, cpu, sky

Review URL: https://codereview.chromium.org/133053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244295 0039d316-1c4b-4281-b951-d872f2087c98

> Password manager: Gnome support for Public Suffix List matching
> 
> This CL:
> 
> * Enables Public Suffix List (PSL) general utilities on Linux.
> * Enables PSL flag for Linux.
> * Adds Gnome Keyring support for searching and filtering multiple origins, including UMA metrics and a unit test.
> 
> BUG=324291
> 
> Review URL: https://codereview.chromium.org/123223003

TBR=vabr@chromium.org

Review URL: https://codereview.chromium.org/134923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244292 0039d316-1c4b-4281-b951-d872f2087c98

A subtle race condition was occurring between the destruction of the AudioBus
and a while-loop's final dereferencing of the audio_bus pointer before
breaking.

BUG=332623

Review URL: https://codereview.chromium.org/132783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244288 0039d316-1c4b-4281-b951-d872f2087c98

drawPosTextOnPath() was deprecated on skia and is going to be deleted
after no one is using it on Chrome.

BUG=skia:1834
TEST=None, no functional changes
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/132593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244287 0039d316-1c4b-4281-b951-d872f2087c98

This CL:

* Enables Public Suffix List (PSL) general utilities on Linux.
* Enables PSL flag for Linux.
* Adds Gnome Keyring support for searching and filtering multiple origins, including UMA metrics and a unit test.

BUG=324291

Review URL: https://codereview.chromium.org/123223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244286 0039d316-1c4b-4281-b951-d872f2087c98

Chrome no longer carries the patch to NSS to enable this support; remove the
traces that exist in Chrome to support it.

BUG=none
R=wtc
TBR=brettw

Review URL: https://codereview.chromium.org/122573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244285 0039d316-1c4b-4281-b951-d872f2087c98

Actually, just move mojo::system::CoreImpl::Init() to
mojo::embedder::Init(), in its own header file.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/135073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244284 0039d316-1c4b-4281-b951-d872f2087c98

It's only used inside an UNSHIPPED_TRACE_EVENT1(), which causes:

../../base/message_loop/message_pump_gtk.cc:17:13: error: unused function 'EventToTypeString' [-Werror,-Wunused-function]

Review URL: https://codereview.chromium.org/131323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244283 0039d316-1c4b-4281-b951-d872f2087c98

As focusable() may effect the preferred size it is important that it
returns the last value passed to SetFocusable() rather than if the
view is focusable right now. Otherwise focusable() could change value
based on enabled or visible state, resulting in the preferred size
bouncing around.

I'm also making focusable() protected as it's really only subclasses
that should care about it. Especially since we also have
IsFocusable().

BUG=330696
TEST=covered by test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/129863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244282 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 304023

Review URL: https://codereview.chromium.org/129833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244281 0039d316-1c4b-4281-b951-d872f2087c98

These are the new "build-only" builders for that
NaCl SDK which should be fast and reliable and
catch basic build breaks.

BUG=302579

Review URL: https://codereview.chromium.org/26747002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244280 0039d316-1c4b-4281-b951-d872f2087c98

Allow the Chrome-internal bookmarks manager extensions to specify
the chrome_settings_overrides manifest key in all channels, so that
they can use the bookmarks_ui subkey. Specifying subkey channels in
manifest_features.json would be better, but this is not fully supported
yet.

BUG=333362
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/134843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244279 0039d316-1c4b-4281-b951-d872f2087c98

Causing webkit_unit_tests to fail.

> base: Fix registering of memory pressure listeners used when emulating discardable memory.
> 
> Memory pressure listeners need to be created on a thread with a message
> loop current. Discardable memory is often used on worker threads that
> don't have a message loop and with the current system where listeners
> are registered on first use, the result is that we're most likely never
> notified of memory pressure.
> 
> This adds a function to the discardable memory interface that allows us
> to register memory pressure listeners on a thread, and at a time, when
> we know a message loop is current.
> 
> BUG=332570
> TBR=jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/129963002

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/135113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244278 0039d316-1c4b-4281-b951-d872f2087c98

A recent version of Clang warned about this:

  ../../ash/system/user/tray_user.cc:1055:20: error: field 'listener_' is uninitialized when used here [-Werror,-Wuninitialized]
      : CustomButton(listener_),
                     ^
BUG=323668
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/133743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244277 0039d316-1c4b-4281-b951-d872f2087c98

R=vadimt@chromium.org

Review URL: https://codereview.chromium.org/134513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244275 0039d316-1c4b-4281-b951-d872f2087c98

> IndexedDBFactory now ForceCloses databases.
> 
> Also, IndexedDBContextImpl used to maintain a map of open
> connections. This change also deletes this map, and instead
> relies on one which already exists in IndexedDBFactory.
> 
> BUG=259564
> 
> Review URL: https://codereview.chromium.org/93873017

TBR=cmumford@chromium.org

Review URL: https://codereview.chromium.org/134503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244273 0039d316-1c4b-4281-b951-d872f2087c98