GitLab

Adds an inline implementation of NeuralStylusPalmDetectionFilterModel,
with a few extra changes:

1. Updates the factory to add a Flag and appropriate instantiation of
NeuralStylusPalmDetectionFilter when that flag is turned on.

2. Update the unit test of the factory to appropriately test that the
NeuralStylusPalmDetectionFilter is correctly instantiated.

3. Update NeuralStylusPalmDetectionFilter with a few lint updates
suggested by git cl lint

4. Move 2 items from private to public in NeuralStylusPalmDetectionFilter .

Bug: 1009290
Change-Id: I35c5a5e2c61c436dd2eaaeba439245cc7cc9433a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890376
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712835}

This reverts commit cc2f9f85.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 712774 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NjMmY5Zjg1Y2UyM2VjYmM4NGM1MmQwYTI1NjhiMjE0ZGRkNmVhMWIM

Sample Failed Build: https://ci.chromium.org/b/8897587343409415744

Sample Failed Step: content_browsertests

Original change's description:
> Reland "Fix UIA Fragment Root Navigation in Inspect"
> 
> This is a reland of 5e7f2837
> 
> This was reverted due to flaky tests. I was not able to reproduce the
> failures, but I was able to see via the logs that the failed cases
> were opening the first popup instead of the third. As a mitigation, I
> have switched the logic to find the third popup. Previously, I had
> added a count parameter to FindNode, so it would find the third node
> with that name. This change adds a name to the parent node (in this
> case the <input> node), and updated the logic to search for that node
> as a parent.
> 
> Original change's description:
> > Fix UIA Fragment Root Navigation in Inspect
> >
> > We discovered that the fragment root change that was recently submitted
> > here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822
> > regressed fragment root navigation in Inspect. This was not the case
> > when Kevin had first submitted it. I traced it down to the changes that
> > I made for Controller-For elements, so this change undoes those
> > modifications.
> >
> > In order to stabilize the content_browsertest that prompted the changes
> > (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it
> > was discovered that there were several issues in how we were
> > handling date-time popups.
> >
> > The first issue is that we were failing to return the proper parent
> > window for the fragment root. In
> > RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were
> > returning nullptr as the parent of datetime popups, which was
> > parenting the popup under the root desktop window in Inspect. This
> > change now returns the host's window, which places the popup under
> > the correct parent window in Inspect.
> >
> > The second issue is that there was a cardinality problem with datetime
> > popup windows. Since they share a BrowserAccessibilityManager with
> > the main window (but are under a different fragment root),
> > LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would
> > always return the main window's root kRootWebArea instead of the
> > popup window's kRootWebArea. So we'd have two different fragment roots
> > that map to the same gfx::NativeViewAccessible. This would cause
> > GetFragmentRootParentOf to return the incorrect parent most of the
> > time. This change fixes that issue by adding an extra step for popup
> > windows that traverses the root node and searches for the popup web
> > root via OneShotAccessibilityTreeSearch.
> >
> > Bug: 1019016
> > Change-Id: I678425c8417334275727053243a39b1039e6f135
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102
> > Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#711358}
> 
> TBR=sky@chromium.org
> 
> Bug: 1019016
> Change-Id: I73dc98eeb049788b3a7a086f5e6ac2927e2b0473
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894761
> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#712774}


Change-Id: I233bd67fb5c6a392e86ef4f65d65d17d907ab00f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900140
Cr-Commit-Position: refs/heads/master@{#712834}

This is only called in View::SetBoundsRect which then triggers a layout as well. This also prevents crashing when initially laying out the new extensions container.

Bug: 995448
Change-Id: Ic066bd12870f4dde2392cbcb85321f5e1420a127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899424Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712833}

This CL is fixing a bug where there is a mismatch index/offset
between the text_ and layout_text_.

The layout_text_ is a rewritten version of text_. The styles
sets in RenderText are in offset of text_. There is a function
TextIndexToGivenTextIndex(...) which convert an index (char16
array position) from one text to the other one.

The previous implementation was using UTF16IndexToOffset(...)
which convert from the initial text index to the position
(codepoint offset). But there was a missing UTF16OffsetToIndex(...)
to convert back to index.

The bug detected was with the obscured(...) feature and obscure
reveal.

The input sequence was  { a, B1, B2, c } where each entry is a
16-bit char, but B1 and B2 are a surrogate pair and make a single
code point. The obscure feature create a string with 3x bullet
{ Bullet, Bullet, Bullet } which are 16-bit characters. When they
reveal a character the sequence is becoming
{ Bullet, B1, B2, Bullet }. The "offset" of the last bullet is 3 but
is index is 4. This mismatch is making a DCHECK to fire while trying
to ItemizeText since the "end" of style will be reported to be at
index 3 insteaad of index 4.

The issue was not visible without using obscured(...) feature since
the conversion is completely skipped.

Bug: 1020814, 1021720
Change-Id: Ie008d3a0ce1b4f87d5d81ee04d9e0841a6a466c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896867
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712832}

This change will be necessary since the Translate Infobar changes
states through the Translate lifecycle, requiring the banner texts
to be update.

Bug: 1014959
Change-Id: I74e908b33e17529dfa3ebd39a636564ce2df2871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897909Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712831}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f168baf4df53..edf176c888c1


Created with:
  gclient setdep -r src-internal@edf176c888c1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None
Change-Id: Ic2fc81c4b2059f4789be8ed63578b32ec5aaf1c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900202Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712830}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e2a4d97fd4c..2150a694c71f

git log 0e2a4d97fd4c..2150a694c71f --date=short --no-merges --format='%ad %ae %s'
2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@2150a694c71f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I0227933ddc1d45c59be145236398a7f07b5fa0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900203Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712829}

NewBrowserCallback is used from window.open (among other things). As
part of this BrowserFragmentController now has an API to get the list
of BrowserTabControllers and the ability to set a single active one.

BUG=none
TEST=testNewBrowser.testNewBrowser

Change-Id: I55702381c1adee4322a6fc660ce161bcc92c3dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897487Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712828}

Bug: 1016355
Change-Id: Ie5b5a19735bb50738bc2e0ba7541a91f04b5cb12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884824
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712827}

None of the AllowRunningInsecureContent overrides use the "origin"
param, so remove it. The renderer shouldn't be trusted anyway.

Bug: 1019772
Change-Id: Idb9f062a9d4c319537c02fbdda47acd55a2b4b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894478Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712826}

css/css-flexbox/ttwf-reftest-flex-order.html tested the same thing as,
and was very similar to css/css-flexbox/flex-order.html

Change-Id: I9fd430da819d9401167bb88982a129239d1fa460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900404Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712825}

This change converts DistillabilityService mojom interface client in
components to use BrowserInterfaceBroker. Since DistillabilityDriver
is a WebContentsObserver, a static helper function is used to register
its binder.

Bug: 936482,1006361
Change-Id: If92c3a6f3aede131beff7a0f943bb9a2e4df157b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889275
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712824}

https://android.googlesource.com/platform/external/perfetto.git/+log/287edca9b437..b550d6837e71

git log 287edca9b437..b550d6837e71 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 treehugger-gerrit@google.com Merge "Un-inline the Rpc default constructor."
2019-11-05 fmayer@google.com Merge "More efficiently track unique_retained."

Created with:
  gclient setdep -r src/third_party/perfetto@b550d6837e71

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I0ee393e585dbf7ea19b471c27fba74ea723a2dc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900180Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712823}

Change-Id: I16eaca23a40eb942fa054a054951adc2398a659a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900466Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712822}

To support testing, adds ProgressCenter function to inhibit file
operation completed messages being propagated to progress center panels.

Test copies a file, remembers the text written on the progress panel,
closes the foreground window, then opens a new foreground window and
verifies that a progress panel is created with the same text as the
original window.

Bug: 988137
Tests: --gtest_filter="*FilesAppBrowserTest.Test/transferInfoIsRemembered"
Change-Id: If48d4ba1c181bc615a6e71abfd3814d2ec239d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898902
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712821}

https://skia.googlesource.com/skia.git/+log/1803f4ef6fe7..ce200acafa7a

git log 1803f4ef6fe7..ce200acafa7a --date=short --no-merges --format='%ad %ae %s'
2019-11-05 michaelludwig@google.com Cache tessellation metadata between inset/outset calls
2019-11-05 senorblanco@chromium.org Dawn: fix mipmap width and height computation during upload.
2019-11-05 mtklein@google.com friendly wrapper to allocate uniforms
2019-11-05 senorblanco@chromium.org Roll Dawn to ToT.
2019-11-05 halcanary@google.com SkPDF/bublic.bzl: switch away from Sfntly subsetter.

Created with:
  gclient setdep -r src/third_party/skia@ce200acafa7a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: I6dfa7a015783f99cbe16b825aaed481dbd3d815f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900181Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712820}

Introducing a conversion function to fade the icon in/out in a way that
it never intersects with the url text.
- Adding separate functions for setting the alpha/visibility of the
status icon.
- Supporting non-google engines for alpha fading.

Bug: 1007577,1018870
Change-Id: Ibcc76087f2ca964614f8bb3b4a18c04e4edee753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874577
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#712819}

This is in preparation of turning on such PRESUBMIT checks for src/components.

Bug: 1019312
Change-Id: Ib16a5244aed27807f74d6cdac6911ec48cecc284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900172
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712818}

This fixes:
   tooltip position in case content is scrolled.
   average power computation.
   allows digits in normalized names.

TEST=Locally
BUG=b/143532713

Change-Id: I25f7976f2cb9832d05a93f2bea1d2590ba454516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899894Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712817}

TBR=aliceywang@chromium.org

Bug: 1020068
Change-Id: I3a32b199482852f197973792d6de3f14f3a93729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900468Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712816}

enable_cbcs_encryption_scheme flag was set on all platforms except
Fuchsia. There is no reason this feature needs to be disabled on
Fuchsia. Remove this flag.

Bug: 1021308
Change-Id: If79065f337119f9098254f21caa12bec79609b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898640Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712815}

Bug: 1002490
Change-Id: I99765485b46e05c66d373115e1f7b77f545354bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899896
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712814}

https://webrtc.googlesource.com/src.git/+log/ad04327df8c5..3c0e86a87d08

git log ad04327df8c5..3c0e86a87d08 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 honghaiz@webrtc.org Add a field trial to use only the higher 64 bits to find network handle from an ipv6 address.
2019-11-05 alessiob@webrtc.org RNN VAD: prepare for SIMD optimization

Created with:
  gclient setdep -r src/third_party/webrtc@3c0e86a87d08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: Ida3335789f81d53f7a7659ec989c3e00f62d1f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899339Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712813}

This CL adds support for some additional X11 color types: RGB565, ARGB4444,
RGBA1010102. Also avoid unnecessarily rendering into an RGBA8888 buffer and
converting to the window format; just render into the correct format directly.
Also simplify/refactor some code.

BUG=1016383
R=rjkroege

Change-Id: I08051526b81d364a236c37654fda1be6bad1bc20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899324Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712812}

Change-Id: I4c16fce1dd6377e83663850a78df718915291756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900508
Auto-Submit: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712811}

Instead of watching and unwatching the thumbnail associated with a hover
card every time the mouse moves on or off a tab (or something grabs
mouse focus) we now watch a handful of thumbnails of tabs we've recently
hovered.

Note that re-watching a tab with a valid thumbnail is mostly a no-op.

Bug: 1021332
Change-Id: I55646c89514a001052cd6d453ffe3a3b6e11a731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899388
Auto-Submit: Dana Fried <dfried@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712810}

Previously we updated fragments of link highlights during paint, and
called LocalFrameView::SetForeignLayerListNeedsUpdate() when we had
less fragments than before, but SetForeignLayerListNeedsUpdate()
should be called before paint because it deletes paint controller.

Now separate the work into a new step LinkHighlightImpl::UpdateAfterPrePaint()
to update the link highlight fragments and call
SetForeignLayerListNeedsUpdate() when the number of fragments changes.

Bug: 1021470
Change-Id: I4d81a522844e957aebcb406fb36044297872ab55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899317Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712809}

Bug: 997049
Change-Id: I5093e48e16a6fe11167a20e3868b66e1b14558d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898485
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712808}

As described.

TEST=Locally
BUG=b/143532713

Change-Id: I601d43bc1d7d0f1eb061674b9b1537f990e3f6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900166Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712807}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4306aa57..db6f5198

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I13f7454f6658f86ae7d4b3b924344016affb9e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899797Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712806}

Bug: 1007873
Change-Id: I60e4c7972d5e261b666f745017747d1ad8eda043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834221
Commit-Queue: Thomas Tellier <tellier@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712805}

Launch bug: crbug.com/1006375.

Bug: 995926
Change-Id: I28143ab04cabe15243e5bde7ac4d0b48708ae9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898440Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712804}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5364042c0287..38f84022167e

git log 5364042c0287..38f84022167e --date=short --no-merges --format='%ad %ae %s'
2019-11-05 dburger@chromium.org Extend paladin build timeout for goma slow build bug.

Created with:
  gclient setdep -r src/third_party/chromite@38f84022167e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I2c715571fab9c1172c51a28a756ab3827c2ed4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900366Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712803}

This CL implements the basic component functionality and adds some
general tests.

Change-Id: Idbacd856128e3b584a618d85c400beec36918fa4
Bug: 1004570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879331
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712802}

Hope the fuzzer will be able to crash and give out helpful stack trace.

Change-Id: Ie9a42b465eb966c10d52e4e263ed331a227d3e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900261Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712801}

When too many Infobar Banners are dismissed and presented right after the
other by stopping their Coordinators, the Banners won't be queued, and the
dismissal animation of the first one might cause the second banner to be
presented after its own Coordinator has been stopped, leaving a presented
bannerVC.

This CL stops animating the banner dismissal whenever its Coordinator has
been stopped.

Bug: 1020199
Change-Id: I2f44867e5265abea8d18c94641c78e2b2c42b656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898747Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712800}

RenderFrameHost::delegate_ is never null.

New CLs are adding more and more null check for this, just to be sure,
because there are locations where this is checked.

This patch remove all the location where is checked to avoid this to
spread further.

Bug: None.
Change-Id: I5ba7903a199fdb3117df6adf514e187b0a36ea0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899501
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712799}

This change adds a nullptr check in GetFragmentRootParentOf.
AXFragmentRootMapWin maps from HWND to fragment root, and it was assumed
that an existing fragment root with a valid HWND will always have its
child delegate available via GetChildNodeDelegate. However, this bug
demonstrates that this assumption is incorrect.

gets called during the destruction of any WebContents while the HWND is
still valid. In the repro case I found, ToolbarActionView::UpdateState
initiates a layout during tab restore, which ends up firing accessiblity
events, which end up doing tree traversal and hit this crash.

A unit test was added that reproduces this specific scenario and which
crashes without the nullptr check.


RenderWidgetHostImpl: :DetachDelegate will get us in this state, and it
Bug: 1021633
Change-Id: I344651844f093b81f7b8fbdfade54f1c7bd029f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900095
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#712798}

Bug: internal b/140189221

Test: Cast from Youtube to Android TV.
      TTS on Android Things.

Change-Id: I1cc4e355a0644ff35193a62c47f7fa748de17fb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900151
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712797}

This fixes a bug that caused commands to be non-functional on a
subresource triggered SB committed interstitial if a different type of
interstitial had been shown on the same webcontents previously. The bug
was triggered depending on the order different WebContentsObservers
were installed (which determines the order DidFinishNavigation is
called in them). This CL changes the observer that needs to fire first
so it uses ReadyToCommitNavigationInstead.

Bug: 1021334
Change-Id: I3e6683279523dc6b74a2266fdd2bf05e0ab4d132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896346
Auto-Submit: Carlos IL <carlosil@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712796}