- 29 May, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590652675-be69972bb8b130c690a24c0cd0561e6e4a5c40c5.profdata to chrome-win64-master-1590710362-c13fe441c8f420f4cd2f4cff6b98279f2ecbf633.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I0380e9f8dc5e0efd25037c80d42785098283368d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773038}
-
Adam Rice authored
Attempting to Tee() a BodyStreamBuffer object when the execution context was destroyed would crash the render process. Instead, explicitly throw an exception. This makes Request and Response clone() throw when there is a body. clone() is still permitted when there is no body, which is convenient for Request. Bug: 1082688 Change-Id: I2d18f7a13b74caa89a9bd6c56eb9241bb2f5513d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217753Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#773037}
-
Frank Tang authored
This reverts commit d90baa9e. Reason for revert: reland ICU67.1 after #if 0 the problematic new code Fix in 630b884f84d Original change's description: > Revert "Roll ICU to 67.1 f2223961" > > This reverts commit db2cb995. > > Reason for revert: caused 30ms startup performance regression on Windows > > Original change's description: > > Roll ICU to 67.1 f2223961 > > > > ICU 67.1 release notes: http://site.icu-project.org/download/67 > > ICU 66.1 release notes: http://site.icu-project.org/download/66 > > CLDR 37: release notes: http://blog.unicode.org/2020/04/unicode-locale-data-v37-released_23.html > > > > 1. Update to 67-1 > > Diary https://docs.google.com/document/d/1ZDtSPa3ZkzBIJmqrDVmGmyrTihjx8Me4fKQoQcBj02E/edit# > > > > Size changes: > > 65-1 . 67-1 > > 7786368 7778704 android/icudtl.dat > > 6412768 6400752 android_small/icudtl.dat > > 1418320 1430976 android_small/icudtl_extra.dat > > 5060880 5048912 cast/icudtl.dat > > 10481632 10470736 chromeos/icudtl.dat > > 10506736 10498032 common/icudtb.dat > > 10506736 10498032 common/icudtl.dat > > 900576 . 898416 flutter/icudtl.dat > > 6375984 6363968 ios/icudtl.dat > > > > > > Bug: 1064326, 827538 > > Change-Id: I169e1f99514b36cafd54a6bc8a9914ccf222d008 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Commit-Queue: Frank Tang <ftang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#764138} > > TBR=machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1064326, 827538, 1080367 > Change-Id: I98ebe6e01631b10ecc1955ac9d3bc53be11e23c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209232 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771137} TBR=wittman@chromium.org,machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1064326, 827538, 1080367 Change-Id: I6d255bac08a68d6716ac51d84765acc010c6a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220363Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773036}
-
Joel Hockey authored
Refactor only change. Change places where vm_name and container_name are being used in a function to use ContainerId, and particularly ContainerId::GetDefault. TBR=haraken@chromium.org Bug: 846190 Change-Id: Iaa545c750aa979cceff74c87e89ef4bd21867f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220106 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773035}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590695681-757fb4797cdbf3f0b9decd998cf3c3173838cd05.profdata to chrome-win32-master-1590710362-da8362c2cf2dc829b7840d09501bff322abdb5d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I77cda28cd5c5d87d7504f2c602bcd20e98c83524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220887Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/209cf8fa408b..33004b09f180 2020-05-28 ynovikov@chromium.org Roll VVL and Headers to v1.2.141 2020-05-28 cclao@google.com Add egl::ShareGroup class to abstract the share context group If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I7cf697c45192608ca0c1a74f6ed80b4f1744c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220702Reviewed-by:
-
Sunny Sachanandani authored
VSyncProviderWin through DWM provides a more accurate vsync interval than getting the refresh rate from the Win32 GetMonitorInfo() API. However, the vsync phase from DWM via VSyncProviderWin is noisy especially when any kind of mouse movement occurs, so the logic for vsync time is not changed. Bug: 1085548 Change-Id: If74d927c1e19864cf245b3bda82327a8219a5e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217065Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#773032}
-
Yuichiro Hanada authored
The property will be set to true if the window wants to receive a key event before it's consumed by IME. It's the responsibility of the window to send a key event after the window processes it if the property is set to true. The property will be set to true for ARC windows which want to receive a key event before it goes to IME. Please refer to go/arc-key-event-dispatch for the details. Bug: b:148193316 Test: aura_unittests Change-Id: I121d64b53ea3613864bc480c4804d7857185fc4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210183 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#773031}
-
Alexey Baskakov authored
WebAppInstallManager API should not receive requests to install something before Start or after Shutdown. Drive by: Change TestWebAppProvider API so SetRunSubsystemStartupTasks can be changed in test fixtures before they call Start(). Bug: 1084939 Change-Id: Ie10ef3c9cc3fd6261bdddee10844388cb9ba5630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217916Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#773030}
-
Alex Danilo authored
When text is displayed on a feedback panel, it sits inside a child span with a fixed width. In the case when its parent container has its width reduced to fit wide buttons, the parent can end up smaller than the span, causing the end to be clipped. Set a minimum width for the parent container to 'fit-content' so it won't shrink and clip its child content. Changes the name of the growable <div> that's used to help the flex layout look correct and to make its meaning a bit more obvious. Bug: 1087210 Change-Id: Iae9f6a7d46503c81e8cfd9bfbbe1389ba828ed2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217997Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#773029}
-
Eizan Miyamoto authored
This change whitelists /dev/video-enc0 through /dev/video-enc4. For the Oak uprev project (Linux 3.18->4.19 on MT8173 devices), we are now exposing two video encode device nodes that support different output formats. However up until this change, only /dev/video-enc was whitelisted, causing tests like tast.webrtc.MediaRecorderAccelerator.vp8 to fail with the error "hardware accelerator was not used". BUG=b:157434587 TEST=Install ChromeOS 13208.0.0 hana image; emerge-hana-kernelnext chromeos-kernel-4_19; install_kernel.sh ... --board=hana-kernelnext; autoninja ... && deploy_chrome ...; tast run ... webrtc.MediaRecorderAccelerator.vp8_cam Change-Id: Icecc4f5a2da4426d6b73842e350eb25fd03b8944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217756Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Joseph Kim authored
This update allows us to track the following apps in demo sessions: - Calculator - Calendar - AutoCAD - Asphalt 9 - Stardew Valley - KineMaster - Pixlr Also, we differentiate between Chrome app and Android app versions of Google Docs, Sheets, Slides, and Keep. Bug: b:155581252, b:148753427 Change-Id: I100fb976a33a218c7195a0342754b566486ec0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215546Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Joseph Kim <josephkimsh@google.com> Cr-Commit-Position: refs/heads/master@{#773027}
-
Gabriel Charette authored
[base] Make PostTaskAndReply destination explicit in /chrome/browser/chromeos/extensions/file_manager Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. This CL is thus a no-op. These changes are required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This CL was uploaded by git cl split. R=joelhockey@chromium.org Bug: 1026641, 968047 Change-Id: I87ec1f293c064e1db64ff62b92264b025a55e47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219014 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#773026}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I73821dcbde418df59c56b81cb33e79eb1e75ef20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220622Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/251f6d529453..09841a6eaf28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dbertoni@google.com,shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1055164,chromium:1087078,chromium:912681 Tbr: dbertoni@google.com,shimazu@google.com Change-Id: I83ee2d2cacd2706bea6ff6a7c62214bccf37d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220698Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773024}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/090475cde4fa..b8de90f2cb72 2020-05-29 iannucci@chromium.org [led] Update to latest version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1015181,chromium:1087651 Tbr: agable@chromium.org Change-Id: I485b25a456baf9078291155a397956e4641e8fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220886Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4627d3a7ce27..8c643ad793bf 2020-05-29 dberris@chromium.org pinpoint: Remove column class from pin field If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1079183 Tbr: rmhasan@google.com Change-Id: I9259ce344ae27a45fd95fcffda6487cf4b774c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220697Reviewed-by:
-
Fabrice de Gans-Riberi authored
Follow-up tasks for the Cast Streaming Receiver service implementation have been moved to separate bugs. Bug: 1042501, 1087520, 1087524, 1087528 Change-Id: I860ea215d43b6f8cfcbf14cbf2181927bf6f2ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220629 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773021}
-
Julie Jeongeun Kim authored
This CL allows atk_ref_accessible_at_point on the native frame or panel to hittest web area. According to the comment from ViewAXPlatformNodeDelegate::HitTestSync, AXPlatformNode is supposed to do a recursive hit test and AXPlatformNodeWin works recursively already. So, AXPlatformNodeAuraLinux hittests recursively. The difference between Windows and AuraLinux is that WebArea is also a descendant of the top window in AuraLinux. AX-Relnotes: atk_ref_accessible_at_point recurses into descendants. So, it finds a node from the web page when it's called on the ancestor of web area. Bug: 1051616 Change-Id: I03f0a37999fdaf9b2656b7eddc805467657a4b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210291Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1080832 Change-Id: I7c01babed13186995b83d4c3a49ce6fdaf2c648e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219582 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#773019}
-
Patrick Monette authored
The new name puts more emphasis on the fact that this function is responsible for making modifications on the graph. Also, the name is now more distinct, especially compared to AddChildWorker(), which was a bit confusing. Bug: 993029 Change-Id: Icfa5a26a628193f60adaba1fe20ac38d7a77f390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212810 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773018}
-
Yuichiro Hanada authored
Before this CL, the visibility changed observer method is called only when ARC IME is closed by the back button on the shelf. ArcAccessibilityHelperService needs to know the visibility change always, so this CL fixes the issue by makiing ArcInputMethodManagerService observe the size of the ARC IME window directly. Bug: 1060272 Bug: b:150659537 Test: unit_tests Test: ChromeVox can read the keys of Android Gboard. Change-Id: I1a96775ea23db8e19b221eb051105a94b9707d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217514Reviewed-by:
-
Piotr Bialecki authored
Instead of creating a distinct enum and union type blink-side, use the mojo types directly. Changes: - blink::XRReferenceSpace::Type is equivalent to mojom's XRReferenceSpaceCategory and was removed - mojom's XRReferenceSpaceCategory was reordered to match the blink's enum values since reference space type enum was used in UMA histogram - blink::XRNativeOriginInformation is roughly equivalent to mojom's XRNativeOriginInformation and was converted into a static class (it is impossible to create instances of blink::XRNativeOriginInformation, but the class was still kept for namespacing purposes & provides factory methods for mojo type) - the factory methods exposed via blink::XRNativeOriginInformation no longer return base::Optional<...> since they are guaranteed to succeed (but the XRSpace::NativeOrigin() still returns optionals to allow for the situation where an XRSpace does not have a native origin known to the device side) - XRSpace::NativeOrigin() is now purely virtual w/o implementation There should be no functional change introduced by this CL. As a follow-up, mojom's XRReferenceSpaceCategory enum will be renamed into XRReferenceSpaceType - it was originally named differently to avoid confusion with blink::XRReferenceSpace::Type, which this CL removes. Bug: 1071231 Change-Id: Icb2d713b60a99395a8943556acc62e3208fb3702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203277 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#773016}
-
Nico Weber authored
From what I can tell, the GN build uses //build/config/linux/pkg-config.py instead. No intended behavior change. Bug: none Change-Id: I51723e42236f2809a1536ba9b5f2077d292b0093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219579 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#773015}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/94e7b2caadf4..c67b36213f48 2020-05-28 johnstiles@google.com Fix Metal codegen for Globals struct. 2020-05-28 johnstiles@google.com Reland "Improve matrix construction abilities in Metal codegen." 2020-05-28 bungeman@google.com Remove use of ICU C++ API from SkParagraph. 2020-05-28 johnstiles@google.com Add support for SkASSERTF and SkDEBUGFAIL(F) in SKSL_STANDALONE. 2020-05-28 csmartdalton@google.com Add svg parsing to CanvasKit viewer.html 2020-05-28 kjlubick@google.com [canvaskit] Do not automatically free things provided by Malloc. 2020-05-28 brianosman@google.com Directly compute normalized coords in the color cube runtime effect 2020-05-28 egdaniel@google.com Fix up some comments in regards to gpu flush and submitting. 2020-05-28 michaelludwig@google.com GrClips provided as pointers to GrRTC 2020-05-28 bungeman@google.com Remove use of brkiter from SkParagraph. 2020-05-28 herb@google.com Remove test_makeOp 2020-05-28 ethannicholas@google.com fix variable sample matrices in FP files 2020-05-28 michaelludwig@google.com Fixes for GPU dither If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ie02aa1339ad5b466fae027240d42e83b92c66ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220691Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590695681-66c0724d598d285f987594dc0891dae824795753.profdata to chrome-mac-master-1590710362-35a7ecd8a402bd31319e2be75ae7373248116b8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6df6f4d868805cd3badc68fc91a8fba454319071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220885Reviewed-by:
-
John Delaney authored
A number of different observers currently declare their own LCPHandlers in page load metrics. This functionality is essentially duplicated and can make it more complex to make changes. For example, https://crrev.com/c/1875551 requires adding more callbacks to address a potential memory leak to every observer with LCPHandler. This change creates a LCPHandler that is owned by the PageLoadMetricsObserverDelegate, and accessible from each PLMO. If an observer needs to implement their own specific LCP functionality, they can still create their own handler, but this provides a nice default to observes that simply record suffixed LCP metrics. Change-Id: I816eba01e4e9857deb11a4c7e00a87b02f5a2a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207982 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#773012}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I580e5d5c3fc7042ba8f36500787745948447d5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220558Reviewed-by:
-
Maggie Cai authored
There is no easy way to add the domain verification status update listener in ARC code, therefore, before moving the domain verification status settings from ARC to Chrome OS settings, manually request the update from ARC everytime after the ARC settings app activated. BUG=853604 Change-Id: I269db90ecae765695b06dbdbf5c043da006ba96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214585Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#773010}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7618d93f7ceaa3dc9bda3d53d52af6624215559c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220830Reviewed-by:
-
David Munro authored
I believe that the flakes causing the tests to be disabled happen in SubPageDefault.DiskResizeOpensWhenClicked, since it previously ran for both failing suites. Now that http://crrev/c/2210330 has fixed that, reenable the disk resizing tests which should be good. In case they're not, add lots of debug statements so if they hang again we can see where they're failing. I also fixed a couple failing checks by removing them, since they were testing implementation details instead of behaviour they were brittle without adding value. Test: Run tests locally Bug: chromium:1082027 Change-Id: I0ae341c4c88054734de5b503e4f66228233992e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217910 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#773008}
-
David Bertoni authored
ExtensionSettingsApiTest.ManagedStorageEvents was disabled for flakiness. The test passed 3000 iterations on the bots. Bug: 321448 Change-Id: I55c36469df6eea8323353b0793b3991e35572445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211131Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#773007}
-
tby authored
We request a certain number of results from the settings search backend, and also have a maximum number of results we want to show. However the backend can return duplicate results that are removed, so we should request a few more results than we need to display. This CL also removes a TODO on testing the new settings results. Bug: 1068851 Change-Id: I7a80766112f06679ceae19057f6e9adfe36c44aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217721Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#773006}
-
Nigel Tao authored
Bug: 1070409 Change-Id: Ia9498ead09e72e062db814cf79b8b6e993f266c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212116Reviewed-by:
-
David Bertoni authored
The test OnChangedNotificationsFromSyncNotSentToLocal was disabled for flakiness and became stale. The staleness was fixed by a previous commit in this file. The test passed 3000 iterations on the bots. Bug: 101110 Change-Id: Icc765800d8a30a02b56c02a79125ec949c9b0220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212515Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#773004}
-
Kazuki Takise authored
Unminimizing an ARC window sometimes make it normal even in tablet mode. For non-ARC windows, this is handled in TabletModeWindowState, but as ARC windows use ClientControlledState, a similar window state conversion needs to be implemented there too. BUG=b:154082797 BUG=1081974 TEST=ARC apps get maxmized all the time after being unminimized Change-Id: Icc9818abded16ff8825f8614d0a9d1cf68ffa05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217434Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#773003}
-
Fergal Daly authored
They were all getting a reference to the same object. Instead, let them all access it via the FrameTree. Make Navigator a direct member of FrameTree, accessed as a reference since it cannot be null. This is a mechanical change apart from web_contents_impl.cc:4645 which removes what looks like pointless pointer chasing to get to the NavigationController. Change-Id: Ie809f19f7772113ea9005d2996d0ef9aec05a2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210040 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#773002}
-
Minoru Chikamune authored
HeapMojo wrappers require ExecutionContext to reset mojo objects when ExecutionContext is detached. But AgentMetricsCollector is not tied to ExecutionContext. Bug: 1049056 Change-Id: I4f161656623b90a9788bb3b5fcba3e52c55672e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217919Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Erik Staab authored
TBR=sky@chromium.org Bug: 1087451 Change-Id: Ia9a54248c7cf753a19ae2f9aaeebc542dcd1d616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220163Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#773000}
-
Nate Chapin authored
* Move CreateDocument() to DocumentInit * Move MIME type checks to MIMETypeRegistry These functions are in DOMImplementation for purely historical reasons. They're all static internal-to-blink helpers, and have no interaction with the rest of the functions on DOMImplementation, which actually implement a web-exposed API. Change-Id: I5473b48d4a1096f3db5f627942d1c7211541119f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220075 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
