GitLab

I guess we're all so used to looking at Chromium's
base::Callback::Run() that no-one noticed. Oops!

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/724953002

git-svn-id: svn://svn.chromium.org/blink/trunk@185330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/724483002

git-svn-id: svn://svn.chromium.org/blink/trunk@185329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes a bug when hiding and showing transition elements and adds the test for it.

BUG=370696

Review URL: https://codereview.chromium.org/723073003

git-svn-id: svn://svn.chromium.org/blink/trunk@185328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185307

BUG=407416
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/718373003

git-svn-id: svn://svn.chromium.org/blink/trunk@185327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch implements the showNotification() method by extending the
ServiceWorkerRegistration object, and calling through to the Platform
for requesting display of a persistent notification.

BUG=432527

Review URL: https://codereview.chromium.org/717273002

git-svn-id: svn://svn.chromium.org/blink/trunk@185326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, LayerPainter would try to avoid starting a transparency layer
until it encountered actual drawable content within the RenderLayer that has transparency, or its child.

This optimization makes for code complexity and speed issues, makes it hard to
implement clean display lists, and is most likely not a useful optimization.
It is likely not useful for two reasons:

* It only has effect if the webpage has opacity but no actual content. That does not seem common.
* Skia already has optimizations to remove unnecessary layers if there is no content within them:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/src/core/SkRecordOpts.cpp&q=SkRecordNoopSaveRestores&sq=package:chromium&type=cs&l=21

BUG=432755

Review URL: https://codereview.chromium.org/725433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Per SW spec issue:
https://github.com/slightlyoff/ServiceWorker/issues/550

Cache.put() should throw if request/response bodies
are already used, and consume request body (if non-empty)
and response body.

BUG=430962

Review URL: https://codereview.chromium.org/708703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185323 bbb929c8-8fbe-4397-9dbb-9b2b20218538

PHP 5.4.0 and newer implement hex2bin natively. Since PHP versions
aren't uniform across platforms, just prefix it and hope it doesn't
collide with another function in the future.

BUG=none

Review URL: https://codereview.chromium.org/724863003

git-svn-id: svn://svn.chromium.org/blink/trunk@185322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The main frame's size is no longer simply the viewport size. Instead,
WebViewImpl sizes it after layout to be the either the content width with
a height matching the viewport aspect ratio, or the viewport at minimum page
scale. This fixes a bug where the innerWidth/innerHeight values would be
wrong during an onload event if the onload would happen before the content was
properly sized.

BUG=431097,428722

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185145

Review URL: https://codereview.chromium.org/705423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the second patch in the series to migrate
to LayoutUnits in all InlineBox classes.

BUG=321237

Review URL: https://codereview.chromium.org/699683002

git-svn-id: svn://svn.chromium.org/blink/trunk@185320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#ecdsa

This changelist
 * Defines a new key type for EC keys
 * Implements structured clone for EC keys
 * Adds algorithm parameter parsing for WebCrypto's EcdsaParams, EcKeyGenParams and EcKeyImportParams

This change does not include any LayoutTests, as the tests depend on the Chromium side landing first.

The LayoutTests are part of: https://codereview.chromium.org/707753002/ and will be landed last.

BUG=399094

Review URL: https://codereview.chromium.org/707743002

git-svn-id: svn://svn.chromium.org/blink/trunk@185319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert "Only allow background tabs if the underlying input event allows it" (patchset #1 id:1 of https://codereview.chromium.org/721793002/)

Reason for revert:
Removed failing browser test

Original issue's description:
> Revert "Only allow background tabs if the underlying input event allows it"
> 
> This reverts commit c67fa612fedd3cf79f999ad61f2022dec85ff032, aka r185205.
> 
> Speculative revert to green up browser_tests:
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=PrerenderBrowserTest.PrerenderClickNewBackgroundTab
> 
> TBR=jochen@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185220

TBR=senorblanco@chromium.org
BUG=

Review URL: https://codereview.chromium.org/720283002

git-svn-id: svn://svn.chromium.org/blink/trunk@185318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431697

Review URL: https://codereview.chromium.org/725583003

git-svn-id: svn://svn.chromium.org/blink/trunk@185317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=426520

Review URL: https://codereview.chromium.org/715863004

git-svn-id: svn://svn.chromium.org/blink/trunk@185316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(WebIDL's "unsigned long" is a 32-bit type)

BUG=267360

Review URL: https://codereview.chromium.org/717413002

git-svn-id: svn://svn.chromium.org/blink/trunk@185315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit dd138e54138a00f80fa1547bb3b4922aa02ad335, aka r185305.

Speculative revert to fix Android AOSP build breakage: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/33131/steps/compile/logs/stdio.

TBR=yangguo,jochen@chromium.org,vogelheim
BUG=

Review URL: https://codereview.chromium.org/721373002

git-svn-id: svn://svn.chromium.org/blink/trunk@185314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces the notificationclick and notificationerror
events on the ServiceWorkerGlobalScope, and provides the necessary
plumbing to be able to invoke them from the embedder.

BUG=432527

Review URL: https://codereview.chromium.org/720873002

git-svn-id: svn://svn.chromium.org/blink/trunk@185313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trailing optional Dictionary are automagically handled by bindings,
with a new empty dictionary passed in if the argument is not
specified by script. Overloads are not needed in this case.

BUG=373120

Review URL: https://codereview.chromium.org/717283002

git-svn-id: svn://svn.chromium.org/blink/trunk@185312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Count decoded frames in ImageFrameGenerator, and remove remove multi-frame image decoders when the image is completely decoded

This saves memory on pages with a lot of multi-frame images. data and discussion please see https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/KZ8EDtEZ9-c

BUG=429614

Review URL: https://codereview.chromium.org/688423004

git-svn-id: svn://svn.chromium.org/blink/trunk@185311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The plugin might attempt to call invalidateRect while it is being
destroyed, in which case its renderer could be NULL.

BUG=432045

Review URL: https://codereview.chromium.org/723733002

git-svn-id: svn://svn.chromium.org/blink/trunk@185308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The class was misguided and only needed because
we generated the invalidations using this code
path before https://codereview.chromium.org/665673004

BUG=407416

Review URL: https://codereview.chromium.org/696703005

git-svn-id: svn://svn.chromium.org/blink/trunk@185307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/722683003

git-svn-id: svn://svn.chromium.org/blink/trunk@185306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=jochen@chromium.org, vogelheim@chromium.org

Review URL: https://codereview.chromium.org/720783002

git-svn-id: svn://svn.chromium.org/blink/trunk@185305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test is added disabled since this functionality is currently broken

BUG=432493
R=pfeldman, yurys, sergeyv

Review URL: https://codereview.chromium.org/724053003

git-svn-id: svn://svn.chromium.org/blink/trunk@185304 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a partial revert of r184607. Turns out reducing the number of workers
was not the right solution for our performance issues.

BUG=427569
R=dpranke@chromium.org
NOTRY=true
TEST=test-webkitpy

Review URL: https://codereview.chromium.org/722193002

git-svn-id: svn://svn.chromium.org/blink/trunk@185303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=430337
NOTRY=true

Review URL: https://codereview.chromium.org/724083002

git-svn-id: svn://svn.chromium.org/blink/trunk@185302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The gyp is no longer needed, and the defines in the gypi are
no longer required.

Review URL: https://codereview.chromium.org/717363002

git-svn-id: svn://svn.chromium.org/blink/trunk@185301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pfeldman

Review URL: https://codereview.chromium.org/722273002

git-svn-id: svn://svn.chromium.org/blink/trunk@185300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jkummerow@chromium.org,yosin
BUG=432907

Review URL: https://codereview.chromium.org/722253002

git-svn-id: svn://svn.chromium.org/blink/trunk@185299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Without setting 'all: initial', it's possible for text colours and such to be
inherited by the placeholder, which is unexpected.

TEST=fast/plugins/plugin-placeholder-inherit.html
BUG=364716

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184878

Review URL: https://codereview.chromium.org/669883003

git-svn-id: svn://svn.chromium.org/blink/trunk@185298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I found that I still need a multi purpose dispatcher for the Push API. I'll re-implement the permission request in a followup CL.

BUG=389194

Review URL: https://codereview.chromium.org/728443002

git-svn-id: svn://svn.chromium.org/blink/trunk@185297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Notification events delivered to Service Workers (notificationclick
and notificationerror) will receive an instance of the Notification
object which they were triggered for, represented through a
NotificationEvent. It's of the SW ExtendableEvent type.

BUG=432527

Review URL: https://codereview.chromium.org/718093002

git-svn-id: svn://svn.chromium.org/blink/trunk@185296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

By this CL, all the uses of ArrayBuffer in modules/ have been rewritten
with DOMArrayBuffer.

BUG=235436

Review URL: https://codereview.chromium.org/723143002

git-svn-id: svn://svn.chromium.org/blink/trunk@185295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to rely on event.thread.target in multiple places where
target was needed. These places mostly imply that this was a main
target (i.e. using it to get DOMModel & co), while it can now be a
different (or null) target. Let's keep main target associated with
timeline in Timeline model (and perhaps return null for recorded
timelines later) and plumb it where it is necessary.

BUG=

Review URL: https://codereview.chromium.org/717243002

git-svn-id: svn://svn.chromium.org/blink/trunk@185294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This lets us lose some overloading and code duplication.

BUG=430337

Review URL: https://codereview.chromium.org/714123002

git-svn-id: svn://svn.chromium.org/blink/trunk@185293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since CSSValue.idl and its family were removed, we no longer need
to support [Custom=Wrap].

BUG=235436

Review URL: https://codereview.chromium.org/726553002

git-svn-id: svn://svn.chromium.org/blink/trunk@185292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/718033002

git-svn-id: svn://svn.chromium.org/blink/trunk@185291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows focus to enter and leave plugin placeholders, so that constituent
elements (such as a close button) can be keyboard-focused.

TEST=fast/plugins/plugin/placeholder-focus.html
BUG=364716

Review URL: https://codereview.chromium.org/717193003

git-svn-id: svn://svn.chromium.org/blink/trunk@185290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When calculating "optionality list" for a method (as part of calculating
the effective overload set), treat variadic arguments as optional instead
as required.

WebIDL defines the optionality list as a list of "required", "optional"
and "variadic", whereas we implement it as a list of booleans. A list of
booleans is enough to achieve correct behavior, assuming both "optional"
and "variadic" are considered to be optional (true).

BUG=293561

Review URL: https://codereview.chromium.org/723013003

git-svn-id: svn://svn.chromium.org/blink/trunk@185289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 97aec2f2a341c96bce31aa8264828135c44e1ccb, aka r185263.

This a speculative revert to fix Android Tests (dbg), which is currently
blocking the Blink roll.

TBR=trchen,pdr
BUG=

Review URL: https://codereview.chromium.org/723103002

git-svn-id: svn://svn.chromium.org/blink/trunk@185287 bbb929c8-8fbe-4397-9dbb-9b2b20218538