- 22 Feb, 2019 40 commits
-
-
Ian Kilpatrick authored
Previously we considered text-align for inline-level OOFs inside a block-level context. But we also needed to avoid floats. This is surprisingly consistent across browsers! However no tests. :( So fixed and added tests! Most of the complexity in this patch is making sure the logical->line->logical coordinate transforms are done correctly. Bug: 933996 Change-Id: I78207f8b7cba62e9d6f48f087fd5202178b42910 Reviewed-on: https://chromium-review.googlesource.com/c/1480071Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#634522}
-
Luciano Pacheco authored
Make Files, Gallery and Audio apps work with HTML Imports polyfill. The tests aren't passing yet, which I'm fixing on CL:1462640, but I have tested these 3 apps manually locally with: --disable-blink-features=HTMLImports and they seem to be working. However, I haven't tested them heavily, but I did test things related to Polymer elements which are affected by HTML imports. Add connect-src chrome://resources to Audio and Gallery's manifests (content_security_policy) to allow HTML import polyfill to URL fetch resources (via xmlHTTPRequest). File Manager's manifest already had this CSP setting. Bug: 924873 Change-Id: I43dc5962be9d8cbdcf795b35b8de909578ac4279 Reviewed-on: https://chromium-review.googlesource.com/c/1480296Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#634521}
-
Tsuyoshi Horo authored
Bug: 910516 Change-Id: I01f776e0a787e97430cc033d55bb1a32e900f9e9 Reviewed-on: https://chromium-review.googlesource.com/c/1480363 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#634520}
-
Kunihiko Sakamoto authored
This removes SignedHTTPExchangeOriginTrial feature, and its accompanied SignedHTTPExchangeAcceptHeader feature which is used for the Accept header opt-in. Bug: 827939,887201 Change-Id: I0794b886715a63cb6ac43c37a0adaddeb31f2af8 Reviewed-on: https://chromium-review.googlesource.com/c/1481181Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
As one of the servicification support, this CL makes that IdentityManager::DiagnosticsObserver can handle OAuth2TokenService::DiagnosticsObserver::OnAccessTokenRequestCompleted callback. The test case observe access token fetch request error when account has no refresh token, when access token request succeeded with no error, when access token request fails after revoking refresh token. Bug: 931246 Change-Id: I2d8d1d497c9a8f740e9cc0614141dbd9dc4571e2 Reviewed-on: https://chromium-review.googlesource.com/c/1474958 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634518}
-
Aga Wronska authored
Bug: 839025 Change-Id: I19967724efab49c6ae3b27bac0676a9e9aeebc74 Reviewed-on: https://chromium-review.googlesource.com/c/1449314Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#634517}
-
Abhijeet Kandalkar authored
cross_origin_attribute_value.h is related to fetching. Hence this CL moves cross_origin_attribute_value.h to platform/loader/fetch and port other dependent files to refer to a new include path. Bug: 933886 Change-Id: I7f10e662434caebf82b9b6bdfbc5f613620ef2b5 Reviewed-on: https://chromium-review.googlesource.com/c/1481147Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#634516}
-
David Jacobo authored
Manual style fix, just to keep cols to 80 where easily avoidable. Bug: None. Change-Id: I3d8fc15351e8911ce3976d4903ff15e50393b6cc Reviewed-on: https://chromium-review.googlesource.com/c/1481793Reviewed-by:
-
Oksana Zhuravlova authored
This change adds a way of overriding RenderFrameImpl's document interface broker with a custom implementation. Bug: 718652 Change-Id: Ia1fb901d0188858e67b930121d79e099506a167a Reviewed-on: https://chromium-review.googlesource.com/c/1464923 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#634514}
-
Luke Halliwell authored
This reverts commit c513d32f. Reason for revert: See internal b/124450506 Ultimately, this code gets bitten by these horrors: https://codesearch.chromium.org/chromium/src/services/service_manager/embedder/set_process_title_linux.cc?q=process_title&sq=package:chromium&g=0&l=114 Original change's description: > [fuchsia] Read the command-line from /data/cast/ > > The command-line will now be populated from > /data/cast/castagent-command-line. > > Bug: b/122267826 > Test: Add command-line to show verbose logging, cast_shell_unittests > Change-Id: I741a1a32e59bea07a2ce857d24df57712cf32761 > Reviewed-on: https://chromium-review.googlesource.com/c/1396135 > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Reviewed-by: Sergey Volk <servolk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625457} TBR=wez@chromium.org,servolk@chromium.org,yucliu@chromium.org,awolter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/122267826 Change-Id: I5ce28fa732ac6f1af8f3e19a51d66bceab081681 Reviewed-on: https://chromium-review.googlesource.com/c/1482135Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634513}
-
Nate Fischer authored
No change to the legacy code path. This implements #removeSessionCookies and #removeAllCookies for the network service code path. This implements both APIs on top of CookieManager::DeleteCookies(). This removes 3 tests from the filter (the remaining related test is blocked on fixing #hasCookies). Bug: 931641, 933629, 902641, 933462 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f CookieManagerTest#testRemove* Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Idb8f1bb5c464993fd142f29681395598c2f65cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1478459 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634512}
-
Zhenyao Mo authored
This reverts commit bccf0827. Reason for revert: we got the extra logging we needed from user Original change's description: > Add VLOG to DirectCompositionChildSurfaceWin::SetDrawRectangle > > This is for investigation purpose and will revert after this gets > in Canary and we get the error message from user. > > BUG=914911 > TEST=bots > R=piman@chromium.org > > Change-Id: I67761a335c7e6dee36a2beb8c593f03c4b2d1958 > Reviewed-on: https://chromium-review.googlesource.com/c/1396847 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620164} TBR=zmo@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 914911 Change-Id: I7e3f9daf0abd50b81f8c27a7e08e8ebe56ba1196 Reviewed-on: https://chromium-review.googlesource.com/c/1480070Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634511}
-
Stephen Chenney authored
libxslt fixed an issue with type confusion in xmlXPathNextPrecedingSibling. R=dcheng@chromium.org BUG=930663 Change-Id: Ib8055551b370c7d64957152e0fda57090110dee8 Reviewed-on: https://chromium-review.googlesource.com/c/1477805 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634510}
-
Takashi Sakamoto authored
This reverts commit 56a50dae. Reason for revert: Suspect causing browser_tests, viz_browser_tests, non_single_process_mash_browser_tests failures on Linux Chromium OS ASan LSan Tests (1). E.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31690 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8920872960619542176/+/steps/browser_tests/0/logs/DownloadNotificationTest.IncognitoDownloadFile__status_CRASH_/0 ==19438==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d0001b7a80 at pc 0x55f331c5ce2d bp 0x7f3096281310 sp 0x7f3096281308 READ of size 8 at 0x60d0001b7a80 thread T6 (Chrome_IOThread) #0 0x55f331c5ce2c in content::URLLoaderFactoryGetter::SetNetworkFactoryForTesting(network::mojom::URLLoaderFactory*, bool) ./../../content/browser/url_loader_factory_getter.cc:226:5 ... Original change's description: > Enable NetworkService by default on ChromeOS > > Bug: 920038 > Change-Id: I577d9d497bc564b885a4a96ce5baf4f3326ce1a8 > Reviewed-on: https://chromium-review.googlesource.com/c/1464069 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634333} TBR=jam@chromium.org,jbudorick@chromium.org,rmcelrath@chromium.org Change-Id: Ibfeeadd47f94d4ff4a87ed9518c9bc0d7f2e30b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920038 Reviewed-on: https://chromium-review.googlesource.com/c/1482099Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#634509}
-
David Grogan authored
I didn't realize it was already calculated, it just needed to be passed to the fragment builder. Bug: 845235 Change-Id: I6ac97cd9326b545a395677e3ae03d09a7f341def Reviewed-on: https://chromium-review.googlesource.com/c/1479816Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634508}
-
Hirokazu Honda authored
The original comment about stride in VideoFrameLayout::Plane is confusing as its value is in bytes or in elements. This clarifies that it stands for a stride in bytes. Bug: None Test: Confirm stride is used as bytes everywhere for now Change-Id: I9eae65c77add74ad07bba936bc315f33ea4c7bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1477627Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634507}
-
Adam Langley authored
getTransports is now included in the W3C draft for Webauthn[1]. Thus this change enables it by default by removing its individual flag protection. (See [2] for where this was added originally.) [1] https://github.com/w3c/webauthn/commit/11d549048ac5e462a4f9f44499032302adb29800 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1180083 Change-Id: Iee6209ac0c75fe2537bcb6f9edd0f8bc974e6d15 Reviewed-on: https://chromium-review.googlesource.com/c/1471630Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634506}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3fc635ac4a7f..b607bc8800c1 git log 3fc635ac4a7f..b607bc8800c1 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 hliatis@google.com vkGetDescriptorSetLayoutSupportKHR listed wrong 2019-02-22 hliatis@google.com Update ICD version to 3.0 Created with: gclient setdep -r src/third_party/swiftshader@b607bc8800c1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/125417927,chromium:b/125405086 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Iefd68a04a6a1a8acf7b5ba37e0860113e5451ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1482056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634505}
-
Yoshifumi Inoue authored
This patch gets rid of unused class |NGPaintFragmentWithContainerOffset| for improving code health. Change-Id: I41367bc1801d8adf96858c3fd78d75b4756185be Reviewed-on: https://chromium-review.googlesource.com/c/1480367 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#634504}
-
Sergey Ulanov authored
By default web::Frame instances created in a web_engine are not shown on the screen. Previously web_engine wasn't setting initially_hiddent flag when creating the underlying WebContents instance. This meant that the frame's LayerTreeView had visibility flag set even though it was not actually visible. As result it kept restarting GPU process which was always failing (due to SwiftShader missing), resulting in log spam (see linked bug for details). Bug: 933861 Change-Id: I057cd215612b33b0a73077d610a5cd9486bfa7d8 Reviewed-on: https://chromium-review.googlesource.com/c/1481950Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634503}
-
Lakshman Annadorai authored
Bug: b/113543023 Change-Id: Iafa208c6e650c1a71144b5e38621e981246ec382 Reviewed-on: https://chromium-review.googlesource.com/c/1479572Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Lakshman Annadorai <lakshmana@chromium.org> Cr-Commit-Position: refs/heads/master@{#634502}
-
Eric Karl authored
WebglConformance_conformance2_textures_canvas_tex_3d_r11f_g11f_b10f_rgb_unsigned_int_10f_11f_11f_rev is flaky. Bug: 934556 Change-Id: I19e9f01ec63a9ac2e629fde024997f56682b4e31 Reviewed-on: https://chromium-review.googlesource.com/c/1481120 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634501}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d86ff86d744..e9912ca049a0 git log 3d86ff86d744..e9912ca049a0 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-21 robertphillips@google.com Move StrikeCache and TextBlobCache to RecordingContext 2019-02-21 robertphillips@google.com Revert "SkSL now supports null child processors" 2019-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src dca111a7..61d99852 (495 commits) 2019-02-21 csmartdalton@google.com vk: Hold refs to sampled textures as opposed to raw ptrs 2019-02-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 08573730b75a..962c222aa3be (1 commits) 2019-02-21 ethannicholas@google.com SkSL now supports null child processors 2019-02-21 mtklein@google.com Revert "remove linear sRGB singleton" 2019-02-21 reed@google.com fix mac format for gm 2019-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0eee33250ebb..3fc635ac4a7f (1 commits) Created with: gclient setdep -r src/third_party/skia@e9912ca049a0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ie35ea268e5e1d7182eda5631d66609a576722a24 Reviewed-on: https://chromium-review.googlesource.com/c/1482055Reviewed-by:
-
Ehsan Karamad authored
This CL is the second part in the implementation of navigation to PDF resources with frame-based MimeHandlerView. This change implements the logic for creating a MimeHandlerViewFrameContainer in response to browser's request. To this end, when handling the resource request response for a PDF mime-type, DOMImplementation avoids creating a PluginDocument and implements an HTMLDocument instead. The document is then populated with the templated HTML page injected by the plugin response interceptor. Design document: https://docs.google.com/document/d/1_gJv4_fewyfjI7lcUgFX14iQxDudtEMrsjjWKpkI5BI/edit Bug: 659750 Change-Id: I9a4490d99391d746333f76979e98682fa6742be7 Reviewed-on: https://chromium-review.googlesource.com/c/1477921Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#634499}
-
Nicholas Hollingum authored
Adds the relevant pieces to crostini that allow it to declare that one of ash's folders should be persistent (i.e. alive with only 1 item in it). We do this by adding an observer which updates the folder's metadata with the persistence property. This CL also includes some refactoring of the unit tests here so that they better reflect how chrome and ash communicate, and so the expectations are a bit nicer to work with. Bug: 925052 Change-Id: Ie0c211cf9783fa2318d1e35d1b25827c0fdc048f Reviewed-on: https://chromium-review.googlesource.com/c/1469194 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634498}
-
Erik Chen authored
This CL updates test sharding so that the tests PRE_XYZ and XYZ will always end up in the same shard. Previously, tests were sharded by their name, so the tests PRE_XYZ and XYZ would most likely end up in different shards. The test launcher output for the shard for XYZ would contain the test location for XYZ, but not the test location for PRE_XYZ. However, the test XYZ will cause the test PRE_XYZ to be run. If PRE_XYZ crashed, then the test results tracker would hit a DCHECK when looking for the test location for TEST_XYZ Bug: 927900 Change-Id: I7dae60c5cf2cf8a9ecf3a4d6b025012c89d5cb51 Reviewed-on: https://chromium-review.googlesource.com/c/1450754 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#634497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/689da99593bd..c27f11d2e607 Created with: gclient setdep -r src-internal@c27f11d2e607 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie6820cd60cad8a0b416bfb845a312cf9c4d48102 Reviewed-on: https://chromium-review.googlesource.com/c/1482052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634496}
-
Jared Saul authored
Change-Id: I2f0ecf66e62a03aab712b913fae92414efd79cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1479276 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634495}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/45d4beab9980..76fb06310126 git log 45d4beab9980..76fb06310126 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 takumif@chromium.org Remove MediaRouterDialogTabTest 2019-02-21 benjhayden@chromium.org Add default recommendations to recommended-options. 2019-02-21 crouleau@chromium.org Revert "speed: Look only for the appropriate devices/browsers." 2019-02-21 benjhayden@chromium.org Fix a bug in spa/chart-legend. 2019-02-21 benjhayden@chromium.org Hide empty recommended options. 2019-02-21 benjhayden@chromium.org Fix brush handles in spa/chart-base. Created with: gclient setdep -r src/third_party/catapult@76fb06310126 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:932409,chromium:918193,chromium:918193,chromium:918193 TBR=sullivan@chromium.org Change-Id: I6358dd6f9d731ebb573901804625f675ec1b1121 Reviewed-on: https://chromium-review.googlesource.com/c/1482053Reviewed-by:
-
Mike Wittman authored
Moves the parallel module caching implementation for Windows into ModuleCache. This implementation will be merged with the existing module caching implementation over the course of later refactoring CLs. Bug: 931418 Change-Id: I65309bca1edc2675e7e5d74e0305bf5cfe017fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1478035 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#634493}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4022be40d9f1..36974ad871c9 git log 4022be40d9f1..36974ad871c9 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 ehmaldonado@chromium.org metrics_utils: Fallback to HEAD if upstream is None. 2019-02-21 tikuta@chromium.org [OWNERS] revive agable Created with: gclient setdep -r src/third_party/depot_tools@36974ad871c9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:934494 TBR=agable@chromium.org Change-Id: I174b837793b45c8ce3b5bc87f6cdd9ccb6c2d3da Reviewed-on: https://chromium-review.googlesource.com/c/1482051Reviewed-by:
-
Zhuoyu Qian authored
As the comment in main.py by tkent@, replace "WebKit" with "Blink". Change-Id: I0277158f102a96be6d40381a7d8880f32b221f55 Reviewed-on: https://chromium-review.googlesource.com/c/1481184Reviewed-by:
-
iOS Autoroller authored
TBR=smut Change-Id: Ibd9038884531c842a73d5a0d398a479133197025 Reviewed-on: https://chromium-review.googlesource.com/c/1481118Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#634490}
-
Nate Fischer authored
This removes the `--apk-dir` flag from our docs on run_cts.py. Although this flag used to be a cache directory (at which time it was a useful optimization), this is now only a temp folder (test APKs are pulled in via CIPD, so they don't need to be cached). R=aluo@chromium.org, changwan@chromium.org Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I7dfba4ee0646ce7c62acb89b02e872dfca9b8595 Reviewed-on: https://chromium-review.googlesource.com/c/1481075Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634489}
-
Dale Curtis authored
Rework test to avoid playback, since the timing of the opacity update is unpredictable across platforms and may race with the test's pixel capture. --------------[ Original Description Below ]-------------- Same as the last reland but waits for a requestAnimationFrame cycle to ensure the video surface layer has been painted. --------------[ Original Description Below ]-------------- Simply moves the win7 expectation to win since they both use the same one. Formats the HTML and adds a title too. Adds an expectation for Linux which seems to have changed since last landing... --------------[ Original Description Below ]-------------- Apparently we don't have any vpx-alpha layout tests, hence macOS has had broken support here for some time. BUG=919015 TEST=fails without the macOS alpha fix. TBR=dcastagna Change-Id: I74eb6922e95de8171710f421450e9b69b8e26208 Reviewed-on: https://chromium-review.googlesource.com/c/1480709Reviewed-by:
-
Satoshi Niwa authored
ARC MyFiles : Notify ARC of MyFiles volume by sending a fake mount event from ArcVolumeMounterBridge Design doc : go/arc-myfiles (See "Volume Mounter" section) ARC-side CL : ag/6265279 BUG=b:123362537 CQ-DEPEND=1454017 TEST=Check that ARC VolueMounter receives a mount event for MyFiles Change-Id: Ie75116a69c6785f0b4958b83bfb79006068e8a6d Reviewed-on: https://chromium-review.googlesource.com/c/1454347 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#634487}
-
Lukasz Anforowicz authored
This CL makes the following changes: Product code changes: - Moving most of verification of CommonNavigationParams that used to be done in RenderFrameHostImpl::BeginNavigation into a new helper function in frame_host/ipc_utils.cc - VerifyCommonNavigationParams. - Making sure that VerifyCommonNavigationParams verifies things that used to be covered by RenderFrameHostImpl::BeginNavigation and *also* covers verification of |initiator_origin| (reusing other verification helpers present in frame_host/ipc_utils.cc). - Auditing callers of SetRequestorOrigin and making sure they use the right origin - they should use the initiating frame's origin. The following functions have been tweaked: 1) blink::FrameLoader::ResourceRequestForReload 2) blink::HTMLAnchorElement::HandleClick - Without tweak #1 some browser tests would have failed (e.g. the existing DNSErrorPageTest.StaleCacheStatus or the new ErrorPageNavigationReload_InSubframe_BlockedByClient in the RenderFrameHostManagerTest suite). - I also note that the tweaked line in blink::FrameLoader::ResourceRequestForReload was added in r529246 which also added a regression test which still passes: RenderFrameDevToolsAgentHostBrowserTest.ReloadDinoPage Test changes: - Moving IsolateOrigin[ForTesting] from security_exploit_browsertest.cc into content/public/test/content_browser_test_utils.h - Renaming DidCommitProvisionalLoadInterceptor into FrameHostInterceptor and supporting intercepting one more method of FrameHost - BeginNavigation (in addition to the old support for intercepting DidCommitProvisionalLoad). - Adding test coverage for terminating a renderer that provides an invalid value in the |initiator_origin| argument of BeginNavigation. - Adding test coverage for renderer-initiated reloading of an erorred-out subframe. Bug: 919144 Change-Id: I2de74a634e6691b490cd94df1ac8494248f7c363 Reviewed-on: https://chromium-review.googlesource.com/c/1455470 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
This change replaces then() with await() as suggested in a previous review. It also moves the first assert to a point after the override is set to verify that calls on previously created proxies are not affected by setting the override. Bug: 718652 Change-Id: Ia0ac1e1793503b8548cac8e8ef468f22eac9d934 Reviewed-on: https://chromium-review.googlesource.com/c/1481578Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#634485}
-
tby authored
This uses the Dolphin model added in previous CLs to tweak the search result scores. For context, see: https://docs.google.com/document/d/1BUHZyQ1a07laOgbxSRNNbQnTHaUPLRGjENJEJHYTtn0/edit?usp=sharing Details: - Currently rankings are very conservative, with a multiplier set via a Finch flag. - ranking_item_util has been slightly refactored. This isn't strictly necessary for this CL, but will prevent a merge conflict with CLs from other team members. - Tests have been expanded to support testing the effect of the Dolphin model. Bug: 931149 Change-Id: Ida824072d7553033000eeba771f97816bd71548a Reviewed-on: https://chromium-review.googlesource.com/c/1481172 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634484}
-
Khushal authored
In DoEndRasterCHROMIUM skia flushes the GL work for the complete tile in its GrOpList in prepareForExternalIO which can be a slow operation. Make sure the watchdog thread is notified to avoid spurious hangs. R=piman@chromium.org Bug: 934483 Change-Id: Ifb35ceb70da93796b59da5b9bff78636cd4cea0d Reviewed-on: https://chromium-review.googlesource.com/c/1482032 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634483}
-
