GitLab

WebAudio legacy code often does something like:

  DCHECK(foo);
  if (!foo)
    return;

The style guide says the if/return should be removed; DCHECK failures
should not be handled.

Part 5 of 5: Update a few more files and for the most obvious cases
where we can remove the if/return.

We are basically done; there may be some left, but they're more complicated.

Bug: 957654
Change-Id: I60b472fa3641bb7fd7e927c1f0839adf1ecaaad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769163Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690145}

Add the gradient zone to the scrollable shelf. The zone's location
is based on the layout strategy according to the new spec.

Bug: 973481
Change-Id: I2949ca70bea6219dd2df3a7cf377050f5cb8b3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764765
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690144}

This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1707953. This change requires that users re-authorize Chrome Remote Desktop for
accessibility permission. It's not important enough for that downside.

Bug: 997387
Change-Id: I21047315ab0f53d5b09f09ee1666d6745c9c1c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769714
Auto-Submit: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690143}

Now ARCVM's throttling is handled solely by Concierge. This CL depends
on chromium:1748118.

BUG=b:139095697
TEST=Start ARCVM, verify /sys/fs/cgroup/cpu/vms/arc/tasks is not empty,
 launch Play Store, verify /sys/fs/cgroup/cpu/vms/arc/cpu.shares is 1024,
 switch to Chrome, verify cpu.shares is 64.

Change-Id: Ic9746bb29363ed71ef5b43ef3659f78c23b07be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758588
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690142}

https://dawn.googlesource.com/dawn.git/+log/3f21e11e240a..25cc723823e3

git log 3f21e11e240a..25cc723823e3 --date=short --no-merges --format='%ad %ae %s'
2019-08-23 rafael.cintron@microsoft.com Fix mFenceEvent HANDLE leak

Created with:
  gclient setdep -r src/third_party/dawn@25cc723823e3

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: Ic6d6ff056de954fa5dd5a40d3823a62a9486ec97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769654Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690141}

The bounds of the hotseat are not adapted to RTL. This CL fixes the issue.

Bug: 997356
Change-Id: Ib73aec5af90958ebff2ec82d326dfbb704efaf1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769550Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690140}

- Corrects the About page to calling the correct method on the
AboutPageBrowserProxy.
- Adds a test

Bug: 997155
Change-Id: If39b45274f6d3836b52039c22086b300b5d3f5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769625Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690139}

In particular some tests that test saving to files, as well as making
sure that the usage indicator is shown when the site has write access.

Bug: 993597
Change-Id: I2ee793921b6ea612731e278e8fbd5f4c5cfd093a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761249
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690138}

The present CL implements a more reliable way to determine in which
display a window is being dragged. For mouse dragging, it shall use
CursorManager::GetDisplay. For touch dragging, it shall simply use the
display where the drag started.

Bug: 995413
Change-Id: I3ed8f5ef236d01d8bbbc397cfa7372be530be8af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761523
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690137}

... now that it is Oilpan GC-ed.

This is a follow up of [1].

[1] https://crrev.com/c/1765493

BUG=704136
R=jbroman@chromium.org

Change-Id: I9f2204ac9e1cbbae885acb67ab12874c2a95f96a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768788
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#690136}

During the login sequence, browser context will settle before Assistant
has bound its delegate. This means when the delegate is set, we won't
register the fact that there may already be a set of relevant proactive
suggestions until the browser context changes.

To address this, we notify the delegate of any cached proactive
suggestions when it is being bound.

Bug: b:139199715
Change-Id: Ia2b91eb59368909bda4a54af28048cebe62cdbac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767485
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690135}

This reverts commit 63fbbb92.

Reason for revert: Flaky on ios: https://ci.chromium.org/p/chromium/builders/try/ios-simulator/351893

Original change's description:
> [ThreadPool]: Implement Job Delegate's ShouldYield and concurrency increase.
> 
> This CL partially implement job's delegate, as well as concurrency
> usage assertion:
> - ShouldYield must be called in worker task.
> - max concurrency is expected to decrease unless
>   NotifyConcurrencyIncrease() is called.
> 
> To implement ShouldYield, PooledTaskRunnerDelegate is used
> to communicate with ThreadPool and a racy priority is added to
> task source.
> 
> Bug: 839091
> Change-Id: I3504f00ec48ab600f79b64e44151bc9dded408a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713146
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#690127}

TBR=gab@chromium.org,fdoray@chromium.org,etiennep@chromium.org

Change-Id: Id5b9838a38baa9ac00acda22284b35270344480c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769085Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690134}

This CL updates the system navigation bar and top status bar in GTS for
incognito.

Change-Id: I169c8706eeaa7bb7b4994b02f2bcfffb53fb2b9f
Bug: 997345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769632Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690133}

Bug: 997359
Change-Id: I6d6dbe7d9ee75b82506530529318044873a28f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769703
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690132}

This CL:
* Extracts internet_subpage_tests to a separate test suite.
* Eliminates click-to-navigate logic from tests to fix flakiness.
* Removes the tests from cr_settings_browsertest (they are redundant).
* Re-enables the tests in os_settings_browsertest.

Bug: 92116
Change-Id: Ibb005e607ada112f33d3b6df3695893c8b537aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768909
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690131}

The reported crash shows that BottomSheetController might not be ready
at the beginning when Tab starts getting first overscroll events. This
CL adds nul checks in the interface implementation of NavigationSheet
against the controller to not perform the action until the controller
is ready for use.

Bug: 996184
Change-Id: I6624282caaf79c8d2bd24ce8128aa24f16848cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765055Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690130}

Suppresses Pixel_WebGL_PremultipliedAlpha_False on Win10/Intel HD 630
configurations.

TBR=kbr@chromium.org

Bug: 997313
Change-Id: I9451e3f71d4e435cc0e0b6009e4d9ea41fb23657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769551Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690129}

https://chromium.googlesource.com/angle/angle.git/+log/83c24aa8a1cd..2f4a751866bc

git log 83c24aa8a1cd..2f4a751866bc --date=short --no-merges --format='%ad %ae %s'
2019-08-23 bsheedy@chromium.org Refactor perf tests to fix metric/story swapping
2019-08-23 geofflang@chromium.org Don't reset the texture size to zero in TextureGL::releaseTexImage on Mac.
2019-08-23 geofflang@chromium.org GL: Unset the bound PBO when initiailizing texture data.
2019-08-23 jonahr@google.com Suppress failure in MultisampleCompatibilityTest

Created with:
  gclient setdep -r src/third_party/angle@2f4a751866bc

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@chromium.org,jonahr@google.com

Bug: chromium:923564,chromium:924618
Change-Id: I73ecb3a8d22328dc7ecea0bc0bc52f9cd8fd405c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769648Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690128}

This CL partially implement job's delegate, as well as concurrency
usage assertion:
- ShouldYield must be called in worker task.
- max concurrency is expected to decrease unless
  NotifyConcurrencyIncrease() is called.

To implement ShouldYield, PooledTaskRunnerDelegate is used
to communicate with ThreadPool and a racy priority is added to
task source.

Bug: 839091
Change-Id: I3504f00ec48ab600f79b64e44151bc9dded408a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713146
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690127}

Reduce number of Web Servers created to 3. Initialize all servers
in single base class, and set class derivation to that class.
Remove GlobalStartUp and GlobalTearDown defs and calls where no longer
needed.

Bug: chromedriver:2279
Change-Id: I1a6b9cf89a80a04eef4d7579bc69ae14125af762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767062Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690126}

In my rework, I think there could be some race conditions
in the order of the output. I'll do the dry-run for now
and see whether anything manifests. Perhaps it's worth
doing some sorting of the logs, e.g. we could make the
test insensitive to the order of some of the events in
the golden file, by keeping two or three separate logging
streams for each section.

Bug: 991325
Change-Id: Ib9b8fb0732f5efbf9ad619ff12d5a36bccb02a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762823
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690125}

This still allows failing tests to run in isolation,
while avoiding running faulty tests repeatedly.

Bug: 993428
Change-Id: I4b6a005e03aaba1fa6019acd6628a15ebc8a8b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753694
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690124}

Updates the expiration of all the Preview Tab (aka Ephemeral Tab)
expiration milestones from M-80 to M-82.

BUG=988668

Change-Id: I45f5b87684762ff059cdcdbb8682faf0a30b9852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728182
Auto-Submit: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690123}

Bug: 853953
Change-Id: I00c177bdb0b1c40c23521871b94bea234cd81c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758543
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690122}

Change-Id: I3e1d47daa18f80efb8d8fc2b3f5cc6f671ec4bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722212
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690121}

This also enables the manfifest key for the service worker background
script and adds tests to verify expected state of some API bindings.

Bug: 995601
Change-Id: I3e456b09307093d4356368083c080a51e6db813b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761524
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690120}

The expression used in dom-if for a function call must include braces.
This patch adds the missing braces.

Bug: 976057
Change-Id: I948cf50721c96a5642d65ffecc369fa88689650a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767489Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690119}

Pressing the proactive suggestions view will now open Assistant UI
to show the proactive suggestions response inline.

See bug for demo.

Bug: b:139199739
Change-Id: I10f53bc7c0fe1c5273c2e92052a492676db083bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764104Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#690118}

TBR=kevers@chromium.org

Bug: 997149
Change-Id: I3ccb31de28435dfe85cf6457c9ec8acd7110ed23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769555Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690117}

This CL solves the issue that TabGridDialog uses wrong rect for animation
when the Tabs is sorted in MRU order.

It should be no-op when MRU is disabled.

Bug: 996381
Change-Id: I87d93a0f66199cdef50deaf7826bee77be5f7742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764268Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690116}

This CL also adds a basic test for this.

Bug: 980784
Change-Id: Ic8696ef13811cf2cc0135268966ee47c04c4185f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769235
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690115}

Disable DoH on desktop machines that have platform policies set so that
enterprise machines will not take part in the experiment.

Bug: 955454
Change-Id: I86465e85deddb1ed40a28af53d9bddd6c3d82d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764253
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690114}

This custom layer animation element complicates the animation
and causes regressions on several tests. Let's just replace it
by standard animation.

Bug: 996268, 994933
Test: interactive_ui_tests
Change-Id: I4c93b1db4ce8f4b853915209392796e75c61df53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764755
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690113}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/fb49e6c16449..ed2eef654373

git log fb49e6c16449..ed2eef654373 --date=short --no-merges --format='%ad %ae %s'
2019-08-23 absl-team@google.com Googletest export
2019-08-23 krystian.kuzniarek@gmail.com Googletest export
2019-08-23 zhangxy@google.com Merge pull request #2394 from kuzkry:custom-type-traits-duplication-of-custom-index_sequence
2019-08-23 zhangxy@google.com Merge pull request #2401 from kuzkry:custom-type-traits-add_lvalue_reference
2019-08-23 zhangxy@google.com Merge pull request #2400 from kuzkry:custom-type-traits-enable_if

Created with:
  gclient setdep -r src/third_party/googletest/src@ed2eef654373

The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official
TBR=isamsonov@google.com,staphany@google.com

Bug: None
Change-Id: I40152e10881cf5908f9cb93702f3c4048c510c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769538Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Staphany Park <staphany@google.com>
Reviewed-by: Staphany Park <staphany@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690112}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/fad1fa1b3234..5d51a2e48472

git log fad1fa1b3234..5d51a2e48472 --date=short --no-merges --format='%ad %ae %s'
2019-08-23 tcwang@google.com afdo: Add/Change schedules to toolchain AFDO builders.
2019-08-23 chrome-bot@chromium.org Update config settings by config-updater.
2019-08-23 dhanyaganesh@chromium.org config: Make atlas critical
2019-08-23 saklein@chromium.org uprev_lib: Fix uprev version check.

Created with:
  gclient setdep -r src/third_party/chromite@5d51a2e48472

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I1bc7d1a03ffa24eda03418d061ad98a686c523e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769540Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690111}

Experiment: 50

Bug: 731759
Change-Id: I4cb77566c9500cd46a90d04884c6287233c6f1dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761339
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690110}

Fixes a regression in archive tarball construction which was archiving
stripped binaries in the symbol tarball, as if it was a valid symbol
source.

R=fdegans@chromium.org, frousseau@google.com

Bug: 996050
Change-Id: I329f10a3fc3fdf75f354d537d0923ba1cb670ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769545Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690109}

CONNECTED and SUB_HEADER are actually never be used while
|use_unified_theme_| is false. This cl goes to remove the unnecessary
logic on |use_unified_theme_|.

May do more refactoring of TrayPopupItemStyle after the simplification.

TEST=IME tray and palette tray do not change visually
(these are the only cases where use_unified_theme_ == false is used.)

Bug: 982950
Change-Id: I71885bbff4b178cf2907e92bc539d0cdf650ce10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767095
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690108}

This allows us to easily switch between paths in code. The next step is
to add a OptimizationGuideDecider backed implementation of
PreviewsOptimizationGuide and allow for switching between them behind a
feature flag

Bug: 969558
Change-Id: I0c50bf8dd252958b128bb14737d8dcc92775bd87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765991
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690107}

Settings shows GAIA's notion of the user's email address. For example,
if the user signed up for a Google account "Foo.Bar@gmail.com", they
can login to their device with "foobar", but settings shows "Foo.Bar".

Under the hood, the "canonical" email is "foobar", and this is used to
create AccountId objects. signin_ui_util::GetAuthenticatedUsername()
was trying to create an AccountId object using "Foo.Bar" as input,
which caused the DCHECK. However, the function wants that AccountId
to look up the original email with periods in it.

Use ProfileHelper::Get()->GetUserByProfile(profile)->GetDisplayEmail()
instead. This avoids AccountId construction entirely. See bug for
details.

Also set a "display email" for public accounts to fix tests (and
possibly production).

Bug: 994798
Test: settings opens correctly for "james.cook@gmail.com"
Change-Id: Ia01f1d902d3439afa0f53c5535fe6097299ab916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757509Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690106}