GitLab

This makes sure clicking the native Picture-in-Picture button (after
entering Picture-in-Picture) exits Picture-in-Picture and that video
controls are reflected when entering and exiting Picture-in-Picture.

Screenshot: https://i.imgur.com/081Xbmb.png

Bug: 840516, 806249
Change-Id: I410a4a06cc4eea62dae8e1d368e4d05394f13c86
Reviewed-on: https://chromium-review.googlesource.com/1084833
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564807}

Currently async tests end up timing out when they call assert
but don't catch the resulting exception and call done(true).

It seems more natural that when an async test has an assertion
failure, that the harness should catch the exception and take
care of continuing tests.

The alternative that async tests should catch there own errors
has the drawback that specific errors are not ever reported.
E.g. code below is bad.

testAsync(done) {
  try {
    assertEquals('foo', 'bar', 'foo should match bar');
    done();
  } catch  (err) {
    done(true)
  }
}

Bug: 813477
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idbc88f94f6055eec37ab0d90b4b8d423fba6eb3f
Reviewed-on: https://chromium-review.googlesource.com/1088327Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564806}

See the issue for details.

Bug: 849975
Change-Id: If597bdb282a3f50b7f9f36d1e9970ae7eae27271
Notry: true
TBR: nhiroki@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1088347
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564805}

https://chromium.googlesource.com/catapult.git/+log/36d4a47..9861a71


git log 36d4a47..9861a71 --date=short --no-merges --format='%ad %ae %s'
2018-06-05 sadrul@chromium.org tabs: Switch back to async trace events.


Created with:
  gclient setdep -r src/third_party/catapult@9861a71

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:849182
TBR=sullivan@chromium.org

Change-Id: Id29f0c07a689efcbb900a4d9f0b54d2267602f51
Reviewed-on: https://chromium-review.googlesource.com/1088247Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564804}

Bug: chromedriver:2446
Change-Id: I63cfdc367af8cdbfc7f116fb51a3e3148ee0a950
Reviewed-on: https://chromium-review.googlesource.com/1087803
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564803}

Also allow API to be used via Origin Trial.

BUG=709348

Change-Id: I73e0c316a921ac3f9aac5cf259ef88ed37b38f9f
Reviewed-on: https://chromium-review.googlesource.com/862965Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564802}

This CL fixes animations in the toolbar selection overlay. The elements
would originally instantly appear rather than smoothly animate in due to
the way dom-if worked. This has been fixed by applying an opacity animation
rather than a show/hide.

Bug: 842007
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I75598d9048c3b4533a2dd52d003ff5a5d37e615d
Reviewed-on: https://chromium-review.googlesource.com/1084391Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564801}

The volume label for Android files should be "Android Files", so this CL renames
the label to the appropriate one and internationalize the label.
This CL changes the icon for the "Play Files" volume, too.

Bug: 846589
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id5ad9194094c14985d20a1055c153bab6c4d6b95
Reviewed-on: https://chromium-review.googlesource.com/1086899Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564800}

https://chromium.googlesource.com/angle/angle.git/+log/d197803..0211346


git log d197803..0211346 --date=short --no-merges --format='%ad %ae %s'
2018-06-06 jyan@ca.ibm.com PPC/s390: Fix GN error on PPC and s390


Created with:
  gclient setdep -r src/third_party/angle@0211346

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Idc98620a8db960a78810386991a7fa82dc28dec2
Reviewed-on: https://chromium-review.googlesource.com/1088249Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564799}

CL:1063891 added some expectation files that have testharness
failures. This patch remove them and add as [ Failure ] to
track LayoutNG-only failures.

TBR=yosin@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I8424b1b40a659df694266416166861da24fb4672
Reviewed-on: https://chromium-review.googlesource.com/1088337
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564798}

This adds the metrics for the number of mounts a user has in Native SMB
File Share

Bug: 757625
Change-Id: Iec6e33523c56dbfb094f15758241ec7f2fabe8f7
Reviewed-on: https://chromium-review.googlesource.com/1080089
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564797}

This is a reland of 181414e9

The original change was reverted by:
https://chromium-review.googlesource.com/c/chromium/src/+/1085067

> ==20322==ERROR: LeakSanitizer: detected memory leaks
> Direct leak of 496 byte(s) in 1 object(s) allocated from:
>     #0 0x69b3d2 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
>     #1 0x65a6dca in ash::TopShortcutsView::TopShortcutsView(ash::UnifiedSystemTrayController*) ash/system/unified/top_shortcuts_view.cc:130:43


Original change's description:
> Resize sign out button when it's too long.
>
> Limits the size of the sign-out / sign-out-all button to keep other
> buttons and minimum spacing in the parent view. This is needed because
> the translated text resource can be very long. Also adding description
> for such text resources to keep them shorter in the next revision.
>
> Bug: 847100
> Change-Id: I8fc79b0b0d3eb661553323a2d9f094f02320fa0a
> Reviewed-on: https://chromium-review.googlesource.com/1080364
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564016}

Bug: 847100
Change-Id: Ic2641bf8d61d837c56072988033f68f31f3d5da8
Reviewed-on: https://chromium-review.googlesource.com/1085327Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564796}

This CL makes OnAuthRequired work with WebSocket when the network
service is enabled.

Design Doc: https://docs.google.com/document/d/1L85aXX-m5NaV-g223lH7kKB2HPg6kMi1cjrDVeEptE8/edit

Bug: 721400
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7587ea7937f3e283096a10a70d5d18b1a67d2650
Reviewed-on: https://chromium-review.googlesource.com/1009266Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564795}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/87da90a..844791e


git log 87da90a..844791e --date=short --no-merges --format='%ad %ae %s'
2018-06-06 pwang@chromium.org chromeos_config: remove arc-gts from infoVMTest


Created with:
  gclient setdep -r src/third_party/chromite@844791e

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=chrome-os-gardeners@chromium.org

Change-Id: I21d113592e0f28a427901a3c1c1df379865270aa
Reviewed-on: https://chromium-review.googlesource.com/1088250Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564794}

This reverts commit 85b96ea9.

Reason for revert: crbug.com/849968

Original change's description:
> [PE] Ensure update of LayoutSVGShape::NoScalingStrokeTransform
> 
> In Pre-SPv175 we forced subtree paint invalidation on non-composited
> transform change. SPv175 no longer does that, causing
> NonScalingStrokeTransform not updated on ancestor transform change.
> 
> We also had a non-obvious bug that LayoutSVGShape::StrokeBoundingBox
> didn't get updated on ancestor transform change.
> 
> Now always explicitly update non-scaling-stroke data during layout.
> 
> Bug: 849080
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Ia61eb94f43e53a71a80e1102e4d605e4331f44b1
> Reviewed-on: https://chromium-review.googlesource.com/1086715
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#564584}

TBR=wangxianzhu@chromium.org,fs@opera.com

Change-Id: Ifbdd23b74dc45b5c8bc66c3d64bff580d5306f78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849080, 849968
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1087332Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564793}

This makes sure Picture-in-Picture window controls are hidden when
window is shown.

Bug: 726619
Change-Id: I195df27741440c2f00ae0e50bdcd8abe59367f42
Reviewed-on: https://chromium-review.googlesource.com/1084094Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#564792}

This fixes the window button position for MD refresh.

Bug: 841348
Change-Id: Ib313a773a6a220cb8e3e39c944325e4a105ec7ad
Reviewed-on: https://chromium-review.googlesource.com/1081053
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564791}

Make setupAndWaitUntilReady take optional arguments for default entries
to set up in the file manager. This is required for tests that need a
different set of entries to the default.

Bug: 719959
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0c505ff3be8c8b85167bfbfe300714f728dba19a
Reviewed-on: https://chromium-review.googlesource.com/1088330
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564790}

This neither adds nor deletes declarations. It reorders them to lessen
the diff on a subsequent commit (which automatically generates
file_manager_private.js by running
tools/json_schema_compiler/compiler.py on file_manager_private.idl).

Two declarations (EntryAction, installWebstoreItem) don't have any
corresponding entry in the file_manager_private.idl file.

Test: "ninja ui/file_manager:closure_compile" runs without error
Bug: 613096
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6dcc4a8f4f51182f7e33509decebe72b221f3ea6
Reviewed-on: https://chromium-review.googlesource.com/1082185Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564789}

Currently, FileManagerBrowserTestBase::SetUpCommandLine(), after setting
command line args for guest mode, calls its base class, eventually
calling ExtensionBrowsertest::SetUpCommandLine(), which overwrites
kLoginUser with its test user. This results in guest mode running with
an underlying profile with an associated email address, causing
DriveIntegrationService to be enabled for the underlying profile.

Change FileManagerBrowserTestBase::SetUpCommandLine() to disable the
base class's setting of user account flags so the guest mode tests more
accurately replicate the production environment.

Fix the chrome.fileManagerPrivate.startCopy() implementation to check
free disk on a blocking sequence instead of the IO thread. Without an
enabled DriveIntegrationService for guest mode, this code path is now
covered by tests.

Fix createNewFolder tests to not expect a google drive entry in guest
mode now that it isn't mounted in guest mode.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I953290b120a2a6b4f24214a12516efded442b75c
Reviewed-on: https://chromium-review.googlesource.com/1086888
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564788}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I09abc82ecd2ab71850a70c65a9a2decfcc011fe3
Bug: 849476
Reviewed-on: https://chromium-review.googlesource.com/1086236Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564787}

An |Error| instance already has the |stack| attribute so the exception
doesn't need to be raised, which makes the code cleaner and faster.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I148bb213f58b1c7ea352d862b9c666da35ba2b48
Reviewed-on: https://chromium-review.googlesource.com/1086562
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564786}

Eliminates Termina, Concierge in all user-facing strings. These are internal
code names.

BUG=849900

Change-Id: I47d627c01aafefde001ce4e76cd405caa66ff1cf
Reviewed-on: https://chromium-review.googlesource.com/1084423Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564785}

Using wpt-import in Chromium f7602689.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19097

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding

TBR=foolip

No-Export: true
Change-Id: I77c326860e72242a964bff3b1e592fc5d5d55d9f
Reviewed-on: https://chromium-review.googlesource.com/1087763
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564784}

When a download is removed (e.g. via download home), we should
remove if we are showing an infobar for this download. Fixing
this bug in this CL.

Bug: 849407
Change-Id: I512d0a3e946b9c349badfaad9f304985678fd603
Reviewed-on: https://chromium-review.googlesource.com/1086286Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564783}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/784bb7f..87da90a


git log 784bb7f..87da90a --date=short --no-merges --format='%ad %ae %s'
2018-06-06 dgarrett@chromium.org Revert "config_stages: Fix a missed path that can change per branch."
2018-06-06 dgarrett@google.com config_stages: Fix a missed path that can change per branch.
2018-06-06 dgarrett@google.com chromeos_config: Remove symlinks to new config files locations.


Created with:
  gclient setdep -r src/third_party/chromite@87da90a

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:848020,chromium:848020,chromium:848020
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib07fa234212c937752540d95695c1ce12f57f5cc
Reviewed-on: https://chromium-review.googlesource.com/1088246Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564782}

Use gfx::PresentationFeedback instead of plumbing timestamp, interval,
and flag separately to the following places:
. mojom.CompositorFrameSinkClient
. cc::LayerTreeHostImplClient
. The various PresentationCallbacks in ash, cc, exo, viz.

Also add a mojom type (and struct-traits) for gfx::PresentationFeedback.

TBR=reveman@ for trivial ash/components and components/exo changes.
BUG=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I893833710ab6e8d336176d43342df2b4efe62856
Reviewed-on: https://chromium-review.googlesource.com/1075859
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564781}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b990770..e89dcf7


git log b990770..e89dcf7 --date=short --no-merges --format='%ad %ae %s'
2018-06-06 sergeyberezin@google.com Roll mac_toolchain to 796d2b92c


Created with:
  gclient setdep -r src/third_party/depot_tools@e89dcf7

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:849728,chromium:846485
TBR=agable@chromium.org

Change-Id: Ibda12f0347c61cf3bee4d660e73e907ac1560fcd
Reviewed-on: https://chromium-review.googlesource.com/1087615Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564780}

Currently, KeyboardController::GetInstance returns null if the keyboard
is disabled. This patch changes it so that |GetInstance| always returns
a valid KeyboardController.

However, existing code determines whether the keyboard is enabled by
checking whether KeyboardController is null or not. With this patch,
KeyboardController will never be null. So we have to replace the null
checks with calls to KeyboardController::enabled(). In some cases,
calls to KeyboardController::enabled() can be omitted, but we leave
that to a future patch for easier review.

Bug: 731537
Change-Id: Ica487e69bae0a589d79c726f131611f0bf934672
Reviewed-on: https://chromium-review.googlesource.com/1032230
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564779}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: I603cb0d05a8492f8a98f1eaf17acfbb84c3977ee
Reviewed-on: https://chromium-review.googlesource.com/1087936Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564778}

Tests that fail because there is no share button:
ActivityServiceControllerTestCase.testActivityServiceControllerPrintAfterRedirectionToUnprintablePage
ActivityServiceControllerTestCase.testActivityServiceControllerCantPrintUnprintablePages
ActivityServiceControllerTestCase.testOpenActivityServiceControllerAndCopy
JavaScriptDialogTestCase.testShowJavaScriptAfterShareMenu
PrintControllerTestCase.testPrintNormalPage
PrintControllerTestCase.testPrintPDF
ToolbarTestCase.testCopyPasteURL

Other failures:
TabSwitcherTransitionTestCase.testLeaveSwitcherByOpeningNewNormalTab

Bug: 849492
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I519dda50b0a055bba937aa9685bcfdeb6bf319e1
Reviewed-on: https://chromium-review.googlesource.com/1088239
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564777}

The case is extended from crbug.com/849382. Some elements may display
by scaling down from huge geometries with a tiny scale. When the scale
changes (e.g. from 1e-6 from 2e-6), the rasterized result will
significantly change which should not be ignored.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I31928d95f8d864de83a75af02fd3cfe95ef8e8fa
Reviewed-on: https://chromium-review.googlesource.com/1087812
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564776}

This CL adds persistence for content data, and unittest for it.

Bug:831633

Change-Id: I944d9812133192e24306699bd696b5de8c2e411f
Reviewed-on: https://chromium-review.googlesource.com/1080274
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564775}

This CL adds the skeleton for the unified consent service. The role of this service is to
manage the preferences for unified consent. The initial implementation adds the pref
that monitors whether the user has consented for URL-keyed anonymized data collection.
It also resets this preference to false when the user signs out of Chrome.

Design document: http://go/project-unity-dd (internal only).

Bug: 823809, 814973

Change-Id: If902eee16843b8df73b543c151e7155d966441a7
Reviewed-on: https://chromium-review.googlesource.com/1074658
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564774}

Bug: 715355
Change-Id: I9a43ae333d0844924d08034a9c01cd4d47af357b
Reviewed-on: https://chromium-review.googlesource.com/1087194Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564773}

NOTRY=true

Bug: 843236
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If67f7873e39cdb7aaa88c55a32d6630b1a431335
Reviewed-on: https://chromium-review.googlesource.com/1087935
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564772}

This is a temparory fix so that EncryptedMediaTest.PolicyCheck
doesn't fail on Google Chrome build when using Widevine CDM. A
more proper fix will be landed later.

Bug: 849846
Change-Id: Iaa92f1b547489c825cf5fc095f9a0fc37ac660d2
Reviewed-on: https://chromium-review.googlesource.com/1087819
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564771}

It was registering a service worker for each test case, and had a lot
of test cases.

This changes the file to register a single service worker at the
beginning, and unregister it at the end.

Bug: 847787
Change-Id: Ic2536824a3c57e86bb5e042287e9e62e6222ad9a
Reviewed-on: https://chromium-review.googlesource.com/1087188Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564770}

This adds the metrics for the number of entries found when performing a
ReadDirectory in Native SMB File Share.

Bug: 757625
Change-Id: Iebafa900a76cc27c8aa2a878a9ac69318a7992c3
Reviewed-on: https://chromium-review.googlesource.com/1079891
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564769}

SecureChannelService holds one instance of SecureChannelImpl and brokers
all API calls to that instance.

Bug: 824568, 752273
Change-Id: Iaa3c0cde59fca0382682d3bf34b6458b75712b15
Reviewed-on: https://chromium-review.googlesource.com/1079643
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564768}