GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287435 0039d316-1c4b-4281-b951-d872f2087c98

Revert of sync: Add non-blocking type encryption support (https://codereview.chromium.org/423193002/)

Reason for revert:
Both LSAN and Valgrind complains about leaks in the tests.

Original issue's description:
> sync: Add non-blocking type encryption support
> 
> Introduces the framework for dealing with sync encryption in
> non-blocking types.  Unlike directory sync types, non-blocking type
> encryption only encrypts data before it is sent to the server.
> Encrypting the data on-disk is a separate problem.
> 
> Adds code to the ModelTypeSyncWorker so it can access the directory's
> cryptographer (through a CryptographerProvider interface) and use it to
> encrypt entities before it sends them to the server.  If the
> cryptographer is unable to encrypt with the desired key, the worker will
> not commit until the cryptographer returns to a good state.
> 
> Adds the concept of a "desired encryption key" to the data type state.
> When the cryptographer key to be used to encrypt a type changes, this
> will be reflected in the data type state.  The ModelTypeSyncProxy is
> responsible for ensuring that all items which have not yet been
> encrypted with this desired key are enqueued for commit.
> 
> Makes the ModelTypeSyncWorker, EntityTracker, and ModelTypeSyncProxy
> collaborate on the management of undecryptable (inapplicable) updates.
> The EntityTracker keeps track of their version numbers and content, and
> prevents the committing of new items to the server until the
> inapplicable update has been dealt with.  The ModelTypeSyncProxy is
> responsible for saving inapplicable updates across restarts.
> 
> This CL alone is not enough to enable encryption support for
> non-blocking types.  It requires additional code to hook up the
> ModelTypeSyncWorkers to receive cryptographer events.  This will be
> added in a future commit.  In the meantime, this CL includes plenty
> of unit tests to verify the functionality that's being added.
> 
> BUG=351005
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287428

TBR=zea@chromium.org,stanisc@chromium.org,rlarocque@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351005

Review URL: https://codereview.chromium.org/442623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299804,400547
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/441803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=30346,30633,31985,124500
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/435323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287431 0039d316-1c4b-4281-b951-d872f2087c98

Discoved while running media_perftests on a local debug build.

Review URL: https://codereview.chromium.org/441673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287429 0039d316-1c4b-4281-b951-d872f2087c98

Introduces the framework for dealing with sync encryption in
non-blocking types.  Unlike directory sync types, non-blocking type
encryption only encrypts data before it is sent to the server.
Encrypting the data on-disk is a separate problem.

Adds code to the ModelTypeSyncWorker so it can access the directory's
cryptographer (through a CryptographerProvider interface) and use it to
encrypt entities before it sends them to the server.  If the
cryptographer is unable to encrypt with the desired key, the worker will
not commit until the cryptographer returns to a good state.

Adds the concept of a "desired encryption key" to the data type state.
When the cryptographer key to be used to encrypt a type changes, this
will be reflected in the data type state.  The ModelTypeSyncProxy is
responsible for ensuring that all items which have not yet been
encrypted with this desired key are enqueued for commit.

Makes the ModelTypeSyncWorker, EntityTracker, and ModelTypeSyncProxy
collaborate on the management of undecryptable (inapplicable) updates.
The EntityTracker keeps track of their version numbers and content, and
prevents the committing of new items to the server until the
inapplicable update has been dealt with.  The ModelTypeSyncProxy is
responsible for saving inapplicable updates across restarts.

This CL alone is not enough to enable encryption support for
non-blocking types.  It requires additional code to hook up the
ModelTypeSyncWorkers to receive cryptographer events.  This will be
added in a future commit.  In the meantime, this CL includes plenty
of unit tests to verify the functionality that's being added.

BUG=351005

Review URL: https://codereview.chromium.org/423193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287428 0039d316-1c4b-4281-b951-d872f2087c98

This is a preparation for Bug 329732. The actual fix for the bug
will come in the next separate patch.

The current changes forces GetAboutResource to wait for the result of
running UpdateAboutResource task if any.

BUG=329732

Review URL: https://codereview.chromium.org/439643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287427 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the entire account picker would reload and lose state
whenever a device-local account's policy changed. With this CL, only the
contents of the pod affected by the policy change is updated, no reload
is done and no state is lost.

BUG=398511
TEST=New browser test

Review URL: https://codereview.chromium.org/427053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287426 0039d316-1c4b-4281-b951-d872f2087c98

Supports GN build of //jingle, though its targets won't be linkable
until its dependency //third_party/libjingle is properly supported.

TBR=ajwong
BUG=

Review URL: https://codereview.chromium.org/431423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287425 0039d316-1c4b-4281-b951-d872f2087c98

When gn's desc command is used with --tree, it prints a dependency tree. But recursively printing the dependency tree of a high-level target in Chrome prints too much output to be useful because it's printing, e.g. base and it's deps over and over (//chrome/browser-s --tree is 3210166 lines).

With this patch, a target will be recursed into the first time it's printed, but subsequent times the children will be elided with "..." This brings down //chrome/browser to 2050 lines. The previous behavior is still available (it could be useful in certain cases) via "--tree --all".

This also updates an optimization comment in the the optimization setup (optimize_max isn't just Windows-only).

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/437033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287424 0039d316-1c4b-4281-b951-d872f2087c98

This should work whether or not --google-profile-info is turned on.

BUG=399678
TEST=Flip --new-avatar-menu (but not --google-profile-info). You should
be able to choose your Gaia avatar from the manageProfile dialog.

Review URL: https://codereview.chromium.org/417043008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287423 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390911

Review URL: https://codereview.chromium.org/437613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287422 0039d316-1c4b-4281-b951-d872f2087c98

When attaching to a static page, it may not produce new frames, thus
rendering screencast useless. Forcing a frame helps in this case.

BUG=none

Review URL: https://codereview.chromium.org/441623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287421 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Partially move history_types.{cc,h} to //components/history (https://codereview.chromium.org/439713004/)

Reason for revert:
Missing OWNERS LGTM.

Original issue's description:
> Partially move history_types.{cc,h} to //components/history
> 
> Move all types from //chrome/browser/history/history_types.{cc,h} that do
> not depends on content types to //components/history.
> 
> BUG=371816
> TBR=msw@chromium.org
> TBR=jochen@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287333

TBR=msw@chromium.org,jochen@chromium.org,jhawkins@chromium.org,jif@chromium.org,brettw@chromium.org,sky@chromium.org
BUG=371816

Review URL: https://codereview.chromium.org/428253008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287420 0039d316-1c4b-4281-b951-d872f2087c98

Fix header guard and include for the whispernet_client public interface.

R=ckehoe@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/438163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78368
R=estade@chromium.org
TEST=moar emailz

Review URL: https://codereview.chromium.org/437393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287417 0039d316-1c4b-4281-b951-d872f2087c98

This ports https://codereview.chromium.org/430383002/ to gn.
Patch from brettw in https://codereview.chromium.org/385823002/ , this just
activates it.

BUG=360311
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/426533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287416 0039d316-1c4b-4281-b951-d872f2087c98

The /U__STDC_VERSION__ option was necessary when using VS2012 headers,
which didn't include nan(), but we're on 2013 now.

BUG=82385
TBR=cpu

Review URL: https://codereview.chromium.org/443453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287415 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes the previous reverted CL#437603002.
To fix, removed ExtensionRegistryObserver from TearDownOnMainThread instead of destructor.

R=kalman@chromium.org
BUG=354046
TEST=browser_tests

Review URL: https://codereview.chromium.org/429173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287414 0039d316-1c4b-4281-b951-d872f2087c98

Add a --target-arch argument to the browser finder options. This is used by the
backend to pass the correct arch to the stack symbolization script on crashes.

BUG=399896,385125

Review URL: https://codereview.chromium.org/443443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400002

Review URL: https://codereview.chromium.org/441643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287412 0039d316-1c4b-4281-b951-d872f2087c98

It allows SSLConnectJob waiting even in the case of false start. Additionally, it groups all of the functions for communicating between SSLConnectJobs into one object, the SSLConnectJobMessenger.

R=mmenke@chromium.org,rsleevi@chromium.org,wtc@chromium.org
TBR=mek@chromium.org,asargent@chormium.org,thestig@chromium.org
BUG=398967

Review URL: https://codereview.chromium.org/353713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287408 0039d316-1c4b-4281-b951-d872f2087c98

Messages like "Pod offsetHeight (0) and POD_HEIGHT (226) are not equal." were
reported on desktop user manager. It happened because |placePods_| method call
were made, when account picker was hidden.

In addition deprecated |webkitRequestAnimationFrame| was replaced with
|requestAnimationFrame| in login code.

BUG=none
TEST=Run user manager, see that messages are gone.

Review URL: https://codereview.chromium.org/422563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287407 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/431833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287406 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for the INCR property
(http://tronche.com/gui/x/icccm/sec-2.html#s-2.7.2) to SelectionRequestor and
SelectionOwner

BUG=367549
TEST=Manual, see bug
R=derat,dcheng,erg
TBR=erg for ui/base/BUILD.gn

Review URL: https://codereview.chromium.org/397223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287404 0039d316-1c4b-4281-b951-d872f2087c98

Also adds:

  assertNotReached("message");

as a rough equivalent of

  NOTREACHED() << "message";

in Chromium and:

  ASSERT_NOT_REACHED();

in blink.

R=arv@chromium.org
BUG=393873
TEST=gyp --depth . ui/webui/resources/js/compiled_resources.gyp ui/webui/resources/js/chromeos/compiled_resources.gyp && ninja -C out/Default/

Review URL: https://codereview.chromium.org/405743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287403 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces ChannelMojo IPC::Channel implementation
and optionally applies it for renderer-browser IPC channel.

Current stability is like 5-seconds browser and There are rough edges.
It often closes the channel so needs to be more robust.
Even though the level of stability, having it in the tree will helps
team to try and improve it.

BUG=377980
R=darin@chromium.org,jam@chromium.org,viettrungluu@chromium.org
TEST=ipc_channel_mojo_unittest.cc

Review URL: https://codereview.chromium.org/382333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287402 0039d316-1c4b-4281-b951-d872f2087c98

The fix basically works in the following way. Look at Zoom Observer overridden methods which is implemented in Browser.cc. When the zoom state changes send relevant messages to Command_Updater to enable / disable Zoom Menu Items.

BUG=32919
TEST=Open a NTP , load a url. Zoom-In max and the Zoom-In menu item should be disabled likewise zoom-out max and the zoom-out menu should be disabled.

When a NTP or a page is loaded by default the zoom scale is 100% hence the Actual size menu item should be disabled.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/310913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397120,400503,400509,400511,400521
NOTRY=true
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/436363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400490,400495
NOTRY=true
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/439343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287397 0039d316-1c4b-4281-b951-d872f2087c98

CQ corrupted the PNGs when it landed them. crbug.com/339068

> Copy test data to //extensions
> 
> This copies some assets from //chrome test data into //extensions for use with extensions_unittests.
> 
> BUG=None
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/443473003

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/439723007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287395 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287393 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179474:179479&mode=html
TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org
BUG=

Review URL: https://codereview.chromium.org/421293012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287392 0039d316-1c4b-4281-b951-d872f2087c98

* Adding ability to add, remove and load account info
to device mappings in GCMStore with Tests.
* Moving the code resetting load results to LoadResult
structure (fixed a bug where last_checkin_accounts
where not cleared upon failure to load)

R=zea@chromium.org
BUG=374969

Review URL: https://codereview.chromium.org/429073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287391 0039d316-1c4b-4281-b951-d872f2087c98

chrome/android still used system gcc as host compiler, and system gcc is
gcc 4.6 on Ubuntu Precise. This is too old.

Instead, use clang by default as host compiler (except when building for
AOSP, see http://crbug.com/377684 for that). This is controlled by a new
gyp variable host_clang, which only has an effect if clang=0. The existing
clang gyp variable means "use clang for everything"; if it's not set then
host_clang means "use clang for host compiles".

If your system gcc is 4.8+ and you don't want to use clang, you can set
host_clang=0 to use system gcc for host compiles instead.

In host_clang mode, our clang plugins currently aren't used (I figure if you
want plugins, you can just use clang=1). clang_warning_flags on the other
hand are used, to make sure the build stays warning-free.

BUG=360311
R=hans@chromium.org

Review URL: https://codereview.chromium.org/430383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287386 0039d316-1c4b-4281-b951-d872f2087c98

The component has been unused for a long time, is getting stale, and requires maintenance from time to time.

BUG=370966

Review URL: https://codereview.chromium.org/271673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287385 0039d316-1c4b-4281-b951-d872f2087c98

This copies some assets from //chrome test data into //extensions for use with extensions_unittests.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/443473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287384 0039d316-1c4b-4281-b951-d872f2087c98

And Make EventRouterTest inherit ExtensionsTest to setup for test.

R=kalman@chromium.org
BUG=354046
TEST=unittest

Review URL: https://codereview.chromium.org/430243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287383 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to test_common.
5) Removed un-used test_common header.

BUG=331299

Review URL: https://codereview.chromium.org/436133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287382 0039d316-1c4b-4281-b951-d872f2087c98

Linux.

This is part #1 for fixing the remaining cases where tab dragging leaves the
user in a weird state if the mouse is released at the "right" time.

BUG=392480
TEST=DesktopWindowTreeHostX11Test.CaptureEventForwarding
TBR=erg (For ui/views/views.gyp)

Review URL: https://codereview.chromium.org/380943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287381 0039d316-1c4b-4281-b951-d872f2087c98