GitLab

https://chromium.googlesource.com/angle/angle.git/+log/24627fa40a48..2439a3af02eb

git log 24627fa40a48..2439a3af02eb --date=short --first-parent --format='%ad %ae %s'
2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b766e5e7fbf4..c514ab001bb0 (8 commits)
2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ca9b61a4455f..aaba1e4e6aec (1 commits)
2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src ac02c61ffc63..8317b28e672a (6 commits)
2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src af8c7e040f93..37d3a235af2c (2 commits)

Created with:
  gclient setdep -r src/third_party/angle@2439a3af02eb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: timvp@google.com
Change-Id: I3833067a4900eae31fab1261f855ef6bdec38381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016472Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734413}

https://skia.googlesource.com/skia.git/+log/20d0f9299138..e4ddb8a7cddc

git log 20d0f9299138..e4ddb8a7cddc --date=short --first-parent --format='%ad %ae %s'
2020-01-23 reed@google.com Revert "Specialize SkRectanzier to SkRectanizerSkyline"

Created with:
  gclient setdep -r src/third_party/skia@e4ddb8a7cddc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: I547a89518739863aa6ca9e85ce085268899e73dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015524Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734412}

Before this patch when entering the prompt state, the sheet would always
be expanded so that the buttons were visible to a user. This patch
introduces a new proto field that allows this behavior to be configured
from the backend. Additionally, the configure bottom sheet action is
extended by a new field to expand or collapse the sheet
programmatically.

Bug: b/145204744
Change-Id: I9191e3e4f7b6b688d6a9dae800f730b56056b243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004868
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#734411}

Intended to be eliminated as part of
https://chromium-review.googlesource.com/c/chromium/src/+/2010943.

TBR=carlosil@chromium.org

Bug: 1030692
Change-Id: I16e1d357fb2652119d7075c60e0f45c69426931c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016629Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734410}

1) Suppress FileRead violation (since the point of the test is to
   play a video).
2) Call dismissDialog at the end of the test to properly tear down
   decoder connection (no bug, found while addressing other violation).

TBR: peconn
Bug: 1044333, 895776
Change-Id: I9f93618be30016304770263bbbdf20431ce20950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013287
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734409}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3df70e9c609d..e20606a24add

git log 3df70e9c609d..e20606a24add --date=short --first-parent --format='%ad %ae %s'
2020-01-23 pfaffe@chromium.org Implement a Language-Specific Plugin System

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@e20606a24add

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1042636
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic1ad7ed749dba53c5253983a046a1a22e917c298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734408}

The sending of the CAPTIVE_PORTAL_CHECK_RESULT notification is a
blocker to the ongoing effort to componentize CaptivePortalService. A
previous CL has introduced the ability to register for a callback with
CaptivePortalService as an alternative mechanism of being informed on
the results of captive portal queries. This CL converts the remaining
consumers and eliminates the notification.

Bug: 1030692
Change-Id: I9a2c5f6190922eb6ddb10d572dcbec6b52ffc3ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012383
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734407}

Expectations changed with CL:2007629

TBR=futhark@chromium.org

Bug: 1042760
Change-Id: I544455316f2e5c4fc87184a4a897c44c187bfb37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016644Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734406}

Test added in CL:2003810

TBR=atotic@chromium.org

Bug: 423997
Change-Id: I006328b54c9163e9185fc9f1ff7d7af8ceb0a36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015083
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734405}

For manually installed extensions, the install location is set to INTERNAL.
When it is added to the force installed list, the install location should be
changed to EXTERNAL_POLICY_DOWNLOAD. This can be done by:

Unloading the extension -> changing the extension install location -> Loading
the extension.

In case the extension is disabled by user, remove the disabled by user
DISABLE_REASON as it is now required by policy.

Bug: 1014123
Change-Id: I1329e62708e1ca083af1becfddf75d602dada58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911754
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734404}

TBR=masonfreed@chromium.org

Bug: 1035582
Change-Id: I49522593f975014a2e9936d080880668a8e19dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015049
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734403}

adjusting expectations

TBR=seblalancette@chromium.org

Bug: 1043450
Change-Id: I8cd670df6188c476f7c18d0a7b345cd489970418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015166Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734402}

SSLErrorHandler currently checks internally whether the ability for the
user to proceed past an SSL interstitial has been disabled via prefs.
This pref is a //chrome-level one that WebLayer will never modify from
the default behavior of allowing such proceeding. Thus, rather than
componentize the pref, this CL instead passes the value of whether the
user is allowed to proceed past SSL interstitials to
SSLErrorHandler::HandleSSLError(), giving the boolean a default value
of true so that embedders other than //chrome don't need to worry about
what the default behavior should be.

To avoid needing to thread this argument through
SSLErrorNavigationThrottle, this CL also introduces a //chrome-level
wrapper of SSLErrorHandler::HandleSSLError() that supplies
//chrome-level parameters. This wrapper will be useful for a few other
params, and we will change the current passing of NetworkTimeTracker to
occur this way as well rather than being threaded through
SSLErrorNavigationThrottle.

Bug: 1030692
Change-Id: I840e97b41759e7982b6a0975570a82a9b52ed5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014504
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734401}

This CL renames the histogram
UnifiedConsent.SyncAndGoogleServicesSettings to
UnifiedConsent.MakeSearchesAndBrowsingBetter.OnStartup.

Bug: 1024545
Change-Id: Id5f218e49fc433d89f2505ad16be38d00cde40be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006550Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734400}

This is a reland of b23ba4d3

Reason for revert: Did not roll out internal DEPS
(https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/2450652)

TBR=msramek@chromium.org

Original change's description:
> Ice Server API integration
>
> Integrates network traversal API to fetch stun and turn servers for
> webrtc p2p connection. Handles API failure by returning a list of
> public Google stun servers as a fallback.
>
> Bug: 1031156
> Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295
> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Richard Knoll <knollr@chromium.org>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733941}

Bug: 1031156
Change-Id: Ib1f409842a3277b5e1f47d6511ede46361aa5fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013130
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734399}

Members in stack allocated types issue redundant write-barriers. This CL
provided an option --no-members-in-gc-allocated, which prohibits use of
them.

Bug: 1021889
Change-Id: Iae010f6a3154ba54963fafddc888b45a42b56698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015167Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734398}

This change updates ppapi::RunWhileLocked and ppapi::CallWhileUnlocked
to use base::OnceClosure and base::OnceCallback instead of base::Closure
and base::Callback.

Bug: 714018
Change-Id: I7e827ecffe2baca3a681cf3e27982263c89f9f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011927
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734397}

Dice is now enabled by default, there is no need to explicitly enable it.

Bug: 891781
Change-Id: I2821873a1ff6d24cb34279276a9a6ab09be05e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012032
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734396}

Following bot results are included.
1089 1090 1091 1092 1093 1094 1095 1096 1098 1100

41 lines were removed and 13 lines were deflaked by consecutive
results since 1078.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I5b46330b8ea78cc18996e8cb87c5ee55761cf3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014482Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734395}

CL:1345378 changed display of images in quickview to use the decode()
API to allow the image to be decoded while the containing content node
was detached from the DOM tree in order to avoid visible artifacts
during decoding time. The decode() API fails when large image decodes
are attempted resulting in nothing being displayed, even when those
large images can be viewed from a simple <img src=...> container.

Removes the use of decode() and instead, creates an Image object
responsible for loading the image and uses the onload handler to
reattach the content node to the DOM. Adds an onerror handler
that sends an event to the host container in the case of load and/or
decode failures.

Note, this is in effect creating 2 images - the
first is the host node in the content, the second is a temporary 'Image'
object that is used to trigger the load/decode and when it's loaded the
URL to the object is set on the host image node. That way, the image
is already loaded so minimizes flicker when the 'src' is set, and in
the error case it doesn't set the 'src' at all. (We call  this the
Double Image Device:)

Bug: 645021, 1043799
Change-Id: Id14e01068c29d7cd373563ba20d2e13d7a4bbfe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012368Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734394}

The type check for "WasmModuleObject" was renamed from
"IsWebAssemblyCompiledModule" to "IsWasmModuleObject" in
https://crrev.com/c/2013109.
This CL switches the only caller in chrome to the new API, so we can
deprecate the old one.

R=haraken@chromium.org

Bug: v8:10021
Change-Id: Ibf4d59933ce91086eb3edd1769aae2e3da2a9368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016622Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734393}

We will shortly be componentizing CaptivePortalService out of //chrome.
This class depends on the Content API and should only be used on
//content-based platforms, whereas the existing
//components/captive_portal is shared with iOS. This CL moves the
existing component into a layered component structure in anticipation
of imminently moving CaptivePortalService and friends into a //content
subdirectory.

There are no functional changes here; it is a strict code move.

TBR=jochen@chromium.org

Bug: 1030692
Change-Id: Id231098e56b5c3f28c921c0082918fdf669ebeac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010982
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734392}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0e6361d160f..313d98ee7b49


Created with:
  gclient setdep -r src-internal@313d98ee7b49

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I1c738d66209d0c9850f069c12284795e4bee32f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016470Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734391}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=erikchen@chromium.org

Bug: 1042208
Change-Id: I9148cc5a2f2ecdfa4d081e27470660b22604f431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007640
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734390}

This reverts commit b2a8b8b0.

Reason for revert: Suspected root cause of All/TabletModeControllerTest.* failures on Linux ChromiumOS MSan Tests 

Example build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17429

Example failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890504197399106784/+/steps/ash_unittests/0/logs/Deterministic_failure:_All__x2f_TabletModeControllerTest.DisplayDisconnectionDuringOverview__x2f_0__status_CRASH_/0

First build:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17428


Original change's description:
> Fix the occasional black flash when fling an ARC window to home screen.
> 
> Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804
> doesn't fix the issue entirely. Looking deeper in this issue, it's
> actually caused by ClientControlledShellSurface::UpdateBackdrop() can be
> called on a dragged window (whose backdrop has been disabled (kDisabled)
> when drag starts) to re-enable the backdrop.
> 
> This CL makes sure an ARC window with disabled backdrop mode won't be
> modified.
> 
> Bug: 1027269
> Change-Id: I4d138ddf17bbcee2ab07e1a5fb9785fc05b3fc0c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734250}

TBR=sky@chromium.org,oshima@chromium.org,xdai@chromium.org,afakhry@chromium.org

Change-Id: Iec4b80f5689c72ea9e73a8051b81f640a6e21fef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1027269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016643Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734389}

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=groby@chromium.org

Bug: 1042208
Change-Id: Ia8c1e13be0579db3e51825be0dffd9e94f8f40f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010822
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734388}

This CL adds a web platform test for checking the behavior of
|import.meta.url| in SharedWorker when the script type is set to module.

Bug: 824646
Change-Id: Ifaa34e238fe0a432137c5e8213e81610249b7e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014355
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734387}

This CL is a follow-up CL of https://crrev.com/c/2010448 and adds
the warning message for blink's mojom namespace rule in Blink.

Bug: 1043557
Change-Id: I1839ab7cf235cbff0ef3d3c7321c40c2f0adc71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014217Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#734386}

https://skia.googlesource.com/skia.git/+log/fca88b650404..20d0f9299138

git log fca88b650404..20d0f9299138 --date=short --first-parent --format='%ad %ae %s'
2020-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f2517d68..7afe38da (473 commits)

Created with:
  gclient setdep -r src/third_party/skia@20d0f9299138

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: I93dc3a9257099a2eee56cb62c7c3bdc5a131a653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016463Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734385}

Add explicit expectations whether an event should be dispatched to the
document or to the window.

R=yuzus@chromium.org
BUG=1021536

Change-Id: I97256993d80892e0bb362342aa34221fb345f235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013244Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734384}

The browser process is requesting the renderer process to update its
subresource loaders. This must not happen in a renderer that hasn't
committed any navigations yet.

The browser process is guarding itself against that by checking its
attribute: |has_committed_any_navigation_|

The problem is that |has_committed_any_navigation_| is not updated after
a crash, which allow the browser to misbehave.

Bug: 1023226
Change-Id: I68e23c9d4bd80f4679039fac168a9a9b29fac420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012951Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734383}

Change-Id: Ia240c27b892d29530fc10d7457f7dae40016ba97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011624
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734382}

This reverts commit f32982c9.

Reason for revert: broke QuicTransportServerSessionTest.* on Linux CFI
first broken build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16249

example of failure:
[ RUN      ] QuicTransportServerSessionTest.ClientIndicationTooLong
../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:77:22: runtime error: control flow integrity check for type 'quic::QuicCryptoServerStream' failed during base-to-derived cast (vtable address 0x55bc7d313108)
0x55bc7d313108: note: vtable is of type 'quic::TlsServerHandshaker'
 bc 55 00 00  10 c4 a1 7c bc 55 00 00  60 c4 a1 7c bc 55 00 00  e0 a7 9b 7c bc 55 00 00  90 10 a0 7c
              ^
    #0 0x55bc7ac90d4e in quic::test::(anonymous namespace)::QuicTransportServerSessionTest::QuicTransportServerSessionTest() ./../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:77:22
    #1 0x55bc7ac9d83d in quic::test::(anonymous namespace)::QuicTransportServerSessionTest_ClientIndicationTooLong_Test::QuicTransportServerSessionTest_ClientIndicationTooLong_Test() ./../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:205:1
    #2 0x55bc7ac9d81a in testing::internal::TestFactoryImpl<quic::test::(anonymous namespace)::QuicTransportServerSessionTest_ClientIndicationTooLong_Test>::CreateTest() ./../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:470:44
    #3 0x55bc7c49b176 in testing::Test* testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test*>(testing::internal::TestFactoryBase*, testing::Test* (testing::internal::TestFactoryBase::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2555:10
    #4 0x55bc7c489138 in testing::Test* testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test*>(testing::internal::TestFactoryBase*, testing::Test* (testing::internal::TestFactoryBase::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2610:12
    #5 0x55bc7c488f06 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2797:22
    #6 0x55bc7c4898b1 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2939:28
    #7 0x55bc7c490a81 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5480:44
    #8 0x55bc7c49cd46 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2555:10
    #9 0x55bc7c490728 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2610:12
    #10 0x55bc7c490664 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5067:10
    #11 0x55bc7d023d80 in RUN_ALL_TESTS() ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2470:46
    #12 0x55bc7d023684 in base::TestSuite::Run() ./../../base/test/test_suite.cc:457:16
    #13 0x55bc7bbe67fa in int base::internal::FunctorTraits<int (base::TestSuite::*)(), void>::Invoke<int (base::TestSuite::*)(), NetTestSuite*>(int (base::TestSuite::*)(), NetTestSuite*&&) ./../../base/bind_internal.h:499:12
    #14 0x55bc7bbe678e in int base::internal::InvokeHelper<false, int>::MakeItSo<int (base::TestSuite::*)(), NetTestSuite*>(int (base::TestSuite::*&&)(), NetTestSuite*&&) ./../../base/bind_internal.h:599:12
    #15 0x55bc7bbe672d in int base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<NetTestSuite> >, int ()>::RunImpl<int (base::TestSuite::*)(), std::__1::tuple<base::internal::UnretainedWrapper<NetTestSuite> >, 0ul>(int (base::TestSuite::*&&)(), std::__1::tuple<base::internal::UnretainedWrapper<NetTestSuite> >&&, std::__1::integer_sequence<unsigned long, 0ul>) ./../../base/bind_internal.h:672:12
    #16 0x55bc7bbe66dc in base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<NetTestSuite> >, int ()>::RunOnce(base::internal::BindStateBase*) (.cfi) ./../../base/bind_internal.h:641:12
    #17 0x55bc7b0c8ae4 in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:98:12
    #18 0x55bc7d029cfe in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:162:38
    #19 0x55bc7d029b9b in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:232:10
    #20 0x55bc7bbe63bc in main ./../../net/test/run_all_unittests.cc:55:10
    #21 0x7fe0a7c4282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0
    #22 0x55bc79ff0ee9 in _start ??:0:0

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:77:22 in


Original change's description:
> Roll src/net/third_party/quiche/src/ dfabdfb68..f579b5e51 (5 commits)
> 
> https://quiche.googlesource.com/quiche.git/+log/dfabdfb6884b..f579b5e51aaf
> 
> $ git log dfabdfb68..f579b5e51 --date=short --no-merges --format='%ad %ae %s'
> 2020-01-21 nharper Refactor TlsServerHandshaker to implement QuicCryptoServerStreamBase directly
> 2020-01-21 fayang Disable gfe2_restart_flag_quic_default_on_ietf_loss_detection in QuicEndpointTest.Competition while investigating the issue.
> 2020-01-21 wub gfe-relnote: (n/a) Change the return value of QuicUdpSocketApi::ReadMultiplePackets from number of good packets to number of total packets read. Code not used yet.
> 2020-01-21 bnc Use quiche_export instead of http2_export.
> 2020-01-21 ianswett gfe-relnote: Add a connection option(1ACK) to send only one immediate ACK in QUIC after reordering, instead of 4.  Protected by gfe2_reloadable_flag_quic_one_immediate_ack
> 
> Created with:
>   roll-dep src/net/third_party/quiche/src
> 
> Change-Id: I6a3b22464f673884affc55883c090a8df1dead3c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014053
> Commit-Queue: Ryan Hamilton <rch@chromium.org>
> Auto-Submit: Bence Béky <bnc@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734145}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: Iae4d63a3ffd5f4aa6c3abb4aad9c59a9d9261a1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015242Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734381}

Add TimeBetweenFreeDiskSpace metric to measure how often cleanup is
performed.

Used by crrev.com/c/1960285

BUG=chromium:1043041
TEST=manual

Change-Id: I38bf6b78c4c3b0e808b943ea687f2090314346d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960146Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Victor-Gabriel Savu <vsavu@google.com>
Cr-Commit-Position: refs/heads/master@{#734380}

Add a metric to measure how much space is being cleared by the
automatic disk cleanup.

Used by crrev.com/c/2007128

BUG=chromium:1043037
TEST=manual

Change-Id: I00e88ca84466fa5b3032957641b8b5512649c3e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005991Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Victor-Gabriel Savu <vsavu@google.com>
Cr-Commit-Position: refs/heads/master@{#734379}

https://chromium.googlesource.com/angle/angle.git/+log/135f8fcba837..24627fa40a48

git log 135f8fcba837..24627fa40a48 --date=short --first-parent --format='%ad %ae %s'
2020-01-23 syoussefi@chromium.org Row-major test: switch to compute

Created with:
  gclient setdep -r src/third_party/angle@24627fa40a48

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: timvp@google.com
Change-Id: Ia9dde9b289e322bbe9f799063bc363d0b5b096fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016465Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734378}

Fixed: 1022774
Change-Id: I2ffc80512230316cc3b94b70e7e11f6b2db0390e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010950Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734377}

This patch introduces |NGFragmentItem::IsEmptyLineBox()| along with
|LineBoxType()| for preparation of migrating to |NGFragmentItem|.

Bug: 982194
Change-Id: Ic1500c0c26f36042ccb5321e64065405faf823a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014358
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734376}

So, I removed the x_pending_visual_id from the DWTHLinux and started
to set the wm_role_name in order to identify status-icon window.

That helps to remove X11 specific calls done in outside X11Window class
and brings us closer to Ozone/X11.

This is a prerequisite CL to split current implementation into two parts:
client and platform.

Bug: 1043089
Change-Id: I4de1a34cd38ca0fb760717dc1e9a3d3c8348a728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007709Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#734375}

Currently CONTAINER_START_FAILED is our largest bucket of Restarter
failures, with close to double the failures of every other category
combined. When OnCreateContainer fails emit CONTAINER_CREATE_FAILED
(currently one of the smallest buckets) and create a new error for
setup failing which anecdotally we've seen a lot of.


Test: CQ
Bug: None
Change-Id: I19d9eceb49c121779c7051e70d25725a557a3d4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015877
Commit-Queue: David Munro <davidmunro@google.com>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734374}