- 10 Apr, 2018 40 commits
-
-
tanvir.rizvi authored
For code health we use Ephemeral range instead of passsing position in RemoveInlineStyle. With this we catch a bug at call sites, as EphemeralRange construction takes care of the current DCHECKS in RemoveInlineStyle Bug: 826106 Change-Id: Ibaa37789f7671aa464b4c87d30f12bd023a67a3d Reviewed-on: https://chromium-review.googlesource.com/1001437Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#549466}
-
Michael Lippautz authored
Slots may be deleted after recording a callback for them. Filter out those slots accordingly during processing. Bug: chromium:757440 Change-Id: I23c17c2f79af41a8539b8d4734ec677fb0b99c0b Reviewed-on: https://chromium-review.googlesource.com/1000865 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549465}
-
Makoto Shimazu authored
TBR=rdevlin.cronin@chromium.org NOTRY=true Bug: 831078 Change-Id: Id97988d690315e7d2734a11255dcc9ba901c3d78 Reviewed-on: https://chromium-review.googlesource.com/1004560Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549464}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I6dc555a31615371f10e082a27f894a6b2fcbf981 Reviewed-on: https://chromium-review.googlesource.com/987596 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549463}
-
Patrik Höglund authored
This reverts commit 34f59cac. Reason for revert: Speculative revert: appears to be breaking the stock Chromium Mac builder for WebRTC: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Builder/93792 FAILED: obj/extensions/common/api/libgenerated_api.a Original change's description: > ONC: Add FTEnabled property to WiFi > > Support FTEnabled property in ONC. > > BUG=791202 > TEST=chromeos_unittests > TEST=chrome.networkingPrivate.createNetwork with "FTEnabled":true > enables the device to connect to an FT network. Setting > "FTEnabled":false disables the device from connecting to an FT > network. > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I2470753fd139505704987e301b18983dc51c5c47 > Reviewed-on: https://chromium-review.googlesource.com/982275 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Matthew Wang <matthewmwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549366} TBR=stevenjb@chromium.org,cernekee@chromium.org,kirtika@chromium.org,matthewmwang@chromium.org Change-Id: Ie29fdeaabecf4344ded8e0c5f9f6de1a04d8962e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791202 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1004794Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#549462}
-
Manuel Rego Casasnovas authored
This patch removes the grid logic from LayoutBox::ContainingBlockLogicalWidth|HeightForContent(). Instead it initializes the OverrideContainingBlock size to zero in LayoutGrid::UpdateBlockLayout(). For grid items we don't want to use the grid container size (which would be the regular containing block size), so we want to use the overridden value. And while we don't have such value, it's better we use zero (so percentages are not resolved against the wrong thing). This change is covered by existent tests. Change-Id: If6a96abe7148203a2cdb9ffb2b9dd487239f7aae Reviewed-on: https://chromium-review.googlesource.com/989734 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#549461}
-
https://chromium.googlesource.com/angle/angle.git/+log/0ce016c1bd12..fe4bbe6cbec6 $ git log 0ce016c1b..fe4bbe6cb --date=short --no-merges --format='%ad %ae %s' 2018-04-06 brandon1.jones Create Stubs For Unimplemented Extensions Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I9c19a67052917b124db174f385e6028741a0bc90 Reviewed-on: https://chromium-review.googlesource.com/1004435 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549460}
-
Colin Blundell authored
This CL is in preparation for moving this code into its only remaining consumer, which triggers a presubmit error that the code needs formatting. Bug: 729590 Change-Id: I64246c2cca6f44a4ce60573ff6283c0f0c4b6d72 Reviewed-on: https://chromium-review.googlesource.com/1004614Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#549459}
-
Matt Giuca authored
Previously, this only worked in browser windows. Now, it uses the button provider to detect if the menu is open, in either browser or hosted app windows. Bug: 791399 Change-Id: I885a4979e729eaedbb647903209c54b63286da22 Reviewed-on: https://chromium-review.googlesource.com/991892 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#549458}
-
Jonas Olsson authored
Bug: webrtc:8982 Change-Id: I978e0a2544f6f71c250da9b0ec7aeb8e1a901bb9 Reviewed-on: https://chromium-review.googlesource.com/997336Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549457}
-
cathiechen authored
AtomicInline fragment use legacy_paint_offset which is the offset to its parent, while others use paint_offset which is the offset to line_box. The legacy_paint_offset is not correct when AtomicInline is child of an inline element that has fixed border/margin/padding. It's not easy to deal with nested situation by passing legacy_paint_offset. In this solution, compute the legacy_paint_offset when paint AtomicInline: legacy_paint_offset = paint_offset - offset from parent to linebox. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie3bcfbbf3b9239c5c5e77504242aed40e553ea0e Reviewed-on: https://chromium-review.googlesource.com/995313 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549456}
-
Darren Shen authored
Currently, when we reify a value, we try to first reify it as a single value. If that fails, we try reifying it as a list value. This code was written with the incorrect assumption that only list-valued properties are stored as CSSValueLists. This is not true, as many single valued properties (such as grid-auto-flow) are stored as CSSValueLists. This patch adds an additional check so that only properties that are explicitly marked as list-valued are reified as list values. Bug: 829881 Change-Id: I965e38355b9859a43fcb1b940f19237f9f07fdf6 Reviewed-on: https://chromium-review.googlesource.com/1002214Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549455}
-
Christian Dullweber authored
Add myself to watchlists for browsing_data and site settings. Change-Id: Ib24d1669f5daffd24d043dd23eb8d7f6c6a52af2 Reviewed-on: https://chromium-review.googlesource.com/1004694Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#549454}
-
Boris Sazonov authored
This CL adds the second chunk of elements to the animated vector drawable that is displayed at the top of the sign-in screen. Video of the resulting animation: https://crbug.com/814728#c22. Animation repeating is now done in the code (thus changes in SigninView.java), as there's no reliable way to repeat a set of animations from XML (<set> tag ignores "android:repeatMode" attribute). Bug: 814728 Change-Id: I034fbb6b9d27205998d7c4705d3321b4d16a65c4 Reviewed-on: https://chromium-review.googlesource.com/1000866Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#549453}
-
Shuhei Takahashi authored
Server response may contain useful error descriptions. "Server returned wrong response code: 403: Rate limit exceeded" Bug: None Test: Try opt-in with rate limited account and see: Change-Id: I853a8767baab0a733901a5a956087261e979cd85 Reviewed-on: https://chromium-review.googlesource.com/987419Reviewed-by:Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#549452}
-
Koji Ishii authored
CL:988375 fixed AXLayoutObject::CanIgnoreSpaceNextTo by accessing LayoutText::First/LastTextBox() directly. Since these functions will be gone in LayoutNG, this patch abstracts what it does and hide InlineTextBox inside of LayoutText. Actual implementation of these functions for LayoutNG will be done after CL:986982 adds retrieval of NGInlineItem. It's possible with NGOffsetMapping or NGPhysicalFragment, but NGInlineItem would be better fit. Bug: 821906, 636993, 830546 Change-Id: If590e8c01e59d58b0f77ba6b3f57e35e9c29acb3 Reviewed-on: https://chromium-review.googlesource.com/997912 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#549451}
-
jdoerrie authored
This change adds a list of abandoned devices to U2fRequest. This list gets populated, when the request gives up on a device due to an error. Devices in this list will not be considered when IterateDevice() is called. Bug: NONE Change-Id: I6760b956f2fefa31631379c181224b888ee32902 Reviewed-on: https://chromium-review.googlesource.com/1001897 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549450}
-
Robert Sesek authored
This makes it easier to track down issues in specific areas of the JSONParser. Bug: 489301 Change-Id: I7946451edd2323cabc3fd31c9841a9c6834abd20 Reviewed-on: https://chromium-review.googlesource.com/1002815 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549449}
-
Felix Ekblom authored
This is a reland of 52d81474 Original change's description: > Actually check whether extension is in kiosk mode > > Add the missing check for actually being in kiosk mode, but keep the > autotest bail to simplify testing of the feature. > > BUG=chromium:826568 > TEST=Ran autotest, verified that extension can't access edid. > > Change-Id: I8f93e29d8d977b0977b3eb597ce2aae263b4e9b9 > Reviewed-on: https://chromium-review.googlesource.com/982619 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548147} Bug: chromium:826568 Change-Id: I4a005a804d1de6325fb145f62e7d1d778ee5b201 Reviewed-on: https://chromium-review.googlesource.com/997412 Commit-Queue: Felix Ekblom <felixe@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549448}
-
Takashi Toyoshima authored
This patch adds some browser tests that verifies CORS checks for requests initiated from local files. Tests verify if; - HTTP request has an expected Origin header, 'null' for production mode, 'file://' for test mode with --allow-file-access-from-files flag. - CORS check pass iff the server allow 'null' origin for production mode, 'file://' origin for the test mode. These tests should be provided over file:// protocol, and need to modify --allow-file-access-from-files flag. That requires exaggerated setup if we want to have these tests in Blink layout tests, that's why these are in browser tests here though relevant implementations are in Blink and the network service. Bug: 825567 Change-Id: I986a110f6cddc0349b83cb0ade16ef30581c6ce4 Reviewed-on: https://chromium-review.googlesource.com/987593Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#549447}
-
Tsuyoshi Horo authored
CertUrl and validityUrl and request URL must be absolute. https://github.com/WICG/webpackage/pull/170 Currently the validity of certUrl and validityUrl is checked in ParseSignature(). But there is no validity check of the request url. And also there is no has_ref() check of all of them. So this CL adds these checks: - is_valid() and !has_ref() for request URL. - !has_ref() check for certUrl and validityUrl. Bug: 829932 Change-Id: I4502cb7cbb381e631292c8fd7a1ca998614f21b3 Reviewed-on: https://chromium-review.googlesource.com/1002338Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#549446}
-
Shuo Weng authored
Group mLatestVersion and mMarketURL into VersionConfig to allow the flexibility to return different version config in downstream. Bug: b/77151591 Change-Id: Ie251a5f953a82a480ea19973b41fdeb8c687100e Reviewed-on: https://chromium-review.googlesource.com/987836Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Shuo Weng <shuow@google.com> Cr-Commit-Position: refs/heads/master@{#549445}
-
Takashi Toyoshima authored
Since these files are not used by Blink, we can put them in services/network/cors. This will make it easier for CORSURLLoader to depend on cors::PreflightController. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibebe686a54e70872b33db06bf7ed72d653d4d1f6 Reviewed-on: https://chromium-review.googlesource.com/999692 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#549444}
-
Greg Thompson authored
With this change, alternate_version_generator now also updates occurrences of the version number found in the .rdata section of PE images. As a result, Chrome runs and thinks it is the altered version. While at it, I also switched from using a custom MappedFile to the one in base, which now supports r/w mappings. BUG=461856 R=huangs@chromium.org Change-Id: I4e5c3bbc71e73a05b541d12693e512a7ac1b3ecb Reviewed-on: https://chromium-review.googlesource.com/1001896 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549443}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: Ifb724d96099e6324cfdb7fbf50a6a87cc69449f2 Reviewed-on: https://chromium-review.googlesource.com/989457Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#549442}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c366fc9e..86b145e5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I858c7a08a20d2fa0853507c1da20f75100e231a5 Reviewed-on: https://chromium-review.googlesource.com/1004193Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549441}
-
Yuta Kitamura authored
Scheduler classes are being renamed as part of scheduler architecture refactoring. Bug: 826203 Change-Id: Ic9a74dd8ef8238c0d83dda03d3c9e5a6f505d85b Reviewed-on: https://chromium-review.googlesource.com/994853 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549440}
-
Matt Falkenhagen authored
For ServiceWorkerProviderHost: * Remove IsHostToRunningServiceWorker(). This was a subtle function since it was used mainly as !IsProviderForClient(), but it was also false when the service worker was still starting up. * Add IsProviderForServiceWorker() as an analogue to IsProviderForClient(). * Improve documentation/terminology throughout for consistency with ServiceWorkerProviderContext. Change-Id: I69a0449aeda41f23f41bee767524aebf5ff9b1d2 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/1002216 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549439}
-
https://chromium.googlesource.com/catapult.git/+log/b5c70ce2580e..1bae362e7789 $ git log b5c70ce25..1bae362e7 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 simonhatch HistogramSet - Merge by only a subset of tags. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic0d3e1eaaedd22c46eade2ea5c780e496a214453 Reviewed-on: https://chromium-review.googlesource.com/1004007Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549438}
-
JunHo Seo authored
'type' doesn't give much information. Use more informative name. Bug: 770147 Change-Id: Iad53dfc11347c149f1d076cc5c326437df2f28c4 Reviewed-on: https://chromium-review.googlesource.com/989387 Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#549437}
-
Yuta Kitamura authored
These files were renamed in crrev.com/c/986112, but they should have "_impl" in the back. This patch corrects those names. Bug: 826203 Change-Id: Ib4cf5e51f1e5cd8d517486a0e1fb177bb30d8f78 Reviewed-on: https://chromium-review.googlesource.com/994504 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549436}
-
Peter Kasting authored
Bug: none Test: none Change-Id: Iefdc0ad2f75590e077b5599b4f6e2984f89747d3 Reviewed-on: https://chromium-review.googlesource.com/940769 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549435}
-
Chong Zhang authored
'loading.desktop.network_service' fails randomly when uploading json results, e.g. https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/5265 It seems that we might miss some charts in certain conditions. e.g. We don't have 'timeToInteractive_std' when all values are None. This CL handled the case by only doing diff on common charts / points between control and enabled chartjson result. Bug: 827442 Change-Id: Ibb1b9004d48bdfc2fa017c4acf57c989ae15c17f Reviewed-on: https://chromium-review.googlesource.com/1003520Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549434}
-
Matt Giuca authored
Moves browser-window-specific functionality from AppMenuButton into new subclass BrowserAppMenuButton, and made AppMenuButton a base class of HostedAppButtonContainer::AppMenuButton. BrowserViewButtonProvider now provides an AppMenuButton, rather than a generic MenuButton, allowing code that is common to browser and hosted app windows to interact with the app menu (e.g., detecting whether it is open, and closing it). This will be used in a future CL to fix the code that hides the zoom bubble if the menu is open so that it works in hosted app windows. Tbr: nyquist@chromium.org Bug: 791399 Change-Id: I2bce579b2c220cd70c0a02e95f270e0f3d13ba8d Reviewed-on: https://chromium-review.googlesource.com/983252 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#549433}
-
Karan Bhatia authored
A chrome extension has implicit host permissions to its own origin (chrome- extension://extension_id/). This allows the extension to monitor and modify requests to any of its own resources using the WebRequest API. However, this allows an extension with DNR to also possibly/mistakenly block or redirect its own background page. This is not a problem for the WebRequest API since it is (generally) the background page which does the blocking in case of the WebRequest API. To fix, simply whitelist all resources on the chrome-extension scheme as far as DNR is concerned. BUG=829225 Change-Id: I022f137f1fde20276de22f0f8529aa4f1c9a53db Reviewed-on: https://chromium-review.googlesource.com/1000770Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549432}
-
Alexey Baskakov authored
In the Files App Settings menu, the storage indicator should be clickable and link to the Settings -> Device -> "Storage management" UI. Bug: 680347 Test: Manually tested Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3703b2d94852a3011e7e6d91b2afe010400795b5 Reviewed-on: https://chromium-review.googlesource.com/999240 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#549431}
-
Xianzhu Wang authored
This optimize especially for the following simple case: <div style="overflow: hidden"> ABC </div> which seems quite common in real web pages. This CL saves OverflowClip node and Save/ClipRect/Restore operations when the contents don't overflow. Performance results: CT: (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180409001618/html/index.html) record_time: -2.7% paint_op_count: -2% painter_memory_usage: -0.7% rasterize_and_record_micro.top_25 (https://pinpoint-dot-chromeperf.appspot.com/job/113ce7b4c40000): record_time: -4.5% paint_op_count: -2.4% painter_memory_usage: -1.8% Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia12e0182cb2b712013dca3e2cb9805d2d65cd7df Reviewed-on: https://chromium-review.googlesource.com/1001752 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549430}
-
Xianzhu Wang authored
For: <div style="transform: translateX(10px)"> <div>A</div> <div style="overflow: hidden">B</div> <div>C</div> </div> previously we emitted the following paint operations: Save Transform Draw A Restore Save Transform ClipRect Draw B Restore Save Transform Draw C Restore With this CL, we emit the following paint operations: Save Transform Draw A Save ClipRect Draw B Restore Draw C Restore by reusing transform state across clip state which has the same transform. CT result: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180406052047/html/index.html This CL reduces paint_op_count by 2.6%. Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id0d41b98ffd35440f4a608856650f7109362d425 Reviewed-on: https://chromium-review.googlesource.com/999095 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549429}
-
Charlie Harrison authored
This CL: - Changes the AdDelayThrottle lifetime so it is always created, in an enabled or dryrun state - Adds an enum histogram for the product of {isAd, isSecure} in the destructor. - Fixes a bug where syncXHRs were breaking due to us not properly handling DetachFromCurrentSequence(). Added a browser test for that case. Bug: 829042 Change-Id: Ib4bc572f1edce2c975b72f4a6d128c65b6acd2bc Reviewed-on: https://chromium-review.googlesource.com/998537 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549428}
-
Esmael El-Moslimany authored
Bug: 829722 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I372a6f71ff768fdcc5b113b86617db5b92b10e1c Reviewed-on: https://chromium-review.googlesource.com/998979Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#549427}
-