- 21 Oct, 2019 40 commits
-
-
Ali Juma authored
The injected versions of pushState and replaceState synchronously call the built-in version of these functions, and then send a message to Chrome's process. After receiving this message, Chrome injects script to perform a replaceState with the same state and URL. Since this happens asynchronously, it will incorrectly clobber changes to history state that have happened since the original call to pushState or replaceState. These extra calls to replaceState are also unnecessary, since the injected functions already call the built-in equivalents. A previous attempt (https://crrev.com/c/1514060) at removing this logic only did so for pushState, leading to a bug (crbug.com/949305) when a page does: replaceState(someState, someTitle, "#replace"); pushState(someOtherState, someOtherTitle, "#push"); Because replaceState still had the extra asynchronous call, the actual sequence that was excecuted was: replaceState(someState, someTitle, "#replace"); pushState(someOtherState, someOtherTitle, "#push"); // A bit later: replaceState(someState, someTitle, "#replace"); This effectively erased the pushState. This CL removes the extra calls from both pushState and replaceState, and adds test coverage for back-to-back calls to replaceState followed by pushState and vice-versa. This also fixes subtests in the following two Web Platform Tests that currently fail in Chrome but pass in Safari: html/browsers/history/the-history-interface/history_pushstate_url.html html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc.html Bug: 769945 Change-Id: I34b51a0a91def67cbe85ef16761497a293f1b497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867308 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#707796}
-
Elly Fong-Jones authored
The original version of this used Cmd-Option-Up and Cmd-Option-Shift-Up; after some experimentation and further thought from UX we're going to go to Cmd-Option-Up and Cmd-Option-Down instead, which will free up Cmd-Option-Shift-{Up,Down} for another use. Bug: 956432 Change-Id: Id617bef7f94fcc35d438bf585a675a28a667bc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868914 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707795}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52e9d677c6eb..03882834cb55 git log 52e9d677c6eb..03882834cb55 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 tmrts@chromium.org [vinn] Enable snapshots and update Windows d8 binary to 7.6.303.31 Created with: gclient setdep -r src/third_party/catapult@03882834cb55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1001953 Change-Id: I66e566a214cc0754248e7e00b833061ee9a6bd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707794}
-
Fergal Daly authored
- Move run-swarmed and mb.py to the top of the doc This is a great doc but after working through a lot of steps, I found that I could have just run mb.py. So this adds a "The easy way" section at the top of the doc and moves the combined tools to that. - Factor out the authentication section so that it's linkable. - Add a concrete example and advice on how to construct $criteria. Change-Id: I0e7dcbcf9ce38aeed08a614e35f3f1374d2fa8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871158Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707793}
-
Mikel Astiz authored
A privileged Javascript API is exposed to allowed origins, which requires analogous plumbing between the renderer process and the browser process. In this patch, the Mojo interface is introduced and basic implementation of both ends, with a browser test that exercises the full flow. Design doc (Googlers only): https://docs.google.com/document/d/1YNrBAzmHlhjEigpjcR_hm7yrvGIuJOZpXEhtqNloUec/edit#bookmark=id.bgwil9c791bc Bug: 984940 Change-Id: Ic3c941b5209a03bc35dce44ecdd31a8e47af0b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725913Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707792}
-
nancy authored
BUG=1009248 Change-Id: Idfd3f413054297f40814eabbc650bb70eb3049d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868210 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#707791}
-
Marc Treib authored
These were part of the old bookmark sync implementation and not used anymore. With this, the ModelAssociator interface becomes unused and is removed too. profile_sync_service_bookmark_unittest.cc basically contained unit tests for the two removed classes, also based on low-level directory code. These are not relevant anymore and so are also removed. Bug: 933756 Change-Id: I616f38ab9170d3d3fdae5eac427c8eda1c0ab658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863808 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707790}
-
Ella Ge authored
This reverts commit fac39a19. Reason for revert: Causing ash_unittest failing. Start from: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/35783 Original change's description: > overview: Fixed aspect ratio for overview items in splitview. > > Overview items now match the aspect ratio of the window bounds if they > get snapped. This will happen if splitview is active on either side, or > if the window is getting dragged close enough to an edge. A videos of > before and after this patch is in the bug. > > Follow up: > Make this work for tablet mode with 6 or more windows. In that case > the positioning logic follows a different path. > Match the exact dimensions in the spec, this patch only does rough > clipping. > > Test: added tests, manual > Bug: 1011973 > Change-Id: I3d9d341c54b58d0e86440045ad1408ca3a0fd27d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849175 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707426} TBR=xdai@chromium.org,sammiequon@chromium.org No-Try: true Bug: 1011973 Change-Id: I163b3ca64c454a4a202534e7ed0171e57e178e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872011 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707789}
-
Xida Chen authored
This CL moves the position of a test so that these tests are grouped together. Bug: None Change-Id: Ib84a2898bb6d5566b4a4c19f37c6e85de0ccacfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872010Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707788}
-
Ella Ge authored
This reverts commit 9ed68bfb. Reason for revert: Revert to revert upstream change https://chromium-review.googlesource.com/c/chromium/src/+/1872011 Original change's description: > overview: Clipping for windows using new grid layout. > > Extracts parts of the regular grid layout function into a helper, which > is then used by the new grid layout function. > > Test: manual > Bug: 1011973 > Change-Id: I7bdf40227bbd1df467ea9d56bc84e58b01c12f33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867271 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707460} TBR=xdai@chromium.org,sammiequon@chromium.org No-Try: true Bug: 1011973 Change-Id: I675fb57809d190ca9266d012885269dcea2401c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872012 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c70966b3505e..61386966b2ad git log c70966b3505e..61386966b2ad --date=short --no-merges --format='%ad %ae %s' 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@61386966b2ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I71522c1332ff0bdf84ba55510f8133cf470565d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872229Reviewed-by:
-
Maksim Moskvitin authored
In case of implicit passphrase Nigori the only required field in NigoriSpecifics is encryption_keybag. New test covers this case and checks that passwords could be decrypted once passphrase is provided. Bug: 922900 Change-Id: I36a2e837d4150fd16b1edcf94d8adf24c34f6b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863096 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65397626..cf414fd4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I44b119873febd2eb21fece26fa0364e3c18718b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871890Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707784}
-
Jan Wilken Dörrie authored
In order to be more robust against changes to the observer list, this change modifies FormFetcher to use a base::ObserverList instead of a simple set and makes its consumers inherit from base::CheckedObserver. This allows consumers to delete the form fetcher while being notified, which previously would cause a use-after-free. A corresponding test is added. Bug: 1007556 Change-Id: I645526027e35be222479009199af6545de6a11f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855985 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707783}
-
Abhijeet Kandalkar authored
This CL converts ServiceManagerListener{Ptr, Request} and ServiceManagerPtr and port depending files to adapt to new mojo types. Bug: 955171, 978694 Change-Id: Ic3cda1b527d3f164caf717c982dbb04b09595c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865218 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#707782}
-
Aya ElAttar authored
Remove the supported_on end version from the following policies to avoid breaking the build as soon as the automatic uprev commit that marks the first 82 version lands: - ScreenDimDelayAC - ScreenDimDelayBattery - ScreenOffDelayAC - ScreenOffDelayBattery - ScreenLockDelayAC - ScreenLockDelayBattery - IdleWarningDelayAC - IdleWarningDelayBattery - IdleDelayAC - IdleDelayBattery - IdleActionAC - IdleActionBattery - IdleAction Bug: 346229 Change-Id: I984b8d56eb3b5b83c316e02930dec92866ab3817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871590Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#707781}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/8d000e0cc230..4794168ef8b1 $ git log 8d000e0cc..4794168ef --date=short --no-merges --format='%ad %ae %s' 2019-10-18 yizhou.jiang Use toggle to turn off vsync on D3D12 2019-10-18 rafael.cintron Add D3D12 keyed shared mutexes to Dawn 2019-10-17 rharrison Rolling 4 dependencies 2019-10-17 enga Record and dump trace events in the perf tests 2019-10-17 bryan.bernhart Resource Management 8: placed resource sub-allocation. This CL temporarily skips WebGPU mailbox tests on Windows because the WrapSharedHandle interface has changed. Created with: roll-dep src/third_party/dawn TBR=kbr@chromium.org BUG=None Change-Id: I536c66e85bd3bfc568a7cfca29dc95618b4549d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868951Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#707780}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77780358011f..a0aed87f7121 git log 77780358011f..a0aed87f7121 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 ukai@chromium.org Revert "put goma client in depot_tools" Created with: gclient setdep -r src/third_party/depot_tools@a0aed87f7121 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/77663154 Change-Id: I58fab5d1810fd271ae478e5056eed3489454c022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872149Reviewed-by:
-
Roman Sorokin authored
Bug: 1015705 Test: tried locally Change-Id: If32370184ab246892d3f2ee21eb6005cf26f2cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869222Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707778}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iacdbc0759cc70ed0d22a006e0895af19fb9797d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872109Reviewed-by:
-
Marc Treib authored
This was part of the old bookmarks sync implementation and not used anymore. BookmarkDataTypeController was the only implementation of FrontendDataTypeController, so that can go too. SyncApiComponentsFactory::CreateBookmarkSyncComponents was also unused and is removed. Bug: 933756 Change-Id: I2c678e11a2030eb7aa37b52fed5ae6a363baad49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864684 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Monica Basta authored
Remove code for clearing |prefs::kProfileUsingDefaultName| on sign in/sign out events. Bug: 1012182 Change-Id: I1dd916c059ace7f91d48b7bec1f1f92df8030ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871552Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/82a3f0ad7f2b..b9f69028a0da git log 82a3f0ad7f2b..b9f69028a0da --date=short --no-merges --format='%ad %ae %s' 2019-10-21 danilchap@webrtc.org Store logging streams in a manually linked list instead of std::list Created with: gclient setdep -r src/third_party/webrtc@b9f69028a0da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie4d6be6bff46bfb8f7f53c61acc8f943b93ab802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872112Reviewed-by:
-
Fergal Daly authored
is_component_build=true causes short timeouts _within_ tests to be exceeded, probably due to lazy loading of components. Bug: 1016230 Change-Id: I7236b590d62255154fa52f86999894aa36a95441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870157Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707773}
-
Jüri Valdmann authored
Change-Id: I508786031d2658ab907661caea71fa6e45270006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862686Reviewed-by:
-
Miyoung Shin authored
This CL converts CameraModule{Ptr, Request} in media to the new Mojo type, and uses pending_remote<CameraModule> and pending_receiver<CameraModule> in cros_camera_service.mojom. Bug: 955171 Change-Id: Ib95c14a2f25acb731fa2838c0bb1afdf78e02996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863018 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707771}
-
Tim Schumann authored
in the sync protocol. Change-Id: Ic529edcc4588969828605435256d088b666f8eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869512Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#707770}
-
Jan Wilken Dörrie authored
This change exposes the Touch To Fill base::Feature on all platforms. This is for consistency with other autofill feature flags as well as convenience, as it simplifies implementation and testing. It also updates the name from kTouchToFillAndroid to kAutofillTouchToFill, again for consistency. The corresponding UI flag is kept to be Android only. Note that this change does not modify the actual feature name, as this would interfere with an existing finch study. Bug: 957532 Change-Id: I7d1537449e73b5317385657b68e159d714966d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871589Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#707769}
-
Michael Ershov authored
This CL adds a new policy to configure allowed URLs for device attestation during SAML authentication. Bug: 1000589 Change-Id: Ib1c4e7724c4e5cf14c9be4ba27a39e09ee397889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783148 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a5c8651cfccb..52e9d677c6eb git log a5c8651cfccb..52e9d677c6eb --date=short --no-merges --format='%ad %ae %s' 2019-10-21 perezju@chromium.org [Telemetry] Refactor story_runner_unittest.RunStorySetTest Created with: gclient setdep -r src/third_party/catapult@52e9d677c6eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:921000 Change-Id: I7440bc8632af46cbf36c5415389d37c93a2f17ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871629Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f206982b4654..f11f58996811 Created with: gclient setdep -r src-internal@f11f58996811 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I734e6e2d592f5fb28f81ee193189aca6c0c1ea91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871630Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707766}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3663ed3ad678..82a3f0ad7f2b git log 3663ed3ad678..82a3f0ad7f2b --date=short --no-merges --format='%ad %ae %s' 2019-10-21 danilchap@webrtc.org Replace SingleThreadedTaskQueueForTesting::SendTask usage with ::webrtc::SendTask 2019-10-21 danilchap@webrtc.org Stop using gtest internal macro GTEST_ARRAY_SIZE_ 2019-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db43fd36..8587b26e (707597:707701) Created with: gclient setdep -r src/third_party/webrtc@82a3f0ad7f2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ica8c70dc84a6d47000cc6e56e9a92b4b06a0ba1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871929Reviewed-by:
-
mark a. foltz authored
Add myself as a backup OWNER to miu@ for features related to Cast, to review changes in case miu@ is OOO. Change-Id: Id44fa744f70db2843385b06c58457fbbf5725f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867206Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
sandromaggi authored
Before this change the server had no knowledge of whether or not the onboarding was shown to the user in this run. To be able to log this, a new flag is now sent to the server in the requests for getting scripts. Adding unit tests to check new behaviour. Bug: b/142846407 Change-Id: Ic77bbc70c8add122beaff80a47e3cf7dca4454d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866631 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707763}
-
Jan Wilken Dörrie authored
This change implements suppressing the Autofill popups when the Touch To Fill sheet is shown. Touch To Fill provides more information than a password autofill dropdown, which is why it should take precedence. Bug: 948062, 1015789 Change-Id: I052c0f4d85f79da8818cc3b848d078efed4253f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868956Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8bbd6af6..65397626 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibadbc6f0a5a294d7f476eb05715182c61440ccea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871889Reviewed-by:
-
Omer Katz authored
Allocations during the atomic pause were never supported. Enforcing it using scopes helps debugging issues were this invariant is violated. Bug: 986235, 993415 Change-Id: I5fd8ecd147403e2a7a89185b55057550d135bac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869225 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707760}
-
Greg Thompson authored
The User Data dir cannot be cleanly deleted at the end of the main test function, as there remain files in-use within the directory at that point. Rather, scope the temp dir to the lifetime of the test harness so that it can be cleaned up after the test has been spun down. Bug: 546640 Change-Id: Id942c785bb6c84c40079bc4bde10fad4c7b16d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870113 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#707759}
-
Takashi Sakamoto authored
Bug: 1007769 Change-Id: I3fcf6d89e0bb50fdb9cabe737cb15ebb6a894b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868929Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#707758}
-
nancy authored
BUG=1009248 Change-Id: I9253de4ba310849dc52d0615c211ca11bb9dc548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859418Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
