- 10 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e6f65d9265e7..d37179337d95 git log e6f65d9265e7..d37179337d95 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 digit@google.com [cmake] Add support for CMAKE_SYSTEM_NAME == "Fuchsia" Created with: gclient setdep -r src/third_party/swiftshader@d37179337d95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Icd1e0fb6e2aeb26a63df4bc98a29c50ef48bad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758272}
-
Regan Hsu authored
Wait for iron list to complete resizing, then flush to ensure all os-search-result-rows are loaded. (https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8883704380960662928/+/steps/browser_tests/0/logs/Deterministic_failure:_OSSettingsSearchBoxBrowserTest.AllJsTests__status_FAILURE_/0) Fixed: 1068811 Change-Id: I15b35de45399c13cd10606980cf5c00dcbf0562a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140203Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758271}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2faa33772be4..95c26efc9049 git log 2faa33772be4..95c26efc9049 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 brianosman@google.com Pure SkSL RNG for particles 2020-04-10 bsalomon@google.com Batch across view matrix changes in linearizing convex path renderer 2020-04-10 reed@google.com approx_tan for skvm Created with: gclient setdep -r src/third_party/skia@95c26efc9049 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1066338 Tbr: csmartdalton@google.com Change-Id: Icc86c730e7dcb445b8871d2aaeb0c89d9de7a461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/647a242debd9..68353dd74e3e Created with: gclient setdep -r src-internal@68353dd74e3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046880,chromium:949819 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I3de013cd9d7b343ae2ef9bb9f744ec1c50bf6189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758269}
-
David Bokan authored
This was introduced in https://crrev.com/c/2142514 when the invalid value being case to an EventDisposition enum was turned into a base::Optional de-ref. This situation should never occur but the crashes indicate it does. This CL preverves old behavior to prevent the crash. TBR=nzolghadr@chromium.org Bug: 1069760 Change-Id: I412edf2bff202d68730a3374792f1dab16a91426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145567 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758268}
-
Theresa Wellington authored
A previous CL attempted to deflake this test by waiting for page load start instead of page load finished. This appears to have helped a bit but there was a failed run after the "fix". The failures were due to either the pageLoadStarted check comparison failing to get the right Tab (claimed activity tab URL was about:blank while post test screenshot showed correcct URL) or an NPE when attempting to get the activity tab. This CL waits for the last focused activity to be ChromeTabbedActivity then polls for ChromeTabbedActivity#getActivityTab()'s URL to match the expected test page. BUG=1068608 Change-Id: I13dd6e3ad59963ebfa21d99d011e8b8a600496d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145764 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#758267}
-
Matt Menke authored
In particular, mention SameSite cookies, assembling the cache key (using the NIK), provide a bit more detail on other schemes, particularly websockets and data URLs, and remove information about FTP. Bug: None Change-Id: I3fe69c2f7ea7b4d1e299d9c68973142b87dafcdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144685 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#758266}
-
Donn Denman authored
A new test suite for the Preview Tab. Also adds a helper for FirstRunFlow. Using the helper in existing tests will be done separately. BUG=952319 Change-Id: I756483ce549f9664012a24db8b62e1cdc43b9361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136282 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#758265}
-
Ben Pastene authored
Picks up a single change: $ git log 97d7f0702..8ef1e6c0 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 bpastene@chromium.org device: Don't assume '--device=localhost' means VM. And updates chromeos/test_runner.py to not specify '--device=localhost' when running VM tests. Bug: 1067800 Change-Id: Id8af6b2cb1d8a082b71a6ac01cfe9522578a21b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145762Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#758264}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4fe13170266cb0cdcac3dd5132e3a009464da07b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145780Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758263}
-
Jesse Schettler authored
Print preview occasionally fails in the arc.Print tast test. Add logging to investigate these failures. Bug: b:152251595 Change-Id: I5b8b18213ec8c7fc2a56646c65dfe5262b86f677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144456Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#758262}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bb2b300..8da8c788 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I72025724700cdbce1f48a6e5024021b30a63f446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758261}
-
Becca Hughes authored
Makes init more resiliant and adds more histograms to help debug the crash. BUG=1069626 Change-Id: I20a92bc53e477a8496c455f14ab41d458d12198e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144622 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#758260}
-
John Z Wu authored
Change-Id: I67237332cc5d7e754b170cb09e1728442aada688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144678Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#758259}
-
Caitlin Fischer authored
Bug: 1066297 Change-Id: I2aaed82e4699b3bc11d5b0e5ec81fbd6dfd52f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137009Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#758258}
-
Greg Kerr authored
Bug: 728125 Change-Id: Id13216db97fafe39ba9aa811401b3071e5213572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145852Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#758257}
-
Chong Gu authored
Turn off tests that are failing during investigation. Bug: 1069808 Change-Id: Id44e389b6be7b96a1cfc1a6543897ee36c5f1506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144479Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#758256}
-
Gyuyoung Kim authored
This CL migrates filter-effect-removed[-expected].html tests from css3/filters to external/wpt/css/filter-effects with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to filter-effect-remove-unattached[-ref].html to be align with WPT naming style. Bug: 1063749 Change-Id: I15ec6149c6c3bdc5ae271389f7559a2b502aa5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143018 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#758255}
-
behdad authored
Pixel_OffscreenCanvasIBRCWebGLHighPerfWorker is set to retry on failure on mac intel-0xd26 because of flakiness. TBR=kbr@chromium.org Bug: chromium:1069339 Change-Id: I92875215b66998b33504d2bc5068ef14b0d3690e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145566 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758254}
-
Rohit Rao authored
These histograms are in active use and seem useful indefinitely. BUG=1059804,1037279 Change-Id: If1b5f3d6ae21792d3a6721377f5ee9501153a94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140917Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#758253}
-
Matthew Porter authored
Removed the hardcoded color values of MessageView, focus_view sets the color appropriately already Bug: 1056948 Change-Id: I9ed0caf6fed54dd5b0da18925d0a21d978523e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138232 Commit-Queue: Matthew Porter <matt.porter@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#758252}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: Ib8d60aa02fac5d278069541555a4e615ab5237bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142584 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758251}
-
Eric Roman authored
Change-Id: Idcd3b5b470db3fd782396fa219ca657077b792c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144672Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#758250}
-
Dan Sanders authored
--disable-media-suspend only disables the background suspend feature. Renamed to --disable-background-media-suspend. --enable-media-suspend is a no-op except on Cast. Removed. Bug: 867146 Change-Id: Id5e8acf3aa890b25dedcadd27f1f81976f774358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144819Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758249}
-
Theresa Wellington authored
BUG=949819 Change-Id: I09e3546e3e14f469e3a68fcddfd840ec3fd76e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140928Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#758248}
-
Tibor Goldschwendt authored
Most likely has already been disabled on mobile and an experiment found that most likely can also safely be disabled on desktop. + Remove now redundent fieltrial testing config of the desktop experiment. Bug: 1009579 Change-Id: I5028c2babcef71862096dcd9684eaa29d0ad08b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142758Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758247}
-
Miriam Zimmerman authored
BUG=chromium:1055389 TEST=validate.py Fixed: chromium:1055389 Change-Id: I510e858c1e9e010b6153afbce9aa2de46f3a3391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137675Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#758246}
-
Nasko Oskov authored
This test has been updated to work with --site-per-process, but remained disabled. It passes fine now. Fixed: 671734 Change-Id: I7ba432eb43375b26e672da64e60e953196dee8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144828 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#758245}
-
Reilly Grant authored
This test appears to be flaky. See the attached bug for more details. Bug: 1069850 Change-Id: I6f5ba61be70c59f0a274a32d38301f9d882d6c6c Tbr: katie@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145857Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758244}
-
Esmael El-Moslimany authored
The background iframe was not loading correctly on initial load and after an image was selected following the customize dialog closure. To fix this, only set the path of the background image iframe if the path is not empty and is different. Also do not reset the background selection unless the theme changes. The logo was not updating when the customize dialog background selection changed. Bug: 1032328 Change-Id: I99304d80e7149439f57c02c9192af98af5deb4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145554 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758243}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/90ff937ff645..0780cae6bf8d git log 90ff937ff645..0780cae6bf8d --date=short --first-parent --format='%ad %ae %s' 2020-04-10 bsheedy@chromium.org Revert "[Telemetry] Standardize CrOS quoting" 2020-04-10 bsheedy@chromium.org [Telemetry] Standardize CrOS quoting Created with: gclient setdep -r src/third_party/catapult@0780cae6bf8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068708 Tbr: oysteine@google.com Change-Id: I20fb92b41c339e0cc30a1b2ba24450734ee02c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758242}
-
wutao authored
Bug: none Test: NA Change-Id: I4f577c8383408f8e716e52f96cf977af17b96697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137913Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#758241}
-
Tibor Goldschwendt authored
The share dialog opens when clicking the share button on simple and animated doodles. The dialog lets the user share the doodle via Facebook, Twitter, email, and copy the doodle URL. + Add doodle description tooltip. + Remove TODO about the share button focus ring working for dark doodles. We decided it's an edge case and doesn't warrant fixing. This is a reland of 275bf019 with a fix for flaky Mac tests. `navigator.clipboard.readText()` requires a focused document. Therefore, 'clicking copy copies URL' was moved to interactive_ui_tests, which focuses the document for each test case robustly. Original change info: > Change-Id: Ib2b8d9ca9447a2d6363d3c76167b393f914f60e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138792 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758033} TBR=ajgo@,owone@,aee@ Bug: 1039910 Change-Id: Ia3cd23e03c3c147314066d7e5420138c906b3557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145755Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758240}
-
Reilly Grant authored
This test appears to be flaky and caused a failure on the waterfall. Bug: 1069843 Change-Id: I5afee14c34ed645cc0aed53d5f7ce0e6dc2749c2 Tbr: loyso@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145569Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758239}
-
Stepan Khapugin authored
Forces ShouldScopeFullscreenControllerToBrowser to be enabled when in multiwindow. This greatly improves usability with multiwindow. Bug: 1069752, 1060653 Change-Id: I4521b4814ebd42aaadbe27c5252a8ef710928d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144108Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758238}
-
Corentin Wallez authored
This is step 2 of a N-way patch to move Dawn's GN test targets to a subdirectory: //third_party/dawn to //third_party/dawn/src/tests Bug: chromium:1064305 Change-Id: Icefe9fca706ed19de7a11d989a470b87343317f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144956Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758237}
-
Yves Arrouye authored
Add a new message and a field in the certificate-based registration data that allows us to provide device identification during registration. Bug: b:153503823 Test: None Change-Id: If6246345a52f79114622fb8d6c3cfc35fe81f635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141216Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#758236}
-
Allen Bauer authored
Bug: 1068323 Change-Id: I9a4588f858169fee41b045f9d8331752df3bd413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145556 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758235}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4403e7a7805..2faa33772be4 git log f4403e7a7805..2faa33772be4 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 egdaniel@google.com Revert "Split apart flushing and submitting in the GrGpu classes and GrDrawingManager." 2020-04-10 egdaniel@google.com Remove vulkan validation layer workaround. 2020-04-10 robertphillips@google.com Appease VS 2019 2020-04-10 bsalomon@google.com Remove GrCaps::getYUVAColorTypeFromBackendFormat(). 2020-04-10 bsalomon@google.com Remove unused GrVkFormatColorTypePairIsValid 2020-04-10 egdaniel@google.com Split apart flushing and submitting in the GrGpu classes and GrDrawingManager. 2020-04-10 stani@google.com Trace texture upload always with Android framework 2020-04-10 jvanverth@google.com More fixes to get D3D tests running. 2020-04-10 bsalomon@google.com Always initialize YUYAIndex::fChannel in wacky YUV format GMs Created with: gclient setdep -r src/third_party/skia@2faa33772be4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Id47abb93ee51658a12da17df5e5357650591c4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758234}
-
Alan Cutter authored
This CL fixes the warning in mojo_unittests: The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<EndToEndRemoteTest> Bug: 1045846 Change-Id: Ic67c23f9cdbc3544c857777451691cecc62de92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144793 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#758233}
-