- 24 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/540e6de099d0..8303bf623f17 git log 540e6de099d0..8303bf623f17 --date=short --no-merges --format='%ad %ae %s' 2019-08-24 cjmcdonald@chromium.org Deprecated argument doesn't need to take a value Created with: gclient setdep -r src/third_party/chromite@8303bf623f17 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I35bea630cfc64e02d71922000bb62328eee29c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690189}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/69365b66613f..11e185078e5c git log 69365b66613f..11e185078e5c --date=short --no-merges --format='%ad %ae %s' 2019-08-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@11e185078e5c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I51eba71df25846b3cfcf8fa5881c06bf3b7a2d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770061Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9551b470..8f4f153d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d4e438f12e7841c7db9b3c9bcc5597bf05a0602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768793Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690187}
-
Miyoung Shin authored
This CL converts ServiceWorkerFetchResponseCallbackPtr and ServiceWorkerFetchResponseCallbackRequest in content and blink to the new Mojo types, and uses pending_remote<ServiceWorkerFetchResponseCallback> in controller_service_worker.mojom and service_worker.mojom. Bug: 955171, 978694 Change-Id: I21e90f972d7f93ac09635c1839de6590ea7f3381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761948 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#690186}
-
Andres Calderon Jaramillo authored
This CL fixes the order in which the command buffer queries are created for the RasterTaskTotalDuration and RasterTaskSchedulingDelay UMAs. The CL that introduced the latter assumed that the query for it was issued before the query for the RasterTaskTotalDuration UMA [1]. However, this was not the case. [1] https://cs.chromium.org/chromium/src/cc/raster/gpu_raster_buffer_provider.cc?l=630-632&rcl=1eab052d8f52e823b71fd7bdd5fea70a8f95324f Bug: 995155 Test: None. Change-Id: Ie7f216c7900c7e99377622c3c8ba11001c2cae84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769078 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#690185}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0a07831a9da9..f8d8233d4047 git log 0a07831a9da9..f8d8233d4047 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 lpy@google.com [GPU Profiling] Have a finite set of units. Created with: gclient setdep -r src/third_party/perfetto@f8d8233d4047 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I1801795d33550b3ca14432440f631bd1b789d25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769534Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/079ace40c74f..7e2fc7911e9c Created with: gclient setdep -r src-internal@7e2fc7911e9c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1d92fee24521f66213a2c9bcf70df1fb434848bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769535Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690183}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/34a2b06a63d3..540e6de099d0 git log 34a2b06a63d3..540e6de099d0 --date=short --no-merges --format='%ad %ae %s' 2019-08-24 vapier@chromium.org gerrit_unittest: move GerritTestCase here Created with: gclient setdep -r src/third_party/chromite@540e6de099d0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9735d993ba2f96d379d78a6aa6ef3fbbeb972f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769533Reviewed-by:
-
Wei Lee authored
Since imagecapture.js starts to contain many things that has nothing to do with ImageCapture, this CL refactor it as following: 1. Splits imagecapture.js into MojoConnector, DeviceOperator and ImageCapture to make it clearer and more extensible. 2. Avoids using singleton pattern for mojo connection. 3. For camera Hal v1, simplifies the check and remove try/catch mechanism. Bug: 979104 Test: tast run DUT camera.CCA* Test: Running above test for v1/v3 devices Change-Id: I8b93e05a566ae81731c1e8f71cd00baa82d641f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739035 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#690181}
-
Sunny Sachanandani authored
Fixing vertical flip for desynchronized canvas2d in crrev.com/c/1759214 broke vertical flip for regular canvas2d when switching between tabs. When switching from a canvas tab to another tab the context becomes unaccelerated, so while switching back we set origin to top left based on this, but an accelerated resource is allocated based on the new state. This CL fixes the above issue by reverting to the previous logic of determining the resource provider's is_origin_top_left based on whether we want acceleration or not. Pixel tests are added for switching tabs and verifying that the canvas doesn't get vertically flipped. I've verified that this test fails on ToT, but passes with this CL. Bug: 996622, 994866 Change-Id: Ibe8d63c0fd43071db656b690baebba0c2dba0775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767088 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690180}
-
Yi Gu authored
This reverts commit 06b2d6e4. Reason for revert: compile error due to "if (base::base::FeatureList::IsEnabled(kReduceHeadlessFrameRate))" Original change's description: > Enable 4hz refresh rate on audio-only cast devices > > Use CastExternalBeginFrameClient object during initialization on > audio-only cast devices. > > Bug: b/139299756 > Test: Compile and run cast_shell > Change-Id: Ia5311282398393398bd287f4976a834a79a0e341 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764237 > Commit-Queue: Shawn Gallea <sagallea@google.com> > Reviewed-by: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690175} TBR=spang@chromium.org,dnicoara@chromium.org,sagallea@google.com Change-Id: Icf9fa047d3d752369bdfc163f5d4af382e8477c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/139299756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769666Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690179}
-
Koji Ishii authored
This patch adds |NGFragmentItem::ItemsFor()| that retrieves |NGFragmentItem| associated with a |LayoutObject|. The plan is to store the index to |LayoutObject| so that this operation does not need to iterate items, but this patch adds a slow-but-simple version. The optimization will be in following patches. Bug: 982194 Change-Id: I91f2e85a98dffec47797f9cbe37af40e3c5cecd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768176 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690178}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5cb8b5cdbb62581b16890ea880f9017cbe238613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768954Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8a2c8053daa..69365b66613f git log e8a2c8053daa..69365b66613f --date=short --no-merges --format='%ad %ae %s' 2019-08-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-23 jcgregorio@google.com Add HOME env variable to cloudbuild so vpython can move forward. Created with: gclient setdep -r src/third_party/skia@69365b66613f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I2370ea23d3c5626bf81c54b83593061b07da3f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768953Reviewed-by:
-
Shawn Gallea authored
Use CastExternalBeginFrameClient object during initialization on audio-only cast devices. Bug: b/139299756 Test: Compile and run cast_shell Change-Id: Ia5311282398393398bd287f4976a834a79a0e341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764237 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#690175}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f388237f87d0..1078fdda6aea git log f388237f87d0..1078fdda6aea --date=short --no-merges --format='%ad %ae %s' 2019-08-24 bpastene@chromium.org devil: Allow flash_devices.py to detect fastbooted devices. Created with: gclient setdep -r src/third_party/catapult@1078fdda6aea The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: None Change-Id: Ic1996df3f6a73955aea592ad673e71021c0f78eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769804Reviewed-by:
-
Yue Zhang authored
Currently, when resetting filter state in TabGroupModelFilter, we clear the original mapping and re-add all the tabs. However, this approach loses the last shown tab id information in a tab group, which leads to some inconsistency. This CL fixes this issue. Bug: 997029 Change-Id: I303c2a0db490ecbdd17939b72478fdb197b62736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767120 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690173}
-
Matt Mueller authored
Bug: 991247 Change-Id: Ia7824c5ee17f67fb28d7e6bfa80b88a52a11e0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754278 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#690172}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I26c2f075085d0f448667058ff2517d4f6a2d41da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769838Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690171}
-
Miyoung Shin authored
This CL converts WakeLockServicePtr in blink and WakeLockServiceRequest in content to the new Mojo types. Bug: 955171, 978694 Change-Id: Ibc38dc3423de29620ad67a7ecd259d6f3cb881fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768096Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#690170}
-
Malay Keshav authored
This patch deletes the fingerprint animation APNG file since it is no longer used and is replaced by a lottie animation. Bug: 976057 Change-Id: I92187e86591f56690d8f15a6b6116a28de5116a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764334 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#690169}
-
Johannes Henkel authored
That is, for messages coming from Blink, perform the surgery there. For messages that come from the browser, perform the surgery in content::DevToolsSession as before. Longer term, we may include the session id prior to serializing the message. But this requires much deeper changes to the bindings etc., so this just moves the computation closer to where it will be eventually. Change-Id: I16efafec72e8077d7aaab6458f5253ddb018fd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734142 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690168}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f4a751866bc..3c6b2e1613c8 git log 2f4a751866bc..3c6b2e1613c8 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 jmadill@chromium.org More improvements to trace logging. 2019-08-23 dongja@google.com Vulkan: Improve cubemap emulation seam handling Created with: gclient setdep -r src/third_party/angle@3c6b2e1613c8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I210f3a9fd11dd2e152058ac132ef3eb8ba80b2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769032Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f75c0e92e6a..4016d1b393a1 git log 7f75c0e92e6a..4016d1b393a1 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 vadimsh@chromium.org [lucicfg] Update to v1.8.3. Created with: gclient setdep -r src/third_party/depot_tools@4016d1b393a1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:986972 Change-Id: Ib93d88bd942f7c8f713888e6c795d8e8fad3159c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769033Reviewed-by:
-
Marijn Kruisselbrink authored
Create FileSystemURL for swap file based on virtual_path and mount_type of original entry, rather than based on path and type. To make things more complicated, it isn't always possible to create the swap file in the same file system as the original file, as the file might be part of a single-file isolated file system. In that case we create a new single-file isolated file system for the swap file. Bug: 993597 Change-Id: Iaf13787ab7d274be91e4d45b6fc7ef5ed666dbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766454 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690165}
-
Yue Zhang authored
Bug: 997192 Change-Id: I5ddfea43dad58d17007eb6f4f50966d4ac7a29ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769799 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Benjamin Beaudry authored
The text direction attribute is now properly set for text runs in PDF. It is inferred by the position of the first and the last characters of a text run. This change includes a pdf-template file (text-direction.in) with RTL text representation used to generate our unit test PDF file. Bug: 985604 Change-Id: If5d82296463331e95c4ded4e5244d65be3fbadfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737019 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690163}
-
Fred Mello authored
This avoids IS_BUNDLE being optimized out by the JVM. Added comments to clarify which config target should be used by other java targets. Note: The changes in this CL were originally uploaded @ 1765654 and patched (fixed srcjar_deps for tests) in this CL. Bug: 996821 Binary-Size: Related to a faulty CL(1762699) that decreased it (same amount). Change-Id: Ide295c69c61b98d7039f5f74fe72d97a88b28cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769516 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#690162}
-
Dan Beam authored
Also, start using assert() in NTP code. This is helpful for compile time typechecking and runtime enforcement. Based on https://crrev.com/c/1763345 by Evan Stade <estade@chromium.org> R=gayane@chromium.org BUG=996209 Change-Id: I6ab3f92e93ae52249bafd722733aa4bb63289930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764794 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#690161}
-
Jeremy Roman authored
Do it in the former (which runs earlier) and merely DCHECK in the latter. Change-Id: I53c0a8a64ec4f2b909de6dd710167d3f8e8aefac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769522Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#690160}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/195bf9a75021..079ace40c74f Created with: gclient setdep -r src-internal@079ace40c74f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9c37962d220f0321998fafc7f095eb8c5f68e672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769751Reviewed-by:
-
Ken Rockot authored
Adds two new methods to SequenceBound: PostTaskWithThisObject(), and ResetWithCallbackAfterDestruction() PostTaskWithThisObject() allows for safe execution of arbitrary logic on the underlying sequence-bound object within its bound sequence. This is especially useful when performing batch operations on an object without having to modify the object's public API just to accommodate SequenceBounds's single-method-invocation Post() API. ResetWithCallbackAfterDestruction() allows a continuation to be run on the bound sequence after destruction of the underlying object is complete. This is at least useful in e.g. tests which may need to synchronize against the destruction of the object. Bug: None Change-Id: I600410b5579e0a0f9307ee6ead0845d549b9c4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768663 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Matt Reynolds authored
The Gamepad object stores button and axis data in fixed-length arrays. It has buttons_length and axes_length members that indicate which items in these arrays contain valid data. NintendoController uses a Gamepad object to hold the most recent button and axis state, but does not initialize or check the buttons_length or axes_length members. This CL modifies NintendoController to avoid reading from these arrays unless they have the expected length. If the length does not match the expected length, the arrays are assumed to be uninitialized. BUG=997072 Change-Id: I376fa2518afbb6c00b055bec3d5ddbbc08d80a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769629Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#690157}
-
Dan Beam authored
R=ehmaldonado@chromium.org,iannucci@chromium.org BUG=997396 Change-Id: Ibf79cffe7c9fcb95be328551dcf00e7f13d1e97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769805 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#690156}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/90e930e2da74..7f75c0e92e6a git log 90e930e2da74..7f75c0e92e6a --date=short --no-merges --format='%ad %ae %s' 2019-08-23 jbudorick@chromium.org owners: fix inline comment support in included files. 2019-08-23 ehmaldonado@chromium.org depot_tools: Fix bug when running both python2 and python3 tests. Created with: gclient setdep -r src/third_party/depot_tools@7f75c0e92e6a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:995474,chromium:984182 Change-Id: I501430b1941b6cc107c012086be729aeac751ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769744Reviewed-by:
-
Matt Mueller authored
CertPathBuilder::cert_path_iter_ is constructed with a pointer to out_result_, so out_result_ must be earlier in the member list to ensure it is constructed before cert_path_iter_ tries to access it. Bug: 997340,991247 Change-Id: I93137a16e0022db00d71b91b6636e42d6f39f2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769701Reviewed-by:
-
Ian Prest authored
The current heuristics always creates a new paragraph whenever the font-size changes, which is undesirable. Simply removing the size check causes many of the existing tests to fail because the size-change is often the only reason that we have multiple paragraphs at all. The problem is our PDF file has too few lines on each page to compute reasonable line & paragraph size thresholds. So this change required changing the heuristics. The new heuristic is as follows: 1. We keep track of the top & bottom of the current line, as weighted averages of the (recent) text boxes on the line. 2. When we encounter a new text box, if it significantly overlaps the top-to-bottom range, it's considered part of the same line. 3. If we are starting a new line, we also check the paragraph threshold to see if we should also start a new paragraph. If the paragraph threshold couldn't be computed (because there weren't enough lines on the page), we compare against the line size. We also introduce the `PDFExtensionAccessibilityTextExtractionTest` test suite. These tests are like the tree-dump tests, but they dump raw text content, split into lines and paragraphs. (Compared to tree-dump tests, this approach allows us to test the kNextOnLine and kPreviousOnLine attributes are correct.) Bug: 985604 Change-Id: Idfce6edfef42580e7fac4d8a7753c82495c15bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743032 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
-
Malay Keshav authored
In an effort to reduce disk usage by animations, this patch replaces an expensive APNG animation file usage with a lottie animation file in OOBE. Bug: 976057 Test: Manually tests this and dependent changes by navigating to OOBE Change-Id: I5965688a4d1c17dd6e32c59ee1b347f0496cfa66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764632 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#690152}
-
Joel Klinghed authored
On Android, PrintManager has a virtual method PdfWritingDone which is implemented by PrintViewManagerBasic which extends PrintViewManagerBase. PdfWritingDone() is called whenever a print job has finished, including if it is cancelled or fails. If the print view manager has an ongoing job and is destroyed then PrintViewManagerBase calls DisconnectFromCurrentPrintJob() from its destructor which can end up calling the now pure virtual function PdfWritingDone() (as we are in destructor of PrintViewManagerBase and PrintViewManagerBasic is already destroyed). Avoid this by calling DisconnectFromCurrentPrintJob() from PrintViewManagerBasic destructor so that any current print job is terminated while PrintViewManagerBasic is still available. Added PrintViewManagerBasicTest that triggers this problem on Android. Bug: 993255 Change-Id: If2b9f177fa9e106751e4d3d16f4ea171c6191131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751244 Commit-Queue: Joel Klinghed <the_jk@opera.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d51a2e48472..34a2b06a63d3 git log 5d51a2e48472..34a2b06a63d3 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 vapier@chromium.org cros lint: upgrade pylint to 1.6 2019-08-23 mmortensen@google.com Update gen/chromite/api/binhost_pb2.py for PrepareDevInstallBinhostUploads. Created with: gclient setdep -r src/third_party/chromite@34a2b06a63d3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I855e7f06ae08baaddbb7d219898268ea4877241e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769742Reviewed-by:
-
