GitLab

- Avoid global variables
  Wrap the whole code with 'main()' function
- Don't use obsolete 'string' module
- Don't add parenthesis to assert.
- Remove trailing whitespace
- Remove unused variable 'saved_by_reusing'
- Remove whitespace around a keyword argument =.

This CL has no behavior changes.

Bug: 838772
Change-Id: Ib79344a4c5a671c24a528ed918156e22b0d2c65d
Reviewed-on: https://chromium-review.googlesource.com/1049407Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556749}

This change introduces BluetoothAdapterWinrt, which will contain an
adapter implementation using Mirosoft UWP BLE APIs. This change merely
provides a skeleton, where each member function is NOTIMPLEMENTED().
Further functionality will be provided in future CLs.

Bug: 579202, 821766
Change-Id: I207e14de292f9d24b7d16710437e0dae839c82ec
Reviewed-on: https://chromium-review.googlesource.com/1046589
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556748}

TBR=ksakamoto@chromium.org

Bug: chromium:840659
Change-Id: Id25d5f8678296cf0e797fc668cdf384e01354433
Reviewed-on: https://chromium-review.googlesource.com/1049645Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556747}

AFAICT, this class is completely unused.

Change-Id: I7c6ddf03e6094515833c34a3550457fd8a6b6471
Reviewed-on: https://chromium-review.googlesource.com/1049027
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#556746}

This CL changes the CSS to align the current time and duration with the
newly-positioned media controls buttons.

Bug: 840255
Change-Id: I1a55eeb032ba8f2b968b8bf04fda96396f573bab
Reviewed-on: https://chromium-review.googlesource.com/1048029Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556745}

TBR=finnur@chromium.org

Bug: 792313
Change-Id: Ia48dbdf710a3898fe1393404402295884d8e9c98
Reviewed-on: https://chromium-review.googlesource.com/1049554Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556744}

From using AtomicString (for 'mask', 'marker-*', 'fill' and 'stroke') or
the string representation of SVGResources ('filter' and 'clip-path'),
convert to using SVGResources.
Add an implementation of SVGResourceClient (SVGElementResourceClient)
and register it with the existing resources. Invalidation code is moved
here. This makes the invalidation code slightly more homogeneous between
the various code-paths.

The new SVGResourceClient implementation is stored in SVGElementRareData
as needed.
The various computed style representations are converted to use the new
StyleSVGResource, which is a ref-counted wrapper around an SVGResource
and its underlying string representation (which is needed for
serialization.) Style building is changed to produce this new wrapper
(rather than an AtomicString.) A helper for serialization is added to
ComputedStyleUtils.
The kHasPendingResources flag is removed since it no longer used, and
the hook in Element is removed.
All LayoutSVGResource* subclasses are changed to take SVGResourceClients
instead of LayoutObjects, and the |clients_| set is removed in favor of
the set in SVGResource.
A bunch of helpers are added for updating (adding/removing) the client
registrations. The various LayoutSVG subclasses are updated to call
these helpers.

TBR=junov@chromium.org

Bug: 769774
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I62418465251532240c4e895e5c4d253ed9e53b9a
Reviewed-on: https://chromium-review.googlesource.com/977965
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556743}

Run python tools/metrics/histograms/update_extension_histograms.py
to fix enums.xml.

I don't believe that these features would have had (much) use, so it
should be safe to fix this.

ACCESSIBILITY_PRIVATE_ONSELECTTOSPEAKSTATECHANGEREQUESTED
was inadvertantly added in http://crosreview.com/1030901,
problem compounded a little in http://crosreview.com/1043666

Change-Id: I9f6b2b52fe97ff4c7bb75f079158d9ae4455d319
Tbr: isherman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1049349Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556742}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 835626
Change-Id: Ie214d9ef7241ab084772010b2a854e50ef051b67
Reviewed-on: https://chromium-review.googlesource.com/1049347Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556741}

When urls are removed from chrome://history, the site-engagement score
is not removed if it reaches zero. This CL fixes the issue as it is not
neccessary to keep a score of zero around.

Bug: 838875
Change-Id: Ia580ee49f2c4df8cda46f33c36b6551580dafef7
Reviewed-on: https://chromium-review.googlesource.com/1046765Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556740}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e3f3bcb2..9ef8a461

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I1c65bbcf6ce40050b917cb288293b9226d1563ab
Reviewed-on: https://chromium-review.googlesource.com/1049367Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556739}

I followed the conventions in chromium.linux at ci.chromium.org.

Bug: chromium:840277
Change-Id: I7dd757c00f6e4450d1070ebc503f0d8cdd6887e4
Reviewed-on: https://chromium-review.googlesource.com/1046565
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556738}

WindowEventObserverManager is a new class that will take care of
all window-related events.

- WindowAndroid is now updated through WebContents, and then
ContentObserverManager to trigger observer events.

- More work have been moved to actual observers (GestureListenerManager,
SelectionPopupController, SelectPopup, etc)

Bug: 598880
Change-Id: Ie4b9b209fe3bf67373fd420799effea210e93e5d
Reviewed-on: https://chromium-review.googlesource.com/1018640
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556737}

The default xterm doesn't provide us with extra fun colors, so update
the default to allow that.  This keeps us in sync w/hterm too.

Bug: 800049
Test: compiled & ran it
Change-Id: I648ec77ab5adc8542d2673848f666e5e8568db8b
Reviewed-on: https://chromium-review.googlesource.com/905264Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556736}

and remove the old Polymer dialogue

Bug: 822504
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I30bf627099d257363bb4cd8177c07fbd147974ec
Reviewed-on: https://chromium-review.googlesource.com/1037043
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556735}

The new setting is in the toolbar behind the gear.
Screenshot: https://imgur.com/a/09myIJH

Bug: 810176
Change-Id: Ifbd2a2bfc6712e2f2415e384c040f5520b1e2347
Reviewed-on: https://chromium-review.googlesource.com/1045180
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556734}

We currently use '@JNINamespace' everywhere in WebRTC for setting the
WebRTC namespace, but it would be cleaner to do this from the build file
and the python script already has support for it, we just need to expose
it.

Bug: webrtc:8278
Change-Id: Ibc0529f353572225f0d677dbf7ab0e5883fa197d
Reviewed-on: https://chromium-review.googlesource.com/1044191Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Magnus Jedvert <magjed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556733}

Using wpt-import in Chromium ae6a05c5.
With Chromium commits locally applied on WPT:
ae6a05c5 "webrtc wpt: pass test in promise_test and async_test"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17155

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley

No-Export: true
Change-Id: Iee13af32481de808478ed3946eb4bea31e038382
Reviewed-on: https://chromium-review.googlesource.com/1049565
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556732}

This reverts commit 8d1dda31.

Reason for revert: Now disabling test on relevant platforms.

Original change's description:
> Revert "Adds a test for basic WebRTC video codec conformance."
>
> This reverts commit 72aef1a4.
>
> Reason for revert: Failing on Win / Mac / Linux bots
>
> Unexpected Failures:
> * external/wpt/webrtc/protocol/video-codecs.html
> * virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.html
>
> WebKit Win7 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/63947
> WebKit Win10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/34576
> WebKit Mac10.10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/46846
> WebKit Mac10.11 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/32883
> WebKit Linux Trusty https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/44403
>
> (It passes on Mac 10.12.)
>
> Original change's description:
> > Adds a test for basic WebRTC video codec conformance.
> >
> > This tests that the browser conforms to RFC 7742, "WebRTC Video
> > Processing and Codec Requrements".
> >
> > It establishes a new subdirectory for protocol-related WebRTC tests.
> >
> > Bug: chromium:839753
> > Change-Id: Ia4795c4532fb74ae76e6a47329a41807479113c5
> > Reviewed-on: https://chromium-review.googlesource.com/1043886
> > Commit-Queue: Harald Alvestrand <hta@chromium.org>
> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#556454}
>
> TBR=mflodman@webrtc.org,hta@chromium.org,foolip@chromium.org
>
> Change-Id: Id3789b69df63d7e41be3573ca1fbb5a07b00e7e7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:839753
> Reviewed-on: https://chromium-review.googlesource.com/1049088
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556645}

TBR=mflodman@webrtc.org,hta@chromium.org,ksakamoto@chromium.org,foolip@chromium.org

Change-Id: I867cf04bfc7cd48afea3b5a26f0af77eef731434
Bug: chromium:839753, chromium:840659
Reviewed-on: https://chromium-review.googlesource.com/1049525Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556731}

My change from here is inappropriate:
https://chromium-review.googlesource.com/c/chromium/src/+/1046966

shlex.split in non-posix mode just splits words in whitespaces,
so '-D"MY_DEFINE=\"MY VALUE\""' is still split in two arguments
'-DMY_DEFINE="MY' and 'VALUE"'. This did not caused problems for me
right away because after joining split_command into one string the
command line happens to be properly quoted.

In fact shlex.split properly splits '-D"MY_DEFINE=\"MY VALUE\""',
we just have to reescape split_command instead of just joining it as
string.

Change-Id: I7cdbf47946d1a114d7c787cf9dee897224f2fc09
Reviewed-on: https://chromium-review.googlesource.com/1049548Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kalugin Alexander <akalugin@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#556730}

Bug: 835784
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id3be7b118eb36749bb65e07d6d96e7c03bc52c1c
Reviewed-on: https://chromium-review.googlesource.com/1049010Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556729}

|WebMemoryCoordinator::OnPurgeMemory| has been only called in |RenderThreadImpl::OnPurgeMemory|,
and |RenderThreadImpl::OnPurgeMemory| is only able to be called by |base::MemoryCoordinatorClient|.
But, if there is no performance degradation, it would be good to purge used memory as much as
possible. |RenderThreadImpl::ReleaseFreeMemory| has been more called than |RenderThreadImpl::OnPurgeMemory|
from some callers. So we can free up more memory if we move |WebMemoryCoordinator::OnPurgeMemory|
from |RenderThreadImpl::OnPurgeMemory| to |RenderThreadImpl::ReleaseFreeMemory|.

TEST: Covered RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeMemory

Bug: None
Change-Id: I225401bcd18f236265305aaf5eaf4b4219d9cde4
Reviewed-on: https://chromium-review.googlesource.com/1049414Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#556728}

The new method will offer a crude way to query about the power state of
connected HDMI CEC capable displays.

BUG=b:78171027

Change-Id: Ic37abea8f300d1d22a80368acbd3f129cc5e0187
Reviewed-on: https://chromium-review.googlesource.com/1042575Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Felix Ekblom <felixe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556727}

The handling of RequestToggleWifi and wifi toggle notification was done
in TrayNetwork, which is a SystemTrayItem. We're going to get rid of
SystemTrayItems as UnifiedSystemTray will replace them, so this should
be a NotificationController.

TEST=WifiToggleNotificationController
BUG=837507

Change-Id: I6693db6df2c8ab2fcf8f7954adcd61a48e00f24d
Reviewed-on: https://chromium-review.googlesource.com/1046289
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556726}

Re-arrange the return statement to fix this.

Bug: 840646
Change-Id: I1c550de4433f59a70ab04b430d3d2c95e87e5d7c
Reviewed-on: https://chromium-review.googlesource.com/1049411Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556725}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 835626
Change-Id: I848da4a1571db55d1bbf4795eaa469ff564a55e2
Reviewed-on: https://chromium-review.googlesource.com/1049416Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556724}

R=mkwst@chromium.org,clamy@chromium.org

Change-Id: I1d32699940108e69b116449309a50fae8e07c1bb
Reviewed-on: https://chromium-review.googlesource.com/1049387Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556723}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 835626
Change-Id: I404db91904dab92834a7efca5a567b2ad66d84e4
Reviewed-on: https://chromium-review.googlesource.com/1049474Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556722}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 835626
Change-Id: Ifd9d394f5cf2f4dd25146e0a0422b7bcd00b4103
Reviewed-on: https://chromium-review.googlesource.com/1049415Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556721}

This change adds a base::Feature for the BLE implementation using WinRT
UWP APIs.

Bug: 579202, 821766
Change-Id: I94d64ce60aff2286b0bcaf98e01b68b44db9bf43
Reviewed-on: https://chromium-review.googlesource.com/1046545Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556720}

An audio::GroupMember::Snooper that records the audio from a GroupMember
on one thread, and re-renders it to the desired output format on another
thread. Since the data flow rates are known to be driven by different
clocks (audio hardware clock versus system clock), the SnooperNode also
uses its resampler to compensate for skew and re-synchronize the audio
going into and out of it.

Bug: 824019
Change-Id: I87d410724fd00f9372232bfffdfbb89ada0b3de8
Reviewed-on: https://chromium-review.googlesource.com/1041657
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556719}

The UMA was added to measure the instances of large images which should
be async decoded, and whether they were on img or css tags. The data on
Android indicates that out of about 20% images which fit the size
requirement, 3% are from css and the rest 17% are img tags.

We don't need to keep tracking this anymore.

R=chrishtr@chromium.org

Bug: 802121
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I168245df6a48f3a74a630639c118925b2ed478cf
Reviewed-on: https://chromium-review.googlesource.com/1045729Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556718}

This is a change suggested by altimin@ in <crrev.com/c/1038944>.

Bug: 826203
Change-Id: Ic4b772834fea28cfcf5ed92e12418e437ca92652
Reviewed-on: https://chromium-review.googlesource.com/1046869Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556717}

It's a duplicate. Use service-account-chromeperf instead.

Bug: 839022
Change-Id: I59cbc9a1306f356375da1d2533bbd5c82a4647f2
Reviewed-on: https://chromium-review.googlesource.com/1043002Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: David Tu <dtu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556716}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5c50bf92e6fb..da3ce5f235a2

$ git log 5c50bf92e..da3ce5f23 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 yunlian add elfutils to host packages.
2018-04-29 reveman Add crosvm to video group.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:701659,chromium:837209


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ief473bca3ca4f12541910fb806f6503a6e8a6905
Reviewed-on: https://chromium-review.googlesource.com/1049275Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556715}

Change-Id: I1b8f6ab60fd5c871e0c119200a01f4ce091fdd7c
Bug: 833826
Test: Manually verified by turning on docked magnifier.
Reviewed-on: https://chromium-review.googlesource.com/1049466Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556714}

Spec: https://html.spec.whatwg.org/multipage/workers.html#dom-workerglobalscope-importscripts

"1. If worker global scope's type is "module", throw a TypeError exception."

Bug: 831420
Change-Id: I6a1976363435596562689988ed39394a3b735779
Reviewed-on: https://chromium-review.googlesource.com/1038926
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556713}

Add a histogram to collect metrics on how often handshake has been confirmed
when connection migration is triggered.

Bug: 790547, 804048
Change-Id: I593b80c1557aba30fbea52297497d9f04b51d61e
Reviewed-on: https://chromium-review.googlesource.com/1036452
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556712}

passes the test argument in promise_test and async_test
so it can be used to add cleanup.
Change done with a jscodeshift codemod that detects
there were no arguments to promise_test (or async_test):

export default function transformer(file, api) {
  const j = api.jscodeshift;
  return j(file.source)
    // .find(j.CallExpression)
    .find(j.CallExpression, {callee: {type: 'Identifier', name: 'promise_test'}})
    .forEach(path => {
        if (path.value.arguments[0].params.length === 0) {
          path.value.arguments[0].params.push(j.identifier('t'));
        }
    })
    .toSource();
};

BUG=836871

Change-Id: Ie7dd7fb0dd8a4da6c4c00f3616fd41d1d47854ef
Reviewed-on: https://chromium-review.googlesource.com/1047674Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556711}

The CL https://crrev.com/c/993761 made a change to stop all screen
capture/share sessions in ScreenTrayItem when one of the sessions is
stopped.

Unfortunately the fix does not work in UnifiedSystemTray as it's done
in SystemTrayItem. Also, the behaviors from the notification stop button
and the tray stop button were different.

This CL moves the logic from ScreenCaptureItem to
ScreenSecurityNotificationController.

Ideally we should fix Screen{Capture,Share}Observer interfaces, or
prevent multiple share sessions in the first place but it is not trivial
as noted in https://crbug.com/826041#c6.

TEST=ScreenCaptureTest,ScreenShareTest
BUG=826041

Change-Id: I3f559b95d99bfd4c04a1241e2e86de2718f1dc29
Reviewed-on: https://chromium-review.googlesource.com/1046287Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556710}