- 22 Jul, 2020 40 commits
-
-
David Bokan authored
Page scale is changed when the user pinch-zooms a page or via parameters controlled by the viewport meta tag. Internally, there are two notions of page scale. A typical page hosted in a main frame will have a |page_scale_factor| that transforms all geometry below the the visual viewport. In this situation, a descendant widget (e.g. an OOPIF) will have its surface in the compositor scaled as a result of the page scale changes in the top-level frame. However, the descendant needs to update its content to reraster at the new scale. We cannot change the |page_scale_factor| inside it as that would scale all the geometry inside (the output of which is already scaled in the compositor). To solve this, nested frame widgets use an |external_page_scale_factor|. This value is used solely to affect the scale used for raster without applying any transforms to its layers. However, some widgets are in a state of being both a main frame and also nested inside a frame hierarchy. Portals and GuestViews(*) are two such widgets. Because it is a main frame and runs on Android, a portaled page may require scaling due to constraints set in the viewport <meta> tag; this scaling must apply to the |page_scale_factor|. That is, we want it to apply independently of the scale in the top-level frame and remain when the portal is activated to become top-level. However, prior to the portal being activated, we do also need to reraster its contents based on the page scale in the embedder. This CL does two things. First, it ensures that nested main frame widgets, like portals and GuestViews, participate in the |external_page_scale_factor| propagation from the main frame, as an OOPIF would. Alone, this change breaks assumptions about the |external_page_scale_factor| and |page_scale_factor| never being used in tandem. Thus, we also update PictureLayerImpl to combine these two values for raster and update DCHECKs in various places to make this a new possibility. (*) GuestViews also have this property but aren't really relevant in this case as they do not support browser native pinch-zoom or scaling. However, this fix applies to GuestViews as well, should they ever stop suppressing pinch-zoom. Bug: 932669 Change-Id: I0be06f577c634f3a752a8f8c2439a284f94472d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284613Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790869}
-
Lan Wei authored
hr-timestamp/input-events.htmlEvent timestamp tests that the received events on the page should be equal to the timestamp provided by the eventSender's recorded last event. But we should deprecate eventSender in the future, and GpuBenchmarking sends events based on the current system time, which cannot be equal to the received events' timestamp. Bug: 1047176 Change-Id: I225dec07b1928ae254d61e8a8384ebfc7dab75e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173421 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790868}
-
arthursonzogni authored
This patch fixes a TODO. A COOP access report is sent when two windows from different virtual browsing context groups tries to access each other. COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697 [8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889 [9/N] this patch. Bug: 1090273 Change-Id: I249183839ee8a5b93b6e8d35a033a99a4942b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310530 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790867}
-
Eugene But authored
marq was added to OWNERS file when stuartmorgan left the team. Since that time marq did not do much of ios/web development and codereviews. Currently ios/web has 3 active owners from 3 different timezones (ajuma, eugenebut, gambard) who regularly do codereviews. marq is still top level owner of //ios/ and can review changes in ios/web if other owners are OOO. Confirmed with mark to remove him from OWNERS, so he does not have to do codereviews. Bug: None Change-Id: I0d2c6cef08c6f05f7d9f1bb5e6f9ab2dca2397f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311055 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#790866}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e3f70cddc88f..19031583c314 2020-07-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6b2bcf62..8d6c555e (790515:790803) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9c21b20b01817b760403d186b141341e4273d0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790865}
-
Prabir Pradhan authored
BUG=None TEST=None Change-Id: I8782a4af6ccbf7f44571826d8dea9c2dc3343d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310976Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790864}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99a565b6..724a04e1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9dcf23eca2a67e0aa3da86735522085b3aa70095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313136Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790863}
-
ckitagawa authored
This CL adds a smoke test for the scaling of paint previews. Bug: 1106035 Change-Id: I70db04a8dd83466f585f9c2949bf923b6bce8740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310893 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790862}
-
W. James MacLean authored
This test is causing a fair amount of flake, disabling. TBR=dbertoni@chromium.org Bug: 1107934 Change-Id: Ieda5264517dcfd69f275379434ca3da9a0649f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313121Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#790861}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01373555fef7..e9ced4f3da51 2020-07-22 tdenniston@google.com Elide inner loop geometry sometimes (toy stroker) 2020-07-22 nigeltao@google.com Flip Skia-uses-Wuffs-v0.3 from opt-in to opt-out 2020-07-22 johnstiles@google.com Simplify GrProcessorSet by removing multiple color/coverage FP support. 2020-07-22 adlai@google.com Reland "Migrate SkImage::makeWithFilter to GrRecordingContext" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ibee4c658ef662aed30f726dc78c8a2fd7480e216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313037Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/75efd91227eb..9e1fc05ef7a2 2020-07-22 vmiklos@collabora.co.uk Add FPDFSignatureObj_GetByteRange() API 2020-07-22 thestig@chromium.org Remove deprecated use_relative_hooks setting from DEPS. 2020-07-22 nigi@chromium.org Enable FPDFAnnotEmbedderTest.RenderMultilineMarkupAnnotWithoutAP for Skia. 2020-07-22 nigi@chromium.org Enable FPDFAnnotEmbedderTest.AddAndSaveUnderlineAnnotation for Skia/SkiaPaths. 2020-07-21 tsepez@chromium.org Split off fxv8_unittest.h from cfx_v8_unittest.h 2020-07-21 dmazzoni@chromium.org Add FPDF_StructElement_GetID and FPDF_StructElement_GetLang 2020-07-21 nigi@chromium.org Enable FPDFEditEmbedderTest.InsertAndRemoveLargeFile for Skia/SkiaPaths. 2020-07-21 nigi@chromium.org Make Skia and SkiaPaths take fill option |aliased_path| into account. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107325 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I29aed166f6154077545ef358d32ce6e8f589f346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313038Reviewed-by:
-
Jose Dapena Paz authored
GCC and libstdc++ reject any const type as a member of std::vector. Bug: 819294 Change-Id: I17b7207097ff1033609273b53f5f0103ef5c63e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310434Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#790858}
-
Adrienne Walker authored
Resolve() can end up freeing WebIDBGetDBNamesCallbacksImpl by throwing a mojo error that deletes the self-owned associated receiver that owns it. So, don't call any other functions after it. As the promise resolver can only resolve/reject once, it is safe to not clear it. Bug: 1106682 Change-Id: Iea943f3c5c1e57adb6ad399baff49522f54d264b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311620 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#790857}
-
Maria Kazinova authored
|has_renderer_ids| is not needed anymore, as iOS forms have renderer ids now on par with other platforms. |has_renderer_ids| was also used on other platforms during the saving/filling redesign (https://crbug.com/831123), but this process is also over and |has_renderer_ids| was set to always equal true. Bug: 1075444 Change-Id: I5bf23f309f12247755227036d3e3314ed5424ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309703Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#790856}
-
Peter Wen authored
Add comments to explain why classpath, baseline, and other args are necessary for linting. Bug: None Change-Id: I8f4a7541df965f8c714032893150e3b2f0fa142d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313096 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790855}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595373454-124f6f7a8fdf3bef9667f80d39ed93302475736e.profdata to chrome-win64-master-1595397501-9bcbb05b12c8b76c3ee561633b2647f61403910d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I01a759fde4a613220e074937e8b0a1cf2215e4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311949Reviewed-by:
-
Mike Jackson authored
Plumbs the display_override field from the manifest through the BMO web apps stack. Changes include: - Adds display_mode_override to the web_app.proto object. - Adds the field to the WebApp class with a virtual function in AppRegistrar to retrieve it. - Save display_mode_override to WebAppDatabase. Explainer: https://github.com/WICG/display-override/blob/master/explainer.m Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Screenshots of chrome://internals/web-app after this change: display_override set: https://imgur.com/a/xa2khSM standalone (no display_override): https://imgur.com/a/IAtU9cC Bug: 1092667 Change-Id: I8f01a42daf6a5ea0aa8d34c901ffdef4ebc92ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299192 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
See go/inclusive-codebase. The following words were replaced: - blacklist - whitelist - dummy - sanity-check - he/she/her/him/her The following words were searched for but not found: - slave - master (Note: still used as branch name for chromeos/assistant/internal, which I'll look at in another commit). - first-class - sane/crazy/insane/cripple - greylist/darklist/lightlist - grandfathered - (black|white|gray|grey) hat - redline - man-in-the-middle - white glove - white label Tests: compiled Bug: b/161801556 Change-Id: I37d96697e38ee171f6df7171061a9ecc075eeca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310846Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790852}
-
Aaron Leventhal authored
Introduce a low-risk workaround for textfields with role=combobox, so that as the user arrows through options, and the text in the textfield changes, the entire field is re-read. The workaround is also only applied when the change is > 1 character, and the caret is at the end. AX-Relnotes: Fix VoiceOver support for google.com search suggestions Bug: 1106933 Change-Id: I860d9556437fa5a555627bc71d24e66634c5ea0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305673 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790851}
-
Majid Valipour authored
This refactoring should not have any functional impact. Change-Id: I2494b9c7171f01d1bf8150a042a9bcc27a67aee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309074Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790850}
-
Maksim Moskvitin authored
This CL applies modern style guides and does minor clean-ups in //components/invalidation/public folder. Bug: 1105388 Change-Id: I20a287a6ff638b1d0eb2ebac76b7940a725a19a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310337Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#790849}
-
Guillaume Jenkins authored
Moves all platform-specific logic in ReportScheduler to a delegate class. A few things to note: - For now, ReportScheduler takes the desktop-specific factory in its constructor because it can't use the base factory until ReportScheduler is moved to components. - Observing the build state is now done by the desktop delegate. To notify ReportScheduler of an update, ReportScheduler passes a callback to its delegate, which the delegate can use to trigger report uploads. For this to work, the ReportTrigger enum had to be made visible to the delegate. - ReportScheduler still has one chrome/browser dependency for the name of the kLastUploadTimestamp pref. This pref name will be moved to components in the next CL. - On Chrome OS, ReportScheduler was being given a specific profile to watch. Because Profile cannot be used in Components, the Profile* must now be passed to the delegate directly. So, on Chrome OS, the ReportSchedulerDesktop delegate is instantiated directly and passed to ReportScheduler, instead of ReportScheduler taking the delegate from the factory. Bug: 1092432 Change-Id: Ia3169410c8ca83151556fed4319db512bc9fc258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303589 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790848}
-
Stepan Khapugin authored
Creates a new scene agent that takes care of the blocking overlay. Bug: 1072408 Change-Id: I8a08e90f5a8846f93da513d4af20787fc9feff33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285223 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Emily Stark authored
This CL increases the hover threshold for simplified domain display from 150ms to 250ms based on dogfood feedback. This threshold is how long the mouse has to hover over the omnibox before the full URL begins expanding. It's meant to prevent spurious expansion while mousing over the omnibox on the way to somewhere else (e.g. tab strip). Bug: 1090393 Change-Id: Ia768320f0557f39bf70cd3c12d588ba4827c14fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311311Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790846}
-
ckitagawa authored
This CL removes the static test data for the PaintPreviewPlayerTest as the test now generates its own test data in order to avoid the risk of a stale SkPicture breaking a Skia roll. This test was disabled in http://crrev.com/c/2300277 and was replaced with auto-generated data in http://crrev.com/c/2308137 so these files are no longer needed. Bug: 1106035 Change-Id: Id723d4f376cafad3bc73f6107085acaad51fdada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310895 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e9817f52a1a2..94beb690c019 2020-07-22 szuend@chromium.org Use 'forward_variables_from' in 'devtools_module' 2020-07-22 changhaohan@chromium.org Improve rendering performance in the Computed Styles pane 2020-07-22 jacktfranklin@chromium.org Migrate `data_grid` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093263,chromium:1100148,chromium:1101738,chromium:1106251 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibb4b7950f1de3217471b3e1c24c9a2054722d439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312876Reviewed-by:
-
arthursonzogni authored
This implements the following: 1. New RenderFrameHost are put in their own new virtual browsing context group. 2. When a new window is created, the initial empty document inherits from its opener. 3. When a navigation happens, the virtual browsing context group is inherited from the previous document, except if the COOP/COEP/Origin states require a new virtual browsing context group to be used. COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697 [8/N] this patch. Bug: 1090273 Change-Id: Ic9c2d5a17e222743c1f498ff30bb6564980bec27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275889 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Thomas Tellier authored
Bug: 1015746 Change-Id: I233dc7d47317aae300fd9acd195f8e90652641f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312837Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#790842}
-
Jérôme Lebel authored
Adding to view components in the sign-in view: |xxx.adjustsFontForContentSizeCategory = YES| Fixed: 1107875 Change-Id: I54004499301be7e9b5e1cd705dc9f43d8b714b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312639 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Sebastien Lalancette authored
By adding a scopedHandler to handle both the "Show QR Code" and "Dismiss QR Code" commands, we'll be able to reuse the ActivityServices component to share URLs outside from the BrowserCoordinator. Bug: 1102890 Change-Id: I830b3ed7a1a44cc1e4242c666bc3427d05aaf471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284101 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Simeon Anfinrud authored
Used to integrate Slices-based settings UI for Cast on Android TV. Bug: Internal b/144395218 Test: build cast_shell_apk Change-Id: Ic0a4802f9e41e6a9b9a1933c58f589fe71e8bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310872 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit dc2ffb3b. Reason for revert: Failing on several bots. See https://crbug.com/1108344 Original change's description: > [Autofill Assistant] Added test for image resource identifiers > > We used to have a test like this, but it was disabled some time ago due > to hard-to-reproduce issues on devices with older API levels. This is > a more focused test specifically for vector graphics. I have tried this > on a variety of (emulated) devices and API levels and could not > reproduce, so I'm going ahead and submit this test. > > Tested on: > - Generic phone 21 > - Nexus 5x 23 > - Nexus 5x 25 > - Nexus 5x 26 > - Pixel 3 XL 28 > - Pixel 3 30 > > Bug: b/145043394 > Change-Id: I6d27eeda3e2ef7c2e29d5364838349664a83eb49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310991 > Commit-Queue: Marian Fechete <marianfe@google.com> > Reviewed-by: Marian Fechete <marianfe@google.com> > Auto-Submit: Clemens Arbesser <arbesser@google.com> > Cr-Commit-Position: refs/heads/master@{#790785} TBR=arbesser@google.com,marianfe@google.com Change-Id: Ibb4d1ef13a9368356d9e472bb3919ca69e07b78a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/145043394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312641Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790838}
-
Clark DuVall authored
This is a reland of e5f83907 This was not actually the culprit that broke perf bots. The bots turned green before the revert had landed: https://ci.chromium.org/p/chrome/builders/ci/android-pixel2_webview-perf/12328 Original change's description: > Fix WebView shell APK not being found on perf bots > > All of these APKs are now defined unconditionally since > http://crrev.com/c/2173947 and http://crrev.com/c/2281021. It no longer > makes sense to guard these with public_android_sdk, and this seemed to > be causing some flakiness where the bots sometimes could not find the > correct APKs. > > Bug: 1105096 > Change-Id: I3f73acc277ebf7b40e9f93385a3a097b768662a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310356 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790569} TBR=johnchen@chromium.org Bug: 1105096 Change-Id: I2a3089ec00ca5c20def79cc48bc087738c104462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312856Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790837}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c1278acd658..e3f70cddc88f 2020-07-22 courtneyfe@chromium.org set perfetto flag to default value of false If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If63bf7c4e127f2e9f59f0f769eee03a871e86a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312535Reviewed-by:
-
Miguel Casas authored
V4L2 structs are often composed of unions of other structs. When such a struct is initialized as an aggregate with a braced-init-list, only the first union member is actually initialized. If posterior union members are larger, they are left partially initialized. This CL adds a presubmit for users to avoid such ={} initialization. Bug: b:153935975 Change-Id: If52bb7b670fe5914e864a6d840f6064cae8b7baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300274 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#790835}
-
Mustaq Ahmed authored
The user activation was added as part of crbug.com/765266 to be able to differentiate "pasting through right-click context" from a JS initiated paste command. Since UAv2 shipped in M72 the transient user activation from a right click event is now available to the ExecuteCommand by design. So we don't need the synthetic activation. Fixed: 1103842 Change-Id: Ied918ff20451ee5efb2dc11e97601ab9c95ad9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311142 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#790834}
-
Michael Lippautz authored
Will be used in a Finch experiment. Bug: chromium:1107901 Change-Id: I68ea04be372ef2a931519c6d63916ed6001d7a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312816Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790833}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e1eb168a544..01373555fef7 2020-07-22 adlai@google.com Remove GrContext variant of SkImage::isValid If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Id98b3d8c87b2f6643b4008fc01abb28c050c31ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312530Reviewed-by:
-
Wojciech Dzierżanowski authored
This gathers some pieces of MediaSession-specific logic spread across WebMediaPlayer implementations and moves them to MediaSession-specific code area. The aim is for the WMPD interface to be for conveying generic media-related events (metadata changes, play/pause, etc.), and for MediaSessionController to be the consumer of these events that is able to process them to make MediaSession-specific decisions (activate/suspend MediaSession when unmuted playback starts, etc.). This also enables future changes like teaching MediaSessionController to activate MediaSession upon entering Picture-in-Picture even if media is not playing. Bug: 1091203 Change-Id: I8b2d29c0fe40f8ef80234fe832c4fd50878c1f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308423 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790831}
-
Eric Willigers authored
On Android, the Share Service now checks that the Web Share API is enabled by feature policy. Remaining work: crbug.com/1108163 Generate FeaturePolicyFeature enum from mojom TBR=rouslan@chromium.org Bug: 1079104 Change-Id: I9e9061e06f4cd39ebbc3ab33a8a1fc44e2ae366d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306124Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790830}
-
