- 01 Apr, 2020 40 commits
-
-
Ben Mason authored
Bring chrome://terms in line with https://www.google.com/chrome/terms/ Bug: 1060545 Change-Id: I823aa5bdf51c55488777ebb18406b79f9887e6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120046Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#755585}
-
Greg Guterman authored
Make mb validate checks for internal consistency between mb_config.pyl and mb_config_bucket.pyl Also regenerate mb_config_buckets.pyl using https://drive.google.com/a/google.com/file/d/1rypZZRxxMdyPZ8zAYt0GanfRkAHgtsYe/view?usp=sharing Bug: 1062141 Change-Id: I865a2ca64b26dc7a6c7415b4a6f87a439b0e5241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108793 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#755584}
-
Matt Jones authored
Since the previous patch is producing consistently green bots (https://crrev.com/c/2128790), this patch applies the same logic and shares common code into a new helper method. Bug: 947694, 882003 Change-Id: I7c8fdcf30e9fefd2e36e6f693b57cbcafba530b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130810 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#755583}
-
Kyle Horimoto authored
(1) Change flag exposing settings to disabled by default, and move it to //chromeos where it is accessible from //ui. (2) Adjust preference values to fall back to legacy values when flag is disabled. (3) Update setting name strings in input_device_factory_evdev.cc. (4) Address various nits from the previous CL. Bug: 836258, 1063412 Change-Id: Ibda0b2693c6c04fb951c21a7dea9506c54f8f3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123035Reviewed-by:Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#755582}
-
Sam Sebree authored
This change uses the native_theme_base controls properties to set correct dark mode styling for meter controls. Bug: 929098 Change-Id: Iabb9859ef122c24d3b6cfbab172e23f1154161bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130888Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#755581}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4085.6-1584959535-benchmark-83.0.4097.3-r1 to 83-4091.0-1585565910-benchmark-83.0.4099.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I184c8a83f1662c223510214e47da5688ef0eae8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755580}
-
Devlin Cronin authored
These tests exercised that, when the user assigned an extension the same accelerator as used by the bookmark command (Ctrl | Cmd + D), the native controls like the bookmark star and "Bookmark this tab" menu items did not trigger the extension. Since the code to ever override these commands is gone, we can remove the tests (which were disabled anyway). Bug: 448956, 894447 Change-Id: I478002870833455b7a0a6822b3441c12783c4102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132847Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755579}
-
Andrew Xu authored
ScrollableShelfView::Layout() is triggered asynchronously by Invalidate- Layout(). As a result, the code which transforms the clip rectangle to shelf container view's coordinates is executed before Layout() which updates the bounds of shelf container view. This CL solves the problem by moving the code related to coordinate transform into Layout() right after the place where shelf container view's bounds are set. Bug: 1065030 Change-Id: I8a2a26e05be80b93cbc6d226056cfde18d8de4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132842Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755578}
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Bug: 1049056 Change-Id: If5804e673aa1f7fe0bc24af92768323557dedde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117553Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#755577}
-
Lei Zhang authored
Give variables and a test case clearer names. Change-Id: Ic8274dabbf88bbaae4d471b4c12018b4f4f683bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131846 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#755576}
-
Hailey Wang authored
Change the initial value to the LastActiveTime of the web content. Used inside BackgroundTabLoadingPolicy in order to determine if a PageNode should be loaded. Bug: 1059341 Change-Id: Ieea245eaaebc3cb71ccaad6bb31695df160e6813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132526 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#755575}
-
Dave Tapuska authored
maxlength-number.html sends multiple keys in one call. Iterate across the keys string to send more than one character. Move another test that uses the actions API to the unsupported section. Change-Id: Ic0eb9467e171933deaf6b389bd0cf701ce24f0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132679Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#755574}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e4572046..16df139b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaaf4bfafa1d7850481d40f4c5755ff711fe231b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132430Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755573}
-
Ahmed Mehfooz authored
Bug: 1065079 Change-Id: Iac3b64ea8246b044fd07aed41c2bce2cdf59b616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125429 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#755572}
-
Olivier Tilloy authored
This adds logic to the linux_package template to generate a snap package from build artifacts, similar to what is done for .deb and .rpm packages. BUG=1055026 Change-Id: I59cd411eac5c97120404ed6680739b8ac803e129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058888Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#755571}
-
Nikita Podguzov authored
This is needed to reuse this information for MaxSheetsAllowed policy which is introduced in follow-up CL. Bug: 1061077 Change-Id: I51cd80c1be6d2ed2a734b47b720a318836779602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129552Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#755570}
-
Johann authored
The new wrapper changed the behavior slightly during the migration. The wrapper defines a default ContextDestroyed method. If some other cleanup method tries to access receiver_ it may crash. This change reverts to the pre-migration behavior. BUG=chromium:1049056 Change-Id: I9feafcf13c732664e8b10b6cba1a5258e3012e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131803Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#755569}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 83-4085.6-1585564150-benchmark-83.0.4097.3-r1 to 83-4085.6-1585564150-benchmark-83.0.4099.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7d5e16660abb9503909bb4a3a3a637d07e10d803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133153Reviewed-by:
-
Trent Begin authored
This class will be used to collect and aggregate network information for feedback, device telemetry, and debugging. Bug: chromium:1057739 Test: unit_tests --gtest_filter=NetworkHealthTest.* Change-Id: I6d3181e96dbe8f51ed698f3b5838cc7f79bd355a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117159 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#755567}
-
George Steel authored
Fix ComputedStyleUtils::ValueForTransformOperation so that Z translate parameters are correctly unzoomed. Also unzoom the reciprocal-length parameters in transformation matrices. Add comments explaining which coefficients need to be unzoomed and how. Add regression tests. Bug: 1057307 Change-Id: Ibfc8f5bfdaae33515bfa23b557c2e79327cc3fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128936 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#755566}
-
Peter Wen authored
Using md5check speeds up the build by not re-compiling resources if its dependencies have not changed. Shaves 5 seconds off for Chrome Java Signature Change (77s -> 72s). Shaves 12 seconds off for Base Java Signature Change (174s -> 162s). Makes md5_check more robust by including all args as: - input_paths if it's a path and already in GN inputs - depfile_deps if it's a path and not already in GN inputs - output_paths if it's a path and already in GN outputs - input_strings for everything else. The compile_resources step now runs when android_channel is changed. Bug: 906803, 1066594 Change-Id: If4ed96cdd914f18e131a274d683d998e22c71090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132288 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#755565}
-
Dave Tapuska authored
The WebVTT failures are due to padding being off. BUG=1012242 Change-Id: I28fb040b120ed38276f8dcbb2782764c461ac3ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132936 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Matt Jones authored
Tests still flake occasionally post https://crrev.com/c/2128790, this patch does the following: - Dispatches events to the control container directly. - Accesses the toolbar via the ToolbarManager rather than by lookup. - Increases the number of "move" events sent to the view. Bug: 813584 Change-Id: I71f15318354842bd0462d478941e92c35e0e7728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132846Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4085.6-1584956258-benchmark-83.0.4097.3-r1 to 83-4091.0-1585562740-benchmark-83.0.4099.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie5e8624153411943684cb65e933bf1f40104f7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133147Reviewed-by:
-
Peter Kasting authored
Setting up TestScreen too early causes problems with AshTestHelper, which I'll be enabling soon for ChromeViewsTestBase. This restricts it to only be alive for a narrow window of time. Bug: none Change-Id: If6d3b059175cf438a3df00469a8406d24a66b5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132971 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#755561}
-
Peter Kasting authored
The registry only actually uses the latter, so this expresses its dependency more cleary and would allow for easier dependency injection. Bug: none Change-Id: Ibf569055c0afa753c1eee87529c5f977477c59b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132937 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#755560}
-
Guido Urdaneta authored
This CL introduces underlying source and sink classes for encoded audio. The source allows sending frames from WebRTC to a ReadableStream. The sink allows sending frames from a WritableStream to WebRTC. Unit tests in https://chromium-review.googlesource.com/c/chromium/src/+/2132258 Bug: 1052765 Change-Id: Ie9083ad92b0bbabc177c284f0bf482b7bc1555b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132133Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#755559}
-
Mark Schillaci authored
This CL disables AccessibiliEvent throttling, and disables the AccessibilityNodeInfo caching on Android. This CL leaves all the code in place but does not leverage it so that we know M83 will be cut without regressions. We can then revert this change and land them in M84 or later. Change-Id: I405e712431a4b114ab4bebe7924bb7e75d98e989 RelNotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132927 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#755558}
-
Lei Zhang authored
Change-Id: I2839601358a8d3b97778d89463a9c9dab6ac2af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129894Reviewed-by:
-
danakj authored
The test_runner is part of content/shell/renderer. Move the shared constant that the browser side wants to use out to content/shell/common/web_test/web_test_constants. Because the common/web_test code is a separate build target now, we can have the test_runner and content_shell_lib both depend on it. R=avi@chromium.org Bug: 866140 Change-Id: Ifcc484108e2982284d78977a0c70f24565c7dc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132837Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#755556}
-
Aaron Leventhal authored
If anything tries to advance or rewind the document lifecycle during ProcessUpdates(), a DCHECK will activate providing a stack leading to the exact cause. Bug: None Change-Id: Ib913e4878b24ebfb1154806793910ea95cf4258a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132606Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0d258401. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" 4f79553f "CookieStore: Add wpt for path behavior" 5954f48b "[css-flexbox] Move canvas-dynamic-change.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I87c14ff71b77ace080b9857275c9aea23202c560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132428Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755554}
-
Antonio Gomes authored
BUG=1063749 R=cbiesinger@chromium.org Change-Id: Id12f61879857b18eef099acdcb7bee2d3741850e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132986Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#755553}
-
Guido Urdaneta authored
This class implements the WebRTC interface for encoded audio insertable streams. It allows receiving encoded frames from WebRTC (e.g., from the encoder or depacketizer) and writing encoded frames back to WebRTC (e.g., to the packetizer or decoder). Bug: 1052765 Change-Id: I548defd3b6abc020a11add797ef7708d9d81f054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132208Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
John Budorick authored
Change-Id: I61205e4a5a80405f8570691fc2c28ac3a0c228ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132593Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#755551}
-
Lei Zhang authored
Printers usually have at least 1 paper size. Add one for this test case and make sure it gets parsed correctly. Since there are now 3 paper sizes to check, also refactor the checking code into VerifyPaper(). In VerifyPaper(), simplify the base::Value API usage. Change-Id: Ib5f101b1eb92cfc79d8dee9c19479be2d1d1ded0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131794 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Garrett Beaty authored
This will simplify the process of updating the main consoles on branch day. Bug: 922150 Change-Id: Iee6c7a10bb05c60c65a5bf3ca9027b8837c4b3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128242 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#755549}
-
Oriol Brufau authored
Before r747669, both explicit and implicit named lines were stored in NamedGridColumnLines and NamedGridRowLines. But that patch moved the implicit ones into their own ImplicitNamedGridColumnLines and ImplicitNamedGridRowLines fields. However, LayoutGrid::NamedGridLinesDefinitionDidChange was not updated to also look at the new fields. Therefore, a dynamic change in grid-template-areas might not force the grid items to be placed again. BUG=1066679 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-007.html Change-Id: I4b6ff2de1f1c13f985b146169f39283613defc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132397Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#755548}
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@chromium.org Change-Id: I698cdd287a0da0d7eefee5343c8595a985844c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132431 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Mike Reed authored
These no longer appear in the skia src tree. Change-Id: If5702b671ca5910905b5e685e02ef8624e254734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132832Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#755546}
-
