GitLab

BUG=563793
R=ikilpatrick@chromium.org

Review URL: https://codereview.chromium.org/2391893004 .

Cr-Commit-Position: refs/heads/master@{#422937}

BUG=none
R=einbinder, dgozman

Review-Url: https://codereview.chromium.org/2387003004
Cr-Commit-Position: refs/heads/master@{#422936}

Only used by SVGAnimateElement.

BUG=641437

Review-Url: https://codereview.chromium.org/2394583002
Cr-Commit-Position: refs/heads/master@{#422935}

BUG=

Review-Url: https://codereview.chromium.org/2389073003
Cr-Commit-Position: refs/heads/master@{#422934}

ClientOnPageFinishedTest#testCalledAfterError is flaky.

BUG=652577

Review-Url: https://codereview.chromium.org/2397533002
Cr-Commit-Position: refs/heads/master@{#422933}

Also default 'false' for shouldAggregateLogForTapSuppression and isConditionSatisfiedForAggregateLogging

BUG=642897

Review-Url: https://codereview.chromium.org/2386413002
Cr-Commit-Position: refs/heads/master@{#422932}

BUG=

Review-Url: https://codereview.chromium.org/2393533002
Cr-Commit-Position: refs/heads/master@{#422931}

Records false if we haven't received a swap ack for more
than 8 seconds. Otherwise, records true.

BUG=602486
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2258253002
Cr-Commit-Position: refs/heads/master@{#422930}

The decoder blithely passed any old 16-bit code unit through, in
violation of the Encoding standard. Surrogate pairs should go through
unscathed:

  [ ... 0xD800 0xDC00 ... ] => [ ... U+D800 U+DC00 ... ]

But cases like these should result in replacement characters:

  [ ... 0xD800 ... ] => [ ... U+FFFD ... ]
  [ ... 0xDC00 ... ] => [ ... U+FFFD ... ]
  [ ... 0xDC00 0xD800 ... ] => [ ... U+FFFD U+FFFD ... ]

This aligns Chrome's behavior with Firefox and Edge.

Note that flushing at the end of a stream remains a special case.
Streams terminating in the above sequences will not get replacements
emitted (current behavior). In addition, a lead surrogate appearing at
the end of a stream will now not be emitted, matching other browsers.

BUG=368904
R=jshin@chromium.org,foolip@chromium.org

Review-Url: https://codereview.chromium.org/2379333003
Cr-Commit-Position: refs/heads/master@{#422929}

BUG=none

Review-Url: https://codereview.chromium.org/2385793003
Cr-Commit-Position: refs/heads/master@{#422928}

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2376743002
Cr-Commit-Position: refs/heads/master@{#422927}

This adds functionality to clear the previews black list on the IO
thread and the UI thread. Further this exposes other black list calls on
the UI thread.

BUG=639087

Review-Url: https://codereview.chromium.org/2387823002
Cr-Commit-Position: refs/heads/master@{#422926}

The traits impl was depending on the wrong generator target,
leading to potential build flag.

BUG=652779
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2392903003
Cr-Commit-Position: refs/heads/master@{#422925}

Review-Url: https://codereview.chromium.org/2391593003
Cr-Commit-Position: refs/heads/master@{#422924}

This creates a LayoutNG virtual test suite for fast/block/margin-collapse path and switches to use "Skip" instead of "Failure" to mark tests that LayoutNG doesn't support at this moment.

BUG=635619

Review-Url: https://codereview.chromium.org/2396583002
Cr-Commit-Position: refs/heads/master@{#422923}

If onAllDownloadItemsRetrieved() has already been called, return
early rather than repopulating lists.

BUG=652650

Review-Url: https://codereview.chromium.org/2391053002
Cr-Commit-Position: refs/heads/master@{#422922}

BUG=649815

Review-Url: https://codereview.chromium.org/2383243002
Cr-Commit-Position: refs/heads/master@{#422921}

BUG=563793

Review-Url: https://codereview.chromium.org/2389253002
Cr-Commit-Position: refs/heads/master@{#422920}

TESTS=chrome_elf_unittests: NtRegistryTest*
BUG=641169
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2345913003
Cr-Commit-Position: refs/heads/master@{#422919}

BUG=650710

Review-Url: https://codereview.chromium.org/2389113003
Cr-Commit-Position: refs/heads/master@{#422918}

Previously we used containingBlock() as the default flipped blocks
container in LayoutBox::topLeftLocation(). This was incorrect for
table rows and table cells whose locations and topLeftLocations
should be relative to the containing section.

This fixes layout tests about table row/cells in vertical writing
mode for slimmingPaintInvalidation.

BUG=652392

Review-Url: https://codereview.chromium.org/2392503003
Cr-Commit-Position: refs/heads/master@{#422917}

BUG=635596

Review-Url: https://codereview.chromium.org/2390863002
Cr-Commit-Position: refs/heads/master@{#422916}

Key point of the implementation:
  * We want to apply 2 commands but only push 1 undo entry.

Solution:
  1. Introduce empty wrapper command |DragAndDropCommand| and
     apply first
  2. Apply |DeleteSelectionCommand| for |deleteByDrag|
  3. Apply |ReplaceSelectionCommand| for |insertFromDrop|

The wrapper command in 1. won't create undo entry by itself, but will
act as a catcher and combine the following 2 commands into a single
undo entry.

--- After CL behavior

* Event order: (See [1])
  1. 'drop'
  2. 'beforeinput' InputType=|deleteByDrag|
  3. (DOM update for deletion)
  4. 'input' InputType=|deleteByDrag|
  5. 'beforeinput' InputType=|insertFromDrop|
  6. (DOM update for insertion)
  7. 'input' InputType=|insertFromDrop|
  8. 'dragend'

* Canceling 'beforeinput' will only prevent DOM update for current
  'beforeinput', and won't affect remaining events.
e.g. Cancelling 'deleteByDrag' won't affect 'insertFromDrop'

* |dataTransfer| field:
  1. NULL for |deleteByDrag|
  2. Readonly |dataTransfer| for |insertFromDrop|

* Undo entry:
  1. Creates a single undo entry for Drag&Drop, if no JS-triggered DOM mutation happened in between
  2. Otherwise creates 2 separate undo entries

For more detailed behavior please refer to LayoutTest.

[1] Event order for |deleteByDrag| and |insertFromDrop|:
https://github.com/w3c/input-events/issues/24#issuecomment-249153755

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

BUG=652393

Review-Url: https://codereview.chromium.org/2374743002
Cr-Commit-Position: refs/heads/master@{#422915}

There's a race between page resize and devtools emulation disabling
which can change the root layer transform scale.  If a commit occurs
after the page resize but before the scale, then layers end up picking
the wrong scale, and if they have will-change on them then they will
not change again after the root layer transform scale.

This scale isn't really part of the page or under the author's control,
and so will-change should be ignored when devtools changes the scale
and content should always be rerastered and the ideal scale.

This patch implements that behavior by plumbing a flag all the way from
the devtools scale change to LayerTreeHost which then then resets the
raster scale on all the picture layers after commit.

BUG=630979
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2390923002
Cr-Commit-Position: refs/heads/master@{#422914}

Follow-up to post-vommit comment in:
https://codereview.chromium.org/2388293002/

TBR=senorblanco@chromium.org
BUG=652126

Review-Url: https://codereview.chromium.org/2393493003
Cr-Commit-Position: refs/heads/master@{#422913}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/04593858..18233f57

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2397493002
Cr-Commit-Position: refs/heads/master@{#422912}

Whitelists the metricsPrivate.getIsCrashReportingEnabled() extension API
function separately from the rest of the metricsPrivate API.

This should prompt developers to get an OWNERS review for new usages of
getIsCrashReportingEnabled(). It's implemented as a feature whitelist instead of
a permission whitelist so that existing uses will continue to work. To that end,
also whitelists all extensions that are already whitelisted for the
metricsPrivate permission as a starting point.

BUG=374199,647397

Review-Url: https://codereview.chromium.org/2387793002
Cr-Commit-Position: refs/heads/master@{#422911}

For Android JellyBean and older, there was a bug in
MappedByteBufferAdapter that caused ByteBuffer#rewind() to not be
propagated to the underlying buffer, causing buffer underflow when
the same buffer was read completely again to save the state. Fix is
to manually read the buffer rather than rely on rewind/remaining.

BUG=635744

Review-Url: https://codereview.chromium.org/2395493002
Cr-Commit-Position: refs/heads/master@{#422910}

Fix a data race introduced by https://codereview.chromium.org/2378663006

BUG=

Review-Url: https://codereview.chromium.org/2391093002
Cr-Commit-Position: refs/heads/master@{#422909}

It's not something we want permanently set via about:flags. We'll enable it for
debugging via net-internals.

BUG=344544
TEST=passing --disable-async-dns to chrome does nothing anymore
R=thestig@chromium.org,mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2388783003
Cr-Commit-Position: refs/heads/master@{#422908}

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996

Review-Url: https://codereview.chromium.org/2387503002
Cr-Commit-Position: refs/heads/master@{#422907}

This allows NativeMessageProcessHost to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.

BUG=645114

Review-Url: https://codereview.chromium.org/2384163003
Cr-Commit-Position: refs/heads/master@{#422906}

Otherwise, argument-dependent lookup will (given that the proper set
of headers are included at the same time) identify WebRTC's
rtc::MakeCheckOpString as an alternative to logging::MakeCheckOpString
if one of the function arguments are from the rtc:: namespace, making
the call ambiguous.

This was the reason why https://codereview.webrtc.org/2384693002 had
to be reverted.

Review-Url: https://codereview.chromium.org/2384263004
Cr-Commit-Position: refs/heads/master@{#422905}

This CL changes the direction of the back arrow in rtl languages. In ltr
we go forward to the right and back to the left. That is reversed in rtl
and this CL makes the icon match the language flow.

BUG=586579
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2389123003
Cr-Commit-Position: refs/heads/master@{#422904}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9d498f565765..da2a4758cdc2

$ git log 9d498f565..da2a4758c --date=short --no-merges --format='%ad %ae %s'
2016-10-04 achuith Fix a bug in credentials parsing, add tests.
2016-10-04 petrcermak [tracing] Change breakdown view dimension upon pressing left/right arrows
2016-10-04 dproy Add a method to access renderer with largest pid

BUG=651249

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2391073002
Cr-Commit-Position: refs/heads/master@{#422903}

Originally written by xunjieli in
https://codereview.chromium.org/2360813003/.

Review-Url: https://codereview.chromium.org/2393543003
Cr-Commit-Position: refs/heads/master@{#422902}

Instead of storing borrowed pointer to TestRunner, WebFrameTestClient
and WebViewTestClient can both obtain the same pointer via another (also
borrowed) pointer they already have - one to WebViewTestProxyBase.

Less fields to worry about (e.g. wrt lifetime management) is good.
In the long-term we also should remove |delegate_| field from
WebFrameTestClient (responsible for UaF in https://crbug.com/606594).

BUG=595089

Review-Url: https://codereview.chromium.org/2386683002
Cr-Commit-Position: refs/heads/master@{#422901}

Straightforward conversion, no surprises.

Also changes some (re-)initialization details of RPHI. Namely:

* The mojom::RouteProvider and mojom::Renderer associated
interface proxies are acquired immediately upon Channel creation,
before pausing the Channel. This avoids an issue where one of
these interface requests could be lazily acquired during Channel
pause, blocking a subsequent message on that interface which
should be sent immediately while the Channel is unpaused.
See https://goo.gl/ot0S32 for some explanation of this behavior.

* Any cached associated interface proxies are reset in
ProcessDied() rather than Init(), per nasko@'s suggestion.
This clarifies that they are per-process state.

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2383853003
Cr-Commit-Position: refs/heads/master@{#422900}

This CL adds the said settings to the idl (capabilities
and settings) and wires them through image_capture.mojom
to its implementations in Fake and Linux/CrOs video capture
device.

BUG=650676
TEST= manually using [1] and a Logitech C920,
result equivalent to e.g. guvcview.

[1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture --use-fake-ui-for-media-stream https://rawgit.com/Miguelao/demos/master/imagecapture.html

Review-Url: https://codereview.chromium.org/2387303002
Cr-Commit-Position: refs/heads/master@{#422899}

https://chromium.googlesource.com/skia.git/+log/779582280747..3fdf52cf389d

$ git log 779582280..3fdf52cf3 --date=short --no-merges --format='%ad %ae %s'
2016-10-04 caryclark fix fuzz with null check
2016-10-04 mtklein Make all SkRasterPipeline stages stock stages in SkOpts.
2016-10-04 liyuqian Resubmit issue 2221103002 to fix the iOS build by declaring the flag in SkCommonFlags.h
2016-10-04 csmartdalton Move GPU fences into sk_gpu_test
2016-10-04 stephana Revert of Analytic AntiAlias for Convex Shapes (patchset #14 id:260001 of https://codereview.chromium.org/2221103002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/2390363002
Cr-Commit-Position: refs/heads/master@{#422898}