- 21 Nov, 2011 16 commits
-
-
jar@chromium.org authored
Histograms are found via a locked function, and then placed into static atomic variables. They allow for racing with a second thread that emplants the same pointer into that atomic variable. r=dhollowa BUG=104776 Review URL: http://codereview.chromium.org/8491067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110885 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
R=mpcomplete@chromium.org BUG=chromium-os:23194 TEST=Run browser_tests --gtest_filter="ExtensionApiTest.InputImeApiBasic" Review URL: http://codereview.chromium.org/8558013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110884 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=101600,94925 TEST=none TBR=satorux Review URL: http://codereview.chromium.org/8480033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110883 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
BUG=None TEST=None R=noelallen@google.com Review URL: http://codereview.chromium.org/8473005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110881 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110529 Review URL: http://codereview.chromium.org/8502024 TBR=rch@chromium.org Review URL: http://codereview.chromium.org/8609006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110880 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110529 Review URL: http://codereview.chromium.org/8502024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110879 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
BUG=None TEST=None R=noelallen@google.com TBR Review URL: http://codereview.chromium.org/8610002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110877 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Adds necessary pieces to get the WebKit compositor working with compositor_unittests target on Mac. Required gyp build flags are: 'use_aura': 1, 'use_webkit_compositor': 1, 'use_skia': 1, BUG=104390, 104555 TEST=compositor_unittests --gtest_filter=LayerWithRealCompositorTest.* passes and shows correct visual results. Review URL: http://codereview.chromium.org/8486020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110875 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
BUG=none TEST=trybots Review URL: http://codereview.chromium.org/8473009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110874 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110873 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
Dropping large binaries. Redo of http://crrev.com/110822 checkdeps + checkperms have now beep updated in preparation. BUG=None TEST=None R=noelallen@google.com TBR git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110872 0039d316-1c4b-4281-b951-d872f2087c98
-
bashi@chromium.org authored
Uses new getFontFamilyForCharacters() WebKit Chromium API so that Chromium can pass bold and italic property. This will fix issue 32109. No behavior change at this time. The CL will work after the fix of WebKit side is completed. The WebKit bug entry is https://bugs.webkit.org/show_bug.cgi?id=38701. BUG=32109 TEST=compiled. Review URL: http://codereview.chromium.org/8590028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110871 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
This will allow a verbatim migration of the nacl sdk into chrome. BUG=None TEST=None R=noelallen@google.com Review URL: http://codereview.chromium.org/8609003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110870 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
can land verbatim. BUG=None TEST=None R=noelallen@google.com Review URL: http://codereview.chromium.org/8568043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110869 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=101600,94925 TEST=none TBR=stevenjb Review URL: http://codereview.chromium.org/8609002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110868 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Also remove a few unused strings. BUG=101600,94925 TEST=none Review URL: http://codereview.chromium.org/8608001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110867 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Nov, 2011 13 commits
-
-
file:///mihaip@chromium.org authored
BUG=104547 R=aa@chromium.org Review URL: http://codereview.chromium.org/8470004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110866 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
it possible to test APIs that require user gestures and other input events. BUG=none TEST=none Review URL: http://codereview.chromium.org/8413021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110865 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8228009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110861 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110860 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Move some arrow anchor/location logic; etc. Expose non-const |chevron|, and |location_entry_view|. Add a setter for BubbleDelegateView's |anchor_view|. BUG=98323 TEST=ExtensionInstalledBubbles function as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110824 Review URL: http://codereview.chromium.org/8590047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110858 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
TBR=rdsmith BUG=104886 TEST=None Review URL: http://codereview.chromium.org/8470011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110857 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
The goal was to avoid alloc/free during the thread teardown callback, and this CL provides a very simple and clear implementation. r=rtenneti BUG=104696 Review URL: http://codereview.chromium.org/8597017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110856 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
I'm reverting because this test is consistently failing on all bots. Remember that it's the committer's responsibility to ensure that his change lands safely. ====================================================================== FAIL: special_tabs.SpecialTabsTest.testAboutAppCacheTab: "Test App Cache tab to confirm about page populates caches." ---------------------------------------------------------------------- Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/special_tabs.py", line 317, in testAboutAppCacheTab self._VerifyAppCacheInternals() File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/special_tabs.py", line 207, in _VerifyAppCacheInternals []) File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/test_utils.py", line 232, in StringContentCheck msg='"%s" missing from content.' % s) AssertionError: "Manifest" missing from content. BUG=102517 TEST=none Review URL: http://codereview.chromium.org/8533018 TBR=dyu@chromium.org Review URL: http://codereview.chromium.org/8473011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110855 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
is throttled. BUG=98498 TEST=*ExtensionSettings* Review URL: http://codereview.chromium.org/8491033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110854 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This is instead of http://codereview.chromium.org/8566054/ and should allow the refactoring code to proceed. BUG=chromium:103427 TEST=See issue Review URL: http://codereview.chromium.org/8550003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110853 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
local quota) by adding a WriteOptions flag to Set and using FORCE when writing from sync. Otherwise sync will effectively be permanently disabled when the settings are over quota. BUG=103514 TEST=*ExtensionSetting* (unit_tests, browser_tests) Review URL: http://codereview.chromium.org/8587025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110852 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
timezone change. BUG=104667 TEST=none R=ben@chromium.org,stevenjb@chromium.org TBR=ben@chromium.org,stevenjb@chromium.org Review URL: http://codereview.chromium.org/8605006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110851 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
wrong InputMethodDescriptor. In this test case we end up in MaybeChangeCurrentKeyboardLayout with value.string_list_value.size() == 5 so that we don't reset current_input_method_ and instead pass in current_input_method_, which is empty. Another possible fix is to change the if to be !value.string_list_value.empty(). Not sure if that's the right fix though. BUG=104674 TEST=none R=yusukes@chromium.org Review URL: http://codereview.chromium.org/8561025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110850 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Nov, 2011 11 commits
-
-
adinardi@chromium.org authored
The new tab button mouse enter is handled in the tab strip controller to ensure an accurate hover indication (the button is an odd shape). XIB Changes: Update the new tab button's cell class to the new NewTabButtonCell. BUG=104326 TEST=Hover over the new tab button, it should light up. Hover slightly to the right of it, it shouldn't light up. Review URL: http://codereview.chromium.org/8566036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110849 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/8536054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110848 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
BUG=none TEST=trybots Review URL: http://codereview.chromium.org/8604010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110847 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=98716 Review URL: http://codereview.chromium.org/8470006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110846 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110845 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This fixes time() on Linux 3.1. BUG=104084 TEST=trybots Review URL: http://codereview.chromium.org/8536053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110844 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=104872 TEST=none TBR=shess Review URL: http://codereview.chromium.org/8500011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110843 0039d316-1c4b-4281-b951-d872f2087c98
-
ahendrickson@chromium.org authored
These will be used to resume hash generation when a download is interrupted and later resumed. BUG=None. TEST=SecureHashTest.TestSerialization Review URL: http://codereview.chromium.org/8588057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110842 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
BUG=none TEST=trybot runs Review URL: http://codereview.chromium.org/8570021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110841 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110838 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
ObserverListThreadSafe was overkill since there was only two threads involved, and only one observer. Add MessageLoop member variables to various test classes that need it (ObserverListThreadSafe had a hack that made it unnecessary before.) BUG=103732 TEST=Start with a clean profile and set up sync. about:profiler shouldn't show ObserverListThreadSafe::Notify calls with sync threads anymore. Review URL: http://codereview.chromium.org/8586014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110836 0039d316-1c4b-4281-b951-d872f2087c98
-