GitLab

Also, a small update to the documentation in idl file.

BUG=408772
TEST=Checked out server2/preview.py

Review URL: https://codereview.chromium.org/933353002

Cr-Commit-Position: refs/heads/master@{#317133}

The import status column currently shows up everywhere, which is undesirable.  Disable it until this problem is fixed.

BUG=460135

Review URL: https://codereview.chromium.org/943693003

Cr-Commit-Position: refs/heads/master@{#317132}

* Makes use make_scoped_ptr() when possible (less typing/noise).

Entries found with the following command line:

$ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)' ui/

BUG=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/922923002

Cr-Commit-Position: refs/heads/master@{#317131}

Change the RendererScheduler's |ShouldYieldForHighPriorityWork| query
to always return true if we are awaiting touchstart response, regardless
of whether any high-priority work has been queued. This should facilitate
more aggressive yielding immediately after touchstart, reducing the risk
of long-running tasks interrupting dispatch of the subsequent touchmove.

BUG=452956

Review URL: https://codereview.chromium.org/933293004

Cr-Commit-Position: refs/heads/master@{#317130}

The main construct provided is the DataReductionProxyTextContext, which
is able to create real/test/mock versions of several DRP classes, and is
also able to link them together. This simplifies many of the unit tests
by removing boilerplate construction of dependencies.

BUG=452773

Review URL: https://codereview.chromium.org/932993002

Cr-Commit-Position: refs/heads/master@{#317129}

Among other things, this silences a compiler warning.

BUG=none
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/913193004

Cr-Commit-Position: refs/heads/master@{#317128}

Previous attempts:
https://codereview.chromium.org/880063002
https://codereview.chromium.org/895623003/
https://codereview.chromium.org/890013006/
https://codereview.chromium.org/907973004/
https://codereview.chromium.org/940763002/

Marks all flakey tests as MANUAL. The tests appear to be taking longer than the timeout on buildbots.

BUG=460150
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/943693002

Cr-Commit-Position: refs/heads/master@{#317127}

We don't need it anymore since WebURLLoaderImpl is in content.

This is based on https://codereview.chromium.org/226273005.

BUG=338338

Review URL: https://codereview.chromium.org/938933002

Cr-Commit-Position: refs/heads/master@{#317126}

Use the fetcher to populate the single website preferences screen if it is given only a url string.

This also enables showing the Notifications settings by default.

Based on Sasha's old downstream patch.

BUG=430345

Review URL: https://codereview.chromium.org/927763003

Cr-Commit-Position: refs/heads/master@{#317125}

I didn't intend to remove all the remnants of NPAPI from the webapp. I only made the minimum change needed to removed the inapplicable daemon states.

BUG=453172

Review URL: https://codereview.chromium.org/897313005

Cr-Commit-Position: refs/heads/master@{#317124}

Maintaining the test expectations across two very different
implementations is challenging at best. Separate the test expectations.

BUG=371442

Review URL: https://codereview.chromium.org/929793007

Cr-Commit-Position: refs/heads/master@{#317123}

AutoLaunchCanceled() is called much more frequently than
we've thought. We need to record the UMA action only when
the auto launch is actually canceled by the user.

BUG=459848
R=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/938723003

Cr-Commit-Position: refs/heads/master@{#317122}

BUG=460000

Review URL: https://codereview.chromium.org/943713002

Cr-Commit-Position: refs/heads/master@{#317121}

NaCl and V8 have more complicated requirements for handling architectures
than GN could previously handle. This CL reworks things to meet their
needs.

NaCl occasionally has the need to be able to override build_cpu_arch. This
comes up when they want to use a 32-bit host toolchain (i.e., build
32-bit "host" objects) on a 64-bit kernel. In addition, it is conceivable
that other projects will need this functionality on systems capable of
building for running programs for multiple architectures (any system
that can run both 32-bit and 64-bit binaries), and there is no way that
GN can always correctly guess which arch to use by default.

V8 has the need to be able to run a host toolchain that knows what the
requested target cpu_arch is; we can not use the existing "cpu_arch" for
this because that needs to be the cpu_arch of the current toolchain.
The concrete example is running a host binary on Linux x86 that needs to
get specific flags to target arm (rather than x86), for example. We could
solve this in the build configs by passing custom variables across the
toolchain, but this suggests that we should have a general solution to
track these things, which is what this CL does.

This CL introduces two new predefined variables -- target_cpu and
target_os -- and renames cpu_arch and os to to 'current_cpu' and
'current_os', and renames build_cpu_arch and build_os to
host_cpu and host_os for consistency.

current_cpu and target_cpu default to the same value as
host_cpu, and current_os and target_os default to the same value
as host_os.

Any of these variables is (and should be) overridable on the command line
or in a build config file. We want them to be overridable because (a) it's conceivable
that some projects might always want fixed values for target_os and
target_cpu_arch regardless of what platform GN is running on, and (b) we might
want to set the values based on other values (i.e., have target_cpu_arch
default to "arm" if target_os == "android").

Due to the renaming of "os" and "cpu_arch", this CL is likely to break any and
all existing project builds; projects will need to update their build configs when
rolling in the new binary.

R=brettw@chromium.org
BUG=344767

Review URL: https://codereview.chromium.org/914873002

Cr-Commit-Position: refs/heads/master@{#317120}

Pull web-animations-js into third-party via the third_party/polymer/reproduce.sh script. Add necessary third_party bits.

R=cpu, dzhioev
BUG=424574

Review URL: https://codereview.chromium.org/917523002

Cr-Commit-Position: refs/heads/master@{#317119}

policy_component doesn't need to depend on autofill_core_browser. Also
added dependency on gfx_geometry in favicon_base. policy_component was
failing to compile without it.

BUG=458581

Review URL: https://codereview.chromium.org/926093002

Cr-Commit-Position: refs/heads/master@{#317118}

The component updater now only uses bsdiff so courgete diffs no longer have to forwards and backwards compatible, since Chrome always ships the correct version of the courgette patcher with the courgette diff.

However, bsdiff generated diffs still have to be version compatible.

This CL adds a test for the forwards compatible case.

BUG=459505

Review URL: https://codereview.chromium.org/918403003

Cr-Commit-Position: refs/heads/master@{#317117}

BUG=459773

Review URL: https://codereview.chromium.org/932703006

Cr-Commit-Position: refs/heads/master@{#317116}

This is redundant with the UpdateDrawProperties that happens during
CommitComplete.  One pixel test was amusingly changing draw properties
after the commit and update, so modify it to do the update earlier.

Review URL: https://codereview.chromium.org/935143002

Cr-Commit-Position: refs/heads/master@{#317115}

This recently came up on our mailing list, and isn't quite obvious.

R=sbc@chromium.org
BUG= none

Review URL: https://codereview.chromium.org/940503003

Cr-Commit-Position: refs/heads/master@{#317114}

The issue involved a discrepancy between sizes specified in logical versus physical pixels. See https://codereview.chromium.org/939443002/ for an explanation on a very similar bugfix, which this CL utilizes.

BUG=459266

Review URL: https://codereview.chromium.org/934303003

Cr-Commit-Position: refs/heads/master@{#317113}

This CL creates two subclasses of FastNavigationProfileExtender:
CookieProfileExtender and HistoryProfilerExtender. The former performs up to
500 navigations, with the goal of filling up the Cookie Database but not
overfilling it (which is possible, unfortunately). The latter performs a large
number ~20,000 navigations to URIs pointing at the local file system to fill up
the History Database.

The run these profile extenders, this CL adds the class LargeProfileCreator.
This new class intentionally contains minimal logic, since the existing
profile_creator.py file is pretty hacky, and the goal is to eventually move
away from it entirely.

BUG=442546

Review URL: https://codereview.chromium.org/914253005

Cr-Commit-Position: refs/heads/master@{#317112}

net: a batch of manual HSTS updates.
Cr-Commit-Position: refs/heads/master@{#317111}

BUG=448030

Review URL: https://codereview.chromium.org/831173005

Cr-Commit-Position: refs/heads/master@{#317110}

Also, fixed variable names to comply with style guide.

BUG=459426

Review URL: https://codereview.chromium.org/939083003

Cr-Commit-Position: refs/heads/master@{#317109}

BUG=401439

Review URL: https://codereview.chromium.org/933423002

Cr-Commit-Position: refs/heads/master@{#317108}

The main thread calculates needed render surfaces, but doesn't have all
of the information that it needs.  In particular, it may not know that
one of its twin layers on the pending or active tree still has an
unserviced copy output request that will live through the commit and
activation, and thus that twin will still need a render surface.

As render surface calculations will probably move to the compositor
thread, rather than adding in complicated tracking and counting of
outstanding copy requests to Layer and request callbacks, instead
just add some logic to check if there are remaining copy output requests
during commit and activation and take that into consideration when
setting the output surface.

This also reverts commit 1e447ad6,
which was clearly legit as it caught this mistake.

BUG=457217

Review URL: https://codereview.chromium.org/935193002

Cr-Commit-Position: refs/heads/master@{#317107}

Previously, creating a TraceValue would store the associated trace_data in
memory and defer serialization until needed. In this CL, the trace_data is
serialized right away into a temporary file to prevent it from being stored in
memory.

BUG=457385

Review URL: https://codereview.chromium.org/920523002

Cr-Commit-Position: refs/heads/master@{#317106}

Revert of Add Autofill to the <webview> chrome://chrome-signin page (patchset #12 id:340001 of https://codereview.chromium.org/866523002/)

Reason for revert:
Introduced crashes in ManagePasswordsUIController::OnPasswordSubmitted:(

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2742.0.2309.0%27%20AND%20custom_data.ChromeCrashProto.channel%3D%27canary%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27ManagePasswordsUIController%3A%3AOnPasswordSubmitted%27

Original issue's description:
> Add Autofill to the <webview> chrome://chrome-signin page
>
> The change in the chrome_autofill_client.cc is needed to enable the autofill popup on
> Mac.
>
> BUG=447938
> TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username
> with an incorrect password. After the password error appears, you should be able
> to autofill that username.
>
> Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285
> Cr-Commit-Position: refs/heads/master@{#314889}
>
> Committed: https://crrev.com/e6d3ca36ec225b0e13e385318c6c4f35fad4ca47
> Cr-Commit-Position: refs/heads/master@{#316899}

TBR=estade@chromium.org,fsamuel@chromium.org,lazyboy@chromium.org,vabr@chromium.org,engedy@chromium.org,jww@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447938

Review URL: https://codereview.chromium.org/944513002

Cr-Commit-Position: refs/heads/master@{#317105}

Summary of changes available at:
https://chromium.googlesource.com/chromium/third_party/ffmpeg/+log/2e38ab8..d4b1674

BUG=459114

Review URL: https://codereview.chromium.org/919663003

Cr-Commit-Position: refs/heads/master@{#317104}

two_button_menu_item was added in https://codereview.chromium.org/608283004
but it is not used anymore due to menu button removal from the menu popup.

four_button_menu_item was also added to support menu button inside the menu
popup.

BUG=None

Review URL: https://codereview.chromium.org/934353003

Cr-Commit-Position: refs/heads/master@{#317103}

In enhanced bookmark UI, we still showed the partner bookmark node
in the side drawer even if it's deleted.

BUG=460122

Review URL: https://codereview.chromium.org/941733002

Cr-Commit-Position: refs/heads/master@{#317102}

BUG=460137
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/936603005

Cr-Commit-Position: refs/heads/master@{#317101}

Just a small update to the baked-in config for mail.google.com.

BUG=

Review URL: https://codereview.chromium.org/945443002

Cr-Commit-Position: refs/heads/master@{#317100}

Revert of Fix Presentation API mocks: do not eagerly drop clients. (patchset #2 id:20001 of https://codereview.chromium.org/938033002/)

Reason for revert:
This change appears to be causing failures in running layout tests ('webkit_tests' step) of Windows 7 and Linux debug builds. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/1363 or http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9658 .

Original issue's description:
> Fix Presentation API mocks: do not drop eagerly drop clients.
>
> BUG=412331
>
> Committed: https://crrev.com/4ff204b8d2637af0abd8a05485e5941af8ef4271
> Cr-Commit-Position: refs/heads/master@{#317057}

TBR=mkwst@chromium.org,avayvod@chromium.org,mlamouri@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=412331

Review URL: https://codereview.chromium.org/940783003

Cr-Commit-Position: refs/heads/master@{#317099}

This causes Chrome to show a scary infobar when either of these flags is used,
in order to discourage their use in production. They are intended for Chromium
development only.

BUG=454504

Review URL: https://codereview.chromium.org/928593004

Cr-Commit-Position: refs/heads/master@{#317098}

Key IDs and keys used in JSON data should be encoded base64url,
not just base64 with trailing = removed.

BUG=459834
TEST=new tests pass

Review URL: https://codereview.chromium.org/934423002

Cr-Commit-Position: refs/heads/master@{#317097}

bookmark_index.cc, bookmark_model.cc and bookmark_utils.cc all uses
functions from base_i18n.

Review URL: https://codereview.chromium.org/938003002

Cr-Commit-Position: refs/heads/master@{#317096}

Disable now notifications extension in component loader if launcher field trial is running (ChromeOS only)

BUG=460164

Review URL: https://codereview.chromium.org/936203002

Cr-Commit-Position: refs/heads/master@{#317095}

This updates to the following revision: bad2a08db205 (2015-02-17 17:53 +0000)

It includes changes from revision 97c40a737bda (2014-11-21 04:28 +0100) to
revision bad2a08db205 (2015-02-17 17:53 +0000), listed at
http://hg.mozilla.org/mozilla-central/log/bad2a08db205/netwerk/dns/effective_tld_names.dat

R=pkasting@chromium.org
BUG=37436

Review URL: https://codereview.chromium.org/923713005

Cr-Commit-Position: refs/heads/master@{#317094}