GitLab

debugging.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/330030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30252 0039d316-1c4b-4281-b951-d872f2087c98

2 sec for the history results to be returned (displaying the
thumbnails).  Work around this by giving extra time to the test.

BUG=25949

Review URL: http://codereview.chromium.org/339029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30249 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25913
TBR=dank
Review URL: http://codereview.chromium.org/343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30247 0039d316-1c4b-4281-b951-d872f2087c98

I think this may increase the popularity and usability of our tools.
Review URL: http://codereview.chromium.org/343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30246 0039d316-1c4b-4281-b951-d872f2087c98

Loosen RFC 1738 compliance check to allow underscores where we already allowed hyphens, to match real-world needs.

I don't believe further loosening will be required but that data will hopefully be coming soon.  In the meantime people are asking for this fix.

BUG=25714
TEST=Entring "a_b.com" in the omnibox should default to navigate, not search
Review URL: http://codereview.chromium.org/339017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30245 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30244 0039d316-1c4b-4281-b951-d872f2087c98

CID=127
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/304009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30243 0039d316-1c4b-4281-b951-d872f2087c98

(This is in preparation for a very large reworking of BrowserThemeProvider).

BUG=http://crbug.com/21121

Review URL: http://codereview.chromium.org/338027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25948
TEST=With a suitably recent KSR, mess up the update server URL in the ticket,
     and verify that the update status line in the About box shows the gray
     icon with "update server not available" after attempting to check for
     an update.
Review URL: http://codereview.chromium.org/344002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/333034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30239 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/339028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30238 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/329038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30237 0039d316-1c4b-4281-b951-d872f2087c98

change: https://bugs.webkit.org/show_bug.cgi?id=30785

Patch by: Kelly Norton (knorton@google.com)

TEST=create extension, register for events, verify that they fire
BUG=none

Review URL: http://codereview.chromium.org/339016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30236 0039d316-1c4b-4281-b951-d872f2087c98

it will be picked up first. This is how scons was setup.  This is important for initializing swiftshader.
Review URL: http://codereview.chromium.org/331002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30235 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/329030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30234 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rolandsteiner
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/338045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30233 0039d316-1c4b-4281-b951-d872f2087c98

R=yaar
BUG=25898,25899,25900,25901,
TEST=none

Review URL: http://codereview.chromium.org/338041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30232 0039d316-1c4b-4281-b951-d872f2087c98

This is hard to test since this bug could only cause a very rare cache
collision.

R=eroman
BUG=25939
TEST=none

Review URL: http://codereview.chromium.org/338046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30231 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Preferences-->Under the Hood. Click on downloads path, don't get awkward blue focus ring.

Review URL: http://codereview.chromium.org/330028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30230 0039d316-1c4b-4281-b951-d872f2087c98

Actually copy the autofill data into the FormFieldValues vector.  Fixes a regression caused by r29913.

BUG=25874
TEST=none
Review URL: http://codereview.chromium.org/338047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25855,25945
TEST=valgrind should report no leaks caused by media_bench itself

Review URL: http://codereview.chromium.org/332038


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23907
TEST=Using ratchet + clank theme, go to NTP while bookmark bar is off so you see a floating bar. Maximize the window. It should look right.

Review URL: http://codereview.chromium.org/329022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24085

Review URL: http://codereview.chromium.org/332039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/338048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30224 0039d316-1c4b-4281-b951-d872f2087c98

GPUPluginObject sends event to client process when its window is resized.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/344001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30223 0039d316-1c4b-4281-b951-d872f2087c98

chrome/tools/build/mac.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/334049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30222 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/333051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30221 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=13770
Review URL: http://codereview.chromium.org/339024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30220 0039d316-1c4b-4281-b951-d872f2087c98

This changes the details text from gray to black. It also persists in the preferences the state of devMode (whether the developer tools are showing). Lastly, it adds a fade/slide effect on page elements which are shown in devMode.

BUG=25471

Review URL: http://codereview.chromium.org/329018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25708
TEST=Visual inspection. See bug.

Review URL: http://codereview.chromium.org/329028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30218 0039d316-1c4b-4281-b951-d872f2087c98

Fixes bug introduced in r28333, where we were checking if path.empty() instead of !PathExists(path).
In addition makes background page load check.

BUG=24041
TEST=Try loading extension with content script that doesn't exist on disk, but is listed in manifest.

Review URL: http://codereview.chromium.org/335037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30217 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/341001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30216 0039d316-1c4b-4281-b951-d872f2087c98

Remove -clearRecentStatus which really tied KeystoneGlue too closely to
AboutWindowController.  If KeystoneGlue ever wound up with any other clients,
this relationship would have been harmful.  AboutWindowController now
maintains a static variable to handle what -clearRecentStatus had been used
for.

Remove -releaseDefaultKeystoneGlue, which was only intended to be used for
testing, as a workaround for test flake.  The test flake has been removed.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/333049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30215 0039d316-1c4b-4281-b951-d872f2087c98

with GNOME HIG.

BUG=18076
TEST=Compile and see label

Original patch by Ramkumar Ramachandra <artagnon@gmail.com> at
http://codereview.chromium.org/338015/show

Review URL: http://codereview.chromium.org/333052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30214 0039d316-1c4b-4281-b951-d872f2087c98

structure rather than using several variables.  Added a stub
DestroyRendererContext function.  Updates the test to work with
the changes.

Review URL: http://codereview.chromium.org/322003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30213 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/338002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30212 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/337043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30211 0039d316-1c4b-4281-b951-d872f2087c98

BUG=TEST=none

Review URL: http://codereview.chromium.org/334029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25788
TEST=See bug

Review URL: http://codereview.chromium.org/337040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30209 0039d316-1c4b-4281-b951-d872f2087c98

Also includes a unit test fix.
BUG=21908

TEST=Control-click on the bookmark bar, either on an existing folder
or on the blank area and choose "Add Folder..." from the contextual
menu. A sheet will drop down from the bookmark bar asking for the name
of the folder to add. The edit field will be populated with the
proposed name 'New folder'. ('New folder' will be appropriately
localized.)


Review URL: http://codereview.chromium.org/329031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30207 0039d316-1c4b-4281-b951-d872f2087c98