- 29 Jan, 2018 40 commits
-
-
Tien-Ren Chen authored
Previously composited clip-path are applied multiple times, and can be applied in the wrong order. This CL makes it so that composited clip-path is always and only painted in the mask layer. BUG=792280,792311 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4544c1709e98ca70996655e2e4bbbdc8fc7bd78a Reviewed-on: https://chromium-review.googlesource.com/858299 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532650}
-
Alexander Timin authored
Bail out early when a condition in the switch is fulfilled. This does not change behaviour due to RemoveTaskObserver being no-op when the task observer is not present in the list. R=thakis@chromium.org Bug: 177475 Change-Id: Ibc7772c79f8a8c8a1d63a997dabe1efda5d3a7bd Reviewed-on: https://chromium-review.googlesource.com/891187Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532649}
-
Bret Sepulveda authored
This was done previously, but the virtual/mouseevent_fractional version was missed. Also marking them flaky only on Win 7, as per the original report. TBR=alexclarke@chromium.org Bug: 784909 Change-Id: Iaa7ad21c750acedf179a9da0dcf686c65bf7300f Reviewed-on: https://chromium-review.googlesource.com/891979Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#532648}
-
Jinsuk Kim authored
WebContents manages PopupZoomer (tap diambiguation) via WebContentsUserData. To make the migration possible, split the class into |TapDisambiguator| that is actually managed via WCUD, and |PopupZoomer| is now a pure UI part implementing the popup view inheriting android.view.View. Bug: 789000 Change-Id: Icf36cf3075c0d79f642b585f7a1f8fc7150e8025 Reviewed-on: https://chromium-review.googlesource.com/872132Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#532647}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id6548d65c07bfa7217c16b6ce31c6ecb534622d5 Reviewed-on: https://chromium-review.googlesource.com/890053Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#532646}
-
Jason Chase authored
There is a fuzzer for parsing of origin trial tokens. In bug 802377, we discovered that fuzzer was generating tokens > 500KB in size. This was apparently causing sporadic timeouts in the fuzzer. The token generation and parsing logic can support valid tokens of such large sizes. Realistically, there's no need for such large tokens. In the token contents, the origin is only portion that is user-supplied. While there is no specified limit on the size of URLs or domains, there do seem to be practical limits. This CL limits token payloads to 4KB in size. That allows for the origin to be ~4KB in size, which is 2x some practical limits for URLs. Bug: 802377 Change-Id: I80c31dcd6d0e02afe9cbc1c53479fea3b5821751 Reviewed-on: https://chromium-review.googlesource.com/886822 Commit-Queue: Jason Chase <chasej@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#532645}
-
Troy Hildebrandt authored
Bug: 805509 Change-Id: Iff8178c0bc707da7c33b38f940cf6ca3fa19f994 Reviewed-on: https://chromium-review.googlesource.com/887293 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532644}
-
Penny MacNeil authored
- Log all blocked or allowed attempts. - Export API to drain log, and to register for log notification. - New tests. BUG=769590 TEST=chrome_elf_unittests.exe, Whitelist* Change-Id: I4f1ec911efbe3eada231aa36b0fadceb3756521e Reviewed-on: https://chromium-review.googlesource.com/847894 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#532643}
-
Bret Sepulveda authored
This reverts commit 009da37a. Reason for revert: The new test is flaky on iPhone 6s. Example failures: https://ci.chromium.org/buildbot/chromium.mac/ios-simulator/28895 https://ci.chromium.org/buildbot/chromium.mac/ios-simulator/28892 Original change's description: > More integration tests for autofill in //ios/web_view. > > One test that verifies fetching, filling, and clearing. > > Bug: 778764 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Icc484e63fc0787bdfcedca95a15528111e4d7dcb > Reviewed-on: https://chromium-review.googlesource.com/841342 > Commit-Queue: John Wu <jzw@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532462} TBR=eugenebut@chromium.org,jzw@chromium.org Change-Id: I2b994d4b5592ca84f0c77f2621ae894f4d52a36b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778764 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/892118Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#532642}
-
Theresa authored
BUG=806899 Change-Id: I6a5f1156fca2e8aa0b3726f69e9a1f6d40c0357c Reviewed-on: https://chromium-review.googlesource.com/891418Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532641}
-
Christian Fremerey authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=806440 This CL adds a null check to prevent a NullPointerException. Bug: 806440 Change-Id: I7106de9d1a9bbdfa3dd0bdb3fbfd3315d611f8d2 Reviewed-on: https://chromium-review.googlesource.com/891810 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#532640}
-
Mohamed Heikal authored
Currently ExternalNavigationDelegateImpl tries to LoadUrl async. However at the time of the call the tab may be in the process of closing and native may no longer be available causing a crash. This cl adds a TabObserver to ExternalNavigationDelegateImpl and checks if the tab is closed before trying to load the url. Bug: 662877 Change-Id: I280f9ed1af11177b6efb84221f25a9786856f9a2 Reviewed-on: https://chromium-review.googlesource.com/889704Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532639}
-
Steve Kobes authored
The updated expectations were generated with the try-flag tool, documented at http://bit.ly/flag-try-jobs. The flag try job's test results are at http://crrev.com/c/794897. The spv175 tests are no longer skipped, as they seem to be passing. Bug: 711468 Change-Id: Ie9e8addc75dbcc428d234039afb02956e731383b Reviewed-on: https://chromium-review.googlesource.com/891645Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#532638}
-
Sunny Sachanandani authored
Receiving an invalid child window handle is most likely due to a race between the gpu process destroying the child window and the browser receving SetChildSurface. There's not a strong argument to crash the gpu process in this case. This is high volume on stable and polluting other crash data. R=piman BUG=782359 Change-Id: If463462b0a15778513236013a8d31c833840c3ab Reviewed-on: https://chromium-review.googlesource.com/891566Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#532637}
-
Tarun Bansal authored
quality when it matches the typical quality of the network Bug: 806949 Change-Id: I02c8db315200e7ab28f72a0627015be15d8cfc4e Reviewed-on: https://chromium-review.googlesource.com/890859Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532636}
-
Nico Weber authored
This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 177475 Change-Id: I004e612b6ab4ad45c43eb618f93a682cadbdebd3 Reviewed-on: https://chromium-review.googlesource.com/891480Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532635}
-
Matthew Jones authored
BUG=805938 Change-Id: Idd9c8c1945ace56192c11bbc94eb657a17cd26ee Reviewed-on: https://chromium-review.googlesource.com/887718 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#532634}
-
Misha Efimov authored
Bug: 803922 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7b3320bea9e37afbab78e0f0d686f0a873b0f5c9 Reviewed-on: https://chromium-review.googlesource.com/876447Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#532633}
-
erikchen authored
The information already exists in the AllocationContext, and the plumbing already exists from supporting type_name for PartitionAlloc. This CL just hooks up the two pieces. This CL also adds escaping for type_name. Bug: 758739 Change-Id: Ie3c0e07730f7fba8dda6efa7be5c06b422cbf648 Reviewed-on: https://chromium-review.googlesource.com/889880 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#532632}
-
Nico Weber authored
This CL was uploaded by git cl split. R=delphick@chromium.org Bug: 177475 Change-Id: Ibe368c7c16b12efb290f1ebfd12bd9a5a1aa8bac Reviewed-on: https://chromium-review.googlesource.com/891886 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#532631}
-
Nico Weber authored
This CL was uploaded by git cl split. R=pkalinnikov@chromium.org Bug: 177475 Change-Id: I476fc29fb162f6a3f147f9c8fb9b93801e7df84a Reviewed-on: https://chromium-review.googlesource.com/891880Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532630}
-
Nico Weber authored
This CL was uploaded by git cl split. R=anthonyvd@chromium.org Bug: 177475 Change-Id: Ief31154059327447aefb6b6639e0db3ca91895cb Reviewed-on: https://chromium-review.googlesource.com/891742Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532629}
-
Nico Weber authored
This CL was uploaded by git cl split. R=csharrison@chromium.org Bug: 177475 Change-Id: Ia80655945af8c8c53561a7dbe5658a04f2572499 Reviewed-on: https://chromium-review.googlesource.com/891883Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532628}
-
James Wallace-Lee authored
This CL adds the --cc-check-damage-early flag. If the flag is enabled, an additional call to HasDamage is made in LayerTreeHostImpl::WillBeginImplFrame. If that check returns false, we can abort the frame early, which on WebView prevents the compositor from needlessly drawing the frame. Bug: 687695 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iaae6749b40b09762b2ac581f784a7e6937d20229 Reviewed-on: https://chromium-review.googlesource.com/767851Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#532627}
-
Geoff Lang authored
Resizing to zero causes the emulated default framebuffer to be incomplete leading to a context loss. Match the validation of the validating command buffer and add an assertion that the offscreen framebuffer is never resized to zero. BUG=804433 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If8563a8adee0730207c486ffa0823624a4a5cdec Reviewed-on: https://chromium-review.googlesource.com/891558Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532626}
-
Mirko Bonadei authored
//testing:gmock_mutant depends on //base (which uses C++14) and this breaks the WebRTC build (which is pinning C++11). The dependency has been introduced with: https://chromium-review.googlesource.com/c/chromium/src/+/848466 The easiest fix is to pull //testing:gmock_mutant in //testing/gmock only when building with Chromium. Bug: 806952 Change-Id: I1137dbb7dcb404a613dc9a37bb51d2b6c941c793 Reviewed-on: https://chromium-review.googlesource.com/888698 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#532625}
-
Nico Weber authored
This CL was uploaded by git cl split. R=estade@chromium.org Bug: 177475 Change-Id: Id1f4e2e71a38854049523f1b27e71cf060c83cd1 Reviewed-on: https://chromium-review.googlesource.com/891918Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532624}
-
Samuel Huang authored
This reverts commit 5978ffa4. Reason for revert: Seems to cause failure in linux-chromeos-rel test: telemetry.internal.actions.scroll_unittest.ScrollActionTest.testWheelScrollDistanceWhileZoomed Original change's description: > Reland Group effects support in cc::AnimationPlayer > > Patch https://chromium-review.googlesource.com/c/chromium/src/+/742162 > got reverted because it caused cc_unittest failure on CFI bot. This > patch fixed the bug. > > Commit message from the original patch: > > The current cc/animations logic assumes a single animation has a single > keyframe effect and can only affect a single layer. To enable animations > with multiple keyframe effects, cc::AnimationPlayer need to support > multiple AnimationTickers each corresponding to one keyframe effect. > > Currently there is a 1:1 relationship between AnimationPlayer and > AnimationTicker. This patch is to extend it to 1:n. Here is a summary of > changes: > - Introduce a sub-class of AnimationPlayer, a.k.a > SingleTickerAnimationPlayer, to handle the existing logic (single > effect). SingleTickerAnimationPlayer owns only one AnimationTicker as > the AnimationPlayer does today. > - Currently a AnimationTicker is created upon creating AnimationPlayer. > In this patch, tickers are created separately and added to the player > afterwards. Tickers that the player owns may belong to different targets > therefore the player needs to coordinate with AnimationHost regarding > this situation. > - Adjust existing unit tests according to the changes above. > > Bug: 767043 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: If21bad1285c35bbc048fef6b619c8272c0760551 > Reviewed-on: https://chromium-review.googlesource.com/890724 > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532519} TBR=vollick@chromium.org,yigu@chromium.org Change-Id: Ic82337555158a49ec24ae10fb7a6d63db3114828 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767043 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/891998Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#532623}
-
Aaron Leventhal authored
This enables easier view debugging in IA2 object tree dumps and event streams. It also does make it possible for IA2 clients such as JAWS and NVDA screen readers to utilize the class name for specific logic in parts of the Chrome UI, although this should be a last resport. Bug: None Change-Id: I3d45f8d661f4ad3e298cad24e640efa53a8c64a0 Reviewed-on: https://chromium-review.googlesource.com/889737Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532622}
-
Nico Weber authored
This CL was uploaded by git cl split. R=dgozman@chromium.org Bug: 177475 Change-Id: If1482432b8a150d242c77c53f24f21a3b7cc8b6c Reviewed-on: https://chromium-review.googlesource.com/891881Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532621}
-
Emily Hanley authored
Adding a few environment flags to the swarming.py trigger call in an attempt to connect the dots between our custom trigger script and the built in swarming sharding mechanism that we are re-using in a custom way. This CL also ignores the shards flag from sharding since we define our own shards based on the bot-ids passed on. This *should* get rid of the failures we have been seeing on the obbs_fyi bot :) Bug: 758630 Change-Id: I28f67ae50d747e42fbe30cc95a1becead751ef20 Reviewed-on: https://chromium-review.googlesource.com/890824Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#532620}
-
Katie D authored
InlineTextBoxes are not as stable as their staticText parents. Select to Speak will now keep track of staticText instead of inlineTextBoxes during speech. Also adds some null/undefined checks and a new test, which should improve robustness. This still does not work on sites that update live, like nytimes interactive articles which refresh every second or so. However, it does fix behavior in cases like the examples listed in the bug. Bug: 800912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ica886e954905cfb69b9b6a533965d6490c2fae0c Reviewed-on: https://chromium-review.googlesource.com/879405Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#532619}
-
Christian Fremerey authored
Change-Id: I1e6b63c0aed845ac3edd291ac93851fc2dd5c32a Reviewed-on: https://chromium-review.googlesource.com/891622Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532618}
-
Bret Sepulveda authored
This reverts commit d79797fb. Reason for revert: compile failure on Chrome OS, see failure: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/44972 Original change's description: > Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen." > > This is a reland of 69f0b0d2. > (Relanding to pick up resource file change.) > > Original change's description: > > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. > > > > > > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo > > to it. > > > > BUG=805507 > > > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 > > Reviewed-on: https://chromium-review.googlesource.com/889916 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532221} > > TBR=oshima@chromium.org > > Bug: 805507 > Change-Id: I153d86a34bf73a7b02f9a844fbc137d658897944 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/891562 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532599} TBR=oshima@chromium.org,alemate@chromium.org Change-Id: Icfae88c24e16ccc29b6f3522b451f3c55f20e1e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/891811Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#532617}
-
Nico Weber authored
This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 177475 Change-Id: I4505418ceed6056b95b4bbb5e7ab02ba8b265afe Reviewed-on: https://chromium-review.googlesource.com/891919Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532616}
-
Denis Yaroshevskiy authored
Bug: 803822 Change-Id: I65b3eea6ebd61fff719650d8af5364d429b73103 Reviewed-on: https://chromium-review.googlesource.com/888701 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#532615}
-
https://skia.googlesource.com/skia.git/+log/58acd74f55f2..caaf211e8dd0 $ git log 58acd74f5..caaf211e8 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 reed handle conics in text warper 2018-01-29 bsalomon Remove some unused sample count caps 2018-01-29 reed compare textonpath techniques Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Iab0a54275c1d271ffbb896d36dd148844061a1c9 Reviewed-on: https://chromium-review.googlesource.com/891804Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532614}
-
Joy Ming authored
Begin implementation for downloads by creating entries in ukm.xml and a DownloadUkmHelper following go/downloads-ukm for: - Download.Started: file_type, download_source - Download.Interrupted: change_in_file_size, reason, resulting_file_size, time_since_start - Download.Resumed: mode, time_since_start - Download.Completed: resulting_file_size, time_since_start The implementation strategy is to have a ukm_download_id persisted that will uniquely identify each download. The ukm_source_id will be reported only at the start of the download. Bug: 785557 Change-Id: I94b46bc3287fcde949e58424dc929e71cec7df16 Reviewed-on: https://chromium-review.googlesource.com/742357 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532613}
-
Sergey Ulanov authored
Looks like the bug was fixed, so we don't need this. Bug: 445616 Change-Id: Id33ecc6249b1e68337650c733d0877e3326732bf Reviewed-on: https://chromium-review.googlesource.com/885021 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532612}
-
Xiaocheng Hu authored
This patch refactors the function so that it no longer requires a RenderedPosition instance, by making it call LocalCaretRectOfPosition() instead of calling LayoutObject::LocalCaretRect() directly. This also helps converting RenderedPosition::AbsoluteRect to the NG code path. Bug: 771398 Change-Id: I9eb61a68cad265769e35e206fd5d230414f83680 Reviewed-on: https://chromium-review.googlesource.com/889643 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532611}
-