GitLab

This is to prepare for running the scanner as a presubmit check.

I have added some manual tests to make sure that the new scanner is
compatible with the old one. I plan to replace them with automatic
unittests once I start using presubmit-style input API objects that
are easily mockable.

BUG=343104

Review URL: https://codereview.chromium.org/622493004

Cr-Commit-Position: refs/heads/master@{#297828}

To move the WebView telemetry bot off hard coding
which tests to use and start getting the list of tests
automatically we need to label which tests don't work
on the WebView.

Bug tracking enabling them here: crbug.com/419687

BUG=391488, 419687

Review URL: https://codereview.chromium.org/619903003

Cr-Commit-Position: refs/heads/master@{#297827}

Sync up chrome_restart_request.cc with ui/events/event_switches.h

BUG=none

Review URL: https://codereview.chromium.org/617583002

Cr-Commit-Position: refs/heads/master@{#297826}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/28da02d..2152879

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/617703003

Cr-Commit-Position: refs/heads/master@{#297825}

Use a boolean to only send WINDOW_CONTENT_CHANGED the first time
notifyFrameInfoInitialized is called. See bug for longer discussion of
issue.

BUG=419541

Review URL: https://codereview.chromium.org/624503002

Cr-Commit-Position: refs/heads/master@{#297824}

Propagate touchscreen information so that Ash can map touchscreens to displays.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/616633002

Cr-Commit-Position: refs/heads/master@{#297823}

We never unregistered an audio stream that were using keyboard mic channel, so we never inactivated the keyboard mic when no more streams were using it. This fixes it.

Fix for CL https://codereview.chromium.org/599443003/

BUG=418993

Review URL: https://codereview.chromium.org/618663003

Cr-Commit-Position: refs/heads/master@{#297822}

Creating a runtime table of std::string objects, just to copy those
into a map, is not optimal from a runtime or footprint point of view.

Making the table use raw char pointers shrinks the code and data by 75%,
from 36 KB to 10 KB (clang, Linux, 64 bit content_shell).

clang:
Total change: -27266 bytes
==========================
  2 added, totalling +8448 bytes across 1 sources
  774 removed, totalling -36401 bytes across 2 sources
  1 grown, for a net change of +687 bytes (481 bytes before, 1168 bytes after) across 1 sources

R=estade@chromium.org,mark@chromium.org
BUG=

Review URL: https://codereview.chromium.org/573623003

Cr-Commit-Position: refs/heads/master@{#297821}

BUG=v8:3597
R=cpu@chromium.org,wfh@chromium.org

Review URL: https://codereview.chromium.org/619543002

Cr-Commit-Position: refs/heads/master@{#297820}

Cr-Commit-Position: refs/heads/master@{#297819}

BUG=417315

Review URL: https://codereview.chromium.org/599173002

Cr-Commit-Position: refs/heads/master@{#297818}

According to latest editor draft(http://rawgit.com/w3c/html-api-map/master/index.html) above mentioned input type attributes should have xml-roles. Also math tag should have xml-role.

BUG=418486

Review URL: https://codereview.chromium.org/609343002

Cr-Commit-Position: refs/heads/master@{#297817}

Revert of Making WebRTC Java api avaliable in Chromium. (patchset #5 id:100001 of https://codereview.chromium.org/551793003/)

Reason for revert:
This CL breaks official Chrome.

Original issue's description:
> Making WebRTC Java api avaliable in Chromium.
>
> BUG=383418
> TEST=Build target libjingle_peerconnection_javalib
>
> Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0
> Cr-Commit-Position: refs/heads/master@{#297801}

TBR=hellner@chromium.org,kjellander@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418

Review URL: https://codereview.chromium.org/614263007

Cr-Commit-Position: refs/heads/master@{#297816}

BUG=399735

Review URL: https://codereview.chromium.org/617963006

Cr-Commit-Position: refs/heads/master@{#297815}

The existing file handler registration code in ShellUtil was highly
specific to Chrome (and the necessary actions to register a web
browser). Refactored the code and split it up so that there is reusable
code for general (non-browser app) file handler registrations.

Added AddFileAssociations and DeleteFileAssociations, which can register
and unregister file handlers for any command line and for any file
extensions. These are intended to be used when installing/uninstalling
Chrome apps with file_handlers in their manifest.

BUG=130455

Review URL: https://codereview.chromium.org/487693002

Cr-Commit-Position: refs/heads/master@{#297814}

TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/614223005

Cr-Commit-Position: refs/heads/master@{#297813}

Currently the credentials mode of the FetchEvent's request is always 'omit'.
But this should be 'same-origin' or 'include'.
ex:
- <img src="./test.png">
 mode: no CORS
 credentials mode: same-origin
- <img src="./test.png" crossOrigin="anonymous">
 mode: CORS
 credentials mode: same-origin
- <img src="./test.png" crossOrigin="use-credentials">
 mode: CORS
 credentials mode: include

[1/2] blink: https://codereview.chromium.org/610403002/
[2/2] chromium: https://codereview.chromium.org/615493003/

This value is passed from the renederer to the ServiceWorker in the following steps.

In the renederer process:
  blink::ResourceRequest::setFetchCredentialsMode()  // not called yet
 blink::ResourceRequest::m_fetchCredentialsMode
  content::WebURLLoaderImpl::Context::Start()
   blink::WebURLRequest::fetchCredentialsMode()
    GetFetchCredentialsMode()
 conetnt::RequestInfo::fetch_credentials_mode

In the browser process:
 conetnt::RequestInfo::fetch_credentials_mode
  content::ResourceDispatcherHostImpl::BeginRequest()
   content::ServiceWorkerRequestHandler::InitializeHandler()
    content::ServiceWorkerProviderHost::CreateRequestHandler()
     content::ServiceWorkerControlleeRequestHandler::ServiceWorkerControlleeRequestHandler()
 content::ServiceWorkerControlleeRequestHandler::request_credentials_mode_
  content::ServiceWorkerControlleeRequestHandler::MaybeCreateJob()
   content::ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob()
 content::ServiceWorkerURLRequestJob::request_credentials_mode_
  content::ServiceWorkerURLRequestJob::CreateFetchRequest()
 content::ServiceWorkerFetchRequest::credentials_mode

In the ServiceWorker process:
 content::ServiceWorkerFetchRequest::credentials_mode
   content::ServiceWorkerScriptContext::OnFetchEvent()
   GetBlinkFetchRequestCredentialsMode()
   blink::WebServiceWorkerRequest::setCredentialsMode()
 blink::WebServiceWorkerRequest::WebServiceWorkerRequestPrivate::m_credentialsMode
  blink::Request::create()
  blink::FetchRequestData::create()
 blink::FetchRequestData::m_credentials

BUG=418509

Review URL: https://codereview.chromium.org/615493003

Cr-Commit-Position: refs/heads/master@{#297812}

This is a long-standing task, I have been waiting to proceed with it to avoid complicated merges while things were hot on the settings protection front.

Now is a good time to clean this up before doing further cleanup work.

TBR=grt@chromium.org
BUG=419505

Review URL: https://codereview.chromium.org/620933002

Cr-Commit-Position: refs/heads/master@{#297811}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e3dbcaf..28da02d

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/623703002

Cr-Commit-Position: refs/heads/master@{#297810}

This workaround is no longer needed as the NSS bug was fixed in NSS 3.12.10 (see: https://bugzilla.mozilla.org/show_bug.cgi?id=635778), and Chromium requires NSS 3.14.3 or later now.

BUG=138571

Review URL: https://codereview.chromium.org/616093002

Cr-Commit-Position: refs/heads/master@{#297809}

This CL removes IndividualSettings and GlobalSettings from ExtensionManagment header file in order to simply header file and reduce static size of ExtensionManagement class. Linked pointer is used to prevent potential unintended use of copy constructor of these structure in the future, when more fields are added.

A new internal header file is created since these structures are also used in unit tests.

BUG=177351

Review URL: https://codereview.chromium.org/602803002

Cr-Commit-Position: refs/heads/master@{#297808}

"X-DevTools-Request-Initiator" and "X-DevTools-Emulate-Network-Conditions-Client-Id" HTTP headers may be set by InspectorResourceAgent when the inspector window is open.
This headers are removed by DevToolsNetworkTransaction before sending the request to the network.
But when the request passed to the ServiceWorker these headers are not removed.
This may cause accidental problems.

BUG=419318

Review URL: https://codereview.chromium.org/615413002

Cr-Commit-Position: refs/heads/master@{#297807}

This is the Chromium part of a two-sided patch.
The Blink part is https://codereview.chromium.org/615893004

R=dgozman, vsevik

Review URL: https://codereview.chromium.org/620953003

Cr-Commit-Position: refs/heads/master@{#297806}

BUG=400674

Review URL: https://codereview.chromium.org/621503005

Cr-Commit-Position: refs/heads/master@{#297805}

BUG=267281
TEST=run Files.app

Review URL: https://codereview.chromium.org/620003004

Cr-Commit-Position: refs/heads/master@{#297804}

BUG=N/A
TBR=rockot

Review URL: https://codereview.chromium.org/617003009

Cr-Commit-Position: refs/heads/master@{#297803}

This CL separates the part of LocalSharedObjectsContainer which is to be componentised into an interface, and keeps the LSOC itself an implementation detail of TabSpecificContentSettings (to be moved to the embedding client at a later point).

More design details here: https://docs.google.com/a/google.com/document/d/1rQ9PMCPL6wHh-QjaZWOBcaYXQgbCka7unSsciQ52qOs/edit#heading=h.hid3xtn12izy

BUG=384873

Review URL: https://codereview.chromium.org/588583002

Cr-Commit-Position: refs/heads/master@{#297802}

BUG=383418
TEST=Build target libjingle_peerconnection_javalib

Review URL: https://codereview.chromium.org/551793003

Cr-Commit-Position: refs/heads/master@{#297801}

Revert of No longer requiring pixel output for WebRTC tests. (patchset #4 id:60001 of https://codereview.chromium.org/611953004/)

Reason for revert:
Turns out this change makes video+canvas grabbing produce junk; this is not good since our tests depend on that working. Reverting.

Original issue's description:
> No longer requiring pixel output for WebRTC tests.
>
> We used to require pixel output for our canvas-scraping, but that
> appears to no longer be required. This speeds up the test 3x on my
> win machine, from 30 seconds to about 10.
>
> The content_browsertests on ChromeOS will still enable pixel
> output since it seems the requirements there are different - video
> tags will not work unless that is enabled, it seems. I think
> that's fine since our original problem was with the browser_tests
> anyway, and I think the content_browsertests are probably fast
> enough on ChromeOS anyway (whereas the browser_tests weren't).
>
> BUG=396505
>
> Committed: https://crrev.com/e6a342dcab57c3a2de1fd21301f37fdf3f8ad070
> Cr-Commit-Position: refs/heads/master@{#297654}

TBR=tommi@chromium.org,xians@google.com
NOTREECHECKS=true
NOTRY=true
BUG=396505

Review URL: https://codereview.chromium.org/619003003

Cr-Commit-Position: refs/heads/master@{#297800}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d8126c1..e3dbcaf

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/625513003

Cr-Commit-Position: refs/heads/master@{#297799}

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/624573002

Cr-Commit-Position: refs/heads/master@{#297798}

The name conflicts with CSS's Rect.

BUG=419360
TEST=None

Review URL: https://codereview.chromium.org/624563002

Cr-Commit-Position: refs/heads/master@{#297797}

TEST=Not affected.
BUG=None

Review URL: https://codereview.chromium.org/622683004

Cr-Commit-Position: refs/heads/master@{#297796}

These null-checks were inadvertedly removed during this
refactoring:
https://codereview.chromium.org/481803004/

getWebContents() can return null after destruction
so we need to null-check before use.

BUG=415666

Review URL: https://codereview.chromium.org/615883003

Cr-Commit-Position: refs/heads/master@{#297795}

Revert of Revert of Use the new java_cpp_enum rule in content. (patchset #1 id:1 of https://codereview.chromium.org/625543002/)

Reason for revert:
Oops, wasn't supposed to revert this after all.

Original issue's description:
> Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
>
> Reason for revert:
> Fails to compile on several bots:
>
> https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
>
> First error:
> FAILED: cd ../../clank/native/framework; python <snip ...>
> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
> import org.chromium.content.common.TopControlsState;
>                                   ^
>   symbol:   class TopControlsState
>   location: package org.chromium.content.common
>
> Original issue's description:
> > Use the new java_cpp_enum rule in content.
> >
> > This moves most of the generated Java enums under content/ to use the
> > java_cpp_enum rule removing the need for keeping the enums in
> > separate list files and the need for the .template files.
> >
> > BUG=405532, 351558
> >
> > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> > Cr-Commit-Position: refs/heads/master@{#297789}
>
> TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=405532, 351558
>
> Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef
> Cr-Commit-Position: refs/heads/master@{#297793}

TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org,perezju@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558

Review URL: https://codereview.chromium.org/617103007

Cr-Commit-Position: refs/heads/master@{#297794}

Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)

Reason for revert:
Fails to compile on several bots:

https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio

First error:
FAILED: cd ../../clank/native/framework; python <snip ...>
../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
import org.chromium.content.common.TopControlsState;
                                  ^
  symbol:   class TopControlsState
  location: package org.chromium.content.common

Original issue's description:
> Use the new java_cpp_enum rule in content.
>
> This moves most of the generated Java enums under content/ to use the
> java_cpp_enum rule removing the need for keeping the enums in
> separate list files and the need for the .template files.
>
> BUG=405532, 351558
>
> Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> Cr-Commit-Position: refs/heads/master@{#297789}

TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558

Review URL: https://codereview.chromium.org/625543002

Cr-Commit-Position: refs/heads/master@{#297793}

volumeId. When the notification saying "Open removable device" is clicked,
Files.app finding corresponding volumeId from the map, and navigate to the
volume.

Files.app: Remove navigationVolumeMap from the background page.

But if the background page once closed, the map is cleared and the app cannot
find the corresponding volume.

The CL adds devicePath field to VolumeInfo, and let the app find the
corresponding volume information directly without using the map.

BUG=419107
TEST=repro steps of the bug.

Review URL: https://codereview.chromium.org/612303005

Cr-Commit-Position: refs/heads/master@{#297792}

BUG=400674
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/604383003

Cr-Commit-Position: refs/heads/master@{#297791}

BUG=

Review URL: https://codereview.chromium.org/619873009

Cr-Commit-Position: refs/heads/master@{#297790}

This moves most of the generated Java enums under content/ to use the
java_cpp_enum rule removing the need for keeping the enums in
separate list files and the need for the .template files.

BUG=405532, 351558

Review URL: https://codereview.chromium.org/615893003

Cr-Commit-Position: refs/heads/master@{#297789}