GitLab

Revert of Roll libyuv d204db6...194f740 (r1172..1285) (patchset #1 id:1 of https://codereview.chromium.org/943513002/)

Reason for revert:
Failing Windows DrMemory memory test: content
Error report:
07:13:11 drmemory_analyze.py [INFO] Found 1 error reports
07:13:11 drmemory_analyze.py [INFO] Report #1
### BEGIN MEMORY TOOL REPORT (error hash=#FBECECDC73272255#)
UNINITIALIZED READ: reading 0x001ff960-0x001ff980 32 byte(s) within 0x001ff960-0x001ff980
# 0 content.dll!CopyRow_AVX                                                    [third_party\libyuv\source\row_win.cc:2687]
# 1 content.dll!CopyRow_Any_AVX                                                [third_party\libyuv\source\row_any.cc:672]
# 2 content.dll!CopyPlane                                                      [third_party\libyuv\source\planar_functions.cc:72]
# 3 content.dll!I420Copy                                                       [third_party\libyuv\source\convert.cc:90]
# 4 content.dll!I420Rotate                                                     [third_party\libyuv\source\rotate.cc:1193]
# 5 content.dll!ConvertToI420                                                  [third_party\libyuv\source\convert_to_i420.cc:241]
# 6 content.dll!content::VideoCaptureController::VideoCaptureDeviceClient::OnIncomingCapturedData [content\browser\renderer_host\media\video_capture_controller.cc:514]
# 7 content::VideoCaptureControllerTest_DataCaptureInEachVideoFormatInSequence_Test::TestBody [content\browser\renderer_host\media\video_capture_controller_unittest.cc:661]
# 8 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2420]
Note: @0:05:20.487 in thread 3640
Note: instruction: vmovdqu (%eax) -> %ymm0

Original issue's description:
> Roll libyuv d204db6...194f740 (r1172..1285)
>
> This roll is primarily done to pick up ValidateJpeg performance improvement.
>
> TBR=fbarchard
>
> Committed: https://crrev.com/50bf61b785adf9366446bc26c09e691a1c0db15f
> Cr-Commit-Position: refs/heads/master@{#317304}

TBR=fbarchard@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/941573004

Cr-Commit-Position: refs/heads/master@{#317325}

This CL makes inclusion list and exclusion list to be passed to
shill during setparameters API call in third party VPN.

BUG=459609
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/940423002

Cr-Commit-Position: refs/heads/master@{#317324}

When used in manual mode, SetZoom() should early-out if the new zoom
level is the same as the old one in order to avoid sending unnecessary
ZoomChangedEvents.

BUG=459995

Review URL: https://codereview.chromium.org/942023002

Cr-Commit-Position: refs/heads/master@{#317323}

The problem was that if the wallpaper of the non active user got changed on a different system, the remote system would replace the wallpaper of the active desktop with the change, no matter which user currently was active.

JS is supplying the browser-context to the api call which can be used to get the applications owner - and that is used to identify the proper user.

Creating a test case for this scenario is a lot of work (setting up multi profile, running the wallpaper manager for both users, triggering a change in the app of one user to force a change, waiting until the change has trickled through the system, ..).
Since the work required for an automated test feels rather complex and time consuming for this setup and the change itself is fairly straight forward and simple, so I did not create a test.

BUG=459599
TEST=visual

Review URL: https://codereview.chromium.org/939233004

Cr-Commit-Position: refs/heads/master@{#317322}

BatteryStatusObserver::Stop can be called twice from
BatteryStatusService::Shutdown, so power_handle_ and batter_change_handle_
should be set to NULL on the first call, otherwise the second call
will pass invalid handles to UnregisterNotification.

Review URL: https://codereview.chromium.org/924193006

Cr-Commit-Position: refs/heads/master@{#317321}

WebRTC 8439:8443
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/00316a4..de41287

Libjingle 8437:8444
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/92478da..0366d0b

TBR=niklase@chromium.org

Review URL: https://codereview.chromium.org/940413002

Cr-Commit-Position: refs/heads/master@{#317320}

platformKeys API also must open a dialog for client certificate selection.

Compared to SSLClientCertificateSelector, the API's dialog
- does not need synchronization of multiple open dialogs on different tabs of the same origin.
- does not need slot unlocking, as it is implemented on ChromeOS only.

While there fixing the tests of the selector: The test certificates were imported without private key and thus the Unlock crashed because the NSS slot was null.

BUG=121007,103534,103529,450167

Review URL: https://codereview.chromium.org/932553002

Cr-Commit-Position: refs/heads/master@{#317319}

This patch fixes the Chromium Android Linker bug which causes a
RuntimeException when LibInfos are unmarshalled from the shared RELRO
Bundle in renderer process. The problem was caused by an ABI mismatch
between ParcelFileDescriptor.writeToParcel() and
Parcel.readFileDescriptor() (b/19451018).

BUG=348621, 382485

Review URL: https://codereview.chromium.org/941913003

Cr-Commit-Position: refs/heads/master@{#317318}

Cleans up error names for push messaging, and adds UMA tracking for Unregister and GetRegistration calls, as well as for incoming push message delivery (these supplement the existing UMA for registration and whether notifications are shown).

BUG=401438

Review URL: https://codereview.chromium.org/938123002

Cr-Commit-Position: refs/heads/master@{#317317}

crrev.com/933613002 introduced a ODR violtaion by adding the
DeleteForTesting method (other definition in trace_event_impl.cc).
This was causing an ASan assertion (see crbug.com/459556) and failures
of base_unittests in debug builds (see crrev.com/933613002 #33).
This CL fixes the DeleteForTesting pattern removing the awkward ODR
violation.

BUG=459556,458295
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/942803002

Cr-Commit-Position: refs/heads/master@{#317316}

E.g. this happens for Ethernet (not the EAP configuration) which is always shared by all users.

BUG=454966

Review URL: https://codereview.chromium.org/946533003

Cr-Commit-Position: refs/heads/master@{#317315}

Lock globals at the head of Add/DelEntryImpl() callback handlers.

  The crazy linker exports updates to _r_debug pages to the UI thread
  if a callback poster function has been supplied.  At the time the
  callback is posted, the crazy linker holds the globals lock, used to
  prevent other threads from loading libraries (in particular through
  ::dlopen(), used for system libraries).  When the callback is
  received on a different thread the receiving code needs to reacquire
  the lock.

Make the globals lock reentrant.

  If there is no callback poster function then the updates to _r_debug
  pages happen immediately on the current thread.  Here the globals
  lock is already held.  Reentrancy ensures that we do not deadlock
  in that case.

Fix potential inaccuracy when looking for the page to mprotect.

  The addresses checked for writability are currently the start of the
  object being modified.  This is 12 or 16 bytes (on arm, 24 or 32
  bytes on arm64) below the address that will actually be written, and
  not guaranteed to be in the same memory page where the object
  crosses a page boundary.

Workround for races with the system linker over _r_debug protections.

  There is no way to safely and accurately sense whether _r_debug is
  in a readonly page -- we might read while the system linker is in
  the process of writing to it, and conclude that it is not readonly
  when it is.  Similarly, we may set it read/write, update pointers,
  and then set it readonly between the system linker setting it to
  read/write and updating pointers.  To work round this, we always map
  it to read/write, no matter its apparent initial state, and never
  map it back to readonly.  This may leave a small security hole, but
  it is better than the alternatives (typically, a crash).

BUG=450659,458346

Review URL: https://codereview.chromium.org/937813002

Cr-Commit-Position: refs/heads/master@{#317314}

This is the second part of being able to open new windows on Android from
a background service, where no Activity may be available. New tabs are
launched with a request ID, which will be used to feed back creation of
the tab to the ServiceTabLauncher.

TBR=jbudorick@chromium.org
BUG=454809

Review URL: https://codereview.chromium.org/904453002

Cr-Commit-Position: refs/heads/master@{#317313}

Revert of Revert of Make sure MessagePortService is used in a thread safe manner. (patchset #1 id:1 of https://codereview.chromium.org/942583005/)

Reason for revert:
This does not seem to cause the problem.

Original issue's description:
> Revert of Make sure MessagePortService is used in a thread safe manner. (patchset #4 id:80001 of https://codereview.chromium.org/937503003/)
>
> Reason for revert:
> This CL is suspected to cause the Win7 test (dbg) failures.
>
> Original issue's description:
> > Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner.
> >
> > BUG=459115
> >
> > Committed: https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306
> > Cr-Commit-Position: refs/heads/master@{#317178}
>
> TBR=creis@chromium.org,sgurun@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=459115
>
> Committed: https://crrev.com/60583adc54a6b043dc0b812f10869801eb0da0b4
> Cr-Commit-Position: refs/heads/master@{#317299}

TBR=creis@chromium.org,sgurun@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459115

Review URL: https://codereview.chromium.org/947483002

Cr-Commit-Position: refs/heads/master@{#317312}

Cr-Commit-Position: refs/heads/master@{#317311}

is selected by user as the default search provider.

Filled the "image_url" and "image_url_post_params" fields
for the Yandex' search engine. Inserted a "Content-Type"
header to the post parameter containing binary image data.

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/939713003

Cr-Commit-Position: refs/heads/master@{#317310}

Adding support for storing webrtc logs locally with an extension supplied unique id, for later upload.
This approach has two new methods:
  * store() - allows the application to specify an ID for the log file that will be stored locally, but not uploaded.  The file can be stored for up to 5 days.
  * uploadStored() - allows the application to upload a previously stored log file.

Refactoring the code for less copy/paste.

BUG=459750

Review URL: https://codereview.chromium.org/927233005

Cr-Commit-Position: refs/heads/master@{#317309}

This CL fixes the documentation for split tunnel API.

BUG=459609
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/944003002

Cr-Commit-Position: refs/heads/master@{#317308}

onGetPixelsEnum was just for staging.

R=dalecurtis@chromium.org,reed@chromium.org

BUG=skia:3257

Review URL: https://codereview.chromium.org/944543002

Cr-Commit-Position: refs/heads/master@{#317307}

Visual state callbacks should always be received,
even if there are no pending commits. We add
a test for that. See crbug/458577 for more details.

BUG=458577

Review URL: https://codereview.chromium.org/939673002

Cr-Commit-Position: refs/heads/master@{#317306}

This CL makes it possible to navigate to the custom launcher page from
the start page using the keyboard.

Patch written by calamity@chromium.org. Original code review at
https://codereview.chromium.org/941213003/.

BUG=458884
R=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/924193005

Cr-Commit-Position: refs/heads/master@{#317305}

This roll is primarily done to pick up ValidateJpeg performance improvement.

TBR=fbarchard

Review URL: https://codereview.chromium.org/943513002

Cr-Commit-Position: refs/heads/master@{#317304}

This CL whitelists the ARC Runtime that has been approved for use in
public sessions.

BUG=459614
TEST=None

Review URL: https://codereview.chromium.org/932163002

Cr-Commit-Position: refs/heads/master@{#317303}

Factor out the code which generates the native export stub name for a
given native function, previously duplicated in two places, and also use
it in a third place: when generating the table of method registrations.
This will allow the table to be generated even when in native export
mode, as previously the table referred to the default name which is not
defined when using native exports.

BUG=442327

Review URL: https://codereview.chromium.org/938373002

Cr-Commit-Position: refs/heads/master@{#317302}

Previously, this linked to the notifications settings screen for all sites.

BUG=436594

Review URL: https://codereview.chromium.org/943993002

Cr-Commit-Position: refs/heads/master@{#317301}

It fixes the following clang format:

In file included from ../../ui/ozone/platform/dri/gbm_surface.cc:14:
../../ui/ozone/platform/dri/gbm_wrapper.h:18:3: error: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
  ~GbmWrapper() override;
  ^
../../ui/ozone/platform/dri/gbm_wrapper.h:14:20: note: [chromium-style] 'GbmWrapper' inherits from 'ui::DriWrapper' here
class GbmWrapper : public DriWrapper {
                   ^
../../ui/ozone/platform/dri/dri_wrapper.h:41:33: note: [chromium-style] 'DriWrapper' inherits from 'base::RefCountedThreadSafe<DriWrapper>' here
class OZONE_EXPORT DriWrapper : public base::RefCountedThreadSafe<DriWrapper> {
                                ^
BUG=none

Review URL: https://codereview.chromium.org/940223002

Cr-Commit-Position: refs/heads/master@{#317300}

Revert of Make sure MessagePortService is used in a thread safe manner. (patchset #4 id:80001 of https://codereview.chromium.org/937503003/)

Reason for revert:
This CL is suspected to cause the Win7 test (dbg) failures.

Original issue's description:
> Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner.
>
> BUG=459115
>
> Committed: https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306
> Cr-Commit-Position: refs/heads/master@{#317178}

TBR=creis@chromium.org,sgurun@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459115

Review URL: https://codereview.chromium.org/942583005

Cr-Commit-Position: refs/heads/master@{#317299}

When a profile was loaded asynchronously, ProfileManager::GetProfileByPath could return it before it had been fully initialized, which could lead to... interesting problems. We now return null if that is the case, because callers of GetProfileByPath need to deal with a null return value anyway.

ProfileManager::GetProfile (which is supposed to create the profile synchronously if it doesn't exist) will now DCHECK when trying to get a profile that is not fully initialized.

This CL also stops AppController from trying to get a profile that has just been deleted, which would now crash otherwise.

BUG=425785

Review URL: https://codereview.chromium.org/929073002

Cr-Commit-Position: refs/heads/master@{#317298}

Since we've deprecated TSan v1, these aren't used anymore and may potentially hide errors in lock-free synchronization that TSan v2 could detect otherwise.

BUG=349861
TBR=nduca@chromium.org,scottmg@chromium.org
R=danakj@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/790473002

Cr-Commit-Position: refs/heads/master@{#317297}

BUG=447445
TEST=cc_unittests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/929883004

Cr-Commit-Position: refs/heads/master@{#317296}

Revert of bpf_dsl: decouple PolicyCompiler from Syscall (patchset #3 id:40001 of https://codereview.chromium.org/939943002/)

Reason for revert:
This CL seem to increase nacl_helper size and results in Linux_x64 failure.

Original issue's description:
> bpf_dsl: decouple PolicyCompiler from Syscall
>
> Logically, the "escape hatch PC" is now like a compiler flag, that the
> user can set appropriately.  In the case of SandboxBPF, it will set the
> PC to Syscall::Call(-1), as before.
>
> This isn't a very satisfying way to resolve this cyclic dependency, but
> it's the simplest and least intrusive I could think of.
>
> BUG=449357
>
> Committed: https://crrev.com/242ad8711d9f0d58fb45b134468ad68b0835fad2
> Cr-Commit-Position: refs/heads/master@{#317237}

TBR=jln@chromium.org,mdempsky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449357

Review URL: https://codereview.chromium.org/937303005

Cr-Commit-Position: refs/heads/master@{#317295}

Revert of bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h (patchset #1 id:1 of https://codereview.chromium.org/945743002/)

Reason for revert:
To allow https://codereview.chromium.org/937303005/ to submit.

Original issue's description:
> bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h
>
> PolicyCompiler runs in a normal process context, so it doesn't require
> the extra low-levelness of SANDBOX_DIE.
>
> BUG=449357
>
> Committed: https://crrev.com/deed70455d69ca62e4a5bfd2123a9376c5197797
> Cr-Commit-Position: refs/heads/master@{#317265}

TBR=jln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449357

Review URL: https://codereview.chromium.org/944763004

Cr-Commit-Position: refs/heads/master@{#317294}

Added rounded focus ring for controls on dialog footer.
Tab order should be reconsidered later as accessibility improvement.

BUG=402344
TEST=manually tested

Review URL: https://codereview.chromium.org/938383002

Cr-Commit-Position: refs/heads/master@{#317293}

When swap promises are enqueued we request a commit. If there
are no updates the promises should be broken and the commit
skipped (EarlyOut_NoUpdates). To achieve that we request
the commit by calling SetNeedsUpdateLayers instead of
SetNeedsCommit in order to not unset can_cancel_commit. Note
that SetNeedsUpdateLayers is a subset of SetNeedsCommit and a
no-op when a commit has already been requested.

BUG=458577

Review URL: https://codereview.chromium.org/925353002

Cr-Commit-Position: refs/heads/master@{#317292}

BUG=402344
TEST=manually checked

Review URL: https://codereview.chromium.org/922193003

Cr-Commit-Position: refs/heads/master@{#317291}

The CL filters out errors come from analytics.js in guest session.

BUG=459983
TEST=None

Review URL: https://codereview.chromium.org/941253002

Cr-Commit-Position: refs/heads/master@{#317290}

This CL adds split tunnel capability to chrome.vpnProvider interface.
Furthermore, additional sanity checks are added to the input from the
extensions.

BUG=459609

Review URL: https://codereview.chromium.org/932063003

Cr-Commit-Position: refs/heads/master@{#317289}

BUG=460034

Review URL: https://codereview.chromium.org/939073003

Cr-Commit-Position: refs/heads/master@{#317288}

Back and Mic buttons now have accessible names. Also added a tooltip to
Back button. Added some special logic to avoid focusing the Search box
in the search results page (because of the dual focus; it is more
important to read out the result than the search box).

BUG=458885,459859

Review URL: https://codereview.chromium.org/935293002

Cr-Commit-Position: refs/heads/master@{#317287}

This CL adds the Apps.AppListDoodleClicked histogram for when the app
list doodle is clicked.

BUG=459650

Review URL: https://codereview.chromium.org/930243009

Cr-Commit-Position: refs/heads/master@{#317286}