- 31 Jul, 2019 40 commits
-
-
Eugene But authored
This target will be used in EG2 tests in test process, which can not depend on larger ios/chrome/browser:browser target which contains app code. Bug: 987646 Change-Id: I42a8735896a71e53f976ed11de3c30af1ed31905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726312 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682672}
-
Eric Willigers authored
dominant-baseline is specified to accept auto | text-bottom | alphabetic | ideographic | middle | central | mathematical | hanging | text-top Blink hasn't implemented support for text-bottom or text-top. https://drafts.csswg.org/css-inline-3/#dominant-baseline-property Change-Id: I956027066788415063ee0d6b9867af458da365cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728890Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#682671}
-
vitaliii authored
Mark external/wpt/cookie-store/serviceworker_cookieStore_subscriptions_eventhandler_attribute.tentative.https.html as flaky (timeout) on Linux Debug in TestExpectations and on Linux for ASAN. TBR=pwnall@chromium.org Bug: 989014 Change-Id: Iaf1feeede1f72d15b572c0a9124b8b482e53c94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728872Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682670}
-
Takashi Toyoshima authored
This patch handles parsed BundledExchanges metadata and hook the navigation to the BundledExchange resource so that it redirects to the main resource of the BundledExchanges. Also this patch renames BundledExchangesFactory to BundledExchangesHandle. Bug: 966753 Change-Id: Ia9920c65755fc44f5632366c214c872930228a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716046 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#682669}
-
Mohamed Abdelhalim authored
These calls are calling back methods from the NavigationRequest, this CL removes the extra step. Bug: 916537 Change-Id: I8ca129f57a97da0903e6fcd08e30c97c41748848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724684 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#682668}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1ebe6014389e..34ebecc19c6b git log 1ebe6014389e..34ebecc19c6b --date=short --no-merges --format='%ad %ae %s' 2019-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f04f1f93a70f..eea340047eca (1 commits) 2019-07-31 xinghua.cao@intel.com Correct barriers of glMemoryBarrier in test cases Created with: gclient setdep -r src/third_party/angle@34ebecc19c6b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I3b00f0defe713576d0a2f3b1302cd5723742bb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728258Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682667}
-
vitaliii authored
Mark virtual/compositor_threaded_scrollbar_scrolling/fast/scrolling/scrollbars/scrollbar-button-gesture-target.html as flaky (crash) on Win. TBR=arakeri@microsoft.com Bug: 987115 Change-Id: I95eeddd53240a6921b5dec33b7481bb7bbe5232e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728658Reviewed-by:
-
Rune Lillesveen authored
We do not modify the DOM during style recalc, but we may remove pseudo elements if they are no longer rendered after style recalc. The recalc code marked the pseudo elements for reattachment before removing them which meant the layout_tree_rebuild_root_ in StyleEngine pointed to a disconnected pseudo element. Avoid the marking if we are about to remove the pseudo element. This is done as part of the preparation for flat tree style recalc. Bug: 972752 Change-Id: Icb472bf8073e518a456c86bceb1a1ddbf48f9c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728653Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682665}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=haven@chromium.org Change-Id: I66ca154ecb0432c3843515347ddfdd39dad6f3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649510 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Carlos Caballero <carlscab@google.com> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682664}
-
Jérôme Lebel authored
When swiping the advanced sign-in settings view, the cancel confirmation dialog is displayed. The dialog is the same than tapping on cancel. Bug: 982300 Change-Id: I8451ece5281853e2dcdf4dc90e585affca7dd575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725916Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#682663}
-
Hirokazu Honda authored
This is a partial revert of crrev.com/c/1694962. I was going to use frame size by AssignPictureBuffers(). However, the frame size is also known by ImportBufferForPicture(). The frame size in AssignPictureBuffers() even can be wrong in secure mode. So I would dealy and call VDA::AssignPictureBuffers() in GAVDA::ImportBufferForPicture on the first picture buffer. So the mojo change and GAVDA change in crrev.com/c/1694962 is unnecessary. NOTE: I haven't changed ARC++ and ChromeOS side for this mojo change. So it is safe to revert the mojo change. Bug: 979115 Test: None Change-Id: Ie8f7f3dd9e4b104ed2e590379ec86e88ad76e708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720298 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#682662}
-
Himanshu Jaju authored
Bug: 972059 Change-Id: I5d643dff5a400ee072522e874b29d261820185e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728580Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#682661}
-
Christos Froussios authored
This case handles clients which haven't migrated from Keyring/KWallet into the login database, but have entries in login database. These are clients who either haven't updated in a long time or haven't had functioning Keyrings/KWallets for the duration of the migration. The unencrypted contents of login database will be encrypted in-place. Bug: 950267 Change-Id: Id1ba10e87bfd110704a0f63ab038cbb7dda7053a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720837Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c98484b..fb6a1792 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I12c17834d4e543d50d8c2f000db82b807aa60098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728210Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682659}
-
Mohamed Abdelhalim authored
This is in reference to a comment on: https://chromium-review.googlesource.com/c/chromium/src/+/1715283 Change-Id: I7058826e27110d84e9a846394758044b512bac09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718224Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#682658}
-
Daniel Bratell authored
Inside the namespace performance_manager the string features can refer either to ::performance_manager::features or to ::features depending on what the compiler knows about. In jumbo builds the compiler has more information and will always resolve features to ::performance_manager::features. This broke the windows jumbo fyi builder, but the fix is trivial, just write ::features instead of features. (Having a sub namespace with the same name as a common top-level namespace violates the code style guide but this is common for features and switches and need a large cleanup.) TBR=treib@chromium.org Bug: 973963 Change-Id: Ida06c223f595130b48a8e4442a8e17f5476de8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728551Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#682657}
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=droger@chromium.org Change-Id: Id81a7f75bf4fa64c4c7b4ca4d8830768ef6b2d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715819 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
The CheckIsSelfCollapsing code looked a little scary, e.g. for inline children it was checking if a (legacy) linebox was was present. This sets the self-collapsing bit directly for the layout overflow calculation - which might have a slight perf improvement. Change-Id: I1b214f915005b8ef21a32305be762f9d52f9156b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556399Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#682655}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLAnchorElement> and DynamicTo<HTMLAnchorElement> as new downcast helper. 2. Use IsA<HTMLAnchorElement>(element) in place of IsHTMLAnchorElement(element) Bug: 891908 Change-Id: I188cf14a847cab9f3cfc270e8cb5cbfeafcca770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726034 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#682654}
-
vasilii authored
PasswordManager.SuggestionClicked and PasswordManager.SuggestionShown are gone. They are replaced with cross-platform ones: - PasswordManager.PasswordDropdownItemSelected and - PasswordManager.PasswordDropdownShown Bug: 988730 Change-Id: I8be52f9ad89efdbe574dfada697619a2ec400487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724688Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682653}
-
Johannes Kron authored
Total decode time was recently added as a WebRTC stats metric. This CL adds average decode time as a metric calculated by |totalDecodeTime| / |decodedFrames|. Bug: webrtc:10775 Change-Id: I7fe074d88014f2814ab713c4f8c73148187763d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728569Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#682652}
-
Hajime Hoshi authored
Now the test harness was fixed, WebSocket should be available with BackForwardCache. Bug: 981740 Change-Id: I0adfaefac2032bb35e6e5488ed88f78fd979d877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690404Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c005b52e553..6697895fb46b Created with: gclient setdep -r src-internal@6697895fb46b The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I54c94de7ebcc306bf7edfde1f83e181383986e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728257Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682650}
-
Eric Seckler authored
We were accidentally attempting to return proto-formatted trace data as a text json stream instead of a binary stream over the protocol. Bug: 938879 Change-Id: Ia7215bb8c394199471eb42ec012ad8922193c0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724091 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#682649}
-
Jan Krcal authored
This CL adds the first version of identity pill -- only the triggering logic to show and to hide the pill. No animation nor UI changes are included in this CL. Bug: 967317 Change-Id: I76c98e9963ba97606bc9458eb111d3a6bc0872ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679764Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#682648}
-
Lowell Manners authored
This reverts commit 109a13b8. Reason for revert: This breaks the BackforwardCache, causing the wrong site to be shown on a back/forward navigation when the document is cached. TBR=alexmos@chromium.org Original change's description: > Do not hide the aura window of RWHVA > > Windows placed in inactive virtual desks will be considered > hidden by the occlusion tracker. This currently end up in > a call to RenderWidgetHostViewAura::Hide() which unnecessarily > hides the aura::Window. This causes issues when reflecting that > window in the desks mini_views. > > This CL keeps the aura::Window visible, while updating only > the occlusion state. > > BUG=866622 > TEST=Added a new test. > > Change-Id: I7f71cfa072240264fea2e4934f2c7350f66a74c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711113 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681459} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866622,988477, 988999 Change-Id: I7a40d0a8695682e08776a05547a36673a40d17ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725645 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682647}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ac3d131054ac..31590104ec86 git log ac3d131054ac..31590104ec86 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 dneto@google.com Add pass to inject code for robust-buffer-access semantics (#2771) 2019-07-30 zoddicus@users.noreply.github.com Update OpMemoryBarriers rules for WebGPU (#2775) 2019-07-30 dneto@google.com Add opt test fixture method SinglePassRunAndFail (#2770) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@31590104ec86 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I127c2fc7469a886098fa2663811ebd9e2942e3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728102Reviewed-by:
-
Himanshu Jaju authored
Integration tests were reverted because of this error: https://chromium-review.googlesource.com/c/chromium/src/+/1727231 Bug: 982229 Change-Id: Id88be2768477a06320ba1f664cdc762c2865d765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728652 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
-
vitaliii authored
Disable {virtual/blink-cors/}http/tests/security/img-crossorigin-redirect-credentials.html (expect Pass and Timeout), because flaky. TBR=yhirano@chromium.org Bug: 989365 Change-Id: I7df6d12e466b6ed626bd338a92ea86daea6e36b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728575 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by: -
Chromium WPT Sync authored
Using wpt-import in Chromium 5961d93d. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iedcb2912a69154c251e6bb334463f96344fb68be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728510Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682643}
-
Carlos Caballero authored
It is going away soon. Had to fix a lot of includes. Bug: 891670 Change-Id: I7da88b9801a5333a719ada8000a7399edf1957fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728573Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#682642}
-
Michael Ershov authored
Create a new int-enum policy to control CA certificate management permissions for users. It can have one of the following values: 0: Users can manage all CA certificates. 1: Users can manage user CA certificates, but not built-in CA certificates. 2: Disallow users from managing CA certificates CrSettingsCertificateManagerTest.All.ImportButton_CAPolicy, CertificateHandlerTest.* Bug: 958455 Test: CrSettingsCertificateManagerTest.All.MenuOptions_Edit, Change-Id: Idd81c4bb5b1375adc7a76f0c332d8372496ac7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718364 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:Matt Mueller <mattm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
All of 4 builders have less than 6 hour hourly resource usage in p99. http://shortn/_M8BzjMoQXa So I expect this won't add much burden to existing xenial pool. Bug: 954450 Change-Id: I0a6bae69557f8baa40e7abed1895025ded932dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728416Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#682640}
-
Anders Hartvoll Ruud authored
Instead of having an AdditiveKeyframeHook function which "patches" the InterpolationValue after it's created, this CL introduces the MakeAdditive function, which takes an InterpolationValue as input, and returns a new InterpolationValue with necessary flags set. This means we will need to copy the NonInterpolableValue in some cases, which *is* more expensive than poking the existing value. However, I think it's worth it if we can make NonInterpolableValues immutable (which will happen in a subsequent CL). Long term we might want to create the correct NonInterpolableValue in the first place, by passing the state we need to the converters. Bug: 981024 Change-Id: I897e176d38346a1c724e79dea028701bd33f922d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724510 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682639}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63b0b8018380..2c005b52e553 Created with: gclient setdep -r src-internal@2c005b52e553 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I3261d2248d4bb47b4d79143a7ff601ea8bc80bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728035Reviewed-by:
-
Ioana Pandele authored
Users that don't have password sync enabled cannot use this link, so it shouldn't be displayed. Bug: 860248 Change-Id: I52d3311cb637867116443571a6346d6418c92ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720776 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682637}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0b1b7f03bc17..88aae3b05111 git log 0b1b7f03bc17..88aae3b05111 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 perezju@chromium.org [Telemetry] Allow support of external results_processor 2019-07-31 dberris@chromium.org Add dberris@ to OWNERS Created with: gclient setdep -r src/third_party/catapult@88aae3b05111 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:981349 Change-Id: Iade5959d0f61461a0bbe276918a2fc77cec3465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728034Reviewed-by:
-
Carlos Caballero authored
It is currently just an alias to MessagePump::Type. This patch changes all references to use MessagePump::Type as MessageLoop will eventually disappear. This patch also changes some variable names from message_loop_type to message_pump_type. In particular one field of the GpuPreferences mojo struct. It is weird to see things like message_loop_type = MessagePump::Type::UI BUG=891670 Change-Id: I44680b19c83f009f7fbb0900f4d5b1140d51457f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726050Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
Before this CL, ResourceRequest for browser-initiated worker script loading (PlzDedicatedWorker and PlzSharedWorker) always doesn't set the |upgrade_if_insecure_| flag, and upgrade-insecure-requests handing completely doesn't work. To fix it, this CL plumbs the flag from outside FetchClientSettingsObject in a renderer process to the request created in the browser process. upgrade-insecure-requests handling works only when the browser-initiated request is redirected from a secure context to an insecure context. For non-redirect case where the request is directly sent to an insecure context from a secure context, upgrade-insecure-requests handling doesn't work because of https://crbug.com/917532 Note that this removes expectation files for virtual/omt-worker-fetch, but some tests are still suppressed by another expectation files for non-virtual. Bug: 906991, 917532, 987491 Change-Id: I690db42609133390fc6dc4aae150e0d94eab3199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715899 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Yi Su authored
Some public functions WebFramesManagerImpl are only used for unittests. These functions should be converted to private to improve encapsulation and unittests of WebFramesManagerImpl. Bug: 956516,956511 Change-Id: I9d5b85f9014ffe7cf60a77331cb308a27fb6b1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718408 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#682633}
-
