- 10 May, 2018 40 commits
-
-
Jian Li authored
These new files are simply copies of OfflinePageRequestJob files with name changes. They're not added to compile targets. This will allow easier reviewing for next patch that refactor OfflinePageRequestHandler to support both with network service enabled and without network service enabled. Bug: 841617 Change-Id: I295479cfe2240eddd77a7f9580af4c0346997282 Reviewed-on: https://chromium-review.googlesource.com/1053364Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557681}
-
Xi Han authored
ServiceManager. We need a thread to post/execute tasks when starting the ServiceManager. This thread needs to be created before the browser main loop is initialized, and will be registered as the BrowserThread::IO thread which is currently used by ServiceManager connections. The creation of such a thread is moved to service_manager::main via MainDelegate::CreateIOThreadAndGetTaskRunner(). Since it requires no thread created before calling fork() on posix, we also move the setup of sandbox before creating the IO thread. Bug: 740677, 729596 Change-Id: I23ef57eb52bfb1eb363682dadf98c571c12afcd1 Reviewed-on: https://chromium-review.googlesource.com/969098 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557680}
-
Evan Stade authored
This is a reland of f57e1c35 which was reverted due to being blamed for the msan failures which were fixed by d8f72fd2 Original change's description: > cros - Update appearance of resolution change notification. > > This removes the last raster asset in ash_resources.grd, so remove that > file and the associated build target. > > Bug: 840509,505953 > Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c > Reviewed-on: https://chromium-review.googlesource.com/1050523 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557292} TBR=jamescook@chromium.org,sky@chromium.org Bug: 840509, 505953 Change-Id: Iae0b07cbf2e14e307b74e11d07d21290ee72291b Reviewed-on: https://chromium-review.googlesource.com/1054222 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#557679}
-
Stefan Zager authored
TBR=evanm@chromium.org NOTRY=true Change-Id: I14319a25baa26ed7361e796839ed6b4c689529e5 Reviewed-on: https://chromium-review.googlesource.com/1054491Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#557678}
-
Ehsan Chiniforooshan authored
If the reader of the stream stops reading from it for some reason, a deadlock is possible: - WriteToStream() obtains stream_lock_ but does not release it because it is blocked on writing to the stream that is not read from. - CloseStream() does not close the stream because it waits on the lock that WriteToStream() is not releasing. I will remove the lock alltogether. So, CloseStream() does not wait and just closes the stream. Then, if the BlockingCopyFromString() statement of WriteToStream() is blocked, it will be signaled that the stream is closed. It is not a perfect solution because if CloseStream() closes the stream after the "if (stream_.is_valid())" check of WriteToStream() but before BlockingCopyFromString() reaches the wait statement, the stream handle becomes invalid and a DCHECK will fail. I cannot think of a simple solution right now, but the above-mentioned scenario is very unlikely to happen. For sure, this CL improves the current flakiness. Bug: 837215 Change-Id: I5d064b93dfb6af444c778bb60f156b29b43f1617 Reviewed-on: https://chromium-review.googlesource.com/1054092 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#557677}
-
Leonard Grey authored
Currently, all clicks on a bookmark folder button trigger their action on mouse down, so that the folder menu can open on mouse down as expected. This also includes command click, which, rather than opening the folder menu, opens all the bookmarks in the folder as new tabs. This isn't desirable since: - The expected behavior is that button clicks trigger on mouse up. - Triggering this on mouse down interacts poorly with the nested run loop created by the confirmation dialog we display when the folder has many links. This change causes the action to no longer fire on mouse down if the user is command-clicking the folder button. Bug: 840387 Change-Id: Ic1364160cf26f2f3ea6e67d7dd0d6cf5079082eb Reviewed-on: https://chromium-review.googlesource.com/1053947Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557676}
-
Yuke Liao authored
This CL: 1. Updates out-dated comments about component build. 2. Makes sure logging is configured before it is called, otherwise, all logs will be eaten. Change-Id: Ibe3a162f55e0ab5dbf38ce33e0e192d79bb1057b Reviewed-on: https://chromium-review.googlesource.com/1054345Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557675}
-
Dmitry Gozman authored
... since it's not overridden by embedder anymore. Bug: 775830 Change-Id: Ic719cb4f542785b5dc198900b3e0fca206ba5e86 Reviewed-on: https://chromium-review.googlesource.com/1045728 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557674}
-
Carlos IL authored
Change-Id: I09fe3e8759bba624fe1d39a796be32120de333de Reviewed-on: https://chromium-review.googlesource.com/1054368Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#557673}
-
Gabriel Charette authored
While having these enums since r396989 makes callsites more readable, I find that most of the time for simple use cases in tests I don't care much about the ResetPolicy (one time usage) and always want it to be NOT_SIGNALED initially. Surverying the codebase yields a slight majority of MANUAL over AUTOMATIC (from experience I've written AUTOMATIC in some places where it didn't matter either way as well). And NOT_SIGNALED is an obvious winner for InitialState. Also, IMO, MANUAL is the less-surprising default (i.e. can be used as a flag). As such I think having default arguments will vastly simplify writeability for code using WaitableEvents (tests in particular). Few sites will need to care and most that do will only need to specify the ResetPolicy. R=danakj@chromium.org Bug: 612843 Change-Id: Ib0ef193b041e64ea9456748633bc49c64af60f19 Reviewed-on: https://chromium-review.googlesource.com/1053843Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557672}
-
Stephen Lanham authored
This permission is needed on Cast devices, including Linux-based builds, but it was removed here: crrev.com/c/1045962. Restore it on Cast builds. BUG=b/79526220 Bug: 79526220 Test: CQ Change-Id: I0678a29e97eb003878db458dface608b6550d2fc Reviewed-on: https://chromium-review.googlesource.com/1054334Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557671}
-
Reid Kleckner authored
Add a missing 'clang::' namespace qualifier. TBR=thakis@chromium.org NOTRY=True BUG=841908 Change-Id: I60e48efbfd92017a3802e9f74d77a9ddcb307b27 Reviewed-on: https://chromium-review.googlesource.com/1054527Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557670}
-
Fady Samuel authored
This CL removes the ChildLocalSurfaceIdAllocator on the Blink main thread. Instead, RenderWidget::DidAutoResize requests a new LocalSurfaceId from the impl thread and continues to use the current LocalSurfaceId provided by the parent. A test was removed that was intended for the pre-child-allocation code path and another was simplified to verify that DidAutoResize requests a new LocalSurfaceId. A separate unit test verifies that the request goes from LayerTreeHost to LayerTreeFrameSink. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8e11ac681aee1c5ea7fa6406d3c6cfd806b79986 Reviewed-on: https://chromium-review.googlesource.com/1051868Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557669}
-
Ryan Tseng authored
This is done by reading the file in as a protobuf file, and then writing it back out again. No data is changed. Notable changes: * "field {" is used instead of "field: {" * All inner fields are ordered by field number, except for "header.id" * All extra spacing removed, except for top level spaces Bug: 840631 Change-Id: Ie91a27bf392834b2b186e9d354046f8eea059f11 Reviewed-on: https://chromium-review.googlesource.com/1053412 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#557668}
-
Pavol Marko authored
Keys that are stored on a user's public token are now recognized by GetKeyLocations. If no locations were found for a key, KeyPermissions::CanUserGrantPermissionsFor now returns false as a safeguard. A mechanism was introduced in nss_util.cc to simulate a separate private slot in Chrome OS browsertests. Bug: 839573 Test: browser_tests --gtest_filter=*PlatformKeysTest* Change-Id: If8b4cd4ef3a5763dd37a158426ec3cf87e1d10ae Reviewed-on: https://chromium-review.googlesource.com/1047208Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557667}
-
David Black authored
The fact that assistant controller is in Ash is self evident. Performing refactor now before code complexity increases. In the CL in which AshAssistantController was introduced, there was also going to be a ChromeAssistantController in browser. This did not actualize and there are no plans for a ChromeAssistantController so it is easier to refer to the singular AssistantController in ash. Bug: b:79493096 Change-Id: I5ff5150b3895274704ea18e20d149e13361b66b3 Reviewed-on: https://chromium-review.googlesource.com/1053365Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#557666}
-
Bence Béky authored
See discussion at https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/PJOXupl9ztA Bug: 841899 Change-Id: I58158270f304c5e6d50a85d47e1d3f599b5870d5 Reviewed-on: https://chromium-review.googlesource.com/1053831 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557665}
-
Patrick Monette authored
This is to make the terminology consistent for all the classes related to the Incompatible Applications Warning, which is the name used in the UI. Tbr: pkasting@chromium.org,battre@chromium.org, dpapad@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id4ec87a73d67985458f38d623b7f10a4979d594b Reviewed-on: https://chromium-review.googlesource.com/993699 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#557664}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0a8d63a4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17253 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-scoping TBR=markdittmer No-Export: true Change-Id: Ie6671a05bcacb0c331f1db4aa71e467b2fce751e Reviewed-on: https://chromium-review.googlesource.com/1053844 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557663}
-
Reid Kleckner authored
PPCallbacks::InclusionDirective now takes an extra SrcMgr::CharacteristicKind parameter. TBR=thakis@chromium.org NOTRY=True Bug: 841908 Change-Id: I34557d16829d34687fbdfdb0ee885b2ab2b75a3e Reviewed-on: https://chromium-review.googlesource.com/1054445Reviewed-by:
-
Eric Karl authored
This reverts commit 1f41d1da. Reason for revert: These flakes are addressed with https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659 Original change's description: > Disable flaky WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting on Android > > TBR=bsheedy@chromium.org > > Bug: 840725 > Change-Id: Id47604a849bcfcbb51e33ddf94ffa7a539ecb1df > Reviewed-on: https://chromium-review.googlesource.com/1049668 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556762} TBR=guidou@chromium.org,bsheedy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 840725 Change-Id: Ie558ae22bc52438a919ccf0a49d15bea6d2ab424 Reviewed-on: https://chromium-review.googlesource.com/1054350 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557661}
-
Joe Downing authored
BUG=680809 Change-Id: I923a3c5735f1769703e9e3c5bef6e9c2df80d91b Reviewed-on: https://chromium-review.googlesource.com/1054127Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#557660}
-
Peter Collingbourne authored
This simplifies the process of creating an APK, and will make it easier to create APKs with overlapping files. Bug: 835622 Change-Id: I57f884fc41d86c16ce81ad2adb703ffda64198cc Reviewed-on: https://chromium-review.googlesource.com/1041566 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557659}
-
xlai authored
Bug: 802053 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I95833e58c0b7aed7244918869af159325bee75c1 Reviewed-on: https://chromium-review.googlesource.com/1050618Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#557658}
-
Navid Zolghadr authored
NACL expects modifiers to contain buttons information. So we need to also set that information not only in buttons field but also modifiers. Bug: 839539, 839303 Change-Id: Ib859a2e071984be4625f0a42094982c7513ae5ae Reviewed-on: https://chromium-review.googlesource.com/1052171Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557657}
-
Jamie Madill authored
These configs are superceded by the standalone ANGLE configs. Bug: 833999 Change-Id: I3b5e2fc869ea4a08b5412682aa60de9b183696f1 Reviewed-on: https://chromium-review.googlesource.com/1054147Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
-
erikchen authored
On ChromeOS builds, defined(OS_LINUX) also evalutes to true, so defined(OS_CHROMEOS) must come first in order to ensure that the correct product name is set. Change-Id: I17e15b4aafc486d6b09ce5745a9f86638afe0b65 Reviewed-on: https://chromium-review.googlesource.com/1053961Reviewed-by:
-
Avi Drissman authored
This reverts commit 3c6230c7. Reason for revert: Breaks lots of trybots. https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8946884395716827184%2F%2B%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout /b/swarming/w/ir/cache/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/test/browser_tests/chrome_password_protection_service_browsertest.o.d -DHAS_[.l..]rd_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc -o obj/chrome/test/browser_tests/chrome_password_protection_service_browsertest.o ../../chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc:491:22: error: too many arguments to function call, expected 2, have 3 "stub-user@example.com"); ^~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc:120:3: note: 'PrepareSyncAccount' declared here void PrepareSyncAccount(const std::string& hosted_domain, ^ 1 error generated. Original change's description: > Refactor HashPasswordManager to accept multiple password hashes > > This CL doesn't change existing behavior, but only refactor > HashPasswordManager class such that it can keep track of multiple > password hashes. This CL introduces a new struct PasswordHashData to > replace SyncPassswordData. > > Migration from SyncPasswordData to PasswordHashData is in place so that > we'll not lose already captured sync password. IsSyncPasswordHashSaved > histogram enum is added to track this migration. SyncPasswordData > will be deprecated after the transition period. > > Bug: 830998 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 > > TBR=jochen@chromium.org > > Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 > Reviewed-on: https://chromium-review.googlesource.com/1036464 > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557646} TBR=xiyuan@chromium.org,meacer@chromium.org,dvadym@chromium.org,jialiul@chromium.org Change-Id: I9c30d5a060590f6bf3fd24c2a527e5838d5308c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830998 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1054467Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557654}
-
Peter Wen authored
Includes documentation for recent changes for native editing, fast by default, and channel support. Bug: 620034 Change-Id: Ie6570a4c032853a4bfdfd3443091ea7f698e8e99 Reviewed-on: https://chromium-review.googlesource.com/1054333 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/a932b6b51505..6110763fec16 $ git log a932b6b51..6110763fe --date=short --no-merges --format='%ad %ae %s' 2018-05-09 geofflang Refactor the GL surfaces and framebuffers to not hold renderer objects. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I772f5370dc65670e539cc2d256fbfc094c1fba0d Reviewed-on: https://chromium-review.googlesource.com/1053792Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557652}
-
Eric Karl authored
This reverts commit 7241f600. Reason for revert: These flakes are addressed with https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659 Original change's description: > Disable flaky testControlsVisibleAfterExitingVr_WebXr. > > Disable org.chromium.chrome.browser.vr_shell.WebVrTransitionTest > testControlsVisibleAfterExitingVr_WebXr, because it is flaky. > > TBR=bsheedy@chromium.org > > Bug: 841103 > Change-Id: I55651a634cfd81b43fd3668660cc3d59eda008a1 > Reviewed-on: https://chromium-review.googlesource.com/1052012 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557181} TBR=bsheedy@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841103 Change-Id: I6c99f796ec56a02dbd448d0571832348bcd83d6f Reviewed-on: https://chromium-review.googlesource.com/1054349Reviewed-by:
-
Toni Barzic authored
Leaving tablet mode on lid state changes is a workaround for the lid being erroneously detected as fully open at small lid angles, which could cause the device to be detected as in tablet mode while opening the lid. This workaround should not override tablet mode state if tablet mode switch is on - this is a reliable indicator that the device actually is in tablet mode. Overriding this state could be problematic on detachable devices if the keyboard is detached while the lid is closed. In that case, the device could report lid as open after entering the tablet mode, and subsequently, and unexpectedly leave the tablet mode. BUG=b/79327284 Change-Id: I31f2d31182122fc8a6a73e185360858e035118fe Reviewed-on: https://chromium-review.googlesource.com/1054370Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557650}
-
Carlos IL authored
Renamed SSLErrorTabHelper to SecurityInterstitialTabHelper and moved it into components. Currently that TabHelper is only used for committed SSL interstitials, but the plan is to reuse it for safe browsing committed interstitials, hence the rename. Its unit tests were also modified to not depend on //chrome code. Change-Id: Iaede7d9e5075dcaa6fd2ff929563e59068bac079 Reviewed-on: https://chromium-review.googlesource.com/1053120 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557649}
-
Nektarios Paisios authored
Cause behind P1 bug that prevented NVDA to read spin controls, i.e. <input type="number">. Broke NVDA, was not used by ChromeVox and Select to Speak, wasn't needed by VoiceOver and also doesn't work on Safari either. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 730965 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic59229d286bf1b0992253408a77730d662bc2876 Tested: Manually Reviewed-on: https://chromium-review.googlesource.com/1044709Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#557648}
-
https://pdfium.googlesource.com/pdfium.git/+log/95061379c945..80302c77a854 $ git log 95061379c..80302c77a --date=short --no-merges --format='%ad %ae %s' 2018-05-10 rharrison Use test_dir instead of 'pdfium' for source type 2018-05-10 thestig Add CPDF_Transparency. 2018-05-10 thestig Make GetTestDataDir() work in a non-standalone checkout. 2018-05-10 tsepez Fix destruction order in CPDF_Dibsource. 2018-05-10 npm Remove a completeness check from CJBig2_GRRDProc::DecodeTemplate0Opt Created with: roll-dep src/third_party/pdfium BUG=chromium:841513,chromium:840695,chromium:841200 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I579c4a7663af521bb842f5e0f309f2bcd71732f3 Reviewed-on: https://chromium-review.googlesource.com/1054263Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557647}
-
Jialiu Lin authored
This CL doesn't change existing behavior, but only refactor HashPasswordManager class such that it can keep track of multiple password hashes. This CL introduces a new struct PasswordHashData to replace SyncPassswordData. Migration from SyncPasswordData to PasswordHashData is in place so that we'll not lose already captured sync password. IsSyncPasswordHashSaved histogram enum is added to track this migration. SyncPasswordData will be deprecated after the transition period. Bug: 830998 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 TBR=jochen@chromium.org Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 Reviewed-on: https://chromium-review.googlesource.com/1036464 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#557646}
-
Dale Curtis authored
We shouldn't be crashing if a user attempts to put h264 content in a developer build that doesn't support proprietary codecs; we should instead just fail gracefully during decode. BUG=b/63115808 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2fc1321453a2ae160b86a379a724b7acefe3b45d Reviewed-on: https://chromium-review.googlesource.com/1054328Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557645}
-
Victor Costan authored
BackgroundSyncContext's members background_sync_manager_ and services_ are documented to only be accessed on the IO thread. However, the BackgroundSyncContext destructor accesses them when running their destructors, even though it may be run on any thread (BackgroundSyncContext is RefCountedThreadSafe). These accesses are not threadsafe. This CL solves the thread safety issues by having the class' destructor run on the IO thread. Change-Id: Ib40c94987ee7cdfc58d513561493d4c8155b4b2d Reviewed-on: https://chromium-review.googlesource.com/1053404 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557644}
-
Caleb Rouleau authored
For desktop, have Chrome allocate the remote port itself by passing 0. For Android, have the adb_server allocate the port forwarding port itself by passing 0. Bug: chromedriver:2161, chromedriver:2400 Change-Id: I2eccc2979c116ca47909bb84b8c81c5fb5c4cd75 Reviewed-on: https://chromium-review.googlesource.com/994378Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#557643}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0675e8b8e369..f24714c46c60 $ git log 0675e8b8e..f24714c46 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 perezju [soundwave] Implement --continue for timeseries 2018-05-09 benjhayden [dashboard] Add Google Surveys to alerts, report, group_report, speed_releasing. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I2adf1095944176286a4d0d995f58e6e84442a757 Reviewed-on: https://chromium-review.googlesource.com/1054250 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557642}
-
