- 16 Mar, 2020 40 commits
-
-
Benoit Lize authored
The hooks' spinlock in PartitionAlloc is not performance-sensitive, and is likely used as PartitionAlloc used not to rely on base/. Removing it to reduce the use of custom locking (see the attached bug for motivations). Bug: 1061437 Change-Id: Id1d74ac9f108bdc462fd0d5586e89b0be056b67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102532 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#750521}
-
Yoav Weiss authored
This fixes a regression from [1], which accidentally modified CrOS' User-Agent string. Bug: 1061132 Change-Id: Ib42fe7eb840ceab38dba9a29d498b5c9ed041fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102554Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#750520}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb9a86a9d867..d1d96d73bff7 git log cb9a86a9d867..d1d96d73bff7 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 18daa81e3d3d..3a50a43df988 (14 commits) Created with: gclient setdep -r src/third_party/angle@d1d96d73bff7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ynovikov@chromium.org Change-Id: Ic72e9c810a5fd501931e5f2d6c78a7353807bc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750519}
-
Vasilii Sukhanov authored
Mock: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g76725620de_2_176 Bug: 1047726, 1061087 Change-Id: If49570dfefec51614814f314d0fe1cce4a64aaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095731Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750518}
-
Colin Blundell authored
WebLayer will shortly be incorporating //components/navigation_interception, following the model set by //chrome. As a precursor, this CL moves the functionality that is in the //chrome subclass of InterceptNavigationDelegate to be available to all embedders via a construction parameter of InterceptNavigationDelegate. WebLayer will reuse this functionality. TBR=eroman@chromium.org Bug: 1031465 Change-Id: I0dae07c117e071d9bc16e937cc5dc5cd64960ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102730 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750517}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7146ea83c0c4..29de50e4d8ee git log 7146ea83c0c4..29de50e4d8ee --date=short --first-parent --format='%ad %ae %s' 2020-03-16 hjd@google.com ui: Fix thread state Created with: gclient setdep -r src/third_party/perfetto@29de50e4d8ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:151569976 Tbr: perfetto-bugs@google.com Change-Id: I9c61478b50d8f35f60f560baaae0cfc9cd3cae12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104706Reviewed-by:
-
Wolfgang Beyer authored
A DevTools CL (see below) changes the expected output for this test. This patch temporarily allows the relevant Blink Web Test to fail, so that we can land the devtools-frontend patch. We can re-enable and update the test once that happens. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078851 Bug: chromium:1041830 Change-Id: I38bfd1bcb14da3382ced9fd145aa60a9d22cb8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095591 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#750515}
-
Gauthier Ambard authored
This reverts commit 9e64c392. Reason for revert: Failing on iOS device. See crbug.com/1061863 Original change's description: > Set a limit on how shared memory can be mapped in one process. > > Allowing arbitrary amounts of shared memory to be mapped can make it > easier for an attacker to bypass ASLR as documented in > https://googleprojectzero.blogspot.com/2019/04/virtually-unlimited-memory-escaping.html > > Bug: 1056572 > Change-Id: I812542e2b3d9e7842a7ae54bdd837fa956a99177 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083447 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750211} TBR=dcheng@chromium.org,rkaplow@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056572 Change-Id: I78af6cfd9737a96cbb120c6e3db769145c244f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104050Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#750514}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cb66c20c2371..80ed7ca9c63c git log cb66c20c2371..80ed7ca9c63c --date=short --first-parent --format='%ad %ae %s' 2020-03-16 szuend@chromium.org Use Ninja to build ArrayUtilities unit test Created with: gclient setdep -r src/third_party/devtools-frontend/src@80ed7ca9c63c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9fa271ac22f4aec0d9e6a5510d68f2553450e32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104705Reviewed-by:
-
Fredrik Söderqvist authored
This starts dismantling SVGFilterPainter by moving some of the logic into the FilterData class. Various methods are added to FilterData to handle manipulation of its state. Member fields are made private. The kPaintingFilter* states are renamed to kGeneratingFilter* because that more closely describes what they are there for (which is made more obvious by the new structure). Bug: 109224 Change-Id: Idfa1d584b4d37c8e4d6733f8729e8e942313533c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102573 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750512}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/567ffda407c9..f4a3e7498a60 Created with: gclient setdep -r src-internal@f4a3e7498a60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I20e12914a9b39e6809c3d3b8fa54bd322e33c97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104703Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750511}
-
Dominik Röttsches authored
Address gab's additional review comments from https://chromium-review.googlesource.com/c/chromium/src/+/2032119/6#message-3d833beea111694a8a8920ede2468ac775ca310a Make DWriteFontLookupTableBuilder use a DeferredSequencedTaskRunner instead of manually maintaining the pending callbacks vector.Replace WaitableEvent with AtomicFlag.AtomicFlag makes things simpler in comparison to introducing our own sequence guarded boolean, as its used synchronously in tests. Bug: 1047054 Change-Id: I8a07c3eadec6f45784be013d062a467ab496dfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083143 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#750510}
-
Will Cassella authored
The reference pages for the 'embedded_style_media_queries*' tests previously didn't wait to take a screenshot (as opposed to their counterparts which wait 100ms to take a screenshot), causing them to be a bit flaky. This CL fixes that. Change-Id: Ie8dd12b3b4dd7f810d72b3ba94ae2e5cb3644fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103142 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#750509}
-
Gauthier Ambard authored
This reverts commit 092dd8d9. Reason for revert: Failing on device bots. See crbug.com/1061867 Original change's description: > [AppLauncher] Look at core page transition type rather than explicit. > > This allows page to open app URLs via JavaScript. > > Bug: 1058388 > Change-Id: I3aabfab102c89156c342cf8f4fec72e69d69e2fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087905 > Reviewed-by: Peter Lee <pkl@chromium.org> > Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750317} TBR=pkl@chromium.org,seblalancette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058388 Change-Id: I202ca98be0ab43a77dabd03d3e6e13a09c5f61a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102542Reviewed-by:
-
Kei Nakashima authored
Implemented |NewLinkedHashSet::front|, |NewLinkedHashSet::back|, |NewLinkedHashSet::size|, |NewLinkedHashSet::IsEmpty|. Also added tests for those functions. Along with this change, added DCHECK to |VectorBackedLinkedList::front| and |VectorBackedLinkedList::back|. Change-Id: I8f90dd8b744b85dd4ceb8366a64398d5f88c34bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103595Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
James Cook authored
A couple of tests verify that no notifications are shown if the sync system is disabled. They need to be updated to turn off OS sync on Chrome OS, because we still show the notifications if OS sync is enabled. These manifest as unit_tests failures when I run: unit_tests --enable-features=SplitSettingsSync This CL is preparation for turning SplitSettingsSync on by default. Bug: 1060289 Change-Id: Ia3e8d9d3b5be0879b1c929faed0f988338b730bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103439 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#750506}
-
Rob Buis authored
Implement the CSS property math-style as specified in [1]. The property is still a proposal [2] so it is toggled using the runtime flag CSSMathStyleEnabled. It a CSS property rather than an extra field of ComputedStyle because it will be used (amongst other things) in the MathML UA sheet to implement complex inheritance of scriptlevel/displaystyle and in the resolution of font-size (in particular they should have high priority). Additionally, we believe it makes sense to expose these properties for users (other than just MathML attributes) so that people can understand the magic behind the scriptlevel and displaystyle changes. However, we probably don't want to expose these properties yet, until details are agreed with the CSSWG. [1] https://mathml-refresh.github.io/mathml-core/#the-math-style-property [2] https://mathml-refresh.github.io/mathml-css-proposals/math-script-level-and-math-style-explainer.html Bug: 6606 Change-Id: I0d854c0829f5b7453901651a97efd5a7e5cea39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100787 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#750505}
-
Shik Chen authored
When the system is extremely slow, the buffer allocation of the output buffer can fail and upper layer would get the raw un-rotated buffer. This CL mitigates the issue by increasing the pool size. Bug: 1061346 Test: Run Hangouts Meet and `stressapptest -M 32 -m 0 -i 0 -c 2 -s 30` concurrently, the flipped frame count in 30s dropped from 85 to 0 on Nocturne. Change-Id: I16a5cd260adc2799d8109bf323eae413ef7ac612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102268 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#750504}
-
Kunihiko Sakamoto authored
TBR=gyuyoung@igalia.com No-try: true Bug: 1061180 Change-Id: Iacddc75a342283f5be7bf27ff67854f0ef7f24ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104850Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750503}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibe92a15c48d11ea70391663a780bb846d90ccb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102934Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#750502}
-
Ewann authored
Only failure for EG1 were seen. Enables testEmptyOmnibox for iPhone 13.3 and later, EG2 only. Bug: 1046787 Change-Id: I2aec75146a8a6a32ba28f14438cc092956ee09d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094988 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#750501}
-
Andreas Haas authored
This CL removes the list of ArrayBufferViews held by the ArrayBuffer. This list was originally introduced to handle a bug use-after-free issue in audio buffers, but this issue has been dealt with otherwise in the meantime, see https://docs.google.com/document/d/1h0bfIeGIqNCFi7iKyKKYDbQKpflSvA1kMNh74MCgHZM/edit?usp=sharing. Additionally I removed dead code: * ArrayBufferViews are never detached anymore. * ArrayBufferViews cannot be marked as detachable. R=ulan@chromium.org, haraken@chromium.org CC=hongchan@chromium.org, rtoy@chromium.org Bug: chromium:1008840 Change-Id: I5ee1093a94882e7e2260157cbb88c618bf052a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102530Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Rename single_client_apps_sync_test.cc to single_client_extension_apps_sync_test.cc to be consistent with two_client_extension_apps_sync_test.cc. Bug: 1025156 Change-Id: I634d72d920cdd42d1c8dd3b9fe8bfda588ac5a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103732 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL blocklists WebFileSystem from bfcache. Bug: 1060936 Change-Id: I7e0055f47a30baedafc2d4849c3c6f2fb89dcf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094389 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750498}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5609eb6d5256..cb66c20c2371 git log 5609eb6d5256..cb66c20c2371 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 szuend@chromium.org Prepare Linkifier.js for asynchronous live locations Created with: gclient setdep -r src/third_party/devtools-frontend/src@cb66c20c2371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib0d5d96daf87fb3f0992fc410358cbe486a565c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104699Reviewed-by:
-
Mario Sanchez Prada authored
This CL converts the message that notifies the message that the renderer will send to the browser as a response to PerformAction() with kHitTest when the object being hit in the renderer happens to have a child frame, in order to instruct the browser to request a new hit test focused on such child frame as the reference point. Bug: 1010831 Change-Id: I0911124db853f12e4e4e35acd580e48191b47cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096578Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#750496}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd3d91691f1e..7a8f79762c4a git log dd3d91691f1e..7a8f79762c4a --date=short --first-parent --format='%ad %ae %s' 2020-03-13 vasniktel@gmail.com Update dependencies (#3228) 2020-03-12 greg@lunarg.com Instrument: Debug Printf support (#3215) 2020-03-12 vasniktel@gmail.com spirv-fuzz: Support OpPhi when adding dead break and continue (#3225) 2020-03-12 afdx@google.com spirv-fuzz: Fix vector width issue in 'add equation instructions' pass (#3223) Also rolling transitive DEPS: src/third_party/spirv-headers/src dc77030acc9c..30ef660ce2e6 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7a8f79762c4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I4edbebbb32b73fe2bd61142d3f8b1197478817a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104701Reviewed-by:
-
Morten Stenshorne authored
Some block fragmentation unit tests had to be "rebaselined", since we don't see fragments inside lines anymore. Also skip virtual layout_ng_block_frag and layout_ng_fieldset tests when NG is disabled. There's something weird going on with the feature implication mechanism, but running these tests when NG is disabled is pretty meaningless anyway. Bug: 829028, 982194 Change-Id: Ia5e860145cb348425d6171ba624e80c25090983b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102648 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/314e048432c6..567ffda407c9 Created with: gclient setdep -r src-internal@567ffda407c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7fd3b409694149053c9686f85ef56e5d251d9306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104700Reviewed-by:
-
Timothy Loh authored
This CL updates the notification displayed when Plugin VM fails to launch to accommodate both the new error codes, and the unknown error cases. A subsequent CL will probably change this notification into a dialog, so I've temporarily omitted adding screenshots for the strings. Bug: 1041313 Change-Id: I47b3036d167807cc611bc7d7788acc9669060a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100453 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#750492}
-
Keita Suzuki authored
This commit removes all original pywebsocket dependencies. Change-Id: Ied7fb043ed5f82fc87b328f4aa9600624552fbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100148Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#750491}
-
Hiroshige Hayashizaki authored
This CL makes stripUrlForUseAsReferrer() more spec-conformant, in order to support `data:` URLs as the argument, which can happen in testing subresource requests from data: URL workers (no such tests so far though). Bug: 906850 Change-Id: I3ba7b1fbf27e79624d9c09fa2c65862b45d17338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102302Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#750490}
-
Andreas Haas authored
This CL replaces the use of ArrayBuffer in EncodedVideoChunk by DOMArrayBuffer. ArrayBuffer is deprecated. R=yukishiino@chromium.org Bug: chromium:1008840 Change-Id: I3b1bdefce6a7e60e6b30ddaf6f55dbe1b748da3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102584Reviewed-by:
-
Kent Tamura authored
This is a preparation to enable LayoutNG for <input type=file>, which will use the normal LayoutNGBlockFlow. Change the argument type of LayoutFileUploadControl constructor because CreateObject<> template asks a LayoutObject constructor for taking an Element* argument. This CL has no behavior changes for now because FileInputType has TypeShouldForceLegacyLayout. Bug: 1040826 Change-Id: I57a1bc5adb03ed7222d7793155f76abd148b1c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104808 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#750488}
-
Shik Chen authored
When the system is extremely slow, the buffer allocation of the output buffer can fail and upper layer would get the raw un-rotated buffer. This CL mitigates the issue by reusing the original buffer for 180 degrees rotate, which is the default orientation of the user facing camera on Nocturne. Bug: 1061346 Test: Run Hangouts Meet with screen rotated with 0, 90, 180, 270 degrees. Change-Id: I7051fa9e0c3857345ff3ad1916fd3d91d6a59f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101324Reviewed-by:
-
Hiroshige Hayashizaki authored
Manual change: wpt/mixed-content/spec.src.json. Previously, it omitted `http-rp/unset` tests because it expected redundant tests `meta/unset`. However, in certain worker-related tests, there are no `meta` tests, and thus `http-rp/unset` is not redundant. This CL enables generating such non-redundant `http-rp/unset` tests, namely `sharedworker-{classic,module}.http-rp/unset`, i.e. SharedWorkers served from HTTPS origin without no opt-in CSP headers. All other changes are mechanical. Bug: 1061679, 1056500 Change-Id: Ib8c323cf06e1c6e0a0bdeae713bd13848335b95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103967 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: -
Hiroshige Hayashizaki authored
This CL excludes "sharedworker-module" subresources in `spec.src.json`s, because such generated tests are not added to the repository. Bug: 906850 Change-Id: I8d73dbed296c9dda35a4c6e6a8913881f6baeadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102829 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Previously, dump_test_parameters() (which uses json.dumps()) was used to calculate the keys of `exclusion_dict`, so that the keys of `exclusion_dict` include all the fields of the selections. However, this was slow. This CL instead uses `excluded_selection_pattern % selection` where excluded_selection_pattern incudes "`%(key)s`" for all the keys of the selections, except for "expansion". (The exclusion of "expansion" is probably good, as differences in "expansion" fields shouldn't prevent excluded test matching) This CL improves the generator's performance about 5x. This CL doesn't change the generated results or test behavior. Bug: 906850 Change-Id: I67f2cf6e960d7867a9b409cb84bf8249ac1912c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100562 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
`spec_json.js` are not used in WPT production runs. This CL removes them, to omit `spec_json.js`-related diffs in upcoming CLs. This CL doesn't change the generated results or test behavior. Bug: 906850 Change-Id: I1001286f2680294f1d8e747f23a25040f5bfd253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103728 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/735a9cd7804e..314e048432c6 Created with: gclient setdep -r src-internal@314e048432c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1061670 Tbr: jbudorick@google.com Change-Id: Ife9c6b05dab3509413b2a1e40abe3304bb3108c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104695Reviewed-by:
-
