GitLab

BUG=414233

Review URL: https://codereview.chromium.org/545973003

Cr-Commit-Position: refs/heads/master@{#296209}

Note: thie will also change the name of some of our
raster_worker_pool_* performance tests.

BUG=
R=vmpstr@chromium.org

Review URL: https://codereview.chromium.org/584393003

Cr-Commit-Position: refs/heads/master@{#296208}

Split the Perl script into 2 and shard the actual checking, so we can
run it in parallel. On bots, this reduces the time needed to complete
"check licenses" step from 3-4 mins to 40 seconds!

I'm planning to rewrite the scanner in Python soon, but I see that this
change can already help running trybots faster.

BUG=416496

Review URL: https://codereview.chromium.org/589143002

Cr-Commit-Position: refs/heads/master@{#296207}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/593033002

Cr-Commit-Position: refs/heads/master@{#296206}

A valid scenario, observed in the wild, is a touchstart handler removing
itself and adding a touchmove handler. If those are the only touch
handlers on the document, the renderer will forward two distinct handler
existence notifications to the browser. This causes the TouchEventQueue
to effectively drop the remainder of the touch sequence, even though the
element targetted by the touchstart now has a touchmove.

Fix this scenario by making the TouchEventQueue effectively idempotent
to repeated addition and removal of touch handlers. In practice, this
means simplifying its statefulness and instead relying on the existing
pointer id state map to determine whether to forward touches for the
remainder of the sequence.

BUG=412723

Review URL: https://codereview.chromium.org/586553002

Cr-Commit-Position: refs/heads/master@{#296205}

BUG=415838
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/597593002

Cr-Commit-Position: refs/heads/master@{#296204}

BUG=371012

Review URL: https://codereview.chromium.org/575283005

Cr-Commit-Position: refs/heads/master@{#296203}

This removes the rest of guava from a chromium checkout.

It also removes a workaround in build/android/gyp/javac.py
which sorts input files for javac. The issue was fixed in guava 14
(https://code.google.com/p/guava-libraries/issues/detail?id=950),
but it was never rolled in to chromium.

The last remaining files in third_party/guava are left because
some bots do not delete non-existing DEPS. COPYING is a copy of the
current version of the COPYING file from the guava repository.
See http://crbug.com/380688 for details about the DEPS issue.

BUG=412673

Review URL: https://codereview.chromium.org/574103002

Cr-Commit-Position: refs/heads/master@{#296202}

This CL adds two initial tests that use mock URLRequestJob to
intercept URL requests.

BUG=415781

Review URL: https://codereview.chromium.org/558333007

Cr-Commit-Position: refs/heads/master@{#296201}

This CL links libsanitizer_options into every executable built with ASan on OSX.
The existing implementation of __asan_default_options for Chromium.app is merged
with that in sanitizer_options.cc

Also now use_sanitizer_options is only set when building with sanitizers so that
there isn't an unconditional dependency on an empty object file in every
executable in non-sanitizer builds.

In addition to that, the dependency on sanitizers.gyp:sanitizer_options is removed
from ui/base/ui_base_tests.gyp:ui_base_tests_bundle which is not a real shared lib,
despite marked as such.

BUG=302040
TBR=earthdok@chromium.org,cpu@chromium.org
R=avi@chromium.org

Review URL: https://codereview.chromium.org/594843002

Cr-Commit-Position: refs/heads/master@{#296200}

"Add New User" screen should have enabled all hardware
keyboards, owner and system input methods.

BUG=365299
TEST=manual

Review URL: https://codereview.chromium.org/484353005

Cr-Commit-Position: refs/heads/master@{#296199}

BUG=404089

Review URL: https://codereview.chromium.org/571623003

Cr-Commit-Position: refs/heads/master@{#296198}

BUG=none

Review URL: https://codereview.chromium.org/592413002

Cr-Commit-Position: refs/heads/master@{#296197}

BUG=0
NOTRY=true

Review URL: https://codereview.chromium.org/589353002

Cr-Commit-Position: refs/heads/master@{#296196}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/63c0786..f704a8d

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/598593002

Cr-Commit-Position: refs/heads/master@{#296195}

This CL adds an app_shell_browsertest to verify the existence of the webview API.

BUG=352290

Review URL: https://codereview.chromium.org/581283002

Cr-Commit-Position: refs/heads/master@{#296194}

While setting up the scrollbar layer if the properties of the scrollbar
layer didn't change, then avoid setting update_draw_properties.
Scrollbar needs animation if any of the scrollbar properties changed.
In the same way set update_draw_properties if scrollbar properties
are changed.

Review URL: https://codereview.chromium.org/595913002

Cr-Commit-Position: refs/heads/master@{#296193}

Reusing the "base::StringPairs" insted of  "std::vector<std::pair<std::string, std::string> >"
same is defined in  base/strings/string_split.h.

BUG=412250

Review URL: https://codereview.chromium.org/591313004

Cr-Commit-Position: refs/heads/master@{#296192}

Revert of Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #5 id:100001 of https://codereview.chromium.org/588523002/)

Reason for revert:
It broke some internal webrtc bots, revert it for now and will reland it after fixing the problems.

http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Mac%20Tester/builds/22092

Original issue's description:
> Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> BUG=415935
> TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
>
> Committed: https://crrev.com/a5e9fc62b7bf25931ffe6153cc738098d8119c28
> Cr-Commit-Position: refs/heads/master@{#295990}

TBR=tommi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415935

Review URL: https://codereview.chromium.org/594883002

Cr-Commit-Position: refs/heads/master@{#296191}

Controlled with Variations parameter "hide_promo_header" which should be set to "enabled" for the image to be hidden

BUG=413337
TBR=jhawkins

Review URL: https://codereview.chromium.org/587803003

Cr-Commit-Position: refs/heads/master@{#296190}

BUG=414794

Review URL: https://codereview.chromium.org/591263002

Cr-Commit-Position: refs/heads/master@{#296189}

BUG=338303

Review URL: https://codereview.chromium.org/560523004

Cr-Commit-Position: refs/heads/master@{#296188}

This is particularly important on Mac, where unless we do this the Bookmarks/History
menu bar items will reflect the last active profile (which has now been locked).

On Windows this is a nice to have and to be consistent. Overall this adds an extra
layer of security that you won't accidentally open a locked profile's window.

BUG=412952

Review URL: https://codereview.chromium.org/585653002

Cr-Commit-Position: refs/heads/master@{#296187}

BUG=399456

Review URL: https://codereview.chromium.org/575213002

Cr-Commit-Position: refs/heads/master@{#296186}

The stack trace suggests LSOpenApplication fails to find the shim, and this
happens after waiting on a run loop. So a likely cause is that we're not
successfully waiting for the file operations to finish.

This CL changes the test to observe the parent directory instead of the shim
directory, and adds checks that the path exists before proceeding. If the test
still fails for this reason, at least it'll say so.

BUG=415422

Review URL: https://codereview.chromium.org/598443002

Cr-Commit-Position: refs/heads/master@{#296185}

BUG=371012

Review URL: https://codereview.chromium.org/578423002

Cr-Commit-Position: refs/heads/master@{#296184}

BUG=78512
TEST=no change

Review URL: https://codereview.chromium.org/565263005

Cr-Commit-Position: refs/heads/master@{#296183}

BUG=331829,373148,299841,103304
TEST=ninja -C out/Debug ui_unittests, then verify that
out/Debug/ui_base_unittests is there and runs. Same thing with
ui_unittests
R=sky@chromium.org

Review URL: https://codereview.chromium.org/588963002

Cr-Commit-Position: refs/heads/master@{#296182}

This adds a missing "_" suffix to |ozone_buffer_factory| member
variable in ozone implementation of GpuMemoryBufferFactory interface.

BUG=
TBR=alexst@chromium.org

Review URL: https://codereview.chromium.org/594043004

Cr-Commit-Position: refs/heads/master@{#296181}

This reverts commit 41c3d488, CL https://codereview.chromium.org/489103004.

The above change caused a couple of UI issues, as well as internationalization troubles (http://crbug.com/377410#c10). We should land it again after all the fixes get incorporated.

BUG=416754,416818,416825,416757,377410
TBR=engedy@chromium.org,pkasting@chromium.org,btapiz@gmail.com,danbeam@chromium.org

Review URL: https://codereview.chromium.org/589353003

Cr-Commit-Position: refs/heads/master@{#296180}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/595883002

Cr-Commit-Position: refs/heads/master@{#296179}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3cba268..63c0786

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/600433002

Cr-Commit-Position: refs/heads/master@{#296178}

Telemetry leaves a memory hogging subprocess behind if:
1) A Monsoon Power Monitor is attached to host computer (Linux),
2) User runs a power-metric-using benchmark such as sunspider on Android
   ChromeShell, and
3) Benchmark raises an exception between power metric's Start and Stop
   calls. For example, an exception will occur if browser crashes and
   the benchmark does something like tab.WaitForJavaScriptExpression().

This patch fixes the issue by setting the daemon flag on the subprocess.
This will cause the main process to kill the subprocess on exit.

BUG=413596

R=ernstm@chromium.org

Review URL: https://codereview.chromium.org/572643002

Cr-Commit-Position: refs/heads/master@{#296177}

For DrawQuads and SharedQuadState, RenderPass used allocate them one by
one whenever needed. This new class helps RenderPass manages allocation
and iteration of those two types. This container allocates a chunk of
memory at one time and hands out raw pointers. It also provides iterator
and reverse iterators for going through its contents.

Unittest for ListContainer makes sure the raw pointers it hands out are
valid and iterator has same behavior as vector iterators.

Follows 398533002, and 404563005.

BUG=344962

Committed: https://crrev.com/6ae8c50c839a8c0d8fb399578256c754ed3ce39a
Cr-Commit-Position: refs/heads/master@{#296100}

Review URL: https://codereview.chromium.org/400463002

Cr-Commit-Position: refs/heads/master@{#296176}

It observes OnProfilesChanged, but the set of profiles changing doesn't
affect the start page. However, it probably once helped avoid crashes
when deleting profiles since the AppListViewDelegate would hold on to
the Profile* until the app list was shown again. But that was fixed in
http://crrev.com/291852 (now AppListServiceImpl::DestroyAppList() will
reliably tear down the AppListView if the profile is destroyed, without
having to wait for a ShowAppList().

When regular profile switching occurs (i.e. not when the profile is
being destroyed), the profile currently being used by the
StartPageView is also replaced. That is handled by
AppListMainView::ModelChanged() calling into
ContentsView::InitNamedPages() which makes an entirely new
StartPageView().

BUG=403647

Review URL: https://codereview.chromium.org/589333002

Cr-Commit-Position: refs/heads/master@{#296175}

BUG=416843
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/594853002

Cr-Commit-Position: refs/heads/master@{#296174}

BUG=412402

Review URL: https://codereview.chromium.org/592353002

Cr-Commit-Position: refs/heads/master@{#296173}

Cr-Commit-Position: refs/heads/master@{#296172}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cbea1bc..3cba268

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/595753003

Cr-Commit-Position: refs/heads/master@{#296171}

BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/597523002

Cr-Commit-Position: refs/heads/master@{#296170}