- 18 Apr, 2018 17 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/73d9591f..059b1287 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I11d179623a886cd80cf4ae9de11c29816cb8b430 Reviewed-on: https://chromium-review.googlesource.com/1012944Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#551545}
-
David Tseng authored
In some cases, AXNodeData node id refs (e.g. nextOnLine), refer to nodes that don't exist. In the js wrapper objects, we did not ensure objects were valid in AutomationRootNodeImpl: :get(). Change-Id: I7cf5d988ee7dafa6b0595078002524255a072953 Reviewed-on: https://chromium-review.googlesource.com/1015975Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#551544}
-
Shenghua Zhang authored
Bug: 790367 Change-Id: I53baf6424746078bbc0ef23c23aa85e6026ebcc9 Reviewed-on: https://chromium-review.googlesource.com/1015226Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551543}
-
Dirk Pranke authored
If you deleted or moved a directory containing a PRESUBMIT.py file, then the presubmit checks would crash trying to run tests in a directory that no longer existed. R=agable@chromium.org BUG=834077 Change-Id: I8deb59c2d00b80f6b5215597076bba34ff1f0872 Reviewed-on: https://chromium-review.googlesource.com/1015976Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551542}
-
Cathy Li authored
Change-Id: I1aacf702cc4b2247179c97ab393f141090cd8940 Reviewed-on: https://chromium-review.googlesource.com/1009484 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#551541}
-
Xi Cheng authored
We introduce notification_helper_launches_chrome_unittest, which is evolution of notification_helper_process_unittest. In addition to testing the launch of notification_helper by the OS which is notification_helper_process_unittest all about, the new unit test also tests if chrome.exe can be successfully launched by notification_helper.exe via the NotificationActivator::Activate function. This new unit test is compiled into unit_tests.exe under chrome rather than notification_helper_unittests.exe. This is because unit_tests.exe has data dependency on chrome.exe which is required by this new unit test, and it's undesired to make notification_helper_unittests.exe have data dependency on chrome.exe. Bug: 734095 Change-Id: I07ac90a84d7f885a359867f79ce613a194e0bb64 Reviewed-on: https://chromium-review.googlesource.com/1002132 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551540}
-
Yoshifumi Inoue authored
This patch makes |SelectionModifier::Modify()| to do nothing for empty selection to avoid calling |NextWordPosition()| with null-position. Note: |NextWordPosition()| doesn't accept null-position since the patch[1]. [1] http:/crrev.com/c/1004536 Make NextWordPosition() to utilize TextOffsetMapping Bug: 832061 Change-Id: I534af079f068f709c9b48a408988cb413a520b86 Reviewed-on: https://chromium-review.googlesource.com/1014841Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551539}
-
Torne (Richard Coles) authored
changwan@ has been looking into WebView startup performance; add as an owner of the relevant benchmark to get notifications about bugs. Also add component. Change-Id: I34cac9a71d2c36129d40a0a34b1b2b940282b154 Reviewed-on: https://chromium-review.googlesource.com/1015540Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551538}
-
Dominick Ng authored
This CL ensures that querying for ARC apps is gracefully aborted if the owning WebContents is destroyed during the asynchronous process. ArcNavigationThrottle is converted to be a self-owning object with a private constructor and destructor. When the static app query methods are invoked, an instance of the object is instantiated to handle the querying. By overriding WebContentsDestroyed(), it can cancel all in-flight callbacks upon WebContents destruction and safely bail out of querying. BUG=824598 TBR=sky@chromium.org Change-Id: I2ba6d391b9babec46b277cbcebe567786215bf5a Reviewed-on: https://chromium-review.googlesource.com/1003432 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#551537}
-
Kyle Horimoto authored
This CL renames and refactors DeviceCapabilityManager. Now, this class makes use of the SoftwareFeature proto message instead of relying on its own Capability enum. Likewise, now the class utilizes new fields in ToggleEasyUnlockRequest (e.g., is_exclusive). Finally, this class no longer has any promo-related functionality, since that is being removed in favor of the unified setup flow. Bug: 824568, 752273 Change-Id: I23f5c642a3974c2723f29591d67fe79d0426effb Reviewed-on: https://chromium-review.googlesource.com/1011543Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#551536}
-
Mike Wasserman authored
TBR=fdoray@chromium.org Bug: 833989 Change-Id: I6cf7e67add2310af3b09c9659209f5dc60cd4c73 Reviewed-on: https://chromium-review.googlesource.com/1015846Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551535}
-
Tetsui Ohkubo authored
Model variables and logic were stored in TraySessionLengthLimit. This CL adds SessionLengthLimitModel to SystemTrayModel and separates them. In the upcoming CL, session length limit notification will be generated outside TraySessionLengthLimit, as it will be removed with UnifiedSystemTray launch. TEST=TraySessionLengthLimitTest BUG=none Change-Id: Ic3994f45f0ad48460654512fa8f8e23874503a73 Reviewed-on: https://chromium-review.googlesource.com/1015444Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#551534}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6af654c734a4337083800d6efe2598d5e995579d Reviewed-on: https://chromium-review.googlesource.com/1015704 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551533}
-
Pavel Feldman authored
Bug: 833586 Change-Id: I87e956cadfa62a79aa549f22fe09211ee7cf25ce Reviewed-on: https://chromium-review.googlesource.com/1015773Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551532}
-
Yoshifumi Inoue authored
Because of |NextWordPositionInternal()| doesn't accept null-position, this patch adds |DCHECK()| to catch such callers for ease of debugging. Bug: 832061 Change-Id: Id987553c939db8f061e58eca09d7ebcd946482c9 Reviewed-on: https://chromium-review.googlesource.com/1013642Reviewed-by:
-
Scott Chen authored
Bug: 826306 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idb639ff99a917dc59fd04110c918a8d67583db08 Reviewed-on: https://chromium-review.googlesource.com/986287 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#551530}
-
Jun Mukai authored
As is said in the bug, we decided not to show the title in the title bar for ARC apps. However, debugging information (stored in extra_title_) wants to appear, and the overview mode wants to show the actual title (app name) instead of the debugging information. So this CL changed ClientControlledShellSurface as: - GetWindowTitle always return extra_title_ and no title_ so title won't appear anymore - when the widget's title is updated, directly specify the native window's title which is used by the overview mode Bug: 831383 Test: manually, exo_unittests Change-Id: Ifa275bd6f5c72b8ca36cccf7f9c629498c4a670e Reviewed-on: https://chromium-review.googlesource.com/1012783 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551529}
-
- 17 Apr, 2018 23 commits
-
-
Xiaocheng Hu authored
LocalCaretRect should use the "flipped blocks" coordinate space for vertical-rl writing mode. This patch applies that in the NG implementation. Note: this patch only changes behavior for text-anchored carets. When caret is anchored to atomic inline, there is no reference as the legacy behavior is broken, and LocalCaretRect is consumed by legacy. Bug: 822575 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4019f560f8410ef14c7d52312d7fc1de8db6ee28 Reviewed-on: https://chromium-review.googlesource.com/1011296Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#551528}
-
Malay Keshav authored
This patch adds the required aria labels to display zoom slider. The aria labels added are: - aria-valuemin - aria-valuemax - aria-valuenow - aria-valuetext Bug: 791382, 790723 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb1c05d160027cefb91ca270beb5b5c54e3e669b Component: Settings, display settings, display size slider Reviewed-on: https://chromium-review.googlesource.com/1015778Reviewed-by:
-
Oystein Eftevaag authored
This is a reland of 4df8a2dd Original change's description: > Add a Mojo-based transportation layer for Perfetto > > This adds a base layer that individual logging protocols (like tracing) > can use to send their data to Perfetto, using Mojo messaging and > shared memory. > > First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270 > > A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808 > > The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit > > R=primiano@chromium.org,skyostil@chromium.org > > Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552 > Reviewed-on: https://chromium-review.googlesource.com/980578 > Reviewed-by: oysteine <oysteine@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Commit-Queue: oysteine <oysteine@google.com> > Cr-Commit-Position: refs/heads/master@{#551019} Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7 TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@google.com,skyostil@chromium.org Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7 Reviewed-on: https://chromium-review.googlesource.com/1015189Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#551526}
-
Francois Doray authored
Previously, storage::FileSystemUsageCache used a custom timer implementation (TimedTaskHelper). Crash involving this custom timer implementation have been reported (e.g. http://crash/e2c6ff1ef4863460). Therefore, we are moving all uses of TimedTaskHelper to the well maintained base::Timer. Note: The TaskRunner passed to the TimedTaskHelper in storage::FileSystemUsageCache was always the one on which the storage::FileSystemUsageCache was used, so there is no need to an explicit call to base::Timer::SetTaskRunner in this CL. Bug: 760326 Change-Id: I4b0727e4f70c2560a2948015dd28236cd760a9f3 Reviewed-on: https://chromium-review.googlesource.com/1012586 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#551525}
-
https://skia.googlesource.com/skia.git/+log/eedecc6046b2..c186e17a6b78 $ git log eedecc604..c186e17a6 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 robertphillips Add handling to ViaDDL for images that are too large to be uploaded in one go 2018-04-17 herb Move node information to SkStrikeCache 2018-04-17 bungeman IWYU for some more test files starting with 'C'. 2018-04-17 reed detect if we made an infinite rect 2018-04-17 borenet [infra] Support recursive configs in builder_name_schema 2018-04-16 egdaniel No long require copy as draw for vulkan wrapped resources. 2018-04-17 caryclark path is rect diag test is required 2018-04-17 mtklein SkStrikeDifferences::operator() -> add() 2018-04-17 reed avoid overflow by using tmp 64bits 2018-04-17 brianosman Move external texture extension logic into SkSL 2018-04-17 benjaminwagner [infra] Add service account override in gen_tasks.go. 2018-04-17 caryclark path is rect bug number twelve 2018-04-17 bungeman Add paint flags to viewer GUI. 2018-04-17 mtklein skcms→3be11ac refactor a bit 2018-04-17 liyuqian Revert "Fix the fat rect bug in the threaded backend" 2018-04-17 reed only recheck fNeedsTiling if we computed fSrcBounds 2018-04-17 brianosman Add SkColorSpace::Make, taking an skcms_ICCProfile 2018-04-16 mtklein Reland "low-hanging bilerp_clamp_8888 wins" 2018-04-17 mtklein skcms→38f22d2 name types in skcms.h 2018-04-17 herb Reorganize strike cache and glyph cache code 2018-04-16 liyuqian Fix the fat rect bug in the threaded backend 2018-04-17 caryclark yet another path is rect exploit 2018-04-17 angle-skia-autoroll Roll third_party/externals/angle2/ 08b9e046c..86de76b69 (1 commit) 2018-04-16 halcanary SkColorSetARGB in constants 2018-04-16 caryclark a more involved path is rect bug 2018-04-16 egdaniel Update our config fallback switch in GrContext. 2018-04-17 borenet Revert "Reland "[infra] Run recipes through Kitchen"" 2018-04-16 borenet Reland "[infra] Run recipes through Kitchen" Created with: roll-dep src/third_party/skia BUG=chromium:824145,chromium:824145,chromium:824145,chromium:824145 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I1489c857f9c6e71b8e55bd7deaa3230a33759926 Reviewed-on: https://chromium-review.googlesource.com/1015796Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551524}
-
Peter Boström authored
Extends 8dp corners to ToolbarActionView which was missed in a previous change. This makes them consistent with other toolbar buttons. Bug: chromium:822069 Change-Id: Id894664ec698504e3ff997c1b12691821ab1062e Reviewed-on: https://chromium-review.googlesource.com/1015286 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#551523}
-
Koji Ishii authored
Following bot results are included. 4828 4834 4835 4836 4837 4838 4839 4846 2 lines were removed and 0 lines were deflaked by consecutive results since 4772. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I21ecb8193d866c44d026528ffc7831dc7babe59b Reviewed-on: https://chromium-review.googlesource.com/1013788 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Tien-Ren Chen authored
This CL detects the case that a invisible composited layer may have bogus subpixel accumulation on it, and ignore the DCHECK in such case. BUG=816490 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iba98cb3a57dfe24f8a69f1f7469bf78482530d7e Reviewed-on: https://chromium-review.googlesource.com/1012441Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551521}
-
Artur Khachatryan authored
Disabling all tests in CorrectEventFiringTest class. Tests are flaky and we'll enable these tests again as soon as the bug is fixed. Change-Id: I5b02e385869165cb2d2e7cfd87c5611fc81eb9fb Reviewed-on: https://chromium-review.googlesource.com/1015973Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551520}
-
Pawel Pluciennik authored
R=brettw@chromium.org, rsesek@chromium.org, sdefresne@chromium.org, sergeyu@chromium.org Bug: 821738 Change-Id: Ib1dcca4070ad7019c082653217df48adda69ab32 Reviewed-on: https://chromium-review.googlesource.com/962282Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551519}
-
Evan Stade authored
Bug: none Change-Id: If04229d0caf53848f6dde4f0f7aabde053954f67 Reviewed-on: https://chromium-review.googlesource.com/1008526Reviewed-by:
-
Tetsui Ohkubo authored
Power/battery related notifications were generated in TrayPower, whixh is a SystemTrayItem. We're going to get rid of SystemTrayItems as UnifiedSystemTray will replace them, so we should generate the notification outside system tray. TEST=PowerNotificationControllerTest BUG=none Change-Id: Ie707770cd86964f496651d5ed840198890362b40 Reviewed-on: https://chromium-review.googlesource.com/1013784Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/888a7065b4ba..c46e7967a50f $ git log 888a7065b..c46e7967a --date=short --no-merges --format='%ad %ae %s' 2018-04-16 moragues nocturne: Add master builder configuration Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3ac448c88b4d01e1c86eee5eaa75b08475924f60 Reviewed-on: https://chromium-review.googlesource.com/1015651Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551516}
-
Hajime Hoshi authored
Bug: 830489 Change-Id: Ief2540485aa699a72ad9adccafa487a729e7fb08 Reviewed-on: https://chromium-review.googlesource.com/1015441Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551515}
-
Kent Tamura authored
We'd like to provide smaller tarballs with which one can build Chrome, and such tarballs exclude //third_party/WebKit/Tools/Script. We're moving //third_party/WebKit/Tools/Scripts to //third_party/blink/tools, and would like to exclude //third_party/blink/tools as well. However, some build scripts use name_style_converter.py in the directory. This CL moves name_style_converter.py out from //third_party/blink/tools, and enables to exclude //third_party/blink/tools. test-webkitpy includes //third_party/blink/renderer/build/scripts. So the following existing tests run on buildbots in addition to name_style_converter_test.py: - in_file_unittest.py - minimize_css_unittest.py This CL fixes test failures of in_file_unittest.py. Bug: 832283 Change-Id: I7d3b3524daa59291eaf7f323818a7b0e25163179 Reviewed-on: https://chromium-review.googlesource.com/1013768Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#551514}
-
Khushal authored
Temporarily disabling checkering of decode=async tag images to debug entries in ukm logs for checkerboarded images in the control group for checkerimaging finch study. R=vmpstr@chromium.org Bug: 833666 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib9a79262599efa17fd18e9cb71d7518492e9a7ee Reviewed-on: https://chromium-review.googlesource.com/1014644Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#551513}
-
Findit authored
This reverts commit f0acd4fc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 551483 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YwYWNkNGZjZjE5MzlhMTUyYzI3ODdmNjI1NjQ0YThlNTc5NDdkMjgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7001 Sample Failed Step: base_unittests Original change's description: > Fix SampleVector tests to expect CHECK rather than DCHECK deaths. > > Bug: 832728 > Change-Id: I9a2d2d330aa4d250c925b7a614780acbf40dce3f > Reviewed-on: https://chromium-review.googlesource.com/1012732 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551483} Change-Id: Ie2ad7fb9ebd4c214a7dd2cebe0763b2f41793f01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832728 Reviewed-on: https://chromium-review.googlesource.com/1015194 Cr-Commit-Position: refs/heads/master@{#551512}
-
Andrey Kosyakov authored
... so as to insure it's always destroyed on the correct thread even though it's passed around through different threads. Change-Id: Ieae597251f2836de73cc13cb39fa6d39b9645133 Reviewed-on: https://chromium-review.googlesource.com/1013379 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551511}
-
Fredrik Hubinette authored
Bug: 754986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I234a2cc037b78b11d08660b641f5524ed8171a0b Reviewed-on: https://chromium-review.googlesource.com/1014601Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551510}
-
Tommy C. Li authored
Previously, when the autocomplete engine did not provide any matches, the OmniboxEditModel would generate a current match from the text contents of the View. This would lead to bad behavior when Steady State Elisions was on. For example, if the user was at the full URL https://router/, and the elided display text was simply "router", this would trigger a search when the user pressed Ctrl+L, and then Enter. This CL fixes that by only using the View text if user input is in progress, and using the full formatted URL otherwise (if in display mode). This bug doesn't have an impact unless the Steady State Elisions flag is on, so this doesn't require a merge. This CL also adds a test. Bug: 797354 Change-Id: Id27913f567313333e8a171a8040bf906a7a1cc52 Reviewed-on: https://chromium-review.googlesource.com/1013694Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551509}
-
Gabriel Charette authored
This is another scripted pass done by a slightly modified version of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which has a better notion of "scope". The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 781352 Change-Id: Ide6e641f8e9fed673bbf641074f33a05d238735a Reviewed-on: https://chromium-review.googlesource.com/1014782Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/055c0339565a..ca7ee7a2c7fe $ git log 055c03395..ca7ee7a2c --date=short --no-merges --format='%ad %ae %s' 2018-04-17 simonhatch Dashboard - Use bot_configuration in /auto_bisect. 2018-04-16 simonhatch Dashboard - Update delete/migrate to also do histogram data. 2018-04-16 simonhatch Dashboard - Fix up diagnostics Created with: roll-dep src/third_party/catapult BUG=chromium:779618 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie5fbb5255dd417719043563f31e69bb61e633657 Reviewed-on: https://chromium-review.googlesource.com/1015762 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551507}
-
Chris Kuiper authored
Bug: internal b/74159854 Test: Ran on Android Things speaker, verified bug is fixed. Change-Id: I14b4f82c175f771cf7387d1bf6b2655221397edc Reviewed-on: https://chromium-review.googlesource.com/1011297Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#551506}
-
