- 25 Nov, 2020 40 commits
-
-
Ben Reich authored
CL:2559234 introduced changes to disable $i18n{} template replacement when the --devtools-code-coverage flag is passed and only for the Files app extension. Introduce a helper to identify when a filesTooltip test is in code coverage mode and use the $i18n{} label instead of the replaced string. --devtools-code-coverage Bug: 1152612 Test: browser_tests --gtest_filter="*filesTooltip*" Test: browser_tests --gtest_filter="*filesTooltip*" Change-Id: Ia43f1b17ecdf8eea0a42dc5b23a2efd9787791c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558814Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830913}
-
Daniel Cheng authored
Usage has been migrated to use the standard //base/metrics helpers. Bug: 1047547 Change-Id: I8edfefb774a6154e19763833a7885e491d9a3996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559557Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#830912}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606240669-a966a0de7533a2c29e2a147761a10e8425d1cfe7.profdata to chrome-win64-master-1606251063-26a76a6b25625f68800c8ab3d3043b315be73544.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id22adc572ed8b1206dd7ff822e39cd3657e16148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559391Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830911}
-
Joon Ahn authored
Bug: 1125150 Cq-Depend: chromium:2528302 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: Ia0df0ca9f0e5f468d1c020f0d09dcc5c10a313ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552893 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#830910}
-
Thanh Nguyen authored
Implements LocalSearchServiceProvider and related classes for LSS. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I46b43dc5ac9453e3d6da8eceb24293aa19bb3d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556888Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#830909}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0652fd72..5bea3c59 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6478470fbcf43f549d568113c94dd0e5e00c9e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559592Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830908}
-
Hitoshi Yoshida authored
An IDL dictionary member ScrolltimeElementBasedoffset.target's type is non-nullable Element, but there are some routines that can store a nullptr or access without checking it is available. This CL fixes them. Bug: 839389 Change-Id: Ic9529c39fd4a52935570e461db85134f2c5862aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557760Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/70102b71900b..33f29ea9b251 2020-11-25 enga@chromium.org Skip ShaderFloat16Tests on Intel D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I3f7778c1fa3639abc2af8c866c530fd12975d4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559799Reviewed-by:
-
Josiah K authored
AX-Relnotes: N/A Bug: 1151216 Change-Id: I222ec5d29ae2fd06689d6d94876f4fa6973e4c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552163 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#830905}
-
Peter Kotwicz authored
This CL rolls: androidx.recyclerview:recyclerview androidx.viewpager:viewpager androidx.viewpager2:viewpager2 BUG=1064277 Change-Id: I1d288138abedaef79452925436dceba425478d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552379Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#830904}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I439a198c856a6ad3cfeeb9656707f1ff90a0e637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546665 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#830903}
-
Koji Ishii authored
In the initial phase of LayoutNG, outlines for block boxes are fragment-based, but outlines for inline boxes are not. This patch changes the latter to fragment-based. The behavior for continuation is changed. In legacy and NG before this patch, the first inline fragment of a |LayoutInline| paints all outlines, including continuations. This resulted united outlines for a |LayoutInline| including continuations, but computing this requires a special code path when the block-in-inline is block fragmented. While the result looks less optimal, in order to simplify the code, this patch paints outlines for each continuation separately, making them not to be united across continuations. Test rebaselines are for this change. Bug: 1145048 Change-Id: If2a8ae79615323a5c6a3d807930c297d50e6d895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535904 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830902}
-
Ossama Mahmoud authored
Bug: 1108318 Change-Id: I78de7ef132fead2088e8f2cf1be3c19446fe10fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532258 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830901}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bce89d89d4b..888c5d3e57eb 2020-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1b413197a6d7 to 130597e10299 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I2abb07ae0656a73cb859519bd9f966577d3d11b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559856Reviewed-by:
-
Bao-Duy Tran authored
InputMethodManagerImpl unit tests are failing in certain environment due to mixed usage of hermetic test data and non-hermetic CrOS-specific prod data, with inconsistent direct tweaking on an internal delegate. This refactoring doesn't fix the failures as yet but facilitates the move towards consistent usage of hermetic test data in follow-ups. Bug: 970790 Change-Id: I892aeaddf3658c6ab0f2d35ab441a2fa85858c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550146 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#830899}
-
Yoshifumi Inoue authored
This patch changes |ComputePositionForNodeRemoval()| to work correctly for after node/children position to make |SelectionEditor| relocates base and extent positions correctly. Before this patch |ComputePositionForNodeRemoval()| returns position after removed node as child index in parent, e.g. parent@child+1. After this patch |ComputePositionForNodeRemoval()| returns parent@child. Example: <div><a></a><b></b></div> remove <a> <div><b></b></div> When removing <a>, position after <a> should be relocated to <div>@0. Bug: 1145595 Change-Id: Ibd5f30b52cb10ba066dfeca3fbf9f1d5bef6c77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558123 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830898}
-
Victor Fei authored
Moved the logic of AXNodeObject's LiveRegionStatus and LiveRegionRelevant to to AXObject so that AXVirtualObject can properly calculate live region live and relevant status. And in AccessibleNodes we can now set and retrieve live region state. AX-Relnotes: n/a. Bug: 1152104 Change-Id: I2a40992c4f1b301157eeddc29f0cdf0e0b1cb998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555957 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830897}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/724b0bf4449d..c41b944fd821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com Change-Id: I89aba792e112b093144f7a818e4af7411ca501c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559679Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830896}
-
Tom Anderson authored
This is a speculative fix for bug 1137614 possibly introduced by e552c103. The issue is the change from CHECK(gfx::GetXDisplay()) to CHECK(x11::Connection::Get()) The second call will always succeed since x11::Connection::Get() always returns something even if the underlying connection is down. But the intention was to hit the CHECK() in this case, as that's what the behavior was before (gfx::GetXDisplay() returns nullptr when the connection failed). This CL restores the old behvaior by explicitly checking the connection state. R=msisov Bug: 1137614 Change-Id: If2b2049e39b4d892e60fd29813c915459787d8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558716 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#830895}
-
Maksim Sisov authored
When use_gtk is set to false, nothings sets LinuxInputMethodContextFactory. That results in a crash that produces the following error - FATAL:input_method_auralinux.cc(29)] Check failed: LinuxInputMethodContextFactory::instance(). Trying to initialize InputMethodAuraLinux, but LinuxInputMethodContextFactory is not initialized yet. Thus, to fix the problem, create and set a fake input method context factory. Bug: 1084870 Change-Id: Iccce8e3e3e3f09f89c1c3c40d44d86876e5918a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557079Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#830894}
-
danielng authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/dfd19c1b9bbc..f6d74c196c6c $ git log dfd19c1b9..f6d74c196 --date=short --no-merges --format='%ad %ae %s' 2020-11-12 jiejiang patchpanel: Generate neighbor failed/recovered events 2020-11-17 pmarko system_api: Clarify KeyInfo.domain semantics for EMK/EUK 2020-11-19 danielng system_api: adding exec field to apps.proto 2020-11-19 danielng system_api: clarity changes to apps.proto 2020-10-28 niwa cryptohome: Implement GetQuotaCurrentSpaceForProjectId() Created with: roll-dep src/third_party/cros_system_api Change-Id: I31c4ace4d70add29e2659f7d87443999053dcfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557820 Commit-Queue: Daniel Ng <danielng@google.com> Auto-Submit: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#830893}
-
Fergus Dall authored
The failures were confined to kevin, which has been removed from the list of stable crostini boards, so try re-enabling it. Bug: 1141944 Change-Id: I2fce17136809814728b216e5e3fc6a369181e75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558132 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#830892}
-
Bao-Duy Tran authored
This is a preparation step towards fixing test failures caused by mixed usage of hermetic test data and non-hermetic prod data. Some tests don't need these for-test inits, but always applying those inits would help untangle the aforementioned mixed non-hermetic data usage in follow-ups. Bug: 970790 Change-Id: I95c7f72e7c0d7c9c500effc44fbbb1029df8389f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551873 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830891}
-
edchin authored
Design doc: go/bling-phishguard Refactors PasswordProtectionRequest to make code more modular. Bug: 1147967 Change-Id: If8c4195ccf1340439a97719b52176eb5c1d45cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558690 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#830890}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36d06a806f69..7bce89d89d4b 2020-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 03badec5d73a to 33f29ea9b251 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: If7c402f59e7a15400f59a8d797ab820d2d134b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558859Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/acf004a14a8a..130597e10299 2020-11-25 cclao@google.com Vulkan: Use PackedScissor struct to reduce GraphicsPipelineDesc size 2020-11-25 jmadill@chromium.org EGL: Auto-generate validation header. 2020-11-24 ynovikov@chromium.org Skip failing tests on Win AMD RX 5500 XT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1004356 Tbr: jmadill@google.com Change-Id: If737d50a026248c41000cf77d49ee6ad6536e9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559673Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit e0e81ba9. Reason for revert: Breaks win64-chrome :( [12574/27367] CXX obj/chrome/browser/browser/third_party_module_list_component_installer_win.obj FAILED: obj/chrome/browser/browser/third_party_module_list_component_installer_win.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/browser/component_updater/third_party_module_list_component_installer_win.cc(17,10): fatal error: 'chrome/browser/win/conflicts/module_blacklist_cache_util.h' file not found #include "chrome/browser/win/conflicts/module_blacklist_cache_util.h" https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/10472 Original change's description: > More inclusive terminology for chrome/browser/win/conflicts/. > > Bug: 1097283 > Change-Id: I570f98b1f42487aff2696c50f87fd0832667379b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547620 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830830} TBR=pkasting@chromium.org,chrisha@chromium.org,gab@chromium.org,jwd@chromium.org,tedchoc@chromium.org,pmonette@chromium.org Change-Id: Ibe482cba992b06bfc58fc1eaee200cca11b10d72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558083 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#830887}
-
Bao-Duy Tran authored
Bug: 1134465 Change-Id: Ibb5e2a6c8f9296f1ded051a9e58e5bd48fccf715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550144 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830886}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: If1cb17d1b822a5b14e0cfacda0fe301e8d6191a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559162Reviewed-by:
-
Fergus Dall authored
CL:2374267 renamed most crostini tast tests and has now been pulled into the LKGM, so remove the old names. Bug: 1128743 Change-Id: Ib976ce2a0af33b3e99fa3595bd989b85c7d5af37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557066Reviewed-by:
-
Kunihiko Sakamoto authored
`go get` installs commands in $GOPATH/bin (or ~/go/bin if $GOPATH is not set), which may not be listed in the user's PATH environment variable. crrev.com/c/2556739 updated third_party/blink/web_tests/http/tests/ loading/sxg/resources/generate-test-sxgs.sh, and this updates the remaining scripts and READMEs. Bug: 1151384 Change-Id: I2719fad30d3bb1141fb7abbecb8a2cf1b638a51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557159Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#830883}
-
Leo Lai authored
We are deprecating tpm-related APIs by cryptohome. To test this CL, it is attempted to filter out all the affected test manually: 1. For browser test, device_status_collector_browsertest.cc is confirmed working fine. 2. For unit test, the affected tests are searched by grepping `DeviceStatusCollector` and as a result it is confirmed that with the following filters all the tests pass: *StatusUploader* *DeviceCloudPolicy* *AffiliatedSessionService* *ManagementUIHandler* BUG=b:172748724 TEST=build ok. TEST=See above for the test items. Change-Id: Ia41f23d3c2ba9666699bee82cf9c465d5c675159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557123 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#830882}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ia1fd975e3e8ed4b4057deb917e11c302307acce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557077 Commit-Queue: Ricky Liang <jcliang@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830881}
-
Joel Hockey authored
If we drop an unshared file into Plugin VM, we do not share it since Plugin VM requires the whole directory to be shared for file dances. Instead, we show the 'Move to Windows files' dialog in FilesApp. ChromeFileHelper sends new CrostiniEvent 'drop_failed_plugin_vm_directory_not_shared' and FilesApp will show the dialog if it has a drag in process. Bug: 1144138 Change-Id: I647978390aa451af7fb23ce28640d3511c96c4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556742 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#830880}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I21da2663ebdd922a5d36197cada9d4aeae16b6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545970 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#830879}
-
Luciano Pacheco authored
Rename references to the type `FilesMetadataBox` to `FilesMetadataBoxElement`, because that's the type name generated by Polymer. The polymer_modulizer() doesn't support the syntax of assigning the Polymer to a variable that was in use. Bug: 1133186 Change-Id: I0242b5e4e48fbb7040681186eaebccec7cae384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554281 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830878}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/377448c7bd4c..724b0bf4449d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com,ezemtsov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com,ezemtsov@google.com Change-Id: I74eced8ae449bf4328cf034529b2668113a8be89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559383Reviewed-by:
-
Hajime Hoshi authored
This CL is reland of http://crrev.com/c/2531155 with some test fixes. WebFilesystem doesn't have notions of handlers or connections, then it should be safe to allow pages with WebFilesystem to be put into the BFcache. Let's allow WebFilesystem for BFcache in order to improve the BFcache hit rate. This is implemented behind a flag and the feature is disabled by default. This means that this CL doesn't change the behavior by default. We might enable the feature later. Bug: 1144133 Bug: 1151235 Change-Id: I3b3526f180c19d33d6ca16a88efe400fe9bd2c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557160Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830876}
-
Bao-Duy Tran authored
Bug: 1134465 Change-Id: I6570020a4b3bc9f517884cbb99563d767f34142a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551853 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib06c2df5f186002038697ab7249525c3a12ff06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556839 Commit-Queue: Ricky Liang <jcliang@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
