GitLab

Introduce an applyRuleSetChanges method which will take the old and new
ActiveStyleSheetVector use the existing comparison method and apply the
RuleSet diff to invalidate style for the document.

The normal mode for style rules is to schedule RuleSet invalidations
which will decide what to recalculate based on the invalidation sets.
Universal selectors, the presence of Shadow DOM v0 combinators, or
@font-face rules for the document scope, will cause a subtree recalc
for the TreeScope.

@keyframes rules utilizes the existing functionality for invalidating
style in the TreeScope and the host TreeScope for running and
unresolved animations.

This CL introduces appendActiveStyleSheets which will eventually
replace the combination of the lazy appending of sheets in
StyleResolver and appending pending sheets into the ScopedStyleResolver
through appendCSSStyleSheet.

This CL is split out of https://codereview.chromium.org/1913833002 and
re-worked a bit.

The functionality is not yet in use.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2394353003
Cr-Commit-Position: refs/heads/master@{#423810}

Chromium clang plugins depends on clang headers, and the configuration
file assumes it's checked out in a fixed path in the LLVM source tree.
That is inconvenient to build it out of tree.

This CL adjusts the include path setting for external checkout of clang.

Review-Url: https://codereview.chromium.org/2394203003
Cr-Commit-Position: refs/heads/master@{#423809}

BUG=328606

Review-Url: https://codereview.chromium.org/2374913002
Cr-Commit-Position: refs/heads/master@{#423808}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/5ba4397bb3ab875a37501ec8eb0de33d1b4a1514 Wait cloudtail termination in goma module (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2402493004
Cr-Commit-Position: refs/heads/master@{#423807}

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG=625089

Review-Url: https://codereview.chromium.org/2394773006
Cr-Commit-Position: refs/heads/master@{#423806}

Use modified Read and delegate methods from the following CL-
https://codereview.chromium.org/2262653003/

This CL dependents on the following CL as well -
https://codereview.chromium.org/2264973002/

BUG=423484

Review-Url: https://codereview.chromium.org/2264903003
Cr-Commit-Position: refs/heads/master@{#423805}

CSSStyleSheets which have a non-matching media attribute may have a
nullptr for RuleSet since it's not needed. Handle that in active style-
sheet diffing. That means adding a sheet with non-matching media should
not cause any style recalculations.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2401573002
Cr-Commit-Position: refs/heads/master@{#423804}

No more references to exe:chrome, instead anyone wanting browser
interfaces connects to service:content_browser, which is consistent
with the rest of the universe.

ServiceManager and Catalog have some control interfaces added to
override path resolution for executables and manifests. MashRunner
uses this to direct resolution of "exe:chrome_mash" and
"service:content_browser" accordingly, as well as to resolve
content process manifests to chrome's/mash's overlayed versions
on disk.

Also changes the service_manifest GN template to support overlays.
This makes it easy to reuse the existing overlay metadata with
standalone ServiceManager, as well as to layer multiple overlays
(e.g. content_browser + chrome_content_browser + chrome_mash_content_browser).

Adds a browser manifest overlay specifically for Mash, which is
applied on top of Chrome's own overlay.

BUG=646077
TEST=chrome --mash seems to "work", can set wallpaper, browse cat photos, run task_viewer, etc

Review-Url: https://codereview.chromium.org/2389133008
Cr-Commit-Position: refs/heads/master@{#423803}

When interpolating rotate3d transforms we were considering axes that are
the negation of each other to be in the same direction.
This patch fixes this mistake by checking the sign of the dot product.

Spec text for rotate3d interpolation:
https://drafts.csswg.org/css-transforms/#ref-for-funcdef-rotate3d-3
For interpolations with the primitive rotate3d(), the direction vectors
of the transform functions get normalized first. If the normalized
vectors are equal, the rotation angle gets interpolated numerically.
Otherwise the transform functions get converted into 4x4 matrices first
and interpolated as defined in section Interpolation of Matrices
afterwards.

BUG=652705

Review-Url: https://codereview.chromium.org/2391003004
Cr-Commit-Position: refs/heads/master@{#423802}

BUG=648949,651373

Review-Url: https://codereview.chromium.org/2393353004
Cr-Commit-Position: refs/heads/master@{#423801}

Some events, such as RenderStub.onClientSizeChanged(), triggers only once during
its lifetime. Though we can ensure to add a ParameterRunnable before the event
is triggered, it seems a little bit inconvenient.
So this change adds a PromisedRaisable Event derived class to ensure newly
added ParameterRunnable can at least be executed once.

BUG=615277

Review-Url: https://codereview.chromium.org/2385593002
Cr-Commit-Position: refs/heads/master@{#423800}

Revert of [Cast, Tests] Handle low end and JB devices that don't preload videos (patchset #1 id:1 of https://codereview.chromium.org/2400543002/ )

Reason for revert:
Speculative revert because cast tests started flaking very heavily at this revision and it's effectively blocking things in the CQ.

See https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng?numbuilds=200 for example failures

Original issue's description:
> [Cast, Tests] Handle low end and JB devices that don't preload videos
>
> BUG=652872,652389
> TEST=run_chrome_public_test_apk --verbose --gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and not a low end device.
>
> Since https://codereview.chromium.org/2344353003 on low-end and JB devices videos
> are not preloaded so we have to trigger that in a button onclick handler.
>
> Committed: https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42
> Cr-Commit-Position: refs/heads/master@{#423775}

TBR=mlamouri@chromium.org,avayvod@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=652872,652389

Review-Url: https://codereview.chromium.org/2394273003
Cr-Commit-Position: refs/heads/master@{#423799}

Remove IntentHelperInstance's HandleUrlListDeprecated
method. Chrome stopped calling it in
https://codereview.chromium.org/2392253003/.

BUG=647802

Review-Url: https://codereview.chromium.org/2397263003
Cr-Commit-Position: refs/heads/master@{#423798}

Make arc_file_tasks.cc use the IntentHandlerInfo struct's
string "action" field rather than the ActionType enum.
ActionTypes are still used when calling HandleUrlList.

BUG=647802
TEST=manual: still able to launch ARC apps for individual
     files or send multiple files from files app

Review-Url: https://codereview.chromium.org/2398063003
Cr-Commit-Position: refs/heads/master@{#423797}

Previous implementation of IsCancelled doesn't have a specialization for
nested OnceCallback. That implies OnceCallback::IsCancelled returns false
when it's a nested callback and the inner callback is a cancelled OnceCallback.

Review-Url: https://codereview.chromium.org/2401623002
Cr-Commit-Position: refs/heads/master@{#423796}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd Enable goma on pdfium buildbots by default. (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=643139

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2398043003
Cr-Commit-Position: refs/heads/master@{#423795}

https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/11256fd..3e02228

TBR=mmoroz@chromium.org,ochang@chromium.org
BUG=539572

Review-Url: https://codereview.chromium.org/2399283002
Cr-Commit-Position: refs/heads/master@{#423794}

Many media-related tests in web-platform-tests depend on it.
https://github.com/w3c/web-platform-tests/tree/master/media

This CL has no behavior changes.

TBR=kojii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/2401833002 .

Cr-Commit-Position: refs/heads/master@{#423793}

Move SubResourceIntegrity check caches from ScriptResource -> Resource.
This also renames ScriptIntegrityDisposition to generic name ResourceIntegrityDisposition

This is to prepare for CSSStyleSheetResource to use the same logic.
Split from https://codereview.chromium.org/2290983003/.

BUG=642722

Review-Url: https://codereview.chromium.org/2398733003
Cr-Commit-Position: refs/heads/master@{#423792}

Same for RootWindowController and WmRootWindowController. I want to
move TestSessionStateDelegate to ash/common, and it uses these.

BUG=none
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2401803002
Cr-Commit-Position: refs/heads/master@{#423791}

Cr-Commit-Position: refs/heads/master@{#423790}

DedicatedWorkerTests are very slow compared to other tests. According to the
report (https://crbug.com/650346), these take 20% of the running time of
webkit_unit_tests. This CL saves the running time by shortening delays for
postDelayedTask(), setInterval() etc used in the tests.

Before this CL (Linux Debug Build):

[1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms)
[2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms)
[3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms)
[4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms)
[5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms)
[6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms)
[7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms)
[8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms)
[9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms)
[10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms)

After this CL (Linux Debug Build):

[1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms)
[2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms)
[3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms)
[4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms)
[5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms)
[6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms)
[7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms)
[8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms)
[9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms)
[10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms)

BUG=650346

Review-Url: https://codereview.chromium.org/2384723002
Cr-Commit-Position: refs/heads/master@{#423789}

This fixes another place that previously forced clip for contain:paint,
causing corrupted painting in nested contain:paint containers.
Other places were fixed in https://codereview.chromium.org/1985933002.

BUG=648091
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2400063002
Cr-Commit-Position: refs/heads/master@{#423788}

BUG=616242

Review-Url: https://codereview.chromium.org/2396893002
Cr-Commit-Position: refs/heads/master@{#423787}

BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2396793004
Cr-Commit-Position: refs/heads/master@{#423786}

************* Module gn_helpers
W: 68,17: Redefining built-in 'input' (redefined-builtin)
W:108,15: Redefining built-in 'input' (redefined-builtin)
W:242, 4: Redefining built-in 'id' (redefined-builtin)

Review-Url: https://codereview.chromium.org/2389353004
Cr-Commit-Position: refs/heads/master@{#423785}

BUG=569557

Review-Url: https://codereview.chromium.org/2396883005
Cr-Commit-Position: refs/heads/master@{#423784}

TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/2282203002 .

Cr-Commit-Position: refs/heads/master@{#423783}

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Review-Url: https://codereview.chromium.org/2396883004
Cr-Original-Commit-Position: refs/heads/master@{#423450}
Cr-Commit-Position: refs/heads/master@{#423782}

https://codereview.chromium.org/2084933002 added a dependency on
RuntimeEnabledFeatures.h, but the target doesn't depend on the generated
files.

BUG=none

Review-Url: https://codereview.chromium.org/2393363003
Cr-Commit-Position: refs/heads/master@{#423781}

Review-Url: https://codereview.chromium.org/2402463002
Cr-Commit-Position: refs/heads/master@{#423780}

If a URL request is cancelled by a requester, there's a chance on
URLResponseBodyConsumer to run OnReadable() on an invalid
ResourceDispatcher::PendingRequestInfo. That causes a null pointer
access.

This CL clears the URLLoaderClient earlier in the cancellation phase to
avoid the crash.

BUG=603396

Review-Url: https://codereview.chromium.org/2399463002
Cr-Commit-Position: refs/heads/master@{#423779}

This patch removes a TODO which states we should normalize calc() values
when parsing them for registered properties. I don't recall exactly why
I added this TODO but it doesn't seem that the spec says this needs to
be done. We already simplify calc() values in computation as per spec.

https://drafts.css-houdini.org/css-properties-values-api/

BUG=641877

Review-Url: https://codereview.chromium.org/2399803002
Cr-Commit-Position: refs/heads/master@{#423778}

This CL removes unnecessary header inclusions and refactors parameter passing
for startWorkerGlobalScope. This should not change behavior.

BUG=n/a

Review-Url: https://codereview.chromium.org/2401513003
Cr-Commit-Position: refs/heads/master@{#423777}

This extracts the color information from the h264 stream and attaches
it to the video frame. Currently this is only done if the result is
NV12 as we don't have the code yet to do it for RGB frames.

BUG=622133, 647725

Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
Review-Url: https://codereview.chromium.org/2345123002
Cr-Original-Commit-Position: refs/heads/master@{#422942}
Cr-Commit-Position: refs/heads/master@{#423776}

BUG=652872,652389
TEST=run_chrome_public_test_apk --verbose --gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and not a low end device.

Since https://codereview.chromium.org/2344353003 on low-end and JB devices videos
are not preloaded so we have to trigger that in a button onclick handler.

Review-Url: https://codereview.chromium.org/2400543002
Cr-Commit-Position: refs/heads/master@{#423775}

- remove pref for reading context first and manually list roles for which it makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when encountering whitespace as Google TTS appears to have been fixed. Note that this might not be the case on other platforms, but ChromeVox for Chrome OS works well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are not played at the same time sounding like a big error tone). Context is uttered first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2387413002
Cr-Commit-Position: refs/heads/master@{#423774}

Things moved:

- invalidation_adapter
- invalidation_helper
- pref_names
- report_unrecoverable_error (renamed from chrome_*)
- sync_prefs
- system_encryptor

This CL was mostly generated by a script but required tweaking the
SyncPrefs interface slightly to remove a dependency.

BUG=631271
TBR=stuartmorgan,jochen

Review-Url: https://codereview.chromium.org/2395533003
Cr-Commit-Position: refs/heads/master@{#423773}

Previously, scroll offsets were stored in a mix of float, double,
and int.

BUG=470718
R=skobes@chromium.org,bokan@chromium.org,aelias@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2387883002
Cr-Commit-Position: refs/heads/master@{#423772}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/22570732fbb1..b72737924a91

$ git log 22570732f..b72737924 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 aiolos Update Android reference build.
2016-10-06 aiolos Revert of Update android chrome reference builds. (patchset #1 id:1 of https://codereview.chromium.org/2397953002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2398333002
Cr-Commit-Position: refs/heads/master@{#423771}