- 06 Apr, 2020 40 commits
-
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: If1be564636cc503e6e3f88edda7122bad1b4013d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135658Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756602}
-
Kent Tamura authored
This reverts commit c0b367bf. Reason for revert: Found that this was an incorrect approach. Original change's description: > Add a counter for the number of LayoutNG-based LayoutObject instances > > This CL has no user-visible behavior changes. > > Note that LayoutNG ratio computed by this counter and |LocalFrameView:: > layout_object_counter_| is 55.1% on nytiimes.com. > > Bug: 1067527 > Change-Id: I73e349a6f5daab79c5f4005ffc28997167f35788 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136011 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756573} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org Change-Id: Ib534cb175a327ef6ee0bac05057bdd0b5dcb4d6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137192Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#756601}
-
Christopher Lam authored
This CL updates cros_colors.json5 with a few new colors from gogoy@ and changes the comment to reflect the latest thinking on what belongs in that file. Bug: 1018654 Change-Id: I285e08ba0db930f7c6110a21c9b302154456c7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126408Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#756600}
-
Yuki Shiino authored
ScrollTimelineElementBasedOffset is now IDL dictionary, not IDL interface. Bug: 839389 Change-Id: I9e8705476d1ad9aaa844b3a372eb3717dc7db3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134035Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756599}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ie721f00888b7874cb563d84f7216ebe5a984b559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136983Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ic32ad2f916e83423158bf77e846bd0e21cfafe5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136571Reviewed-by:
-
Yuki Shiino authored
The current IDL definitions misuse [HTMLConstructor]. Workarounds it in the new Web IDL database. Bug: 839389, 1068098 Change-Id: I00905dafeb25392b7d2a910b78e26dfd89316ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136979 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Icb0a4d27b2bc6559642b1735dffcd4211d03190e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136572Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I2a4e8323ce14e7f557ff2de93192a0061e879cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136570Reviewed-by:
-
Peter E Conn authored
This CL moves the custom_tabs_client_example_apk target into the Chromium repo. This means that we can remove the third_party/custom_tabs_client dependency. While moving the custom_tabs_client_example_apk target, it was updated to depend on androidx.browser instead of the Android Support Library. Support for browser actions was also removed as Chrome discontinued support that feature half a year ago. Bug: 980567 Change-Id: I716658d3407ef28630dea94d75e9f672eca797d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120724 Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#756593}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I50f4ee672c7c94c37655107c4eeab8c8960bd6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134094Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Zinovy Nis authored
Bug: 995566 Change-Id: Ia71ae2c5b7f423e685d4a88fabc3bc21c22e307a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135694Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#756591}
-
Yuki Shiino authored
Makes "set integrity level to frozen" work on arbitrary v8::Value. This patch supports |FrozenArray<T>?|, which is not always a v8::Object. Bug: 839389 Change-Id: I80f306d9f376a1e3b2d8562703273d610aca8257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136568Reviewed-by:
-
Yuki Shiino authored
NodeFilter is only the callback interface that needs to be exposed on a global object (Window). Bug: 839389 Change-Id: If3498ebda9b98fb2e35349a9bc6322631afe8ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135678Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95fbc0688834..74ac68ad26bc git log 95fbc0688834..74ac68ad26bc --date=short --first-parent --format='%ad %ae %s' 2020-04-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1cc49bb2e230..1c95795f1fb3 (12 commits) 2020-04-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f99302c4efe6..b8d47928094f (15 commits) Created with: gclient setdep -r src/third_party/skia@74ac68ad26bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I02a93936a095eb9c05f2129abc0d5805720073b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756588}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/676162732328..2a34dd3052e2 Created with: gclient setdep -r src-internal@2a34dd3052e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I62f4c6367b32decce769f28d5f32d74c1e3ab7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137124Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756587}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ba30328d0ea..95fbc0688834 git log 0ba30328d0ea..95fbc0688834 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src d086f1bd..c0b367bf (424 commits) Created with: gclient setdep -r src/third_party/skia@95fbc0688834 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ife216c493cdea4357c6562152c021cc71696cd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137125Reviewed-by:
-
Roman Sorokin authored
Fixed: 1067461 Change-Id: I5b9709f24bde696fb43be85d7a82b166132d0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134232Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756585}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56f8fb61b9d5..8684dfae246f git log 56f8fb61b9d5..8684dfae246f --date=short --first-parent --format='%ad %ae %s' 2020-04-06 dberris@chromium.org Pinpoint: Add issue labels based on results Created with: gclient setdep -r src/third_party/catapult@8684dfae246f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1067569 Tbr: wenbinzhang@google.com Change-Id: I320d92a8c255e43260f1f40a5cb0fa6d32d87d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137057Reviewed-by:
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1067211 Change-Id: I2245fa9a29d6630f74c16ef33c395048dffbaff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134095Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756583}
-
Yuichiro Hanada authored
ArcInputMethodService which is at the other side of the mojo channel can call methods even when a text input on a non-ARC window is focused because there is a dummy input view in Android side which is synchronized with the text input on the non-ARC window. Bug: 1063740, b:152792033 Change-Id: I8ea636aeb765500f0fbd12475a660ec104364114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137164Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#756582}
-
Christopher Cameron authored
In r750774, web_app::ShortcutInfo::file_handler_extensions was changed from stripping off the leading `.` to not stripping off the leading `.`. This broke the macOS implementation, because these values are listed directly in CFBundleTypeExtensions in the Info.plist. Fix this by stripping the leading `.` in a helper function, and updating the unit tests to verify this behavior. Bug: 1067368 Change-Id: I222fbd8a342cc1f13bc271bfe59a1aad8989b889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136470 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#756581}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I4feaf0826305ff4787c59c8622fe7f5a9400c9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134757 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#756580}
-
Ian Kilpatrick authored
This was added within: https://chromium-review.googlesource.com/c/chromium/src/+/1754097 When we adjust the table-cell intrinsic-padding for scrollbars. This calculation can safely ignore the block-start scrollbar if present. Bug: 1008302 Change-Id: I3b747714da9c6736708b5b8d563450cdb13df524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136888Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756579}
-
Hiroki Nakagawa authored
This field was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/727826/ ... and became unnecessary by https://chromium-review.googlesource.com/c/chromium/src/+/823374/ Bug: n/a Change-Id: Ib0bb149d9480cb9981135b22b64ff9cb1094cd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132901 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#756578}
-
Gang Wu authored
IDBRequestTest.AbortErrorAfterAbort IDBRequestTest.EventsAfterEarlyDeathStopWithTwoQueuedResults are flaky on Marshmallow TBR=cmp@chromium.org Bug: 1068057 Change-Id: I95203303a82d01eaa81618a1949b8b5cf44e6eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136892Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756577}
-
Kenichi Ishibashi authored
This CL adds ServiceWorkerResourceReader which will be used by browser/embedders to read a service worker script from storage after ServiceWorkerStorage is migrated to the storage service. It is created via ServiceWorkerStorageControl::CreateResourceReader(). This CL only adds ReadResponseHead() method. Subsequent CLs will add methods to read the content of service worker script and metadata (V8 code cache). Following naming convention in content/browser/appcache/, service_worker_resource_writer_impl.{cc,h} are renamed to service_worker_resource_ops.{cc,h} Bug: 1055677 Change-Id: I7ae13a667ad733a1d8c3657f932f420d4f1be3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132559Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#756576}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If a some c++ code called '/signout', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route SIGN_OUT, which is shared with browser routes to a more distinguishable name OS_SIGN_OUT. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: I0733982bc48284d184a0cfdb853ef234ccc1458c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129992 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#756575}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iad6062789915e8949d4dfe98fc7f690249fe3a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137120Reviewed-by:
-
Kent Tamura authored
This CL has no user-visible behavior changes. Note that LayoutNG ratio computed by this counter and |LocalFrameView:: layout_object_counter_| is 55.1% on nytiimes.com. Bug: 1067527 Change-Id: I73e349a6f5daab79c5f4005ffc28997167f35788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136011Reviewed-by:
-
Julian Watson authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/06db03ca54cf..2e5dab7c2630 $ git log 06db03ca5..2e5dab7c2 --date=short --no-merges --format='%ad %ae %s' 2020-03-25 davidmunro vm_tools: Protos for the StartLxd call we're adding. 2020-04-01 juwa system_api: add VmType to cicerone's ApplicationList message 2020-03-30 cylai system_api: add kChromeFeaturesServiceIsCryptohomeDistributedModelEnabledMethod 2020-04-01 ejcaruso system_api: add --flash_mode_check flag to modemfwd switches Created with: roll-dep src/third_party/cros_system_api Bug: None Change-Id: Ib8d7be4101027a2f9fc00f2ee744f0cb29530db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137101 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#756572}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If a some c++ code called '/people', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route PEOPLE, which is shared with browser routes to a more distinguishable name OS_PEOPLE. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: If1528c70ed31429711044985e9589a6025568dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117936 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756571}
-
Nancy Wang authored
This reverts commit c4c43642. Reason for revert: <INSERT REASONING HERE> The test case failure looks not related with the CL. Original change's description: > Revert "Reland "Remove launch service."" > > This reverts commit a7c7613c. > > Reason for revert: Sorry, this seems to be causing test failures: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/24801 > > Original change's description: > > Reland "Remove launch service." > > > > This is a reland of d07c4196 > > > > TBR=ericwilligers@chromium.org > > TBR=dominickn@chromium.org > > > > Original change's description: > > > Remove launch service. > > > > > > BUG=1061843 > > > > > > Change-Id: I12efd2899403cb9cc5e9dafc04300a7156342ed9 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116156 > > > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#756170} > > > > Bug: 1061843 > > Change-Id: I020be92154b0f5fad0d45f1f5c83f2d8539684d0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134036 > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#756556} > > TBR=xiyuan@chromium.org,ericwilligers@chromium.org,dominickn@chromium.org,nancylingwang@chromium.org > > Change-Id: I5d1c9b2e82f3bbca4d482ab0909639ca553c81a2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1061843 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137099 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756559} TBR=xiyuan@chromium.org,aboxhall@chromium.org,ericwilligers@chromium.org,dominickn@chromium.org,nancylingwang@chromium.org Change-Id: Ib807a7375f0b401f96dbcdd902651f777916f187 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136010Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756570}
-
My Nguyen authored
Also add comment in "suggestion_window_controller_impl.cc"to affirm there is no memory leak. Bug: 1060965 Change-Id: Iccb3f2935c1cbdec31c4a260d46a6646c3975edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134029Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756569}
-
Yuzu Saijo authored
Back-forward cache reuses the logic preventing hidden pages from triggering vibrations. Add a test to ensure that this is working. Bug: 1061855 Change-Id: Id27cb53d007a6ef3f7a64e9a62130d2c459adb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103982 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: Id077aa4055c31e519a58f2db634cdd7325429d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136849Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756567}
-
Ian Kilpatrick authored
This was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2099322 It turns out this was reachable! Bug: 1064432 Change-Id: I742f706434cd45ea8c30505e565b193921c3f6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136880 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
This reverts commit 6f300726. Reason for revert: We want the flag enabled in ToT (for M-84 branch). Original change's description: > Revert "Reland "Files app: Enable flag files-ng by default"" > > This reverts commit aed7a18a. > > Reason for revert: Disabling for M-83, feature moved to M-84. > > Original change's description: > > Reland "Files app: Enable flag files-ng by default" > > > > This reverts commit 7545fd48. > > > > Reason for revert: We want to enable the flag by default on ToT, the revert was intended to disable the flag on M-82, on ToT it should be > > enabled. > > > > Original change's description: > > > Revert "Files app: Enable flag files-ng by default" > > > > > > This reverts commit ea497580. > > > > > > Reason for revert: Feature moved from M-82 to M-83. > > > > > > Original change's description: > > > > Files app: Enable flag files-ng by default > > > > > > > > Add files-ng classes and attribute to main.html so files-ng styles are > > > > applied during app startup (to avoid a FOUC flash of non-files-ng blue > > > > color). > > > > > > > > Enable file-ng by default in FilesApp and its browser test harness. > > > > > > > > Bug: 992818 > > > > Change-Id: If437271c5604d36b4b0908abb663a84e52b6ae35 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087308 > > > > Reviewed-by: Alex Danilo <adanilo@chromium.org> > > > > Commit-Queue: Alex Danilo <adanilo@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#747421} > > > > > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > > > > > Bug: 992818 > > > Change-Id: I8b1c770e2c43823eff9a2a9aceae650fcb25a3f8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103992 > > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > > Reviewed-by: Noel Gordon <noel@chromium.org> > > > Reviewed-by: Alex Danilo <adanilo@chromium.org> > > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#750448} > > > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 992818 > > Change-Id: I94e63a873d4e2970d201a32dca0944a4e8fa520f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116152 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Reviewed-by: Noel Gordon <noel@chromium.org> > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#752674} > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 992818 > Change-Id: I3e6a3a82ded4953ea6c9757c0b94b500cd21563f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128045 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754834} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992818 Change-Id: I55c7aaeaa2184c4433792c9538a9b23727d4d3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135653Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#756565}
-
Joseph Kim authored
Details of this change can be found here: 2114014: Demo Mode: Display descriptive progress during Demo setup https://chromium-review.googlesource.com/c/chromium/src/+/2114014 Bug: b:148753805 Change-Id: Id101eb2dde6ed43939cc5012fb09982f1250d08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136009Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Joseph Kim <josephkimsh@google.com> Cr-Commit-Position: refs/heads/master@{#756564}
-
Mei Liang authored
This CL setup the path to get a composed favicon from native for the group tab in tab switcher. Native currently has dummy implementation, so the group tab falls back to use a default favicon. Change-Id: I4707632a240f05f6b81aac314eaad198e8262e76 Bug: 1064153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117649 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756563}
-
