GitLab

Review URL: https://chromiumcodereview.appspot.com/11144040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162266 0039d316-1c4b-4281-b951-d872f2087c98

OpenInputDesktop() can fail when the window station is shutting down. We cannot really do anything about it and it happends often enough polluting the logs.

BUG=156135

Review URL: https://codereview.chromium.org/11195006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162265 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/chromium/issues/detail?id=134093
https://chromiumcodereview.appspot.com/10993067/

This is a better fix than 10993067. This CL undoes that change and moves the fix to the AcceleratorController. This is a more general fix which employs a table of actions that are allowed when in a modal dialog. All other actions are suppressed.

BUG=153077
TEST=System Tray -> Ehternet -> Join Other; while the modal dialog is up, try various ash shortcuts. Observe that the ones are working (like volume up) make sense, but things like new window or moving around windows are inactive.

Review URL: https://chromiumcodereview.appspot.com/10977088

TBR=sschmitz@chromium.org
Review URL: https://codereview.chromium.org/11192016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162264 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11125002

TBR=rch@chromium.org
Review URL: https://codereview.chromium.org/11191015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162263 0039d316-1c4b-4281-b951-d872f2087c98

It appears that paint() checks for non-NULL delegate_, so it makes sense to
do the same for updateGeometry as well.

BUG=155950

Review URL: https://codereview.chromium.org/11148031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162262 0039d316-1c4b-4281-b951-d872f2087c98

<math.h> has all we need

BUG=154451


Review URL: https://chromiumcodereview.appspot.com/11151032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162261 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11125002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162259 0039d316-1c4b-4281-b951-d872f2087c98

The test was originally disabled because of Windows-specific failures, but runs fine on other platforms.

BUG=130327
TEST=browser_tests BrowserViewTest


Review URL: https://chromiumcodereview.appspot.com/11137002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162258 0039d316-1c4b-4281-b951-d872f2087c98

This flag was added by r153554 and only set for desktop Chrome default apps.
Since it affects install behavior (e.g. OAuth scope granting in
ExtensionService::InitializePermissions) it should be set everywhere.

BUG=156001
R=dpolukhin@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11146028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=148615


Review URL: https://chromiumcodereview.appspot.com/11044020

TBR=rouslan@chromium.org
Review URL: https://codereview.chromium.org/11192014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162256 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162255 0039d316-1c4b-4281-b951-d872f2087c98

Soon we'll build necessary libs into gen/sdk/toolchains/... directly, which
will obviate the need to move files around like this. This is just a stopgap to
make the tree green.

BUG=none
TBR=noelallen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/11183010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=148615


Review URL: https://chromiumcodereview.appspot.com/11044020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162252 0039d316-1c4b-4281-b951-d872f2087c98

Media Galleries: Initialize the internal state of MediaGalleriesPrivateEventRouter with the list of already attached storage devices.

BUG=156024

Review URL: https://chromiumcodereview.appspot.com/11164003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162251 0039d316-1c4b-4281-b951-d872f2087c98

R=grt@chromium.org
BUG=155640
TEST=Install old Chrome (user and system level), over-install new Chrome, make sure <root>\Software\Classes\Chrome<suffix>\.exe\shell\run is deleted.

Review URL: https://chromiumcodereview.appspot.com/11146003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162250 0039d316-1c4b-4281-b951-d872f2087c98

The previous overview image of the Calculator app has an OS X title bar,
this updated version is OS-neutral.

BUG=156159

Review URL: https://codereview.chromium.org/11191012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162249 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156119


Review URL: https://chromiumcodereview.appspot.com/11191011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162248 0039d316-1c4b-4281-b951-d872f2087c98

The list of files was generated with the following command line:
$ ls *.h cc/ | grep -v CC

BUG=155413
TEST=cc_unittests
R=enne@chromium.org,jamesr@chromium.org

Review URL: https://codereview.chromium.org/11189011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162247 0039d316-1c4b-4281-b951-d872f2087c98

Do not modify the DOM of the most visited page if nothing has changed, which
is often the case as the top sites are polled periodically just to make sure
they are up to date.

Also, moves the event listener to a node with a text attribute that allows it
to be selected in accessibility mode.

Makes some markup nodes as skippable in accessibility mode by marking them as
having empty alt text.

BUG=155450


Review URL: https://chromiumcodereview.appspot.com/11155022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162246 0039d316-1c4b-4281-b951-d872f2087c98

(a simplified replacement for TextButton[Base], etc.)

Add the LabelButton class, based on TextButton.
(simplify, cleanup, re-use views controls, etc.)
Add a supporting LabelButtonBorder class.
Add unit tests and a views example in ButtonExample.
Add ImageView interactive flag for hit-testing.
Make Label::text() return a const string16 ref.

TODO(followup): Replace TextButton[Base] use, etc.
TODO(followup): Fix CanvasSkia multi-line label painting.

BUG=155363
TEST=views examples use of the new LabelButton, etc.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11068012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162245 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org
BUG=154451


Review URL: https://chromiumcodereview.appspot.com/11144034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155546


Review URL: https://chromiumcodereview.appspot.com/11170007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162243 0039d316-1c4b-4281-b951-d872f2087c98

Added explict type converion to initialization list.

TEST=Built using gcc-4.7
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11148030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11170006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162241 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/chromium/issues/detail?id=134093
https://chromiumcodereview.appspot.com/10993067/

This is a better fix than 10993067. This CL undoes that change and moves the fix to the AcceleratorController. This is a more general fix which employs a table of actions that are allowed when in a modal dialog. All other actions are suppressed.

BUG=153077
TEST=System Tray -> Ehternet -> Join Other; while the modal dialog is up, try various ash shortcuts. Observe that the ones are working (like volume up) make sense, but things like new window or moving around windows are inactive.

Review URL: https://chromiumcodereview.appspot.com/10977088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162240 0039d316-1c4b-4281-b951-d872f2087c98

Add test for web intents host.

R=groby@chromium.org
BUG=153695


Review URL: https://chromiumcodereview.appspot.com/11026070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162239 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162238 0039d316-1c4b-4281-b951-d872f2087c98

This reverts the revert 2ed4f501.

My change https://chromiumcodereview.appspot.com/11098008/ got reverted
due to crash on startup of chromium_testshell.

The difference from the previous CL is that TabBaseAndroidImpl constructor
now calls InitTabHelpers() and that InitTabHelpers() is now a protected instead
of private.


Review URL: https://chromiumcodereview.appspot.com/11137004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162237 0039d316-1c4b-4281-b951-d872f2087c98

DISABLE_CAPS_LOCK is invoked with Shift keyup and should not
be consumed. Otherwise the Shift keyup event is not sent to 
the renderer for tabbed web pages.

BUG=155434
TEST=Manually check Shift keyup event is generated.

Review URL: https://chromiumcodereview.appspot.com/11113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162236 0039d316-1c4b-4281-b951-d872f2087c98

Per discussion with perkj@, after media stream is generated, all error messages would be sent to client, instead of media stream.
Review URL: https://codereview.chromium.org/11146008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162235 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11187002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162234 0039d316-1c4b-4281-b951-d872f2087c98

- Expose the WebGraphicsContext3D for Android's Compositor.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11090075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162231 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=chrome-os-partner:14207

Review URL: https://codereview.chromium.org/11192012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162230 0039d316-1c4b-4281-b951-d872f2087c98

Bug fix: in process router should not expect a sync message from host to plugin.  Replies to sync messages are not sync message.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11112004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162229 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162228 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danakj

Review URL: https://codereview.chromium.org/11198003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162227 0039d316-1c4b-4281-b951-d872f2087c98

The new common_resources.grd will be used for non-loalizeable resources, 
such as images.


Review URL: https://chromiumcodereview.appspot.com/11087059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119379
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11188003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual test by verifying new draggable region syntax works


Review URL: https://chromiumcodereview.appspot.com/11028125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162224 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140319
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11150035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162223 0039d316-1c4b-4281-b951-d872f2087c98