- 14 Mar, 2018 40 commits
-
-
Jinsuk Kim authored
Now we got only a handful of references to ContentViewCore object left in RenderWidgetHostViewAndroid. All but 3 are all null checks trying to see if content_view_core_ is set to null or not, which is equivalent to checking if the native view (ViewAndroid) of ContentViewCore and its own native view form a view tree or not. This can be replaced simply by a boolean flag. The only 3 are significant (i.e. invoking methods of CVC) ContentViewCore::GetViewAndroid() - RWHVA may not have an access to the parent native view. It should be passed to RWHVA instead. ContentViewCore::RequestDisallowInterceptTouchEvent() - It goes up to Java container view to invoke android.view.View.requestDisallowInterceptTouchEvent. One more move from CVC to ViewAndroidDelegate... ContentViewCore::GetWindowAndroid() : same WindowAndroid (or null if not attached to view tree) can be obtained via ViewAndroid::GetWindowAndroid(). Bug: 626765 Change-Id: I80088c6a9ca2ca0047184ac77f84f08f64ff0acb Reviewed-on: https://chromium-review.googlesource.com/958646 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542999}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: I3d8a6c2813b360ca5497f9d8bc31e8e6e2c6caf0 Reviewed-on: https://chromium-review.googlesource.com/961166 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#542998}
-
Keishi Hattori authored
Split GCType into MarkingType and SweepingType so we can track if the gc was incremental marking or not. Change-Id: I2264badba6b0e7dbdbd41e2bb4958ca3fb37cb0d Reviewed-on: https://chromium-review.googlesource.com/958898Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542997}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: I0c1872dc6942c3cccf706b4c60869402bbe47f59 Reviewed-on: https://chromium-review.googlesource.com/961561 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chrome://flags/#force-ui-directionSidney San Martín authored
Bug: 820348 Change-Id: Id9c8ff9878f6595f99d4630a18aa023b55cc8467 Reviewed-on: https://chromium-review.googlesource.com/956297Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542995}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I63fded1b83f7f2fd51ca455f2b1f5eefee8f76d4 Reviewed-on: https://chromium-review.googlesource.com/961809Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542994}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: I2084d2a10cf69f2815c147769d46d8a5f0cba7ff Reviewed-on: https://chromium-review.googlesource.com/961621 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542993}
-
Yutaka Hirano authored
Bug: 809119 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1aa568846bf0a71ebb509c5e55ae3fce9163a78e Reviewed-on: https://chromium-review.googlesource.com/958307Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#542992}
-
Jinsuk Kim authored
WebContents of contextual search panel can be created after the device gets rotated. The content size to be used for WebContents should have been updated to pick up the right size after the rotation happens. This CL fixes that. Bug: 820940 Change-Id: I811d52db9d175adf100c0e13c0bfc35ac5d00d5a Reviewed-on: https://chromium-review.googlesource.com/959408Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542991}
-
Tsuyoshi Horo authored
Screenshot: https://crbug.com/803774#c41 Bug: 803774 Change-Id: I3cffd4258de124df22f4bc7560e0e9dbc91ca442 Reviewed-on: https://chromium-review.googlesource.com/956654 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#542990}
-
Robert Iannucci authored
R=jbudorick@chromium.org Bug: 811974 Change-Id: I50908b28ce18fabf62f033563669f194b68fb9a4 Reviewed-on: https://chromium-review.googlesource.com/961531Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542989}
-
Michael Giuffrida authored
This is causing ninja to treat WebKit as dirty on every compile, for certain build configurations. Follow-up to https://crrev.com/c/957264. Bug: 818691 Change-Id: Idd32f722b8d4efe82388a06e2acc0d638cd9eb4e Reviewed-on: https://chromium-review.googlesource.com/961784Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542988}
-
James Cook authored
The comment on the disabled tests was wrong. Bug: 820464, 821551 Change-Id: Icad7c41fdb814eea44be2fa4c16528404a816176 Reviewed-on: https://chromium-review.googlesource.com/961487Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#542987}
-
https://skia.googlesource.com/skia.git/+log/6fccc50a4a6f..cefa808f3f23 $ git log 6fccc50a4..cefa808f3 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 benjaminwagner Update clang_win to yesterday's build (from Chromium). 2018-03-13 fmalita [sksg] Use SkTrimPathEffect for path trimming Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I6b9d264fc911f25428788a77cb1e577d92e6fe74 Reviewed-on: https://chromium-review.googlesource.com/961725 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542986}
-
Darren Shen authored
Pretty standard test apart from font-size can't be negative. Bug: 774887 Change-Id: Ieae05dc71c68b5f777d6078e4c9daec0b6eebee4 Reviewed-on: https://chromium-review.googlesource.com/936961 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542985}
-
Sammie Quon authored
Phantom window and overlay have other meanings for other uses. Phantom windows -> preview area as it is a highlight which gives a preview of the bounds of a snapped window. Overlay -> drag indicators. The class handles displaying various indications for entering split view. Test: ash_unittests SplitViewWindowSelectorTest.* Bug: 808283 Change-Id: If8bb36792daa7d89c8dac96cc5baf841bee3bdee Reviewed-on: https://chromium-review.googlesource.com/946887 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#542984}
-
tzik authored
This CL applies //tools/clang/base_bind_rewriters to //chrome/browser/extensions. It rewrites base::Bind to base::BindOnce where the resulting base::Callback is immediately converted to base::OnceCallback, which is considered safe to use base::BindOnce. E.g.: base::PostTask(FROM_HERE, base::Bind([]{})); base::OnceClosure cb = base::Bind([]{}); are converted to: base::PostTask(FROM_HERE, base::BindOnce([]{})); base::OnceClosure cb = base::BindOnce([]{}); This reduces the number of 'base::Bind' in //chromecast from from 186 to 121 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: If50b2191fe374860cd17455f9bd0e0e549fbefc0 Reviewed-on: https://chromium-review.googlesource.com/960402Reviewed-by:Sergey Volk <servolk@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#542983}
-
Alexandre Courbot authored
VideoDecodeAccelerators are supposed to work without GL support, provided the make_context_current_cb_ callback is null. However the Initialize() method of V4L2 accelerators checked for a valid EGL display unconditionally. Move this check under the condition that make_context_current_cb_ is not null, so that the V4L2 accelerators can be used without an EGL display. BUG=819542 TEST=Made sure VDA tests were still passing on eve, hana and kevin. Change-Id: I632e85bad6871910c8a9114c6c34338c37262c08 Reviewed-on: https://chromium-review.googlesource.com/954767Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542982}
-
Wez authored
The new StopsCreatingHardwareFramesWhenHiddenOrClosed crashes under Fuchsia, so filter it for now. TBR: sergeyu Bug: 819924 Change-Id: Iecec7d2dae681af105e2c9adde84e120343317bd Reviewed-on: https://chromium-review.googlesource.com/961735Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542981}
-
Hwanseung Lee authored
break-after, break-before, break-inside are added to support in whitelist. and test file are also added. Bug: 820299 Change-Id: I9eb35a7371dd385edf3c039aea367b42e194e1e1 Reviewed-on: https://chromium-review.googlesource.com/960701Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#542980}
-
Jun Choi authored
U2fApduCommand and U2fApduResponse objects in device/u2f are transport and protocol agnostic. Migrate all APDU related objects and tests to src/components. Bug: 807836 Change-Id: I96e71128eb0fcf13b8c38fc7e9a4d0b31203c99f Reviewed-on: https://chromium-review.googlesource.com/896965 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Tao Bai authored
Bug: 785531 Change-Id: I2d9480537259606a347746ab7cdc81c40a938290 Reviewed-on: https://chromium-review.googlesource.com/957426Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542978}
-
https://chromium.googlesource.com/angle/angle.git/+log/aac6df40a2b5..690c8eb7f2d2 $ git log aac6df40a..690c8eb7f --date=short --no-merges --format='%ad %ae %s' 2018-03-12 jmadill Framebuffer: syncState before internal format query. 2018-03-13 jdarpinian Optimize buffer deletion by returning early if buffer is not bound. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iee8415867fa06b64dfcd5ff0329d92ed0137bb3b Reviewed-on: https://chromium-review.googlesource.com/961559Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542977}
-
Charles Harrison authored
Most prefix checks take between 0 and 1 ms. This CL improves the resolution by logging the check in micros. The CL also removes the SB2.FilterCheck metric which is not really needed anymore. Bug: 787092 Change-Id: I18a81d6eb7891f5a4c8c6fd6e7e956dc653d5379 Reviewed-on: https://chromium-review.googlesource.com/960248 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#542976}
-
Ken MacKay authored
* Make it so the old command-line arg to set a fixed output sample rate works. * Avoid NaN in postprocessor volume calculation. Bug: internal b/74089224 Change-Id: Ic9534d16e8eff5e24faf3cac8b41e8aa63c3397a Reviewed-on: https://chromium-review.googlesource.com/960966Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#542975}
-
Eugene Ostroukhov authored
1. Network search is always enabled. 2. Search view toolbar look & feel was updated. 3. Rename "Search all files" to "Search" Bug: 468416 Change-Id: I178a2a7dda312c8be8b103bdbf51cea2527b6ce4 Reviewed-on: https://chromium-review.googlesource.com/959150 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542974}
-
https://skia.googlesource.com/skia.git/+log/e027e19477f8..6fccc50a4a6f $ git log e027e1947..6fccc50a4 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 angle-skia-autoroll Roll skia/third_party/externals/angle2/ f0b30dd8b..690c8eb7f (4 commits) 2018-03-13 bungeman Compile with GCC 7.2.0. 2018-03-13 fmalita Harden initial LinearGradient4f tiling 2018-03-13 benjaminwagner Add Win Clang x86 builds. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ie96ff36dcbaf0e1739dcdad2c10ca941ba5048b9 Reviewed-on: https://chromium-review.googlesource.com/961583Reviewed-by:
-
Brian Anderson authored
Make Log2Floor and Log2Ceiling use CountLeadingZeroBits, which maps to fast underlying CPU instructions. This improves the performance of adding samples to a histogram that relies on Log2Floor to convert values to buckets by 1.5x to 2x. Other code that uses Log2*, will likely see similar benefits. Bug: 807463 Change-Id: Ie21465523d70ce451d8ded6471a0b39107d73d87 Reviewed-on: https://chromium-review.googlesource.com/961490Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#542972}
-
https://chromium.googlesource.com/catapult.git/+log/565a74556b27..7b53f088f8e8 $ git log 565a74556..7b53f088f --date=short --no-merges --format='%ad %ae %s' 2018-03-13 charliea Upload the BattOr agent binary to latest (fixing clock sync bug) Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I5f5a6506e94093f0de5231f72a501f78b48d07ed Reviewed-on: https://chromium-review.googlesource.com/961584 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542971}
-
Stephen Lanham authored
Cast builds were broken by this change: crrev.com/c/957707 BUG= Bug: b/74547326 Change-Id: I41cb56436af9f5657f9ed87d817a9129c8cdf544 Reviewed-on: https://chromium-review.googlesource.com/960742Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542970}
-
Jia authored
Bug: 821036 Change-Id: I98e392f3dd60e4148fd04a164e3a9fe5580fe57f Reviewed-on: https://chromium-review.googlesource.com/961165Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542969}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/c6fcb9bb94ea..7b5a57449ba0 $ git log c6fcb9bb9..7b5a57449 --date=short --no-merges --format='%ad %ae %s' 2017-01-31 johannkoenig vp8 temporal_filter: ignore return value 2018-03-12 marpan vp9-svc: Update layer frame counters when layer is skipped. 2018-03-11 marpan vp9-SVC: Fix to choose_partition when LAST ref is NULL. 2018-03-07 jzern vpx_scale_test: add w/h output to alloc failure 2018-03-05 johannkoenig add worst-case frame size cap 2018-03-05 linfengz Fix a bug in vp9_iht16x16_256_add_neon() 2018-03-05 linfengz Fix a bug in vp9_iht8x8_64_add_neon() 2018-03-04 johannkoenig move vp8 encodeopt to block_error_sse2 2018-02-21 paulwilkins Change to KF frame boost calculation. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=webm:1503 Change-Id: I771065a1f26ad711d6b2f55c769354028ac47ef7 Reviewed-on: https://chromium-review.googlesource.com/961368Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#542968}
-
Tarun Bansal authored
The number of client hints requested by origin can be as high as blink::mojom::WebClientHintsType::kLast + 1. Bug: 735518 Change-Id: I6b5f2552b1f55f01e9b9aff33ce1ff33af8f125c Reviewed-on: https://chromium-review.googlesource.com/961539Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542967}
-
Alan Cutter authored
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=328381&signed_aid=VY4yoX2RjWAXH9GdA_fOqA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=328382&signed_aid=xZ3u2qp0ckn4lR26-iNcmA==&inline=1 Bug: 820314 Change-Id: I8b2eb00c392e11578722656cee876db7abf49640 Reviewed-on: https://chromium-review.googlesource.com/956364 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#542966}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0dfd5a0..e704dea0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2ab948701b08114830f9dad7089555c8eb820f37 Reviewed-on: https://chromium-review.googlesource.com/961521Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542965}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68de9f34db44..064937143390 $ git log 68de9f34d..064937143 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I897521fa7189de77f55d7274c3c998d9d92a6f23 Reviewed-on: https://chromium-review.googlesource.com/961085Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542964}
-
Yuanyao Zhong authored
Bug: b/73285025 Change-Id: I052cf918edb3cf15d3c6576c39adfbd6475ed93e Reviewed-on: https://chromium-review.googlesource.com/955956Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#542963}
-
Nate Fischer authored
No change to production logic, this only affects tests. This plumbs base::i18n::GetConfiguredLocale() to Java for Safe Browsing tests so that we can robustly compare interstitial URLs across various locales (which actually impacted several more tests than initially identified in the bug). getSafeBrowsingLocaleForTesting() uses the same underlying implementation used by interstitial code to append the 'hl' query parameter to help center URLs. This also enables the tests which were previously reported as flaky, as the issue is now resolved. Bug: 819085 Test: change device language to Czech, then run_webview_instrumentation_test_apk -f SafeBrowsingTest#* Change-Id: I4dd6d9732a29c5b486103f4c3dff7c44f4c5057b Reviewed-on: https://chromium-review.googlesource.com/959744Reviewed-by:
-
Philip Rogers authored
The following intersection functions are edge-inclusive: FloatQuad::IntersectsRect FloatQuad::IntersectsCircle FloatQuad::IntersectsEllipse FloatRoundedRect::IntersectsQuad This is different from FloatRect::Intersects and LayoutRect::Intersects which are edge-exclusive. This patch adds a comment above each of these functions specifying that they are edge-inclusive, and adds tests. Bug: 818772 Change-Id: I7c1212a08e5e8874fb9679c5a676f91a97d3fce7 Reviewed-on: https://chromium-review.googlesource.com/960841Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542961}
-
Alexei Svitkine authored
Makes the constructor not call a virtual method by adding a non- virtual helper function, avoiding the need for a wordy comment. This also avoids extra work, since UpdateCrashKeys() only needs to be called once during object construction, rather than once per already-active trial. Also fixes the unit test on iOS device by adding extra initialization & clean up. Bug: 309729, 821162 Change-Id: Icc6c8730bbada99167945b3353bb0d60b7f58600 Reviewed-on: https://chromium-review.googlesource.com/961488Reviewed-by:
-
