- 08 Apr, 2020 40 commits
-
-
Gang Wu authored
Update ClipboardRecentContentGenericTest to handle 10 minutes max age. Bug: 1068866 Change-Id: I81fe82b876783ee82fa3782a1f83d1fcd4c68ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141139Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757477}
-
Dominique Fauteux-Chapleau authored
DeepScanningDialogDelegate now validates various policies by reading an AnalysisSettings instead of reading each policy. Tests are updated to call IsEnabled since that's what sets data.settings. Bug: 1062348 Change-Id: I4f949e3300fa477737c1189e47dd8f8e4051cfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134191Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#757476}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ic2ce5e2ef8d265fd54b1d76efea7a9dae1c076c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139694Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#757475}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d03d968b75ce..f7065f441485 git log d03d968b75ce..f7065f441485 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f0a39ac5..32ec1c1c (757292:757394) Created with: gclient setdep -r src/third_party/webrtc@f7065f441485 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iffbd875b6627278d3198ebb95acabd8b56de2b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757474}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, this test has been slightly modified to become a reftest instead of a crash test, so that we not only check that applying a CSS filter to a <span> element does not crash, but also that it yields the expected results. Bug: 1063749 Change-Id: Icd7234480f6f64a15c4af0ae17c8a19199a12080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141930 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#757473}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca6b5b7a1781..eb17dbb23599 git log ca6b5b7a1781..eb17dbb23599 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 morg@google.com Add kukui-arc-r to chromeos config boards 2020-04-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-08 engeg@google.com cbuildbot: just output csv channels instead 2020-04-08 cjmcdonald@chromium.org cros_sdk: Set encoding for command output 2020-04-08 saklein@chromium.org flash-ap: Remove unneeded is_fast_required. 2020-04-08 saklein@chromium.org flash-ap: Make the is_fast_required function optional. 2020-04-08 cjmcdonald@chromium.org pytest: Make CIDB mock fixture more robust 2020-04-08 camurcu@chromium.org arc: Publish org.chromium.arc.cachebuilder.jar on chromeos bucket 2020-04-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-07 richardfung@google.com Remove eve-arcnext 2020-04-07 bpastene@chromium.org vm: Correctly add Qcow2 args to qemu's args when enabled. 2020-04-07 saklein@chromium.org flash_ap: Remove flash_ap wrapper.py symlink. 2020-04-07 morg@google.com Make VMRVC PFQ runs more frequent 2020-04-07 richardfung@google.com Add betty-arc-r to configs 2020-04-07 cjmcdonald@chromium.org pytest: Don't skip 'mock_error' marker 2020-04-07 cjmcdonald@chromium.org pytest: Add fixture to initialize CIDBConnectionFactory 2020-04-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-07 kimjae@chromium.org build_dlc.py: Fix typo LoadEbuildParams 2020-04-07 mmortensen@google.com Improve autotest logging prior to refactoring BuildAutotestTarballsForHWTest. 2020-04-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-06 mmortensen@google.com In cros_build_lib.CreateTarball, log context on failures. 2020-04-05 vapier@chromium.org Revert "cbuildbot: switch to python3 only via virtualenv wrapper [reland]" 2020-04-04 vapier@chromium.org cros_build_lib: run: only return output when requested 2020-04-04 vapier@chromium.org cbuildbot: switch to python3 only via virtualenv wrapper [reland] 2020-04-04 sanikak@chromium.org auto_updater: reboot device before au kicks off if device is not idle 2020-04-04 saklein@chromium.org run: Fix output capturing calls. 2020-04-04 kimjae@chromium.org build_dlc.py: Non sudo copying from build directory 2020-04-04 engeg@google.com release_stages: add an output tag for channels 2020-04-03 seanabraham@chromium.org chromeos_config: add R83 schedule 2020-04-03 gredelston@google.com Stop using self._current_board as a buildstore 2020-04-03 saklein@chromium.org metrics_unittest: Fix flake. 2020-04-03 tcwang@google.com afdo: Reduce the frequency of AFDO updates to 2x/week 2020-04-03 morg@google.com Add -arc-r boards to unified lab board names hack 2020-04-03 vapier@chromium.org table/upgrade_table: require python 3 2020-04-03 bpastene@chromium.org vm: Add retries to vm.Start() if WaitForBoot fails. 2020-04-03 cjmcdonald@chromium.org pytest: Don't skip 'redirected_stdin_error' marker 2020-04-03 cjmcdonald@chromium.org pytest: Don't skip 'requires_portage' marker 2020-04-02 engeg@google.com chroot_util: preserve env for emerge call for unit tests 2020-04-02 cjmcdonald@chromium.org run_pytest: Add namespacing & chroot initialization 2020-04-02 cjmcdonald@chromium.org pytest: Skip flaky CIDB mock tests 2020-04-02 rkolchmeyer@google.com Revert "lakitu: Turn off GCETest stage" 2020-04-02 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@eb17dbb23599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I6b853545e7decd17786b22170e8bb49e0e3e0164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757472}
-
Wez authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2134299 which had broken handling of dependencies on the CMX manifest fragments of each package's "primary" component. Processing of the fragment to generate the full CMX file is now broken out into a distinct build target, on which the primary component target depends. Some unused Python and CMX files, missed in the original migration CL, are also removed. Migrate the cr_package_fuchsia() rule to use the SDK-provided fuchsia_component() and fuchsia_package() rules internally. TBR=dpranke Bug: 1050703, 1068782, fuchsia:49479 Change-Id: I217d9276f85602c4120e3ad0db6d64c47c691f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141094Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757471}
-
Chris Thompson authored
Download.Started.ContentType.InsecureChain and Download.Started.ContentType.SecureChain have been superseded by the new mixed downloads metrics under Download.InsecureBlocking, so this marks the old histograms as obsolete and removes the collection code. Bug: 1063890 Change-Id: I957d55299c302a3e49b5be5923180858eec1a007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140296Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#757470}
-
Dominique Fauteux-Chapleau authored
Change-Id: Ide49e3143b84c77e73baf09dad79e95f4d732c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141440 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#757469}
-
Jan Krcal authored
This CL fixes a bug in a previously flaky and disabled test and re-enables the test. The issue was with the fake server simulating failure for the first committed user event but it actually simulated failure for the first committed sync entity which could belong to a completely different data type. Bug: 1006155 Change-Id: I335b8acba95086977713a9799efa696bcfca7046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142292 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#757468}
-
Victor Hugo Vianna Silva authored
This CL removes and old TODO in the class referencing the absence of an API that is now already implemented in that class. It also moves the method up to give it more visibility. Bug: None Change-Id: I756666b31320d8fa1e6413e06542d6607d97f00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141918Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#757467}
-
Aaron Krajeski authored
https://chromium-review.googlesource.com/c/chromium/src/+/2124703/6/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc Bug: 1053477 Change-Id: I34d98509bad705b2f9026e96e12781dc5c7d13b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140204Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757466}
-
Peter Kotwicz authored
This CL: - Moves the methods in the WebappInfo subclass - WebApkInfo into WebappInfo - Adds @NonNull annotations to WebappExtras/WebApkExtras BUG=1068692 Change-Id: Ie6d3708df9e08ea68a851fca444eae999def2653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140616Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#757465}
-
chrome://appcache-internalsAdrienne Walker authored
This is a followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2132592 That CL showed token_expires on both entries and groups. It turns out that it should be sufficient to check only the group, so the UI on entry has been removed to avoid confusing developers. Bug: 582750 Change-Id: Ib575241a8f1988ce40b87f9568ff2e4bbc7310a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140104Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#757464}
-
Sylvain Defresne authored
Ensuring ChromeIdentity uniqueness is currently thread-usafe. Removing the uniqueness guaranty requires that code correctly uses -isEqual: to compare identities by value instead of doing the comparison of pointers (like you use -isStringEqual: to compare NSString). After doing an audit of all code using ChromeIdentity, convert all the comparison that were using pointers comparison instead of -isEqual:. Bug: none Change-Id: I110cb8e289ccaf482dd7addf67f5d194aed98a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139666 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#757463}
-
Patrick Noland authored
Bug: 1054829 Change-Id: I6817cc15d151044a38772df72358414a1f3ca45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141205Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#757462}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/94b61ee5c25c..e998a6b46ddd git log 94b61ee5c25c..e998a6b46ddd --date=short --first-parent --format='%ad %ae %s' 2020-04-08 btolsch@chromium.org Fix gcc bot Created with: gclient setdep -r src/third_party/openscreen/src@e998a6b46ddd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ic733862d15de23dc1e31ad27d49e751f5a20b6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757461}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/084944196744..6e3984a4c68e Created with: gclient setdep -r src-internal@6e3984a4c68e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com Change-Id: I5b3d319f0af6eaf796d55fcdb81928d52fd76826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142197Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757460}
-
Lei Zhang authored
- Remove the unused Profile* parameter from MigrateObsoleteLocalState(). - Rename MigrateObsoleteBrowserPrefs() to MigrateObsoleteLocalStatePrefs(), to be consistent with other functions that operate on Local State prefs. Also rename MigrateObsoleteLocalState() to MigrateObsoleteLocalStatePrefs(). - Then call MigrateObsoleteLocalStatePrefs() once per BrowserProcess initialization, instead of once per Profile initialization. - Split part of RegisterLocalState() off to RegisterLocalStatePrefsForMigration(), like the code does with RegisterProfilePrefsForMigration(). Change-Id: Id93c0d912f2418b40de33ed5348e3ffe77fb0f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136190 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#757459}
-
Side Yilmaz authored
Profile.Incognito.Lifetime metric is not working in iOS currently. This CL add Profile.Incognito.Lifetime metric to iOS app. Bug: 1067163 Change-Id: I17cdc2fe493a15c8a1cd57bbf6abb2d7429bab11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137344 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#757458}
-
Chris Lu authored
Currently BVC configures FullscreenController's WebStateListObserver. If the scoping FullscreenController to a Browser flag is on, pass the Browser instance to FullscreenControllerImpl and have it observe BrowserObserver and configure its WebStateListObserver. It will stop listening to WebStateListObserver in response to BrowserObserver::WebStateListObserver. Bug: 790886 Change-Id: I41be8f1645d650c9090a86e98713d571bac976cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132535 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#757457}
-
Liquan (Max) Gu authored
Original patch: https://crrev.com/2135152 Revert: https://crrev.com/2141209 Reason for revert: Test failure - AndroidPaymentAppFinderTest#testFindAppStoreBillingAppIgnoreNonAppStoreBillingApps Reason for reland: The test get fixed. Before: the test expectation assumed a fixed order in Set elements. After: the test doesn't assume it, compare set with set instead. Original change's description: > Revert "[PlayBilling] Support app-store billing in AndroidPaymentAppFinder" > > This reverts commit cc5487e9. > > Reason for revert: testFindAppStoreBillingAppIgnoreNonAppStoreBillingApps is failing consistently on KitKat: > https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29 > > Original change's description: > > [PlayBilling] Support app-store billing in AndroidPaymentAppFinder > > > > After: > > When a merchant page runs in a Trusted Web Activity that's installed > > from an app store (e.g., Google Play) and the PaymentRequest is not > > requesting shipping or payer contact, if it satisfies the following > > conditions, the TWA itself would be included: > > - the PaymentRequest supports the (TWA installer) app store's > > billing method in the payment request. > > - the TWA can handle pay intents. > > - the TWA can handle the app store billing method. > > > > Before: > > AndroidPaymentAppFinder could not include a TWA for an app store > > billing method. > > > > Change: > > * In AndroidPaymentAppFinder#findAndroidPaymentApps, check if the > > merchant page is a TWA installed from app store and if the > > PaymentRequest is requesting shipping or payer contact. If it is, > > add the TWA itself as a payment app if it's eligible. > > * remove mIgnoredMethods. > > > > Note: > > * Counterintuitively, the merchant page would send the pay intent to > > the TWA instead of the Play Store, because it would be the TWA who > > is responsible to interact with the app stores. > > > > Bug: 1064740 > > > > Change-Id: I0a2f6baebae422aaeab574e3c39a10cd61fafb4a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135152 > > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#757128} > > TBR=rouslan@chromium.org,maxlg@chromium.org > > Change-Id: I954a5d5589704b2c8ad13400fcb487eac00bc677 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1064740 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141209 > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757427} TBR=rouslan@chromium.org,pnoland@chromium.org,maxlg@chromium.org Change-Id: Id55022716d27a12c46d1cf4d0166d7bdb7a9ffcf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142334 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757456}
-
Sasha McIntosh authored
Skip promotion of quads to CALayer when the quad's visible rect is empty. As of crrev.com/c/2095494 we no longer remove fully occluded quads, but set the visible rect size to empty instead to improve performance. Fix CALayerOverlayRPDQTest.TooManyRenderPassDrawQuads to properly create the first DrawQuad. Test: CALayerOverlayTest.SkipNonVisible Bug: 1067513,1022544 Change-Id: Iec9b02ab2e5095cdd718845eea0dd4ca737bea43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134774 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#757455}
-
Peter Kotwicz authored
Move setting the initial screen orientation and delaying screen orientation requests to a new class: CustomTabOrientationController BUG=1068271 Change-Id: Ic5885bfb53befb7b197848c5e34e28db3da88bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133881 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757454}
-
Chris Mumford authored
Fixed capitalization typo (lowercase 'i'): UI>Browser>WebAppinstalls ==> UI>Browser>WebAppInstalls This may be the cause of https://github.com/GoogleChrome/chromium-dashboard/issues/800. Bug: None Change-Id: I21abca48d42b5d6f2c00643ab850a3411d778e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139434 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#757453}
-
Lei Zhang authored
IDS_WEBSHARE* got abandoned in https://crrev.com/636332 IDS_WEBAUTHN* got abandoned in https://crrev.com/654020 and https://crrev.com/695687. Change-Id: I4798b80a06e631dc66d081a8a9679653644e6cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140716Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#757452}
-
Xianzhu Wang authored
- Skip tests for pre-CompositeAfterPaint only - Modify compositing/overflow/ancestor-with-clip-path.html to avoid subpixel differences - Rebaseline compositing/overflow/textarea-scroll-touch.html. The diff looks ok. - Rebaseline 2 tests for the new focus ring style. Change-Id: I35ed8a6392c7fc9be7ce95c33885837ee4cf6310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138777Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757451}
-
Gauthier Ambard authored
This CL sets accessibilityViewIsModal to YES on the Browser view when it is shown from the TabGrid. This makes sure that the elements of the TabGrid aren't accessible with VoiceOver while the Browser is shown. Fixed: 1067255 Change-Id: Ie01927a6170fbe5d7b8f1180c08f1cc4459d8849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142271 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#757450}
-
Nnamdi Theodore Johnson-Kanu authored
https://chromium-review.googlesource.com/c/chromium/src/+/2128092 Changes the routes for search pages in settings. os_search_page has a route that was missed. This CL updates the route in os_search_page.html to match the new route, from /search to osSearch. Bug: 1068322 Change-Id: Ife497137528a8abf4511a67523ef6fea5a1e7b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141134Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#757449}
-
Brian Liu Xu authored
This changelist includes the following fixes for virtual views: - Ensures that virtual view accessible bounds are provided for |TreeView| nodes when requested. PopulateAccessibilityData() is responsible for providing the values, but it was being bypassed in GetBoundsRect() and HitTestSync(), which were accessing |custom_data_| instead of calling GetData(). - Converts the virtual view accessible bounds to device pixels by scaling it by the device scale factor. - Makes virtual view accessible bounds robust to changes in the owner view's bounds in screen. This can happen if the host window was moved or resized. Bug: 811277 Change-Id: Icb9379e635e8c09d299a9022f24714f32ffed150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129987Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Brian Liu Xu <brx@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757448}
-
Andrew Grieve authored
find_large_commits.py: * Fix python2->python3 bug with bytes vs str generate_milestone_reports.py: * Remove need to explicit staging directory * Remove obsolete flag Change-Id: I98b32f6f1351a95c4a9965c59a6a59dfb1d08b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139670 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757447}
-
Tim Schumann authored
It frequently times out on dbg builds. Change-Id: I0ddf03fe2deae0fa8fb7ce73bdc890ecedd20075 BUG: 1065331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124308Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#757446}
-
Geoff Lang authored
GpuVideoDecodeAccelerator already handles the texture manager returning null TextureRefs to support the passthrough command decoder. Now that we skip allocating the TextureManager entirely, also protect against it being null. BUG=1059068 Change-Id: I2d1d2a3fbf8166002379724ab97eca5082621374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140674Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#757445}
-
Sahel Sharify authored
This cl moves creating Address from a bundle to a utility function in Address.java since it will be used on changeShippingAddress call in addition to parsing payment response. Change-Id: Ic5b345969d5dae347558ce3f5ebabcf3b0c8dd53 Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139363 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757444}
-
Chris Sharp authored
TBR=sergeyu@chromium.org Bug: 1067727 Change-Id: Idb58bede22b5369cef77889b728a7e780012236a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141594Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#757443}
-
Matthew Webb authored
Change-Id: Id0c2c1e6c5c6ff3f57cb5e546c4f47f7dd125e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133119Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#757442}
-
John Abd-El-Malek authored
The BroadcastReceiver needs to be public, which regressed in r757061. Bug: 1025603 Change-Id: I683936cd4f11af80188d7e7109c55a68af06d800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141222 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#757441}
-
Hans Wennborg authored
Bug: 1068477, 1068974 Change-Id: I358512b0ecad77c26139ed2874560386bf331fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141984Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#757440}
-
Bruce Long authored
This is a reland of 1527cb7a [Fixed Win7 unit test with early return] Original change's description: > Spellcheck: Apply policy for languages that lack Hunspell support > > Spellcheck languages that have Windows platform support but not > Hunspell support (Arabic, Finnish, ...) cannot be disabled or forced > enabled by enterprise policy. This is because of the use of > spellcheck::GetCorrespondingSpellCheckLanguage in > SpellcheckLanguageBlacklistPolicyHandler::SortBlacklistedLanguages and > SpellcheckLanguagePolicyHandler::SortForcedLanguages, a method that > only recognizes Hunspell languages. > > The fix is to instead check if a language with policy being enforced is > on the list of supported accept languages, as these are what are used > to populate the language list on the language settings page. Note that > in the upcoming implementation of support for non-Hunspell languages, > we will only allow Windows platform spellchecking for these accept > languages (if they have a Windows spellcheck dictionary). > > Instead of just searching for the accept language within the tag, the > algorithm first tries for an exact match (so "en-CA" would be found), > then searches for an exact match for the language without locale > info, that is, what's to the left of the hyphen in a language tag > (so "ar" would be found for "ar-SA"). > > Also adds unit test coverage for the spellcheck policy handlers, which > previously had none. > > Note that there is an interplay between forced and blocked languages, > as well as the spellcheck-enabled policy: > > 1) If a language is both forced and blocked, forced wins. > 2) If spellcheck is disabled by policy, the forced/blocked languages > policy has no effect. > > Test cases cover this interplay. > > Bug: 1056850 > Change-Id: Iec54a851d38f00a7aa7597449f7acc30f3dd2de3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080450 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Bruce Long <brlong@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#757107} Bug: 1056850 Change-Id: Iab52315db7c9a8c15d87cf416bc583359de528bd Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140186Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757439}
-
Ramin Halavati authored
Adds two shorthand functions to create, get, or check existence of primary OffTheRecord profile. Bug: 1033903, 1060940 Change-Id: Ic9ff38ea0f9961088a6d34a94ef2f7eaa2bcd9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130351Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#757438}
-