- 21 Aug, 2020 40 commits
-
-
Nate Chapin authored
This case is specific to when window.open() is used, then the opener write()s into the newly opened document and adds a <meta refresh> tag with the refresh url set to the opener's url. When document.write() is called from another document, the targeted document's url is updated to the caller's url. Therefore, the act of writing the <meta> into the newly opened window causes the opener and the opened window to have the same url. Because the <meta refresh>'s url matches the current one, it is flagged as a reload, rather than as a redirect to a new url. However, the browser process has not seen a commit in the newly opened window, so it gets confused and refuses to update the url for a reload when a reload shouldn't be possible. This CL detects that case and ensures that it is treated as a non-reload navigation, which ensures the state sent to the browser process is coherent. Bug: 1112815 Test: http/tests/history/document-write-meta-refresh-in-opened-window.html Change-Id: Ie665bdf40435728bf6bd4fae5ed8ffda99014800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359377 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#800614}
-
Eugene But authored
Swap product name and version calls as expected in function signature Bug: 1103752 Change-Id: I9e21b8c57c6134aee6d66c0e9685146876ee7c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368242 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#800613}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: Ic6d5d5d2ccebbaf2e8ef3bd72a89f9cf50b88add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368440Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#800612}
-
Sami Kyostila authored
(Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2332664) Chrome and WebView have supported basic Android ATrace tracing, but the current approach has some shortcomings: 1) Android R changes the way atrace session activations are broadcast, breaking the code in WebView listening for activations (OnTraceEnabledChangeListener). This means you can't trace a running WebView app with atrace. 2) Neither Chrome nor WebView record early startup events to atrace, which means all events before the native library has loaded are lost. 3) It's not possible to specify trace categories via atrace, which means we need more cumbersome alternative solutions (i.e., command line flags) for startup tracing. 4) Writing ATrace events is only supported in WebView. This patch reworks the ATrace integration to resolve these problems and to align the Chrome and WebView implementations. In short, ATrace session management is moved to the common (TraceEvent) layer, and Chrome and WebView only differ by which trace tags they listen to (APP vs. WEBVIEW). We also add a way to declare trace categories through per-app tags: $ atrace -a org.chromium.chrome,org.chromium.chrome/<category_filter> (Note that the plain package name without any category filters must always appear in the list on its own.) Multiple categories can be separated with a double colon: $ atrace -a org.chromium.chrome,org.chromium.chrome/cat1:cat2 Or by specifying the the app several times to get around the 91 character limit for each entry: $ atrace -a org.chromium.chrome,\ org.chromium.chrome/cat1,\ org.chromium.chrome/cat2 Finally, to capture Java startup events into a tracing session controlled by the system's Perfetto service instead of atrace, a special "-atrace" category can be used to only write events into Chrome's own tracing service instead of atrace. This way when we connect to Perfetto later in the startup sequence and establish the real tracing session, startup-related events can be flushed into that session without emitting duplicate events into ATrace. TEST=atrace -a org.chromium.chrome TEST=atrace webview TEST=atrace -a org.chromium.chrome TEST=atrace webview TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-*:cc TEST=atrace -a com.google.android.gm,com.google.android.gm/-*:cc webview TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-atrace Bug: 1095587, b/160768681 Change-Id: Ifc1488cc1a045bb79a804f13596935234fc7a163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364635 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#800611}
-
Fred Mello authored
The Clank team is reviewing the ownership of all `/android` directories and updating OWNERS as part of an effort to normalize code health metrics across different data sources. https://docs.google.com/document/d/1aP5GMLwcKkdshT9YLS1dkeGAfNSNoLzdUfWvvt0qVLU Bug: 1112872 Change-Id: I58cfb139d7692f67b80694c65946bb4537380e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368502 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#800610}
-
Leonard Grey authored
This is responsible for: - Mediating between the controller and WebUI layers. - Managing the widget the WebUI interface lives in. - Holding the web view the WebUI interface lives in. This is necessary because creating a renderer on demand caused unacceptable latency in the commander prototype. Reviewer note: Please note that there are 5 separate paths to close - Dismissed by controller via ViewModel - Dismissed by browser via Hide - Dismissed by WebUI via OnDismiss - Window closed (possibly from parent window closing) - Object destroyed I'm pretty sure they're all safe, but this part definitely needs a second pair of eyes. Bug: 1014639 Change-Id: I422754923a0be3ce3e2b7b6a500add76f7e5ecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364225Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#800609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c153394161f0..85132f3cbf67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nektar@google.com,fhorschig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nektar@google.com,fhorschig@google.com Change-Id: Ie9e441b50b375dcaccc8ac010c553f693f34c382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369161Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800608}
-
Richard Knoll authored
Opening and closing files needs to happen on a MayBlock runner. This CL introduces a NearbyFileHandler that does this. Bug: 1085067 Change-Id: I5c45f629d7fe9f6142d877f401c06fdf327eb3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367932 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#800607}
-
yilkal authored
This cl ensures that the EDUCoexistence login ui is shown when the request for login comes from ARC++. Bug: 1118198 Change-Id: I04632fbf9d83ca2a9710f2fe5e014b2e16e9a865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364973 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#800606}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/44e1791f100c..66d1f73e2c9d 2020-08-21 capn@google.com Perform independent blend state optimization If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia31a537cf76db91e756ef2f278d38fbcf96fe0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800605}
-
ckitagawa authored
The |service_| weak pointer in PaintPreviewCompositorClientImpl appears to be getting invalidated on a wrong thread in some in the wild crash reports. This CL moves the deleter of PaintPreviewCompositorClient and PaintPreviewCompositorService to always run on the default task runner this should ensure the WeakPtr is invalidated on the right thread. Bug: 1120313 Change-Id: I35f766c58c72537f96022131029008d2a0f6c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368462Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#800604}
-
Kevin Ellis authored
svg-x-interpolation.html was periodically flaking in debug builds due to timeouts. This patch marks the test as a long testin alignment with WPT guidelines. Bug: 1085564 Change-Id: Iffd627361de90f7301a37516a7002a5976fa77ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368015Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#800603}
-
Michael Thiessen authored
Introduce CriteriaHelper#pollUiThreadNested This change adds an assertion that pollUiThread is not called from the UI thread, which is equivalent to calling sleep(), and won't actually run any UI thread tasks. In the few cases where polling the UI Thread from the UI thread is necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests the looper in order to continue running UI tasks. The reland introduces pollUiThreadForJUnit because some junit tests legitimately do need to sleep the UI thread to wait for events on other threads. Bug: 1115220 Change-Id: I09654521c0dab74f45a15b56b7876b4ee1871dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364085Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7161209ef6f1..ee4fc2e01505 2020-08-21 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-21 khmel@google.com arc: Add option to pin version for caches. 2020-08-21 ahassani@chromium.org auto_updater_transfer_unittest.py: Make class reference uniform 2020-08-21 ahassani@chromium.org auto_updater_transfer_unittest.py: Move class instantiator into its own class 2020-08-21 ahassani@chromium.org auto_updater_transfer_unittest.py: Rename class specific variables 2020-08-21 dburger@chromium.org Manually perform config-update from build_config.ToT.json 2020-08-20 vapier@chromium.org upload_prebuilts: rename dev-only-extras.tbz2 2020-08-20 bpastene@chromium.org cros_chrome_sdk: Use the passed in board when setting up the env. 2020-08-20 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-20 vyshu@google.com auto_updater: change mode to scp for all LocalTransfer usecases If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I1b4a0284797a0260323d368e878ee32cd5c92f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369165Reviewed-by:
-
Yann Dago authored
Bug: 1109322 Change-Id: I73d3143fdf37e84a953da464b561f15c4ee11827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368427 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800600}
-
Devon O'Brien authored
Add Let's Encrypt Oak 2023 and TrustAsia Logs 2020, 2021, 2022, 2023 to the list of Qualified CT Logs. Bug: 963693, 1073395 Change-Id: I5896aeecc56542594e16dcc2a1ce1bceb1b4af99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368144Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Cr-Commit-Position: refs/heads/master@{#800599}
-
Ken MacKay authored
Merge-With: eureka-internal/439192 Bug: internal b/162442148 Change-Id: I48246585ffde00158b1aa9ee7a6c403b6668259f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363447Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#800598}
-
Nicolas Ouellet-Payeur authored
Previously, the NewTabPageLocation policy is lower-priority than extensions' "chrome_url_overrides" setting. This is backwards, so this patch fixes the issue. TESTED=Installed Tabby Cat extension and set NewTabPageLocation policy. Manually opened a bunch of tabs before the patch (Tabby Cat) and after the patch (NewTabPageLocation) Bug: 1020590 Change-Id: Ic3dbe9b9e0ed7efb318c85c489ba7f1faefbbb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367976Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#800597}
-
James Long authored
This change adds a bit of clarification via comments on the various mechanisms of graph_view.js, plus a useful link at the beginning as a primer to D3. Bug: 1119942 Change-Id: I4e69ca8626d11d81ea41e0f7a516449866508711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367743 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#800596}
-
Mugdha Lakhani authored
Add a toggle to the WebLayer shell app to switch between dark and light mode overrides. This will help test dark mode override. At application launch, neither override is applied and the app follows system setting for dark mode. Bug: 1103716 Change-Id: Id11c40d4962396fcc641d0dc700008d96c57b725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367097Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#800595}
-
kdillon authored
This queue class name is not accurate to the way that it is currently used and it can be merged with QueueClass::kNone. This class encompasses all of the 'kFrame' QueueTypes that are non-loading (kFrameThrottleable, kFramePausabale, kFrameDeferrable, etc.). Removing this QueueClass will prevent confusion when differentiating between queues with this class and JavaScriptTimer queues. Change-Id: I847eb5d1635eb2932a0399369e982f7a709ece0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341394Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#800594}
-
Russ Hamilton authored
This is a reland of d35f5dac with the addition of ensuring initialization of one of the SurfaceTracker fields in its constructor. The original change was reverted in d35cd337 due to breakage of build Linux ChromiumOS MSan Tests since https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20302 Original change's description: > Modify Privacy Budget UKM Entry Filter to measure identifiable surfaces. > > Add a "SurfaceTracker" to IdentifiabilityStudyState to keep track of > surfaces that have been previously reported for each source. This is > used for deduplication and to limit the number of metrics sent in each > UKM report. > > Bug: 1112787 > Change-Id: I00eb2360849ea6772fbfdcc9b1cf91680f8c6173 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363398 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Commit-Queue: Russ Hamilton <behamilton@google.com> > Cr-Commit-Position: refs/heads/master@{#800332} Bug: 1112787 Change-Id: Iae86f07cb148ff17d449eb9ebf49b8c431391413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368461Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#800593}
-
Zhaoliang Ma authored
This CL set multi-threads encoding based on the image resolution and number of cores for vpx encoding, also enable parallel Tile encoding based on the threads number and row level multi-threading for vp9 encoding. Bug: 1116771 Change-Id: I750ef54c20b79349cefb347aef2522cf128f212c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354642 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#800592}
-
Wenyu Fu authored
Change the FRE UI to better adapt to the transition from loading to ToS. Layout preview: go/clank-fre-ui-preview This CL also changes the visibility of UMA / ToS component to View.GONE when they are hidden. This will free up the space so that the screen will not be scrollable on blank content. Bug: 1108558, 1117352 Change-Id: I3f8616bd5810da71afa8b6e40dea2db92e89013e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352033 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#800591}
-
James Long authored
This change resolves the TODO(yjlong) artifacts scattered around the codebase. Bug: 1119942 Change-Id: I678317d11d8c7b60356d4dabf12d6b9d71055571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367647Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e1e240804211..6a4e145832a9 2020-08-21 egdaniel@google.com Make some public vulkan structs use default initialization. 2020-08-21 fmalita@chromium.org [canvaskit] Fix for OffscreenCanvas-unaware browsers 2020-08-21 jmbetancourt@google.com add SurfaceView support for skottie on android 2020-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5dff6075d29f to d3e800e9ad66 (7 revisions) 2020-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cbfd396756c6 to 44e1791f100c (1 revision) 2020-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e45f0c4d to d3d82066 (463 revisions) 2020-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from eff9ef0f2212 to e8dc820fbc1e (6 revisions) 2020-08-20 johnstiles@google.com Fix thread-unsafe writes to function declarations in the symbol table. 2020-08-20 ethannicholas@google.com Reland "SkSL now supports uniform array types" 2020-08-20 hcm@google.com add M86 branch release notes 2020-08-20 fmalita@chromium.org [skottie] Custom prop manager updates 2020-08-20 jlavrova@google.com Fixing incorrect boundaries calculations + 3 ways of drawing a paragraph 2020-08-20 ethannicholas@google.com replaced SkSL nodeCount with visitor 2020-08-20 nifong@google.com Add origin visualization, add support for Concat44 2020-08-20 ethannicholas@google.com Reland "SkSL CPP and H backends no longer emitted in non-dev builds" 2020-08-20 johnstiles@google.com Migrate additional casts to as<T>. 2020-08-20 kjlubick@google.com Remove webgl from public.bzl 2020-08-20 csmartdalton@google.com Add new tests to trickycubicstrokes 2020-08-20 johnstiles@google.com Remove sk_TextureSamplers from SkSL. 2020-08-20 bungeman@google.com Notify when SkFontMetrics bounds are bogus. 2020-08-20 kjlubick@google.com [canvaskit] Remove getproc when creating WebGL interface 2020-08-20 kjlubick@google.com [canvaskit] Remove fringe EGL dependency. 2020-08-20 kjlubick@google.com [canvaskit,pathkit] Update to emsdk 2.0 2020-08-20 nikolay.igotti@jetbrains.com Search ICU data on Windows relative to the current module. 2020-08-20 johnstiles@google.com Add as<ProgramElementSubclass> to downcast ProgramElements more safely. 2020-08-20 ethannicholas@google.com Reland "Added support for the 'inline' hint on SkSL functions" 2020-08-20 hcm@google.com Update Skia milestone to 87 2020-08-20 reed@google.com Can we remove this flag to picture-recording? If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Test: Test: Test: FramebufferTest_ES31.*Blit*Test: Test: VulkanPerformanceCounterTest_ES31.MultisampleResolveWithBlit Change-Id: Id8bd9f76e8d9b09206e3bca8de8f7f18f979d502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369163Reviewed-by:
-
Daniel Hosseinian authored
Because the sidenav is an "extension" of the toolbar, it too should be disabled when the toolbar is. Use the "hidden" attribute in lieu of the "closed" attribute to avoid a collapsing animation when the viewer starts up. Fixed: 1119950 Change-Id: I51a38f51303ac269509c8f5713b27e1fdd49f4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368160 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#800588}
-
Kyle Horimoto authored
BrowserTabsModel contains metadata about the two most-recently-used browser tabs on the user's phone. This class is now integrated with the high-level PhoneModel class. There is still no code to set the fields within this new model; this will come in a future CL. Bug: 1106937 Change-Id: I972aed6c69de33dc733cf52686d660e9465030cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368075 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800587}
-
Tommy Steimel authored
This CL adds a new KaleidoscopeMetricsRecorder that uses information from the KaleidoscopeUI and KaleidoscopeDataProviderImpl to record which step the user stopped the FRE on. Bug: b:154517281 Change-Id: I129d9cc38a7fe3ca709c0e73c81399c1e2ec4acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365314Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#800586}
-
Thomas Lukaszewicz authored
This CL updates the TabSearchBubbleView and the TabSearchButton such that there can only be a single instance of the Tab Search UI shown at any given time. This CL also changes the TabSearchButton such that it enters the active state immediately on bubble creation so that the bubble's status is communicated to the user while it loads in asynchronously. This behavior mimics that in the IconLabelBubbleView. Bug: 1099917 Change-Id: Ifb5602e55750fd6dd4b834c4dc42835ca08d0f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354509 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#800585}
-
Greg Thompson authored
https://crrev.com/798844 attempted to send up a signal regarding whether or not the fallback temp directory was used. Unfortunately, Omaha does not include the ExtraCode1 value for successful installs. It does, however, send up success HRESULTS in the InstallerError value. This CL, therefore, switches to that. The two values to look out for are 0x00044001 and 0x00044002 (two success HRESULTS in FACILITY_ITF that otherwise appear to be unused). BUG=516207,1100280 Change-Id: I319c5dbe7162543a71465238c5320719225fa1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368353 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800584}
-
Henrique Nakashima authored
e.output only includes stdout. Some errors are shown in stdout and others in stderr, so print both. Bug: 1111056 Change-Id: Ie83c070c726f62771eb6fc0750b60568f5dc0a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366663 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#800583}
-
Alex Turner authored
When the script is about to execute, we check whether it was added by ad script. If it was, we tag that script as an ad. In order to track these scripts, which have no URL, we assign them a fake url based on their script id. Bug: 1098530 Change-Id: Id7a3571a47fb9235379b68a3f041a18952aafa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316326 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800582}
-
Alex Turner authored
This digest will be used to understand how identifying locally installed fonts are. To reduce unnecessary computation, we cache the results on the FontGlobalContext and skip computing the hash when an identical font lookup is already saved. Original CL by mmenke@chromium.org Bug: 1081268 Change-Id: If18c04dc8f818a9052066484dc59717a2480d2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341357Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL batches confirm sync data machine tests. Bug: 1120258 Change-Id: I7c85b3997fb2a2754aac030ce210ef19682ab09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367718 Auto-Submit: Alice Wang <aliceywang@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#800580}
-
nancylingwang authored
With multiple monitors, when launch an app unpin on the shelf, and drag the icon for the launched app, the icon is ripped off from the shelf on all monitors, because the icon opacity is set as 0.0f (transparent): https://source.chromium.org/chromium/chromium/src/+/master:ash/shelf/shelf_view.cc;l=2155 However, when release the button to restore the icon back to the Shelf, only the icon on 1 monitor pulled by the mouse is recovered because the opacity for the icon is restored to 1.0, not transparent by the drag view: drag_view_->layer()->SetOpacity(1.0f); Well other icons on other monitors are not recovered. So modify the drag rip off handling to recover other icons on other monitors when release the mouse for the drag icon. BUG=1119698 Change-Id: I49439a7c02c18b0875c53772bd0081a016ab720d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367261 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Jarryd authored
Bug: 1117159 Change-Id: I8d8088cb7ca703d579754d880faf2926e483236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363258Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800578}
-
Elly Fong-Jones authored
This change: 1) Introduces WidgetDelegate::SetModalType, by analogy with the existing GetModalType() virtual; 2) Removes many overrides of GetModalType() within Views itself, which allows removing several subclasses of WidgetDelegate that existed solely to override this method; 3) Moves DialogDelegate's constructor to public, since it is now useful standalone (i.e. without subclassing it). Bug: 1075649 Change-Id: I90dd7e1d61e9fb5726b4f148ce5c054b207bbbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363262Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#800577}
-
Guido Urdaneta authored
Also define constants for releases M86-M88. Bug: 1120343 Change-Id: If1eec3093b352928f80c744cb57525b364f1fe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369094Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#800576}
-
Side Yilmaz authored
This CL adds getImageFetcher function back to prevent crash causing not profile set before getVisuals function is called. Regular profile is used to create image fetcher when mImageFetcher is null. This is safe since anytime switching to incognito will cause setProfile function is called and image fetcher will be created with incognito profile. Bug: 1119688 Change-Id: I826bde1a36a22ccf59243d0bab194c2ddf0659a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366760 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#800575}
-
