- 04 Oct, 2016 40 commits
-
-
mcasas authored
BUG=651897 Review-Url: https://codereview.chromium.org/2386153004 Cr-Commit-Position: refs/heads/master@{#422685}
-
michaelpg authored
Recalculate overscroll when shrinking the page, so we don't end up with a scrollbar for the empty space below us. BUG=none R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2382603002 Cr-Commit-Position: refs/heads/master@{#422684}
-
kmarshall authored
Add HeliumResult-to-string mapping for easier logging. Add unit tests for string conversion functions. R=lethalantidote@chromium.org,gcasto@chromium.org BUG= Review-Url: https://codereview.chromium.org/2385913002 Cr-Commit-Position: refs/heads/master@{#422683}
-
bugsnash authored
Review-Url: https://codereview.chromium.org/2378103006 Cr-Commit-Position: refs/heads/master@{#422682}
-
dcheng authored
It's important to check this return value to make sure that deserialization actually succeeded. BUG=652129 Review-Url: https://codereview.chromium.org/2392713002 Cr-Commit-Position: refs/heads/master@{#422681}
-
chrishtr authored
Otherwise we'll end up with error that gets larger according to the percentage. Note that subpixel accumulation is already plumbed through for transforms in other ways. BUG=627588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2386263002 Cr-Commit-Position: refs/heads/master@{#422680}
-
khushalsagar authored
This sets up the framework for a LayerTreeHostRemote that implements the LayerTreeHost API when the compositor is running across a network boundary. This change only sets the framework for running/scheduling main frame updates and pushing the serialized state using the CompositorProtoStateSink. Subsequent patches will add state serialization. BUG=648442,652502 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225 Review-Url: https://codereview.chromium.org/2362073002 Cr-Original-Commit-Position: refs/heads/master@{#422555} Cr-Commit-Position: refs/heads/master@{#422679}
-
haraken authored
I've reviewed a lot of patches that need changes to public/ mostly in the context of Onion Soup. Also I hope this will be helpful to increase active reviewers in APAC time who can review trivial changes to public/. BUG= NOTRY=true Review-Url: https://codereview.chromium.org/2389663002 Cr-Commit-Position: refs/heads/master@{#422678}
-
zpeng authored
BUG=638614 Review-Url: https://codereview.chromium.org/2363183002 Cr-Commit-Position: refs/heads/master@{#422677}
-
jamescook authored
The goal is to stop having to maintain separate SystemTrayDelegateMus and SystemTrayDelegateChromeos implementations and eliminate the indirection introduced by SystemTrayCommon. * Always create the SystemTrayClient object in chrome, whether running ash in-process or not * Always allow code in //ash to bind to mojom::SystemTrayClient, even when ash runs in-process * Introduce WmShell::IsRunningInMash so ash can tell which mode its in * Handle connecting to "exe:chrome" vs. "exe:content_browser" based on the process mode * Introduces SystemTrayController in ash, which wraps mojom::SystemTrayClient * Peel two methods off the SystemTrayDelegate interface and changes them to call into SystemTrayController and route over mojo * Remove mojo usage from SystemTrayDelegateMus. Eventually it should go away completely. To keep this CL small it breaks a few system tray features when running under mash (e.g. opening the general settings). This will get fixed in the next CL. TODO: Remove SystemTrayCommon and move its functionality into SystemTrayClient TODO: For methods like SystemTrayDelegate::ShowSettings, migrate callers to use ash::SystemTrayController and always route over mojo. BUG=647412 TEST=manual, clicking on system tray date opens date settings, changing time from 12 to 24 hour works, in both classic ash and mash Review-Url: https://codereview.chromium.org/2381753002 Cr-Commit-Position: refs/heads/master@{#422676}
-
sadrul authored
Only RenderThreadImpl does anything with the gpu memory buffer manager. So move it out of ChildThreadImpl into RenderThreadImpl. This also ensures that if mus is used, then ChildGpuMemoryBufferManager is not created and accidentally used. This fixes a crash in extensions using the tab-capture api when running with --use-mus-in-renderer. BUG=643746 Review-Url: https://codereview.chromium.org/2386913002 Cr-Commit-Position: refs/heads/master@{#422675}
-
dgozman authored
This separates passive "listen to all targets" behavior from "auto-attach to related targets" required by DevTools frontend. BUG=648775 Review-Url: https://codereview.chromium.org/2391823002 Cr-Commit-Position: refs/heads/master@{#422674}
-
rockot authored
This is required for hyphenation on Android. BUG=652453 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2390093002 Cr-Commit-Position: refs/heads/master@{#422673}
-
xidachen authored
Currently in Blink, there is no indication whether a compositor is GPU accelerated or software. This CL plumbs it to Blink, so that we can query whether --disable-gpu-compositing or --disable-gpu is set or not. BUG=650795 Review-Url: https://codereview.chromium.org/2377883002 Cr-Commit-Position: refs/heads/master@{#422672}
-
sergeyu authored
Previously ChromotingClient was responsible for creation of AudioDecodeScheduler. Moved that logic to IceConnectionToHost because WebrtcConnectionToHost will not need it. Also moved AudioDecodeScheduler from remoting/client to remoting/protocol and simplified it. BUG=638505 Review-Url: https://codereview.chromium.org/2384063004 Cr-Commit-Position: refs/heads/master@{#422671}
-
michaelpg authored
The --data-path switch, if passed, specifies what directory to use as the browsing context's data directory. This CL checks that the directory actually exists/can be created, and converts relative paths to absolute. Note: This code is executed twice in content_shell (for normal and OTR contexts); in the long run, giving the shell its own PathProvider may be a better solution. Review-Url: https://codereview.chromium.org/2344073003 Cr-Commit-Position: refs/heads/master@{#422670}
-
rob.buis authored
Make cols/rows/span not accept zero when set from idl, but do similar to what happens when setting the attribute, i.e. set the default values instead [1]. BUG=490511 [1] https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-cols https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-rows https://html.spec.whatwg.org/multipage/tables.html#dom-colgroup-span Review-Url: https://codereview.chromium.org/2387033003 Cr-Commit-Position: refs/heads/master@{#422669}
-
zea authored
The session commit delay is always overridden in production. As such, the default only affects test, where it makes it much more likely to time out. Remove it and re-enable the disabled sessions integration tests. BUG=263369, 232313 Review-Url: https://codereview.chromium.org/2389443003 Cr-Commit-Position: refs/heads/master@{#422668}
-
xiaochengh authored
BUG=651373 Review-Url: https://codereview.chromium.org/2386073003 Cr-Commit-Position: refs/heads/master@{#422667}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2363045762a7..800795e7ff6b $ git log 236304576..800795e7f --date=short --no-merges --format='%ad %ae %s' 2016-10-03 jreck Support POSIX-style ps command 2016-10-03 benjhayden Display weird numbers in a table in breakdown-span. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2392803002 Cr-Commit-Position: refs/heads/master@{#422666}
-
estade authored
- discard pre-MD colors - consolidate color logic that didn't change from pre-MD to MD - remove some colors that either aren't used, or are only used in one place, or otherwise don't make sense to be part of NativeTheme BUG=648281 Review-Url: https://codereview.chromium.org/2382443007 Cr-Commit-Position: refs/heads/master@{#422665}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2387113002 Cr-Commit-Position: refs/heads/master@{#422664}
-
lushnikov authored
This patch introduces uncompressed Trie implementation. Trie comes handy to quickly answer questions of type "give me all words with given prefix". Text editor autocomplete benefits immediately from the trie index. The automapping algorithm prototype also relies heavily on the trie to quickly query file paths. The performance and memory analysis of the implementation: https://goo.gl/UdgS4H BUG=none R=dgozman, pfeldman Review-Url: https://codereview.chromium.org/2385093002 Cr-Commit-Position: refs/heads/master@{#422663}
-
twellington authored
If you move quickly enough, it's possible to select an item that was just deleted then choose to delete it again. Add some null checks to prevent a crash. BUG=652176 Review-Url: https://codereview.chromium.org/2387003003 Cr-Commit-Position: refs/heads/master@{#422662}
-
zpeng authored
Review-Url: https://codereview.chromium.org/2384533004 Cr-Commit-Position: refs/heads/master@{#422661}
-
ltian authored
When changeing language setting of phones, Template Url Service will be changed and unloaded. Then when search engine setting page back to active from background, it fires a NoPointerException for popluating the Listview when Template Url Service is still loading. To fix that, check whether Template Url Service is already loaded before populating UI, if not, force it to load and meanwhile, close the fragment to prevent from crash. BUG=652170 Review-Url: https://codereview.chromium.org/2391753002 Cr-Commit-Position: refs/heads/master@{#422660}
-
hubbe authored
Libyuv has a more optimized version of the half-float conversion code now, and it will probably become more optimized in the future. BUG=445071 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2389003002 Cr-Commit-Position: refs/heads/master@{#422659}
-
lgarron authored
BUG= Review-Url: https://codereview.chromium.org/2385613002 Cr-Commit-Position: refs/heads/master@{#422658}
-
zmo authored
Note that this path isn't accessable through WebGL2, but still a security threat that now we address in this CL. BUG=429053 TEST=gpu_unittests R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2383333002 Cr-Commit-Position: refs/heads/master@{#422657}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c1db96f..ca6b6b16 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2388333002 Cr-Commit-Position: refs/heads/master@{#422656}
-
sebmarchand authored
Review-Url: https://codereview.chromium.org/2365893002 Cr-Commit-Position: refs/heads/master@{#422655}
-
yuweih authored
This CL fixes some compiler warnings about using deprecated APIs. Review-Url: https://codereview.chromium.org/2391633003 Cr-Commit-Position: refs/heads/master@{#422654}
-
dbeam authored
R=tsergeant@chromium.org BUG=647028 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2386533002 Cr-Commit-Position: refs/heads/master@{#422653}
-
sky authored
The window manager should be doing it. To do otherwise means mus is likely conflicting with the wm. Additionally changing the activation as we were meant clients weren't getting notified and got out of sync with mus. BUG=652421 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2391853002 Cr-Commit-Position: refs/heads/master@{#422652}
-
erosky authored
When spoken-feedback is enabled, shell_surface's shadow_underlay will fill the screen for active android windows. When in this mode, the underlay will consume all events and play an earcon to indicate that the event was located outside the android window. BUG=649524 TEST=unit-test and tested on device Review-Url: https://codereview.chromium.org/2361993003 Cr-Commit-Position: refs/heads/master@{#422651}
-
dsinclair authored
The performance timing spec has been clarified[1] to make getEntriesByType case sensitive. This CL updates Blink to this new requirement. [1] https://github.com/w3c/performance-timeline/issues/57 BUG=651507 Review-Url: https://codereview.chromium.org/2390733003 Cr-Commit-Position: refs/heads/master@{#422650}
-
stip authored
This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier. BUG=623989 Review-Url: https://codereview.chromium.org/2364233003 Cr-Commit-Position: refs/heads/master@{#422649}
-
guidou authored
This CL has no behavior changes. BUG=563793 Review-Url: https://codereview.chromium.org/2386213002 Cr-Commit-Position: refs/heads/master@{#422648}
-
klausw authored
On WebVR pages loaded over insecure transport, show a small "Not secure" warning overlay permanently, and a transient more verbose warning for a short time on first entering the page. It uses the information from bajones's "Expose secure origin state to WebVR renderer" implementation. The message strings were previously added to chrome/app/generated_resources.grd in https://codereview.chromium.org/2368443002/ BUG=389343,644492 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2363553003 Cr-Commit-Position: refs/heads/master@{#422647}
-
bashi authored
It wouldn't make much sense to have 'V8' prefix since V8 specific conversions are encapsulated in the generated code. BUG=569301 Review-Url: https://codereview.chromium.org/2383613003 Cr-Commit-Position: refs/heads/master@{#422646}
-