- 16 Feb, 2018 40 commits
-
-
Giovanni Ortuño Urquidi authored
Changes BookmarkAppNavigationThrottle to retrieve the disposition and open the app if the disposition is CURRENT_TAB, FOREGROUND_TAB, or NEW_WINDOW. This means that navigations started with Ctrl + Click will no longer result in an app window being opened. Bug: 756675 Change-Id: I4975c967554f1c380edeb2a49ed1c47dbc324afa Reviewed-on: https://chromium-review.googlesource.com/907773Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#537241}
-
Christopher Cameron authored
Make BrowserCompositorViewMac be the source of ScreenInfo, and merge the update for screen properties with the resize update as BrowserCompositorViewMac::UpdateNSViewAndDisplay. Merge all RenderWidgetHostViewMac paths that update size or screen info into RenderWidgetHostViewMac::UpdateNSViewAndDisplayProperties, which communicates the changes (if any) to RenderWidgetHostImpl. Change-Id: Idc7f654c93d0622815825fdb6fff46afcb38767e Reviewed-on: https://chromium-review.googlesource.com/918284 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#537240}
-
Wez authored
The action rules had |depfile| set, but did not actually create a file, resulting in the steps being re-run even in no-op builds. Bug: 812352 Change-Id: Ia1aa862b2ec96cb5a0304339c861f564bc77b34a Reviewed-on: https://chromium-review.googlesource.com/920794 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537239}
-
Toni Barzic authored
Adds "enabled_on_launch" optional property to "secondary_kiosk_apps" items manifest type. When set, the property controls whether the associated extension should be enabled before kiosk app launches (i.e. before onLaunched event is sent to the kiosk app): * when set to true, the associated secondary extension will be enabled on kiosk app launch - provided that the extension is not disabled due to a reason different than user action. E.g. if the extension is disabled due to a policy, the extension will remain disabled, but DISABLED_USER_ACTION will be removed from its disable reasons. * if set to false, the associated secondary extension will be disabled on kiosk app launch; DISABLED_USER_ACTION will be added to the extension's disable reasons. If the property is not set, the secondary extension's enabled state will not be changed as part of kiosk session startup. BUG=800441 Change-Id: I0b44d1c05846d811d7840cbce65246c0dd7ea885 Reviewed-on: https://chromium-review.googlesource.com/868398 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537238}
-
Yoshifumi Inoue authored
This patch introduces |FlatTreeTraversal::AncestorsOf()| as |NodeTraversal|. This patch is a preparation of the patch[1]. Note: The patch[2] introduces |FlatTreeTraversal::InclusiveAncestorsOf()|. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection [2] http://crrev.com/c/742770 Introduce FlatTreeTraversal::InclusiveAncestorsOf Bug: 778507 Change-Id: I5f76f00c06a4e02b5981600049af11853fa2f60b Reviewed-on: https://chromium-review.googlesource.com/923443Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537237}
-
https://pdfium.googlesource.com/pdfium.git/+log/2388506a1ba1..067a44fcad91 $ git log 2388506a1..067a44fca --date=short --no-merges --format='%ad %ae %s' 2018-02-16 hnakashima Fix fallthroughs in XFA code. 2018-02-16 dsinclair Improve performance of writing path floats. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I92b9eeac8b32895ae7bd69c93cce72bf5366efb3 Reviewed-on: https://chromium-review.googlesource.com/923704 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537236}
-
Hikaru Nishida authored
Before this patch, default values of members in WebSelectionBound are specified in constructor initialization list. To improve maintainability, this patch adds default values to each member definitions. This patch also adds default constructor of WebSelectionBound to improve readability of the patch crrev.com/c/908169 . TEST: No change in behavior. Change-Id: I54c7910aba6ce9fe1dd4c881c7b944da52cf5ec0 Reviewed-on: https://chromium-review.googlesource.com/920048 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#537235}
-
Yoichi Osato authored
LocalCaretRectTest returns null LayoutRect for "after" node such as kAfterAnchor, kAfterChildren, kOffsetInAnchor and offset==length. This patch adds such cases. I'll fix it in later patch. Bug: 812535 Change-Id: I6349360ab6b7ff41870e05f154471436653917dc Reviewed-on: https://chromium-review.googlesource.com/920127Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#537234}
-
Yoshifumi Inoue authored
This patch changes |DeleteSelectionCommand::HandleGeneralDelete()| to use the clean layout tree for calling |start_node->GetLayoutObject()| after calling |DeleteTextFromNode()| or |RemoveChildrenInRange()| to avoid removing |start_node|. Note: When |Text| node with ::first-letter is modified, Blink detach layout object from it in |Text::UpdateTextLayoutObject()| to follow |ShouldUpdateLayoutByReattaching()| which returns true for |true| for |Text| node with ::first-letter. Bug: 808516 Change-Id: I7139398ca3938e56960c81c9196bd58e91bed668 Reviewed-on: https://chromium-review.googlesource.com/920051 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit fefcfdfc. Reason for revert: WinMSVC64(dbg) bot error: https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/2965 c:\b\c\b\win\src\content\browser\webauth\authenticator_impl.cc(393) : error C2220: warning treated as error - no 'object' file generated c:\b\c\b\win\src\content\browser\webauth\authenticator_impl.cc(393) : warning C4702: unreachable code Original change's description: > [webauthn] Don't terminate operations early that return NotAllowedError. > > NotAllowedError responses should not be returned until after the > timer has expired in order to prevent a leak of possibly-identifying > user information. > > See https://w3c.github.io/webauthn/#createCredential step 21. > > Bug: 809104 > Change-Id: I3655f4c9cac29dc29c68c234c2e0b8ea00f1c5c2 > Reviewed-on: https://chromium-review.googlesource.com/912149 > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537229} TBR=engedy@chromium.org,kpaulhamus@chromium.org Change-Id: I022d8586c26a9201c5d80a025b2a954cca3fe5d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809104 Reviewed-on: https://chromium-review.googlesource.com/923223Reviewed-by:
-
Takeshi Yoshino authored
This reverts commit 12325b07. Reason for revert: Broke linux-chromeos-dbg build. See my comment for the details Original change's description: > NetworkConfig: Escape names before passing to i18n() > > i18n() asserts if any unsafe tags are passed to it. We need to > HTMLEscape any network names passed to i18n(). > > Bug: 811562 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I3112dc2f38b0560d1d6ad9fdde91581f1c498a45 > Reviewed-on: https://chromium-review.googlesource.com/920903 > Reviewed-by: Toni Barzic <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537108} TBR=stevenjb@chromium.org,tbarzic@chromium.org Change-Id: I15e8ea3b7ea7eb4bc45ff9262d0c0176fda4c481 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811562 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/923222Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#537231}
-
Takayoshi Kochi authored
This is a step for removing ElementShadow. This CL is a clean up and does not change any behavior. Bug: 624724 Change-Id: Icd8f0ab1076e803b48c9bfdd01252e24489d02a4 Reviewed-on: https://chromium-review.googlesource.com/923242Reviewed-by:
-
Kim Paulhamus authored
NotAllowedError responses should not be returned until after the timer has expired in order to prevent a leak of possibly-identifying user information. See https://w3c.github.io/webauthn/#createCredential step 21. Bug: 809104 Change-Id: I3655f4c9cac29dc29c68c234c2e0b8ea00f1c5c2 Reviewed-on: https://chromium-review.googlesource.com/912149 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#537229}
-
Takeshi Yoshino authored
This reverts commit c67e0638. Reason for revert: Broke unit_tests on Linux CFI bot. See my comment for details Original change's description: > Load resources from extension bundles in the network service. > > Bug: 782025 > Change-Id: I144d650ff86af288a22afbc4173c94de46da4faf > Reviewed-on: https://chromium-review.googlesource.com/834749 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537165} TBR=nick@chromium.org,jam@chromium.org,rockot@chromium.org,rdevlin.cronin@chromium.org,cmumford@chromium.org Change-Id: I57b1630225b9be7020c83d09aa782ec31d67b985 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782025 Reviewed-on: https://chromium-review.googlesource.com/923761Reviewed-by:
-
Lei Zhang authored
Using non-public headers will result in "gn check" failures. Change-Id: Ia5df6f57cb8ae083acf98e259e07dee6e09d387c Reviewed-on: https://chromium-review.googlesource.com/915040Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#537227}
-
Stefan Zager authored
LocalFrameView::UpdateGeometries is called from PerformPostLayoutTasks, and then UpdateGeometriesIfNeeded is called after layout in UpdateStyleAndLayoutIfNeededRecursiveInternal. If the first call doesn't clear the needs_update_geometries_ flag, then the second call will do unnecessary work. BUG=811457 R=chrishtr@chromium.org Change-Id: Idc8e11c444d8b02cd9d54c2fd158bbdd59bd5de4 Reviewed-on: https://chromium-review.googlesource.com/923119Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#537226}
-
Shakti Sahu authored
DownloadManager today has some minimal support to upload a byte array. We are extending it to upload blobs in this CL. The client will embed the blob data inside the post body (ResourceRequestBody) of the DownloadUrlParameters which will be subsequently passed to the URLRequest/ResourceRequest. Bug: 812327 Change-Id: Ia230961294d3bdbcf6284fde0e078c5844a991bf Reviewed-on: https://chromium-review.googlesource.com/919622Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537225}
-
Sergey Volk authored
https://chromium.googlesource.com/chromiumos/platform/minigbm/+log/27a7e6a2..7f79cb53 The minigbm library hasn't been rolled for a while, the last commit is from ~Aug 2017. We'd like to use some new features that were introduced since then. This will roll it to the tip of the master branch. Bug: none Change-Id: I30357dd50e9ac2b735bd35ad97da16ec076a41f7 Reviewed-on: https://chromium-review.googlesource.com/923301 Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#537224}
-
Steve Kobes authored
This fixes selection drag images with RLS. We need absolute (FrameView content) coordinates instead of document coordinates, to get the correct painting_rect in DragController::DragImageForSelection. Bug: 811224 Change-Id: Id6a9f98e60396cfad2904fb5adbe8aaee27f7edf Reviewed-on: https://chromium-review.googlesource.com/919981Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b55c62b2..c0a22f5a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie384364e801af4c67cfcc7fddd942c6eec8ff6cf Reviewed-on: https://chromium-review.googlesource.com/922502Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537222}
-
Peter Collingbourne authored
Avoid using "cmd /c" on non-Windows platforms. This fixes the Windows cross build in a couple of cases. Change-Id: I4da82e50abbc392dbd90afe34befacc9bce9a593 Reviewed-on: https://chromium-review.googlesource.com/920762Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#537221}
-
Kenneth Russell authored
TBR=jbudorick@chromium.org, machenbach@chromium.org, ynovikov@chromium.org Bug: 792780 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I423a0a2fcedf8d9caa86d53f0c6ad13147574a99 Reviewed-on: https://chromium-review.googlesource.com/923563 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537220}
-
Siddhartha authored
BUG=791205 Change-Id: I13e256c1876d6c0ce7e3dc3044bce716666d01e5 Reviewed-on: https://chromium-review.googlesource.com/922889Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#537219}
-
Steve Kobes authored
Bug: 711468 Change-Id: I036ac47727885a4ea57367e384e9fc388b5a7bf5 Reviewed-on: https://chromium-review.googlesource.com/917422 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537218}
-
Yuta Kitamura authored
WebTaskRunner is gone, and "Web" prefix does not make sense anymore. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I88fc46250b6c178886827967240c142bc67a4b83 Reviewed-on: https://chromium-review.googlesource.com/920126Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#537217}
-
Eric Stevenson authored
Decoding crashes on Samsung Galaxy S5 devices running L (potentially due bugs in the system libs). Bug: 807059 Change-Id: Iab24378247c3f8c460d54a6515d75f0e1396999c Reviewed-on: https://chromium-review.googlesource.com/919319 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#537216}
-
chrome://policyGanesh Borle authored
Bug: 804322 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie114ad5c38fbef3cd32b3f830eaa663596041c9d Reviewed-on: https://chromium-review.googlesource.com/908668Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#537215}
-
Ganesh Borle authored
Bug: 561800 Change-Id: I1d92457335d4ee13b7289ce3601160083702e367 Reviewed-on: https://chromium-review.googlesource.com/919021 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537214}
-
edchin authored
This CL creates a simple grid view controller. It also adds an entry in showcase. Partly to avoid name collision, we name the single grid as a GridViewController. The parent tab switcher with multiple panels and other controls is called the TabGridViewController. Bug: 804496 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib5b06befc35408958b8613a776f2c93742137bc7 Reviewed-on: https://chromium-review.googlesource.com/920641 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537213}
-
Mike Wasserman authored
Add plumbing to check if a content setting bubble is showing. Use that to test for bubble presence, not GetAllWidgets. See http://crrev.com/c/922268 for GetAllWidgets changes. Bug: 811940 Change-Id: I5b8e36c5dcddb8dfd407ad0f889ad74fb9804273 Reviewed-on: https://chromium-review.googlesource.com/919922Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#537212}
-
Peter Kasting authored
This upgrades --interactive to a test-launcher-scope switch (necessarily renaming it to --test-launcher-interactive) and treats it as a timeout specifier. For browser UI tests on Windows, this means the parent process will now get an (effectively) unlimited timeout and not just the child process, so the test won't terminate early. BUG=none TEST=none Change-Id: Ic94c5bff322846c2b7f69cad4b805f549dbcaa29 Reviewed-on: https://chromium-review.googlesource.com/919074 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#537211}
-
Dave Tapuska authored
Approved Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/MAHQkH4vvUQ/i0yCobrMCQAJ BUG=244688 Change-Id: I76f996b728bac093033f6e12d239cb3819616a91 Reviewed-on: https://chromium-review.googlesource.com/919201 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537210}
-
Danyao Wang authored
With LegacyNavigationManager, Tab calls |requirePageReconstruction| to free the WKWebView so that it'll be recreated with the user agent of the newest navigation item. This approach doesn't work for WKBasedNavigationManager because deleting the WKWebView would require reconstruction of history. Luckily with iOS9+, WKWebView.customUserAgent can be updated on an existing WKWebView and will cause the new header to be sent to the server. This CL uses this mechanism to update the UA before loading a request based on the current NavigationItem. This alone only reloads the visible page with the new UA under WKBasedNavigationManager because there is no URL change. So to create a back/forward entry, the URL is reloaded using restore_session.html with a client-side redirect. This CL fixes RequestDesktopMobileSiteTestCase for new nav manager. Bug: 798836 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f23232b10a7c83db16f545cd29445a514eaa57c Reviewed-on: https://chromium-review.googlesource.com/919175 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#537209}
-
Yuta Kitamura authored
WebTaskRunner has became SingleThreadTaskRunner. So, the class name WebTaskRunnerImpl does not make sense anymore. Bug: 794845 Change-Id: Ibdb105e889febe98a1b10f96b2f4547657f3f79d Reviewed-on: https://chromium-review.googlesource.com/920724Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 3782 3785 3787 3788 3795 3798 3 lines were removed and 9 lines were deflaked by consecutive results since 3731. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5983d8b830015170ad8c4ee5d90be8eac0079b96 Reviewed-on: https://chromium-review.googlesource.com/920050 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#537207}
-
Darren Shen authored
Currently StylePropertyMap.set doesn't actually work with calcs. The current way to check if something is, say, a <length> is to check its CSSStyleValue::Type. However, this doesn't return the right value for CSSMathValues, whose types may be quite complicated. The correct way is to use the CSSNumericValue matching algorthms: CSSNumericValue::MatchesLength, which also takes into account CSSMathValues and percent hints. This patch changes the following to make this work: - Removed base types from CSSStyleValue::StyleValueType. A base type like "length" is not really a CSSStyleValue type. - Removed unused StyleValueTypeToString. - Changed "Percent" to "Percentage" in CSSProperties.json5 as that's the correct term. - Changed make_cssom_types to use the matching algorithms from CSSNumericValue. Bug: 545318 Change-Id: I16aa71a4873e9992749f0f52ba641671d109170e Reviewed-on: https://chromium-review.googlesource.com/901002 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537206}
-
John Chen authored
This reverts commit 425707a6. Reason for revert: ChromeDriver build bot lacks permission to read gs://chrome-signed/ bucket. Original change's description: > [ChromeDriver] Automatic update Android app on waterfall > > On the ChromeDriver Android build bot on the waterfall, automatically > update the Chrome app when necessary. > > Change-Id: I1af1bb8835c1fea63493b5f76a98923067744f13 > Reviewed-on: https://chromium-review.googlesource.com/907334 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535152} TBR=johnchen@chromium.org,kereliuk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia2e5ff249bedb54d5356feb898c0c64495040ea1 Reviewed-on: https://chromium-review.googlesource.com/922325 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537205}
-
Dominic Mazzoni authored
Based on initial user feedback, move the user profile name to the end, and don't ever include it if there's only one profile. Bug: 783479, 784676 Change-Id: I03cb9a16f5d8fd98a72afe5a4e009ef350ea3092 Reviewed-on: https://chromium-review.googlesource.com/922915 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#537204}
-
Nicolas Pena authored
This CL is the first step in merging the Performance and WorkerPerformance idls. The following are the full set of steps: 1. Rename Performance.h to WindowPerformance.h. 2. Rename PerformanceBase.h to Performance.h. 3. Merge Performance.idl and WorkerPerformance.idl. The following is roughly how it would look like after all steps are completed: https://chromium-review.googlesource.com/c/chromium/src/+/919983 Bug: 707392 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib99ade431badca0fad9bf61dbd580f3549cbab91 Reviewed-on: https://chromium-review.googlesource.com/922927Reviewed-by:
-
Takeshi Yoshino authored
Bug: 812960 Change-Id: I1bb1f5db9bdc5ceb7ca73ee52ac7edc0ad5545f9 Tbr: rsleevi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/923502 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#537202}
-
