GitLab

When connecting to a port on localhost which is not yet open, connect fails and udp_socket crashes when trying to send packets. This fixes that.

Review URL: https://codereview.chromium.org/967723002

Cr-Commit-Position: refs/heads/master@{#330442}

1) Select the correct preference name for synced data type.
2) Set the correct field name when converting Wallet specifics to
   dictionary.

BUG=481595

Review URL: https://codereview.chromium.org/1147753002

Cr-Commit-Position: refs/heads/master@{#330441}

According to comment in base/port.h, in Chromium, we force-define
__STDC_CONSTANT_MACROS, so we can just use the regular (U)INTn_C macros from
<stdint.h>.

BUG=138542
TEST=base_unittests
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/1128203010

Cr-Commit-Position: refs/heads/master@{#330440}

BUG=487391

Review URL: https://codereview.chromium.org/1136273003

Cr-Commit-Position: refs/heads/master@{#330439}

There is no functionality behind this flag yet.

I kept the name "force-saving", since this name of the feature is quite established now, although I wonder whether saying "manually save" wouldn't be more understandable in the description.

BUG=484891

Review URL: https://codereview.chromium.org/1140043003

Cr-Commit-Position: refs/heads/master@{#330438}

chrome.printerProvider API's going to stable, so this is not needed
anymore.

BUG=439448, 488661

Review URL: https://codereview.chromium.org/1130933005

Cr-Commit-Position: refs/heads/master@{#330437}

Review URL: https://codereview.chromium.org/1134383002

Cr-Commit-Position: refs/heads/master@{#330436}

Revert of Remove a HistoryNode's children when it navigates to a new document. (patchset #1 id:1 of https://codereview.chromium.org/1139033002/)

Reason for revert:
Caused a large spike in crashes across several bugs:
https://crbug.com/426658
https://crbug.com/488382
https://crbug.com/488421
https://crbug.com/488434
https://crbug.com/488470

Original issue's description:
> Remove a HistoryNode's children when it navigates to a new document.
>
> When a reload occurs (or other inert commits), we leave the history tree alone. However, if iframes are dynamically created, we end up with both the old iframes and the new iframes in the history tree, and we never prune them. Instead, if a different-document inert commit occurs, remove the committing node's children, since the corresponding frames are no longer in the frame tree.
>
> BUG=485385
>
> Committed: https://crrev.com/9f3e29c910ce2c2a9c3a60b2675db59d95b8ad3a
> Cr-Commit-Position: refs/heads/master@{#329763}

TBR=japhet@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485385

Review URL: https://codereview.chromium.org/1148473002

Cr-Commit-Position: refs/heads/master@{#330435}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d804fe3..3b8b14a

TBR=kbr@chromium.org,yhirano@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/1147733003

Cr-Commit-Position: refs/heads/master@{#330434}

The Chromium Linux Mojo bot's app_tests step started failing here:
  http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/7090
Related to https://codereview.chromium.org/1130353008/

The mojo:view_manager_apptests all crash after passing with:
  [0518/132408:FATAL:x11_event_source.cc(80)] Check failed: display_.

These tests are run headless and shouldn't need an event source.

BUG=NONE
TEST=Bot goes green.
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1125423005

Cr-Commit-Position: refs/heads/master@{#330433}

The oilpan plugin requires trunk clang on Windows, but the asan lkgr bot
uses a pinned, slightly older clang and it times out when using head clang.
Disable the plugin on asan until we have resolved this.

BUG=489123,489123
R=hans@chromium.org, rnk@chromium.org

Review URL: https://codereview.chromium.org/1142733003

Cr-Commit-Position: refs/heads/master@{#330432}

Layout tests generate results in the webkit/ folder which was recently
removed from the chromium tree.

BUG=488288

Review URL: https://codereview.chromium.org/1137683004

Cr-Commit-Position: refs/heads/master@{#330431}

JS messaging to native code for UIWebView is accomplished by adding
and removing an iframe to the window. Some pages interact badly with
this mechanism, including iforgot.apple.com. To circumvent this for
such pages, the functionality in message_dynamic.sendQueue is wrapped
in a function and invoked from window.requestAnimationFrame to delay
message sending.

BUG=470595

Review URL: https://codereview.chromium.org/1132163007

Cr-Commit-Position: refs/heads/master@{#330430}

BUG=488495

R=brucedawson
TBR=jam

Review URL: https://codereview.chromium.org/1147533005

Cr-Commit-Position: refs/heads/master@{#330429}

BUG=485381
TEST=manual
R=jlklein@google.com

Review URL: https://codereview.chromium.org/1137873006

Cr-Commit-Position: refs/heads/master@{#330428}

4 raster threads improve performance on 8 core machines.
8 core machines might not be a priority but it seems
like an unnecessary limitation to have.

BUG=

Review URL: https://codereview.chromium.org/1143473002

Cr-Commit-Position: refs/heads/master@{#330427}

Browser-based widgets that overlay content have a shot at consuming
touch events, e.g., selection handles. Such touches are reported as
consumed to the View chain, however, embedding apps still have the
opportunity to intercept those touch sequences. This can lead to
double-handling, e.g., when dragging a selection handle left or
right and triggering a View side swipe.

Prevent this by calling requestDisallowInterceptTouchEvent() for
touches that are consumed by such browser-based widgets. Note that we
cannot call this method for all touch events as touch dispatch is often
asynchronous and the disposition of the touch handling result cannot
be immediately known when the touch is received from the Android
platform.

BUG=489337

Review URL: https://codereview.chromium.org/1140693004

Cr-Commit-Position: refs/heads/master@{#330426}

Some fraction of successful connections use the fallback, but only due to
a spurious network failure. To estimate this fraction, compare handshakes
to Google servers which succeed against those that fail with an
inappropriate_fallback alert. Google servers are known to implement
FALLBACK_SCSV, so a spurious network failure while connecting would
trigger the fallback, successfully connect, but fail with this alert.

BUG=459690

Review URL: https://codereview.chromium.org/1147453003

Cr-Commit-Position: refs/heads/master@{#330425}

BUG=none

Review URL: https://codereview.chromium.org/1124053009

Cr-Commit-Position: refs/heads/master@{#330424}

There are two possible race conditions in walking the heaps returned
by GetProcessHeaps and on Windows XP we hit one of these race conditions,
manifested in a crash, on 42 of the last 200 base unittests. Disabling
the test entirely until a better fix is found (or perhaps forever).

The unreliability of the underlying code is acceptable for tracing,
although perhaps not acceptable for tracing on XP given the failure rate.

TBR=sebmarchand@chromium.org,primiano@chromium.org
BUG=487291

Review URL: https://codereview.chromium.org/1140943006

Cr-Commit-Position: refs/heads/master@{#330423}

Broken by https://codereview.chromium.org/1015333002

BUG=489160

Review URL: https://codereview.chromium.org/1123263006

Cr-Commit-Position: refs/heads/master@{#330422}

BUG=323304

Review URL: https://codereview.chromium.org/1140523005

Cr-Commit-Position: refs/heads/master@{#330421}

WriteNode::SetTitle copies title into bookmark specifics title for
bookmark entries. When title for newly created bookmark is empty
WriteNode::SetTitle exits early and doesn't update
BookmarkSpecifics.title.

This change ensures that title is updated.

BUG=486407
R=zea@chromium.org
TEST=
- Import bookmarks file attached in the bug. There should be 2 bookmarks with empty titles.
- Create new client for the same account and make sure that both bookmarks get synced.

Review URL: https://codereview.chromium.org/1134793006

Cr-Commit-Position: refs/heads/master@{#330420}

BUG=487016

Review URL: https://codereview.chromium.org/1127133009

Cr-Commit-Position: refs/heads/master@{#330419}

This patch removes declarative_user_script_manager accessor from ExtensionSystem.
DeclarativeUserScriptManager is now a browser context keyed service.

Review URL: https://codereview.chromium.org/1132113008

Cr-Commit-Position: refs/heads/master@{#330418}

Per review comment on https://codereview.chromium.org/1127623005/, sparse
histograms are preferred.

BUG=none

Review URL: https://codereview.chromium.org/1140273002

Cr-Commit-Position: refs/heads/master@{#330417}

BUG=487866

Review URL: https://codereview.chromium.org/1141983002

Cr-Commit-Position: refs/heads/master@{#330416}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9b77796..404b3b2

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1130663007

Cr-Commit-Position: refs/heads/master@{#330415}

The Linux sandbox performance implications that made using
recvmsg()/sendmsg() slower than read()/write() have not applied for a
long time, since we switched from seccomp (v1) to seccomp-bpf.

Review URL: https://codereview.chromium.org/1139703005

Cr-Commit-Position: refs/heads/master@{#330414}

You can now delete things by long pressing suggestions in the dropdown (assuming it's the right kind of suggestion).

BUG=486153

Review URL: https://codereview.chromium.org/1134793004

Cr-Commit-Position: refs/heads/master@{#330413}

Custom menu items where used for WebUI NTP and is no longer used.
This CL removes support for such menus.

BUG=None

Review URL: https://codereview.chromium.org/1142863002

Cr-Commit-Position: refs/heads/master@{#330412}

This patch removes install_verifier accessor from ExtensionSystem.
It can be its own browser context keyed service.
It can be built by its new factory.

Review URL: https://codereview.chromium.org/1127133006

Cr-Commit-Position: refs/heads/master@{#330411}

If one of the core services apps called terminate, the thread won't be valid.

This is split off https://codereview.chromium.org/1139673003

BUG=484234

Review URL: https://codereview.chromium.org/1145473005

Cr-Commit-Position: refs/heads/master@{#330410}

The YouCompleteMe configuration still needs to determine the list of
system include paths. The current chromium.ycm_extra_conf.py logic
requires that the host machine has a 'clang' binary in its PATH that can
yield this information.

This change calculates the system include paths based on the clang++
binary used to compile the target file. It allows the use of wrappers
(E.g. goma), by looking for a clang++ command in the first and second
tokens in the compile command. It's still not perfect since the Clang
library used by ycmd might be different, but it should work better than
the current logic.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1137303005

Cr-Commit-Position: refs/heads/master@{#330409}

Currently each ContentViewCore creates a KitkatCaptioningBridge on K+ devices.
And all of them listens to the system CaptioningManager.
So whenever the system captioning changes, all ContentViewCores will have to handle it separately.
This change simplifies that process by making KitkatCaptioningBridge a singleton.
All ContentViewCores become listeners to that singleton.
Whenever system captioning changes, a single CaptioningChangeDelegate class will handle the change.
It will then inform all ContentViewCores that are alive.
If all ContentViewCores are GC'ed, KitkatCaptioningBridge will stop listen to system CaptioningManager.

BUG=457850

Review URL: https://codereview.chromium.org/1132053005

Cr-Commit-Position: refs/heads/master@{#330408}

BUG=323304

Review URL: https://codereview.chromium.org/1122383005

Cr-Commit-Position: refs/heads/master@{#330407}

Add flag '/deferredrun' to recovery executable for elevated install of recovery component so we can distinguish from first install.

Also changed version arg format from --version to /version.

BUG=

Review URL: https://codereview.chromium.org/1136943004

Cr-Commit-Position: refs/heads/master@{#330406}

BUG=

Review URL: https://codereview.chromium.org/1132133008

Cr-Commit-Position: refs/heads/master@{#330405}

'unsafety' must be 'unsafely', apparently.

BUG=441605

Review URL: https://codereview.chromium.org/1124173007

Cr-Commit-Position: refs/heads/master@{#330404}

BUG=479533
TBR=dtseng

Review URL: https://codereview.chromium.org/1094103006

Cr-Commit-Position: refs/heads/master@{#330403}