- 26 Jan, 2010 30 commits
-
-
cfleizach@apple.com authored
Add ability for image maps to be focused via tabbing https://bugs.webkit.org/show_bug.cgi?id=17513 * fast/events/tab-imagemap-expected.txt: * fast/events/tab-imagemap.html: git-svn-id: svn://svn.chromium.org/blink/trunk@53863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kenneth@webkit.org authored
own implementation and header file. Reviewed by Ariya Hidayat. * QtLauncher/main.cpp: (main): * QtLauncher/urlloader.cpp: Added. (UrlLoader::UrlLoader): (UrlLoader::loadNext): (UrlLoader::init): (UrlLoader::getUrl): * QtLauncher/urlloader.h: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53862 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin@chromium.org authored
Reviewed by Brady Eidson. Chains of history items representing same-document navigation need to always remember that association https://bugs.webkit.org/show_bug.cgi?id=33224 Replace HistoryItem's Document pointer with a DocumentSequenceNumber. During session history traversal, if the current HistoryItem and the target HistoryItem have the same DocumentSequenceNumber, then it means that the current Document should remain. NOTE: To support Chromium's serialization of HistoryItems, I generate DocumentSequenceNumbers that are unique across application launches. DocumentSequenceNumbers are generated using a counter initialized with the time of day. Test: fast/loader/stateobjects/document-destroyed-navigate-back.html * dom/Document.cpp: (WebCore::Document::detach): * dom/Document.h: * history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem): * history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem): * history/HistoryItem.cpp: (WebCore::generateDocumentSequenceNumber): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject): * history/HistoryItem.h: (WebCore::HistoryItem::setDocumentSequenceNumber): (WebCore::HistoryItem::documentSequenceNumber): * loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem): * loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState): * loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation): * page/History.cpp: (WebCore::History::stateObjectAdded): * page/Page.cpp: (WebCore::Page::goToItem): git-svn-id: svn://svn.chromium.org/blink/trunk@53861 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Geoffrey Garen. Using JavaScriptCore API with a webkit vended context can result in slow script dialog https://bugs.webkit.org/show_bug.cgi?id=34172 Make the APIShim correctly increment and decrement the timeout entry counter. * API/APIShims.h: (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): (JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock): (JSC::APICallbackShim::APICallbackShim): (JSC::APICallbackShim::~APICallbackShim): git-svn-id: svn://svn.chromium.org/blink/trunk@53860 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cfleizach@apple.com authored
Add ability for image maps to be focused via tabbing https://bugs.webkit.org/show_bug.cgi?id=17513 * fast/events/tab-imagemap-expected.txt: * fast/events/tab-imagemap.html: git-svn-id: svn://svn.chromium.org/blink/trunk@53859 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cfleizach@apple.com authored
Attempt to make this test pass on GTK. Add ability for image maps to be focused via tabbing https://bugs.webkit.org/show_bug.cgi?id=17513 * fast/events/tab-imagemap.html: git-svn-id: svn://svn.chromium.org/blink/trunk@53858 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=17513 Reviewed by Darin Adler. WebCore: Test: fast/events/tab-imagemap.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::focusedImageMapUIElement): (WebCore::AXObjectCache::focusedUIElementForPage): * accessibility/AXObjectCache.h: * accessibility/AccessibilityImageMapLink.h: (WebCore::AccessibilityImageMapLink::areaElement): (WebCore::AccessibilityImageMapLink::mapElement): (WebCore::AccessibilityImageMapLink::isImageMapLink): * accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isImageMapLink): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap): * html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::getPath): (WebCore::HTMLAreaElement::getRect): (WebCore::HTMLAreaElement::imageElement): (WebCore::HTMLAreaElement::isKeyboardFocusable): (WebCore::HTMLAreaElement::isFocusable): (WebCore::HTMLAreaElement::dispatchBlurEvent): (WebCore::HTMLAreaElement::updateFocusAppearance): (WebCore::HTMLAreaElement::supportsFocus): * html/HTMLAreaElement.h: * html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::imageElement): * html/HTMLMapElement.h: * platform/graphics/GraphicsContext.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing): * platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::drawFocusRing): * platform/graphics/mac/GraphicsContextMac.mm: (WebCore::drawFocusRingToContext): (WebCore::GraphicsContext::drawFocusRing): * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawFocusRing): * platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing): * platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawFocusRing): * platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::drawFocusRing): * rendering/RenderImage.cpp: (WebCore::RenderImage::paint): (WebCore::RenderImage::paintFocusRings): (WebCore::RenderImage::imageMap): * rendering/RenderImage.h: * rendering/RenderReplaced.h: LayoutTests: * fast/events/resources/tabindex-focus-blur-all.js: (test): (testProgrammaticFocus): * fast/events/tab-imagemap-expected.txt: Added. * fast/events/tab-imagemap.html: Added. * fast/events/tabindex-focus-blur-all-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@53857 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: add support for breakpoints, messages and search into the SourceFrame2. https://bugs.webkit.org/show_bug.cgi?id=34165 * inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.get executionLine): (WebInspector.SourceFrame2.prototype.set executionLine): (WebInspector.SourceFrame2.prototype.revealLine): (WebInspector.SourceFrame2.prototype.addBreakpoint): (WebInspector.SourceFrame2.prototype.removeBreakpoint): (WebInspector.SourceFrame2.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame2.prototype.setContent): (WebInspector.SourceFrame2.prototype.findSearchMatches): (WebInspector.SourceFrame2.prototype.setSelection): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame2.prototype._addBreakpointToSource): (WebInspector.SourceFrame2.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame2.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame2.prototype._contextMenu): (WebInspector.SourceFrame2.prototype._toggleBreakpoint): (WebInspector.SourceFrame2.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame2.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame2.prototype._editBreakpointCondition): (WebInspector.SourceFrame2.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame2.prototype._createConditionElement): (WebInspector.SourceFrame2.prototype._keyDown): (WebInspector.SourceFrame2.prototype._evalSelectionInCallFrame): (WebInspector.SourceFrame2.prototype._breakpointChanged): (WebInspector.SourceFrame2.prototype.resize): (WebInspector.BreakpointLineNumberDecorator.prototype.decorate): (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint): (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown): (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu): (WebInspector.ExecutionLineDecorator.prototype.decorate): * inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.set mimeType): (WebInspector.TextEditor.prototype.set readOnly): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype.updateCanvasSize): (WebInspector.TextEditor.prototype.repaintAll): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._repaintOnScroll): (WebInspector.TextEditor.prototype._mouseDown): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._columnForOffset): (WebInspector.TextEditor.prototype._handleNavigationKey): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._replaceSelectionWith): (WebInspector.TextEditor.prototype.setCoalescingUpdate): (WebInspector.TextEditor.prototype._handleUndo): (WebInspector.TextEditor.prototype._handleRedo): (WebInspector.TextEditor.prototype._changeFont): * inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType): * inspector/front-end/inspector.css: * inspector/front-end/textEditor.css: git-svn-id: svn://svn.chromium.org/blink/trunk@53856 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hather. Web Inspector: add methods for getting resource content from within frontend. https://bugs.webkit.org/show_bug.cgi?id=34163 * inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getResourceContent): * inspector/InspectorBackend.h: * inspector/InspectorBackend.idl: * inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetResourceContent): * inspector/InspectorFrontend.h: * inspector/InspectorFrontendHost.cpp: * inspector/InspectorFrontendHost.h: * inspector/InspectorFrontendHost.idl: * inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.getResourceContent): * inspector/front-end/InspectorFrontendHostStub.js: git-svn-id: svn://svn.chromium.org/blink/trunk@53855 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
Variable length stack arrays are a gcc extension. Use QVarLengthArray as a more portable solution that still tries to allocate on the stack first. * qt/api/qscriptvalue_p.h: (QScriptValuePrivate::call): git-svn-id: svn://svn.chromium.org/blink/trunk@53854 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
Reviewed by Tor Arne Vestbø. The JIT support should be determined at compile-time via wtf/Platform.h * qt/api/QtScript.pro: git-svn-id: svn://svn.chromium.org/blink/trunk@53853 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Not reviewed: added null check into the timeline agent getter. * inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::retrieve): git-svn-id: svn://svn.chromium.org/blink/trunk@53852 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Show comboboxes on Maemo 5 https://bugs.webkit.org/show_bug.cgi?id=34088 Don't try to show the combobox by simulating a mouse event from QCursor::pos() to get the combobox position right. The position on Maemo 5 is independent from the mouse and there's no QCursor::pos(). * WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): git-svn-id: svn://svn.chromium.org/blink/trunk@53851 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Simon Hausmann. First steps of the QtScript API. Two new classes were created; QScriptEngine and QScriptValue. The first should encapsulate a javascript context and the second a script value. This API is still in development, so it isn't compiled by default. To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to build-webkit. https://bugs.webkit.org/show_bug.cgi?id=32565 * WebKit.pro: 2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> Reviewed by Simon Hausmann. First steps of the QtScript API. Two new classes were created; QScriptEngine and QScriptValue. The first should encapsulate a javascript context and the second a script value. This API is still in development, so it isn't compiled by default. To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to build-webkit. https://bugs.webkit.org/show_bug.cgi?id=32565 * qt/api/QtScript.pro: Added. * qt/api/qscriptconverter_p.h: Added. (QScriptConverter::toString): * qt/api/qscriptengine.cpp: Added. (QScriptEngine::QScriptEngine): (QScriptEngine::~QScriptEngine): (QScriptEngine::evaluate): (QScriptEngine::collectGarbage): * qt/api/qscriptengine.h: Added. * qt/api/qscriptengine_p.cpp: Added. (QScriptEnginePrivate::QScriptEnginePrivate): (QScriptEnginePrivate::~QScriptEnginePrivate): (QScriptEnginePrivate::evaluate): * qt/api/qscriptengine_p.h: Added. (QScriptEnginePrivate::get): (QScriptEnginePrivate::collectGarbage): (QScriptEnginePrivate::makeJSValue): (QScriptEnginePrivate::context): * qt/api/qscriptvalue.cpp: Added. (QScriptValue::QScriptValue): (QScriptValue::~QScriptValue): (QScriptValue::isValid): (QScriptValue::isBool): (QScriptValue::isBoolean): (QScriptValue::isNumber): (QScriptValue::isNull): (QScriptValue::isString): (QScriptValue::isUndefined): (QScriptValue::isError): (QScriptValue::isObject): (QScriptValue::isFunction): (QScriptValue::toString): (QScriptValue::toNumber): (QScriptValue::toBool): (QScriptValue::toBoolean): (QScriptValue::toInteger): (QScriptValue::toInt32): (QScriptValue::toUInt32): (QScriptValue::toUInt16): (QScriptValue::call): (QScriptValue::engine): (QScriptValue::operator=): (QScriptValue::equals): (QScriptValue::strictlyEquals): * qt/api/qscriptvalue.h: Added. (QScriptValue::): * qt/api/qscriptvalue_p.h: Added. (QScriptValuePrivate::): (QScriptValuePrivate::get): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isValid): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toInteger): (QScriptValuePrivate::toInt32): (QScriptValuePrivate::toUInt32): (QScriptValuePrivate::toUInt16): (QScriptValuePrivate::equals): (QScriptValuePrivate::strictlyEquals): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::call): (QScriptValuePrivate::engine): (QScriptValuePrivate::context): (QScriptValuePrivate::value): (QScriptValuePrivate::object): (QScriptValuePrivate::inherits): (QScriptValuePrivate::isJSBased): (QScriptValuePrivate::isNumberBased): (QScriptValuePrivate::isStringBased): * qt/api/qtscriptglobal.h: Added. * qt/tests/qscriptengine/qscriptengine.pro: Added. * qt/tests/qscriptengine/tst_qscriptengine.cpp: Added. (tst_QScriptEngine::tst_QScriptEngine): (tst_QScriptEngine::~tst_QScriptEngine): (tst_QScriptEngine::init): (tst_QScriptEngine::cleanup): (tst_QScriptEngine::collectGarbage): (tst_QScriptEngine::evaluate): * qt/tests/qscriptvalue/qscriptvalue.pro: Added. * qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Added. (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::init): (tst_QScriptValue::cleanup): (tst_QScriptValue::ctor): (tst_QScriptValue::toString_data): (tst_QScriptValue::toString): (tst_QScriptValue::copyConstructor_data): (tst_QScriptValue::copyConstructor): (tst_QScriptValue::assignOperator_data): (tst_QScriptValue::assignOperator): (tst_QScriptValue::dataSharing): (tst_QScriptValue::constructors_data): (tst_QScriptValue::constructors): (tst_QScriptValue::call): * qt/tests/tests.pri: Added. * qt/tests/tests.pro: Added. 2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> Reviewed by Simon Hausmann. First steps of the QtScript API. Two new classes were created; QScriptEngine and QScriptValue. The first should encapsulate a javascript context and the second a script value. This API is still in development, so it isn't compiled by default. To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to build-webkit. https://bugs.webkit.org/show_bug.cgi?id=32565 * docs/qtwebkit.qdocconf: git-svn-id: svn://svn.chromium.org/blink/trunk@53850 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Adam Barth. Moves JSC-specific classes from bridge/jni/JNIBridge to bridge/jni/jsc/JNIBridgeJSC https://bugs.webkit.org/show_bug.cgi?id=33958 This allows bridge/jni/JNIBridge to be used with both JSC and V8. A later change will add the V8 equivalent of these JSC-specific classes. No new tests, refactoring only. * Android.jscbindings.mk: Modified. Added JNIBridgeJSC.cpp * GNUmakefile.am: Modified. Added JNIBridgeJSC.h * WebCore.xcodeproj/project.pbxproj: Modified. Added JNIBridgeJSC.[cpp|h] * bridge/jni/JNIBridge.cpp: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.cpp (appendClassName): Modfied. Guard calls to JSLock (JavaMethod::signature): Modfied. Guard calls to JSLock * bridge/jni/JNIBridge.h: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.h * bridge/jni/jsc/JNIBridgeJSC.cpp: Copied from WebCore/bridge/jni/JNIBridge.cpp. * bridge/jni/jsc/JNIBridgeJSC.h: Copied from WebCore/bridge/jni/JNIBridge.h. * bridge/jni/jsc/JNIUtilityPrivate.cpp: Modified. Include JNIBridgeJSC.h * bridge/jni/jsc/JavaClassJSC.h: Modified. Include JNIBridgeJSC.h * bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Include JNIBridgeJSC.h git-svn-id: svn://svn.chromium.org/blink/trunk@53849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jocelyn.turcotte@nokia.com authored
[Qt] Fix Windows build when sqlite is not available. * WebCore.pri: * WebCore.pro: git-svn-id: svn://svn.chromium.org/blink/trunk@53848 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=30914 Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26 Reviewed by Simon Hausmann. Remove the manual test case in favor of an automated test case in WebKit/qt/tests/qwebpage. * manual-tests/qt/java-script-prompt.html: Removed. WebKit/qt: [Qt] JavaScript prompt is currently broken https://bugs.webkit.org/show_bug.cgi?id=30914 Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26 Reviewed by Simon Hausmann. In r52152 a patch was landed to convert a null QString to an empty WebCore::String in case the prompt was accepted but the default implementation returned the null QString. The patch tried to avoid assign to result twice and was not checking the QString if it is null but the default value. This lead to always returning an empty string on successful prompts. Fix it by checking the variable 'x' for isNull. The manual test case used didn't cover the case of non empty input, replace it with an automatic test case that should cover all cases. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptPrompt): Fix the bug. * tests/qwebpage/tst_qwebpage.cpp: Add automatic test case (JSPromptPage::JSPromptPage): (JSPromptPage::javaScriptPrompt): (tst_QWebPage::testJSPrompt): git-svn-id: svn://svn.chromium.org/blink/trunk@53847 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Implement HTML and CSS highlighters. https://bugs.webkit.org/show_bug.cgi?id=34144 * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/JavaScriptTokenizer.js: Removed. * inspector/front-end/JavaScriptTokenizer.re2js: Removed. * inspector/front-end/SourceCSSTokenizer.js: Added. (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype._stringToken): (WebInspector.SourceCSSTokenizer.prototype._isPropertyValue): (WebInspector.SourceCSSTokenizer.prototype.nextToken): * inspector/front-end/SourceCSSTokenizer.re2js: Added. * inspector/front-end/SourceHTMLTokenizer.js: Added. (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype.nextToken): * inspector/front-end/SourceHTMLTokenizer.re2js: Added. * inspector/front-end/SourceJavaScriptTokenizer.js: Added. (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken): * inspector/front-end/SourceJavaScriptTokenizer.re2js: Added. * inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.Tokenizer): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set line): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.get condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.hasCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.getLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.setLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype._charAt): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: git-svn-id: svn://svn.chromium.org/blink/trunk@53846 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=34157 Reviewed by Holger Freyther. WebCore: Pass the FragmentScriptingPermission correctly through to the DOM and disallow scripting elements in parseEndElement(), similar to the libxml tokenizer change in r53835. * dom/XMLTokenizerQt.cpp: (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLTokenizer::parseStartElement): (WebCore::XMLTokenizer::parseEndElement): LayoutTests: Add Qt specific result for this test that differs from the cross-platform result in only one character: In htmlcontent.html the href attribute value is http://www.cnn.com, which somehow becomes http://www.cnn.com/ in the cross platform result. With the Qt xml parser that attribute is somehow preserved and so our result does not have the trailing slash. * platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53845 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Shinichiro Hamaji. Convert textarea-rows-cols.html to dumpAsText() https://bugs.webkit.org/show_bug.cgi?id=34074 * fast/forms/script-tests/textarea-rows-cols.js: Added. * fast/forms/textarea-rows-cols-expected.txt: Added. * fast/forms/textarea-rows-cols.html: * platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Removed. * platform/mac/fast/forms/textarea-rows-cols-expected.png: Removed. * platform/mac/fast/forms/textarea-rows-cols-expected.txt: Removed. * platform/qt/fast/forms/textarea-rows-cols-expected.txt: Removed. * platform/win/fast/forms/textarea-rows-cols-expected.txt: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@53844 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Eric Seidel. Add missing declaration for the feMorphology SVG element. https://bugs.webkit.org/show_bug.cgi?id=34151 * bindings/v8/V8DOMWrapper.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@53843 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zoltan@webkit.org authored
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-26 [Qt] Build fix after API changes in r53835. No new tests needed. * dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::parseXMLDocumentFragment): git-svn-id: svn://svn.chromium.org/blink/trunk@53842 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cjerdonek@webkit.org authored
Reviewed by Shinichiro Hamaji. Refactored check-webkit-style by removing the file path parameter from the style error handler functions. https://bugs.webkit.org/show_bug.cgi?id=34031 * Scripts/webkitpy/style/checker.py: - Added _default_style_error_handler() to StyleChecker class. - Moved handle_style_error() to inside _default_style_error_handler(). * Scripts/webkitpy/style/checker_unittest.py: - Removed file path from calls to error handler. * Scripts/webkitpy/style/cpp_style.py: - Removed file path from calls to error handler. * Scripts/webkitpy/style/cpp_style_unittest.py: - Removed file path from calls to error handler. * Scripts/webkitpy/style/text_style.py: - Removed file path from calls to error handler. * Scripts/webkitpy/style/text_style_unittest.py: - Removed file path from calls to error handler. git-svn-id: svn://svn.chromium.org/blink/trunk@53841 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jorlow@chromium.org authored
Reviewed by Darin Adler. Make storage events match the spec. https://bugs.webkit.org/show_bug.cgi?id=30546 Update the storageEvent algorithm to match the change in WebCore. * src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent): 2010-01-22 Jeremy Orlow <jorlow@chromium.org> Reviewed by Darin Adler. Make storage events match the spec. https://bugs.webkit.org/show_bug.cgi?id=30546 This meat of the patch I just posted is very simple. It's just making events asynchronous, not posting them to the frame that generated them, passing a null for the key when issuing a clear storage event, and making the events non-cancelable/non-bubbleable...all of which are clearly stated in the spec. The asynchronous and not posting to the frame that generated them forced me to re-write all the layout tests that dealt with storage events. There's a lot of code there, but I tried to be fairly careful to ensure that test coverage did not shrink in any area. Tests: storage/domstorage/events/basic-body-attribute.html storage/domstorage/events/basic-setattribute.html storage/domstorage/events/basic.html storage/domstorage/events/case-sensitive.html storage/domstorage/events/documentURI.html * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::enqueueStorageEvent): (WebCore::Document::storageEventTimerFired): * dom/Document.h: * storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent): * storage/StorageEvent.idl: * storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch): 2010-01-22 Jeremy Orlow <jorlow@chromium.org> Reviewed by Darin Adler. Make storage events match the spec. https://bugs.webkit.org/show_bug.cgi?id=30546 This meat of the patch I just posted is very simple. It's just making events asynchronous, not posting them to the frame that generated them, passing a null for the key when issuing a clear storage event, and making the events non-cancelable/non-bubbleable...all of which are clearly stated in the spec. The asynchronous and not posting to the frame that generated them forced me to re-write all the layout tests that dealt with storage events. There's a lot of code there, but I tried to be fairly careful to ensure that test coverage did not shrink in any area. * storage/domstorage/complex-values-expected.txt: * storage/domstorage/documentURI-expected.txt: Removed. * storage/domstorage/documentURI.html: Removed. * storage/domstorage/events: Added. * storage/domstorage/events/basic-body-attribute-expected.txt: Added. * storage/domstorage/events/basic-body-attribute.html: Added. * storage/domstorage/events/basic-expected.txt: Added. * storage/domstorage/events/basic-setattribute-expected.txt: Added. * storage/domstorage/events/basic-setattribute.html: Added. * storage/domstorage/events/basic.html: Added. * storage/domstorage/events/case-sensitive-expected.txt: Added. * storage/domstorage/events/case-sensitive.html: Added. * storage/domstorage/events/documentURI-expected.txt: Added. * storage/domstorage/events/documentURI.html: Added. * storage/domstorage/events/resources: Added. * storage/domstorage/events/resources/body-event-handler.html: Added. * storage/domstorage/events/resources/eventTestHarness.js: Added. * storage/domstorage/events/resources/setattribute-event-handler.html: Added. * storage/domstorage/events/script-tests: Added. * storage/domstorage/events/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html. * storage/domstorage/events/script-tests/basic-body-attribute.js: Added. * storage/domstorage/events/script-tests/basic-setattribute.js: Added. * storage/domstorage/events/script-tests/basic.js: Added. * storage/domstorage/events/script-tests/case-sensitive.js: Added. * storage/domstorage/events/script-tests/documentURI.js: Added. * storage/domstorage/localstorage/iframe-events-expected.txt: Removed. * storage/domstorage/localstorage/iframe-events.html: Removed. * storage/domstorage/localstorage/index-get-and-set-expected.txt: * storage/domstorage/localstorage/index-get-and-set.html: * storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Removed. * storage/domstorage/localstorage/onstorage-attribute-markup.html: Removed. * storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Removed. * storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Removed. * storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Removed. * storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Removed. * storage/domstorage/localstorage/simple-events-expected.txt: Removed. * storage/domstorage/localstorage/simple-events.html: Removed. * storage/domstorage/script-tests/complex-values.js: * storage/domstorage/script-tests/documentURI.js: Removed. * storage/domstorage/sessionstorage/iframe-events-expected.txt: Removed. * storage/domstorage/sessionstorage/iframe-events.html: Removed. * storage/domstorage/sessionstorage/index-get-and-set-expected.txt: * storage/domstorage/sessionstorage/index-get-and-set.html: * storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Removed. * storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Removed. * storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Removed. * storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Removed. * storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Removed. * storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Removed. * storage/domstorage/sessionstorage/simple-events-expected.txt: Removed. * storage/domstorage/sessionstorage/simple-events.html: Removed. * storage/domstorage/window-attributes-exist-expected.txt: * storage/domstorage/window-attributes-exist.html: git-svn-id: svn://svn.chromium.org/blink/trunk@53840 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/7573493mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=17475 Reviewed by Darin Adler. WebCore: Test: fast/text/line-break-after-question-mark.html Instead of unconditionally allowing lines to break after a question mark, which was intended to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark, with one exception in the ASCII range to match IE, namely not allowing a line break between a question mark and a vertical line. * rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table for the question mark case in order to keep it fast and not require a text break iterator in the ASCII case. (WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter. LayoutTests: * fast/text/line-break-after-question-mark-expected.txt: Added. * fast/text/line-break-after-question-mark.html: Added. * fast/text/script-tests/line-break-after-question-mark.js: Added. (): * platform/mac/tables/mozilla/bugs/bug6674-expected.checksum: Updated. * platform/mac/tables/mozilla/bugs/bug6674-expected.png: Updated. * platform/mac/tables/mozilla/bugs/bug6674-expected.txt: Updated. git-svn-id: svn://svn.chromium.org/blink/trunk@53839 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pkasting@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=34049 Reviewed by Dan Bernstein. * platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): * platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): LayoutTests: Rebaseline pixel tests affected by changes in scrollbar thumb size. https://bugs.webkit.org/show_bug.cgi?id=34049 Reviewed by Dan Bernstein. * platform/mac/compositing/overflow/overflow-scroll-expected.checksum: * platform/mac/compositing/overflow/overflow-scroll-expected.png: * platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: * platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: * platform/mac/fast/body-propagation/overflow/002-expected.checksum: * platform/mac/fast/body-propagation/overflow/002-expected.png: * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum: * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png: * platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum: * platform/mac/fast/body-propagation/overflow/003-declarative-expected.png: * platform/mac/fast/body-propagation/overflow/003-expected.checksum: * platform/mac/fast/body-propagation/overflow/003-expected.png: * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum: * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png: * platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum: * platform/mac/fast/body-propagation/overflow/004-declarative-expected.png: * platform/mac/fast/body-propagation/overflow/004-expected.checksum: * platform/mac/fast/body-propagation/overflow/004-expected.png: * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum: * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png: * platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum: * platform/mac/fast/body-propagation/overflow/007-declarative-expected.png: * platform/mac/fast/body-propagation/overflow/007-expected.checksum: * platform/mac/fast/body-propagation/overflow/007-expected.png: * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum: * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png: * platform/mac/fast/clip/014-expected.checksum: * platform/mac/fast/clip/014-expected.png: * platform/mac/fast/forms/basic-textareas-expected.checksum: * platform/mac/fast/forms/basic-textareas-expected.png: * platform/mac/fast/forms/form-element-geometry-expected.checksum: * platform/mac/fast/forms/form-element-geometry-expected.png: * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum: * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png: * platform/mac/fast/forms/textarea-scroll-height-expected.checksum: * platform/mac/fast/forms/textarea-scroll-height-expected.png: * platform/mac/fast/inline-block/tricky-baseline-expected.checksum: * platform/mac/fast/inline-block/tricky-baseline-expected.png: * platform/mac/fast/layers/scroll-rect-to-visible-expected.checksum: * platform/mac/fast/layers/scroll-rect-to-visible-expected.png: * platform/mac/fast/overflow/002-expected.checksum: * platform/mac/fast/overflow/002-expected.png: * platform/mac/fast/overflow/003-expected.checksum: * platform/mac/fast/overflow/003-expected.png: * platform/mac/fast/overflow/005-expected.checksum: * platform/mac/fast/overflow/005-expected.png: * platform/mac/fast/overflow/007-expected.checksum: * platform/mac/fast/overflow/007-expected.png: * platform/mac/fast/overflow/008-expected.checksum: * platform/mac/fast/overflow/008-expected.png: * platform/mac/fast/overflow/childFocusRingClip-expected.checksum: * platform/mac/fast/overflow/childFocusRingClip-expected.png: * platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: * platform/mac/fast/overflow/float-in-relpositioned-expected.png: * platform/mac/fast/overflow/image-selection-highlight-expected.checksum: * platform/mac/fast/overflow/image-selection-highlight-expected.png: * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: * platform/mac/fast/overflow/overflow-rtl-expected.checksum: * platform/mac/fast/overflow/overflow-rtl-expected.png: * platform/mac/fast/overflow/overflow-stacking-expected.checksum: * platform/mac/fast/overflow/overflow-stacking-expected.png: * platform/mac/fast/overflow/overflow-text-hit-testing-expected.checksum: * platform/mac/fast/overflow/overflow-text-hit-testing-expected.png: * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: * platform/mac/fast/overflow/overflow-x-y-expected.checksum: * platform/mac/fast/overflow/overflow-x-y-expected.png: * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: * platform/mac/fast/overflow/scrollbar-position-update-expected.checksum: * platform/mac/fast/overflow/scrollbar-position-update-expected.png: * platform/mac/fast/overflow/table-overflow-float-expected.checksum: * platform/mac/fast/overflow/table-overflow-float-expected.png: * platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum: * platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png: * platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum: * platform/mac/fast/repaint/layout-state-only-positioned-expected.png: * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum: * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png: * platform/mac/fast/table/edge-offsets-expected.checksum: * platform/mac/fast/table/edge-offsets-expected.png: * platform/mac/scrollbars/key-window-not-first-responder-expected.checksum: * platform/mac/scrollbars/key-window-not-first-responder-expected.png: * platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum: * platform/mac/svg/custom/invisible-text-after-scrolling-expected.png: * platform/mac/tables/mozilla/bugs/bug149275-1-expected.checksum: * platform/mac/tables/mozilla/bugs/bug149275-1-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@53838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jorlow@chromium.org authored
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-25 * Scripts/webkitpy/committers.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca@apple.com authored
* Misc/WebCache.mm: (+[WebCache empty]): * WebCoreSupport/WebApplicationCache.mm: * WebCoreSupport/WebChromeClient.h: * WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]): * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): * WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): (-[WebView _close]): * WebView/WebViewData.mm: (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): git-svn-id: svn://svn.chromium.org/blink/trunk@53836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34148 Reviewed by Darin Adler. Test: editing/pasteboard/paste-noscript-xhtml.xhtml * dom/Element.cpp: (WebCore::Element::setAttributeNS): * dom/Element.h: * dom/XMLTokenizer.h: * dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs): (WebCore::parseXMLDocumentFragment): * html/HTMLElement.cpp: (WebCore::HTMLElement::createContextualFragment): LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=34148 Reviewed by Darin Adler. * editing/pasteboard/paste-noscript-xhtml-expected.txt: Added. * editing/pasteboard/paste-noscript-xhtml.xhtml: Added. * editing/resources/htmlcontent.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@53835 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sfalken@apple.com authored
Reviewed by Simon Fraser. A WebGeolocationControllerClient is leaked for every WebView https://bugs.webkit.org/show_bug.cgi?id=34145 * WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::geolocationDestroyed): Added. * WebCoreSupport/WebGeolocationControllerClient.h: 2010-01-25 Steve Falkenburg <sfalken@apple.com> Reviewed by Simon Fraser. A WebGeolocationControllerClient is leaked for every WebView https://bugs.webkit.org/show_bug.cgi?id=34145 * WebCoreSupport/WebGeolocationControllerClient.h: * WebCoreSupport/WebGeolocationControllerClient.mm: (WebGeolocationControllerClient::geolocationDestroyed): 2010-01-25 Steve Falkenburg <sfalken@apple.com> Reviewed by Simon Fraser. A WebGeolocationControllerClient is leaked for every WebView https://bugs.webkit.org/show_bug.cgi?id=34145 * page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController): * page/GeolocationControllerClient.h: git-svn-id: svn://svn.chromium.org/blink/trunk@53834 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 25 Jan, 2010 10 commits
-
-
eric@webkit.org authored
Reviewed by Darin Adler. Improve portability of select-item-background-clip.html https://bugs.webkit.org/show_bug.cgi?id=34072 * fast/forms/select-item-background-clip.html: Calculate the pixel height at runtime. git-svn-id: svn://svn.chromium.org/blink/trunk@53820 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dglazkov@chromium.org authored
Unreviewed, trivial baseline updates. -webkit-gradient slows down scrolling when page has horizontal scrollbar https://bugs.webkit.org/show_bug.cgi?id=19650 Update pixel baselines. They changed slightly after http://trac.webkit.org/changeset/53318/ landed. * platform/mac/fast/gradients/border-image-gradient-expected.checksum: * platform/mac/fast/gradients/border-image-gradient-expected.png: * platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum: * platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: * platform/mac/fast/gradients/simple-gradients-expected.checksum: * platform/mac/fast/gradients/simple-gradients-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@53816 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dimich@chromium.org authored
Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle. After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads were already terminated and their threadMap entries cleared. Add a 0 check. Reviewed by David Levin. * wtf/ThreadingPthreads.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread): git-svn-id: svn://svn.chromium.org/blink/trunk@53815 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cmarrin@apple.com authored
parent root layer. https://bugs.webkit.org/show_bug.cgi?id=33847 git-svn-id: svn://svn.chromium.org/blink/trunk@53814 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34076 An image remains accessible via form.property syntax after being removed from document. Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.) * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect assertions added in the previous patch - it's mot true that m_for is always a parent; table parsing can reparent the image element, but m_form still needs to be set. git-svn-id: svn://svn.chromium.org/blink/trunk@53813 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34076 An image remains accessible via form.property syntax after being removed from document. Tests: fast/forms/removed-image-as-property.html fast/forms/reparented-image-as-property.html * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time to make observable changes to DOM. (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that depends on connectedness to some ancestor. We still allow for m_form to be set via constructor, which happens during parsing. (WebCore::HTMLImageElement::removedFromTree): Ditto. * html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument and insertedIntoDocument to private section, as they shouldn't be called directly. git-svn-id: svn://svn.chromium.org/blink/trunk@53812 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=34073 Fixes misspelled words in comments. * accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest): * accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement): * bindings/js/JSDOMBinding.cpp: (WebCore::completeURL): * bindings/js/JSDOMWindowBase.cpp: * bindings/js/JSDOMWindowBase.h: * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): * bindings/js/JSSVGPODTypeWrapper.h: * bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): * bridge/NP_jsobject.cpp: (_NPN_SetException): * bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): * bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField): * css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): * dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach): * dom/Document.h: * dom/Element.cpp: (WebCore::Element::updateFocusAppearance): * dom/Element.h: * dom/MessagePortChannel.h: * dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget): * dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode): * dom/Node.h: * dom/Position.cpp: (WebCore::Position::upstream): * dom/Position.h: * dom/Range.cpp: (WebCore::Range::processContents): * dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): * editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt): * editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): * editing/Editor.cpp: (WebCore::Editor::learnSpelling): * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format): * loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): * loader/Cache.h: * loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable): * loader/CachedResource.h: * loader/CachedResourceHandle.h: * loader/DocumentLoader.h: * loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine): * loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen): * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel): * loader/WorkerThreadableLoader.h: * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded): * notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): * page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations): * platform/LinkHash.cpp: (WebCore::cleanPath): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode): * platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern): * platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition): * platform/graphics/mac/GraphicsLayerCA.h: * platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer): * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): * platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding): * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): * rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged): * rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer): * rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks): * rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform): * wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue): git-svn-id: svn://svn.chromium.org/blink/trunk@53811 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Unreviewed. Add new inspector test added in r53807 to skip list on qt platform. * platform/qt/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@53810 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dbates@webkit.org authored
Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=34073 Fixes misspelled words in comments. * accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest): * accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement): * bindings/js/JSDOMBinding.cpp: (WebCore::completeURL): * bindings/js/JSDOMWindowBase.cpp: * bindings/js/JSDOMWindowBase.h: * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): * bindings/js/JSSVGPODTypeWrapper.h: * bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): * bridge/NP_jsobject.cpp: (_NPN_SetException): * bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): * bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField): * css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): * dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach): * dom/Document.h: * dom/Element.cpp: (WebCore::Element::updateFocusAppearance): * dom/Element.h: * dom/MessagePortChannel.h: * dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget): * dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode): * dom/Node.h: * dom/Position.cpp: (WebCore::Position::upstream): * dom/Position.h: * dom/Range.cpp: (WebCore::Range::processContents): * dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): * editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt): * editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): * editing/Editor.cpp: (WebCore::Editor::learnSpelling): * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format): * loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): * loader/Cache.h: * loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable): * loader/CachedResource.h: * loader/CachedResourceHandle.h: * loader/DocumentLoader.h: * loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine): * loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen): * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel): * loader/WorkerThreadableLoader.h: * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded): * notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): * page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations): * platform/LinkHash.cpp: (WebCore::cleanPath): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode): * platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern): * platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition): * platform/graphics/mac/GraphicsLayerCA.h: * platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer): * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): * platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding): * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): * rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged): * rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer): * rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks): * rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform): * wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue): git-svn-id: svn://svn.chromium.org/blink/trunk@53809 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ggaren@apple.com authored
Fixed a spelling error, tightened up some grammar. * bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMObject): (WebCore::forgetDOMNode): git-svn-id: svn://svn.chromium.org/blink/trunk@53808 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-