1. 26 Jan, 2010 13 commits
    • pfeldman@chromium.org's avatar
      2010-01-26 Pavel Feldman <pfeldman@chromium.org> · f93131b4
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Implement HTML and CSS highlighters.
      
              https://bugs.webkit.org/show_bug.cgi?id=34144
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/JavaScriptTokenizer.js: Removed.
              * inspector/front-end/JavaScriptTokenizer.re2js: Removed.
              * inspector/front-end/SourceCSSTokenizer.js: Added.
              (WebInspector.SourceCSSTokenizer):
              (WebInspector.SourceCSSTokenizer.prototype._stringToken):
              (WebInspector.SourceCSSTokenizer.prototype._isPropertyValue):
              (WebInspector.SourceCSSTokenizer.prototype.nextToken):
              * inspector/front-end/SourceCSSTokenizer.re2js: Added.
              * inspector/front-end/SourceHTMLTokenizer.js: Added.
              (WebInspector.SourceHTMLTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype._stringToken):
              (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
              * inspector/front-end/SourceHTMLTokenizer.re2js: Added.
              * inspector/front-end/SourceJavaScriptTokenizer.js: Added.
              (WebInspector.SourceJavaScriptTokenizer):
              (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
              * inspector/front-end/SourceJavaScriptTokenizer.re2js: Added.
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter):
              (WebInspector.TextEditorHighlighter.prototype._highlightLines):
              (WebInspector.TextEditorHighlighter.Tokenizer):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set line):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set condition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.get condition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.hasCondition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.getLexCondition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype.setLexCondition):
              (WebInspector.TextEditorHighlighter.Tokenizer.prototype._charAt):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53846 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f93131b4
    • hausmann@webkit.org's avatar
      REGRESSION(r53835): Fix editing/pasteboard/paste-noscript-xhtml.xhtml · a7b4fcd6
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34157
      
      Reviewed by Holger Freyther.
      
      WebCore:
      
      Pass the FragmentScriptingPermission correctly through to the DOM
      and disallow scripting elements in parseEndElement(), similar to
      the libxml tokenizer change in r53835.
      
      * dom/XMLTokenizerQt.cpp:
      (WebCore::handleElementNamespaces):
      (WebCore::handleElementAttributes):
      (WebCore::XMLTokenizer::parseStartElement):
      (WebCore::XMLTokenizer::parseEndElement):
      
      LayoutTests:
      
      Add Qt specific result for this test that differs from the cross-platform
      result in only one character: In htmlcontent.html the href attribute value
      is http://www.cnn.com, which somehow becomes http://www.cnn.com/ in the cross
      platform result. With the Qt xml parser that attribute is somehow preserved
      and so our result does not have the trailing slash.
      
      * platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53845 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a7b4fcd6
    • tkent@chromium.org's avatar
      2010-01-26 Kent Tamura <tkent@chromium.org> · 54862e2f
      tkent@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              Convert textarea-rows-cols.html to dumpAsText()
              https://bugs.webkit.org/show_bug.cgi?id=34074
      
              * fast/forms/script-tests/textarea-rows-cols.js: Added.
              * fast/forms/textarea-rows-cols-expected.txt: Added.
              * fast/forms/textarea-rows-cols.html:
              * platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Removed.
              * platform/mac/fast/forms/textarea-rows-cols-expected.png: Removed.
              * platform/mac/fast/forms/textarea-rows-cols-expected.txt: Removed.
              * platform/qt/fast/forms/textarea-rows-cols-expected.txt: Removed.
              * platform/win/fast/forms/textarea-rows-cols-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53844 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      54862e2f
    • eric@webkit.org's avatar
      2010-01-26 Garret Kelly <gdk@chromium.org> · ea23f952
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add missing declaration for the feMorphology SVG element.
              https://bugs.webkit.org/show_bug.cgi?id=34151
      
              * bindings/v8/V8DOMWrapper.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53843 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ea23f952
    • zoltan@webkit.org's avatar
      Unreviewed build fix. · f7db8494
      zoltan@webkit.org authored
      Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-26
      [Qt] Build fix after API changes in r53835.
      
      No new tests needed.
      
      * dom/XMLTokenizerQt.cpp:
      (WebCore::XMLTokenizer::XMLTokenizer):
      (WebCore::parseXMLDocumentFragment):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53842 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f7db8494
    • cjerdonek@webkit.org's avatar
      2010-01-25 Chris Jerdonek <cjerdonek@webkit.org> · 1025c2bc
      cjerdonek@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Refactored check-webkit-style by removing the file path
              parameter from the style error handler functions.
      
              https://bugs.webkit.org/show_bug.cgi?id=34031
      
              * Scripts/webkitpy/style/checker.py:
                - Added _default_style_error_handler() to StyleChecker class.
                - Moved handle_style_error() to inside _default_style_error_handler().
      
              * Scripts/webkitpy/style/checker_unittest.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/cpp_style.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/cpp_style_unittest.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/text_style.py:
                - Removed file path from calls to error handler.
      
              * Scripts/webkitpy/style/text_style_unittest.py:
                - Removed file path from calls to error handler.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53841 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1025c2bc
    • jorlow@chromium.org's avatar
      2010-01-22 Jeremy Orlow <jorlow@chromium.org> · 506e00c9
      jorlow@chromium.org authored
              Reviewed by Darin Adler.
      
              Make storage events match the spec.
              https://bugs.webkit.org/show_bug.cgi?id=30546
      
              Update the storageEvent algorithm to match the change in WebCore.
      
              * src/StorageAreaProxy.cpp:
              (WebCore::StorageAreaProxy::storageEvent):
      2010-01-22  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Adler.
      
              Make storage events match the spec.
              https://bugs.webkit.org/show_bug.cgi?id=30546
      
              This meat of the patch I just posted is very simple.  It's just making events
              asynchronous, not posting them to the frame that generated them, passing a null
              for the key when issuing a clear storage event, and making the events
              non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
      
              The asynchronous and not posting to the frame that generated them forced me to
              re-write all the layout tests that dealt with storage events.  There's a lot of
              code there, but I tried to be fairly careful to ensure that test coverage did
              not shrink in any area.
      
              Tests: storage/domstorage/events/basic-body-attribute.html
                     storage/domstorage/events/basic-setattribute.html
                     storage/domstorage/events/basic.html
                     storage/domstorage/events/case-sensitive.html
                     storage/domstorage/events/documentURI.html
      
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::enqueueStorageEvent):
              (WebCore::Document::storageEventTimerFired):
              * dom/Document.h:
              * storage/StorageEvent.cpp:
              (WebCore::StorageEvent::StorageEvent):
              * storage/StorageEvent.idl:
              * storage/StorageEventDispatcher.cpp:
              (WebCore::StorageEventDispatcher::dispatch):
      2010-01-22  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Adler.
      
              Make storage events match the spec.
              https://bugs.webkit.org/show_bug.cgi?id=30546
      
              This meat of the patch I just posted is very simple.  It's just making events
              asynchronous, not posting them to the frame that generated them, passing a null
              for the key when issuing a clear storage event, and making the events
              non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
      
              The asynchronous and not posting to the frame that generated them forced me to
              re-write all the layout tests that dealt with storage events.  There's a lot of
              code there, but I tried to be fairly careful to ensure that test coverage did
              not shrink in any area.
      
              * storage/domstorage/complex-values-expected.txt:
              * storage/domstorage/documentURI-expected.txt: Removed.
              * storage/domstorage/documentURI.html: Removed.
              * storage/domstorage/events: Added.
              * storage/domstorage/events/basic-body-attribute-expected.txt: Added.
              * storage/domstorage/events/basic-body-attribute.html: Added.
              * storage/domstorage/events/basic-expected.txt: Added.
              * storage/domstorage/events/basic-setattribute-expected.txt: Added.
              * storage/domstorage/events/basic-setattribute.html: Added.
              * storage/domstorage/events/basic.html: Added.
              * storage/domstorage/events/case-sensitive-expected.txt: Added.
              * storage/domstorage/events/case-sensitive.html: Added.
              * storage/domstorage/events/documentURI-expected.txt: Added.
              * storage/domstorage/events/documentURI.html: Added.
              * storage/domstorage/events/resources: Added.
              * storage/domstorage/events/resources/body-event-handler.html: Added.
              * storage/domstorage/events/resources/eventTestHarness.js: Added.
              * storage/domstorage/events/resources/setattribute-event-handler.html: Added.
              * storage/domstorage/events/script-tests: Added.
              * storage/domstorage/events/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
              * storage/domstorage/events/script-tests/basic-body-attribute.js: Added.
              * storage/domstorage/events/script-tests/basic-setattribute.js: Added.
              * storage/domstorage/events/script-tests/basic.js: Added.
              * storage/domstorage/events/script-tests/case-sensitive.js: Added.
              * storage/domstorage/events/script-tests/documentURI.js: Added.
              * storage/domstorage/localstorage/iframe-events-expected.txt: Removed.
              * storage/domstorage/localstorage/iframe-events.html: Removed.
              * storage/domstorage/localstorage/index-get-and-set-expected.txt:
              * storage/domstorage/localstorage/index-get-and-set.html:
              * storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-markup.html: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Removed.
              * storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Removed.
              * storage/domstorage/localstorage/simple-events-expected.txt: Removed.
              * storage/domstorage/localstorage/simple-events.html: Removed.
              * storage/domstorage/script-tests/complex-values.js:
              * storage/domstorage/script-tests/documentURI.js: Removed.
              * storage/domstorage/sessionstorage/iframe-events-expected.txt: Removed.
              * storage/domstorage/sessionstorage/iframe-events.html: Removed.
              * storage/domstorage/sessionstorage/index-get-and-set-expected.txt:
              * storage/domstorage/sessionstorage/index-get-and-set.html:
              * storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Removed.
              * storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Removed.
              * storage/domstorage/sessionstorage/simple-events-expected.txt: Removed.
              * storage/domstorage/sessionstorage/simple-events.html: Removed.
              * storage/domstorage/window-attributes-exist-expected.txt:
              * storage/domstorage/window-attributes-exist.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53840 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      506e00c9
    • mitz@apple.com's avatar
      <rdar://problem/7573493> Error with line break inside ?&raquo; pair of characters. · 606f5bb3
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=17475
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/text/line-break-after-question-mark.html
      
      Instead of unconditionally allowing lines to break after a question mark, which was intended
      to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark,
      with one exception in the ASCII range to match IE, namely not allowing a line break between
      a question mark and a vertical line.
      
      * rendering/break_lines.cpp:
      (WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table
      for the question mark case in order to keep it fast and not require a text break iterator in
      the ASCII case.
      (WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter.
      
      LayoutTests: 
      
      * fast/text/line-break-after-question-mark-expected.txt: Added.
      * fast/text/line-break-after-question-mark.html: Added.
      * fast/text/script-tests/line-break-after-question-mark.js: Added.
      ():
      * platform/mac/tables/mozilla/bugs/bug6674-expected.checksum: Updated.
      * platform/mac/tables/mozilla/bugs/bug6674-expected.png: Updated.
      * platform/mac/tables/mozilla/bugs/bug6674-expected.txt: Updated.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53839 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      606f5bb3
    • pkasting@chromium.org's avatar
      WebCore: Mac scrollbar thumbs were drawn with the wrong size. · 86ed8ce6
      pkasting@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34049
      
      Reviewed by Dan Bernstein.
      
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::paint):
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarThemeMac::paint):
      
      LayoutTests: Rebaseline pixel tests affected by changes in scrollbar thumb size.
      https://bugs.webkit.org/show_bug.cgi?id=34049
      
      Reviewed by Dan Bernstein.
      
      * platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
      * platform/mac/compositing/overflow/overflow-scroll-expected.png:
      * platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
      * platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
      * platform/mac/fast/body-propagation/overflow/002-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/002-expected.png:
      * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
      * platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
      * platform/mac/fast/body-propagation/overflow/003-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/003-expected.png:
      * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
      * platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
      * platform/mac/fast/body-propagation/overflow/004-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/004-expected.png:
      * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
      * platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
      * platform/mac/fast/body-propagation/overflow/007-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/007-expected.png:
      * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
      * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
      * platform/mac/fast/clip/014-expected.checksum:
      * platform/mac/fast/clip/014-expected.png:
      * platform/mac/fast/forms/basic-textareas-expected.checksum:
      * platform/mac/fast/forms/basic-textareas-expected.png:
      * platform/mac/fast/forms/form-element-geometry-expected.checksum:
      * platform/mac/fast/forms/form-element-geometry-expected.png:
      * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
      * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
      * platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
      * platform/mac/fast/forms/textarea-scroll-height-expected.png:
      * platform/mac/fast/inline-block/tricky-baseline-expected.checksum:
      * platform/mac/fast/inline-block/tricky-baseline-expected.png:
      * platform/mac/fast/layers/scroll-rect-to-visible-expected.checksum:
      * platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
      * platform/mac/fast/overflow/002-expected.checksum:
      * platform/mac/fast/overflow/002-expected.png:
      * platform/mac/fast/overflow/003-expected.checksum:
      * platform/mac/fast/overflow/003-expected.png:
      * platform/mac/fast/overflow/005-expected.checksum:
      * platform/mac/fast/overflow/005-expected.png:
      * platform/mac/fast/overflow/007-expected.checksum:
      * platform/mac/fast/overflow/007-expected.png:
      * platform/mac/fast/overflow/008-expected.checksum:
      * platform/mac/fast/overflow/008-expected.png:
      * platform/mac/fast/overflow/childFocusRingClip-expected.checksum:
      * platform/mac/fast/overflow/childFocusRingClip-expected.png:
      * platform/mac/fast/overflow/float-in-relpositioned-expected.checksum:
      * platform/mac/fast/overflow/float-in-relpositioned-expected.png:
      * platform/mac/fast/overflow/image-selection-highlight-expected.checksum:
      * platform/mac/fast/overflow/image-selection-highlight-expected.png:
      * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum:
      * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
      * platform/mac/fast/overflow/overflow-rtl-expected.checksum:
      * platform/mac/fast/overflow/overflow-rtl-expected.png:
      * platform/mac/fast/overflow/overflow-stacking-expected.checksum:
      * platform/mac/fast/overflow/overflow-stacking-expected.png:
      * platform/mac/fast/overflow/overflow-text-hit-testing-expected.checksum:
      * platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
      * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
      * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
      * platform/mac/fast/overflow/overflow-x-y-expected.checksum:
      * platform/mac/fast/overflow/overflow-x-y-expected.png:
      * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
      * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
      * platform/mac/fast/overflow/scrollbar-position-update-expected.checksum:
      * platform/mac/fast/overflow/scrollbar-position-update-expected.png:
      * platform/mac/fast/overflow/table-overflow-float-expected.checksum:
      * platform/mac/fast/overflow/table-overflow-float-expected.png:
      * platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
      * platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
      * platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum:
      * platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
      * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
      * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
      * platform/mac/fast/table/edge-offsets-expected.checksum:
      * platform/mac/fast/table/edge-offsets-expected.png:
      * platform/mac/scrollbars/key-window-not-first-responder-expected.checksum:
      * platform/mac/scrollbars/key-window-not-first-responder-expected.png:
      * platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum:
      * platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
      * platform/mac/tables/mozilla/bugs/bug149275-1-expected.checksum:
      * platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      86ed8ce6
    • jorlow@chromium.org's avatar
      Adding myself as reviewer. No review necessary. · 4e8e57b4
      jorlow@chromium.org authored
      Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-25
      * Scripts/webkitpy/committers.py:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4e8e57b4
    • andersca@apple.com's avatar
      Featureless build fixes. · e870e371
      andersca@apple.com authored
      * Misc/WebCache.mm:
      (+[WebCache empty]):
      * WebCoreSupport/WebApplicationCache.mm:
      * WebCoreSupport/WebChromeClient.h:
      * WebView/WebDataSource.mm:
      (-[WebDataSource _transferApplicationCache:]):
      * WebView/WebFrame.mm:
      (-[WebFrame _cacheabilityDictionary]):
      * WebView/WebView.mm:
      (WebKitInitializeApplicationCachePathIfNecessary):
      (-[WebView _close]):
      * WebView/WebViewData.mm:
      (-[WebViewPrivate dealloc]):
      (-[WebViewPrivate finalize]):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e870e371
    • enrica@apple.com's avatar
      WebCore: Cleanup unwanted tags after pasting. · c139664f
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34148
              
      Reviewed by Darin Adler.
      
      Test: editing/pasteboard/paste-noscript-xhtml.xhtml
      
      * dom/Element.cpp:
      (WebCore::Element::setAttributeNS):
      * dom/Element.h:
      * dom/XMLTokenizer.h:
      * dom/XMLTokenizerLibxml2.cpp:
      (WebCore::XMLTokenizer::XMLTokenizer):
      (WebCore::handleElementNamespaces):
      (WebCore::handleElementAttributes):
      (WebCore::XMLTokenizer::startElementNs):
      (WebCore::XMLTokenizer::endElementNs):
      (WebCore::parseXMLDocumentFragment):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::createContextualFragment):
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=34148
      
      Reviewed by Darin Adler.
      
      * editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
      * editing/pasteboard/paste-noscript-xhtml.xhtml: Added.
      * editing/resources/htmlcontent.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53835 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c139664f
    • sfalken@apple.com's avatar
      2010-01-25 Steve Falkenburg <sfalken@apple.com> · 312b83e8
      sfalken@apple.com authored
              Reviewed by Simon Fraser.
      
              A WebGeolocationControllerClient is leaked for every WebView
              https://bugs.webkit.org/show_bug.cgi?id=34145
      
              * WebCoreSupport/WebGeolocationControllerClient.cpp:
              (WebGeolocationControllerClient::geolocationDestroyed): Added.
              * WebCoreSupport/WebGeolocationControllerClient.h:
      2010-01-25  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Simon Fraser.
      
              A WebGeolocationControllerClient is leaked for every WebView
              https://bugs.webkit.org/show_bug.cgi?id=34145
      
              * WebCoreSupport/WebGeolocationControllerClient.h:
              * WebCoreSupport/WebGeolocationControllerClient.mm:
              (WebGeolocationControllerClient::geolocationDestroyed):
      2010-01-25  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Simon Fraser.
      
              A WebGeolocationControllerClient is leaked for every WebView
              https://bugs.webkit.org/show_bug.cgi?id=34145
      
              * page/GeolocationController.cpp:
              (WebCore::GeolocationController::~GeolocationController):
              * page/GeolocationControllerClient.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53834 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      312b83e8
  2. 25 Jan, 2010 27 commits
    • eric@webkit.org's avatar
      2010-01-25 Kent Tamura <tkent@chromium.org> · a2a8f713
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Improve portability of select-item-background-clip.html
              https://bugs.webkit.org/show_bug.cgi?id=34072
      
              * fast/forms/select-item-background-clip.html:
                Calculate the pixel height at runtime.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53820 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a2a8f713
    • dglazkov@chromium.org's avatar
      2010-01-25 Dimitri Glazkov <dglazkov@chromium.org> · daab4045
      dglazkov@chromium.org authored
              Unreviewed, trivial baseline updates.
      
              -webkit-gradient slows down scrolling when page has horizontal scrollbar
              https://bugs.webkit.org/show_bug.cgi?id=19650
      
              Update pixel baselines. They changed slightly after http://trac.webkit.org/changeset/53318/
              landed.
      
              * platform/mac/fast/gradients/border-image-gradient-expected.checksum:
              * platform/mac/fast/gradients/border-image-gradient-expected.png:
              * platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum:
              * platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
              * platform/mac/fast/gradients/simple-gradients-expected.checksum:
              * platform/mac/fast/gradients/simple-gradients-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53816 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      daab4045
    • dimich@chromium.org's avatar
      Fix Chromium Linux tests: the pthread functions on Linux produce segfault if... · a7b048cf
      dimich@chromium.org authored
      Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle.
      After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads
      were already terminated and their threadMap entries cleared.
      Add a 0 check.
      
      Reviewed by David Levin.
      
      * wtf/ThreadingPthreads.cpp:
      (WTF::waitForThreadCompletion):
      (WTF::detachThread):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53815 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a7b048cf
    • cmarrin@apple.com's avatar
      Fixed bug in positioning of scroll layer within the · 130ef4a4
      cmarrin@apple.com authored
              parent root layer.
              https://bugs.webkit.org/show_bug.cgi?id=33847
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53814 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      130ef4a4
    • ap@apple.com's avatar
      Rubber-stamped by Geoffrey Garen. · 1763fceb
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=34076
              An image remains accessible via form.property syntax after being removed from document.
      
              Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.)
      
              * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect
              assertions added in the previous patch - it's mot true that m_for is always a parent; table
              parsing can reparent the image element, but m_form still needs to be set.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53813 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1763fceb
    • ap@apple.com's avatar
      Reviewed by Geoffrey Garen. · 8e40eb4f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=34076
              An image remains accessible via form.property syntax after being removed from document.
      
              Tests: fast/forms/removed-image-as-property.html
                     fast/forms/reparented-image-as-property.html
      
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time
              to make observable changes to DOM.
              (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that
              depends on connectedness to some ancestor. We still allow for m_form to be set via constructor,
              which happens during parsing.
              (WebCore::HTMLImageElement::removedFromTree): Ditto.
      
              * html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument
              and insertedIntoDocument to private section, as they shouldn't be called directly.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53812 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8e40eb4f
    • eric@webkit.org's avatar
      2010-01-25 Daniel Bates <dbates@webkit.org> · ab35bc1d
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=34073
      
              Fixes misspelled words in comments.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::addChildren):
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper detach]):
              (AXAttributeStringSetElement):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::completeURL):
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::getOwnPropertySlot):
              * bindings/js/JSSVGPODTypeWrapper.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              * bridge/NP_jsobject.cpp:
              (_NPN_SetException):
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaInstance::invokeMethod):
              (JObjectWrapper::JObjectWrapper):
              * bridge/objc/objc_instance.mm:
              (ObjcInstance::setValueOfUndefinedField):
              (ObjcInstance::getValueOfUndefinedField):
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::sortMatchedRules):
              (WebCore::CSSStyleSelector::applyDeclarations):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Document.cpp:
              (WebCore::Document::updateLayoutIgnorePendingStylesheets):
              (WebCore::Document::detach):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * dom/Element.h:
              * dom/MessagePortChannel.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::receivedTarget):
              * dom/Node.cpp:
              (WebCore::Node::isFocusable):
              (WebCore::Node::shadowAncestorNode):
              * dom/Node.h:
              * dom/Position.cpp:
              (WebCore::Position::upstream):
              * dom/Position.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::addCSSColor):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::reconcileTextDecorationProperties):
              (WebCore::StyleChange::extractTextStyles):
              (WebCore::prepareEditingStyleToApplyAt):
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              * editing/Editor.cpp:
              (WebCore::Editor::learnSpelling):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleMessage.prototype._format):
              * loader/Cache.cpp:
              (WebCore::Cache::pruneLiveResources):
              (WebCore::Cache::pruneDeadResources):
              * loader/Cache.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::makePurgeable):
              * loader/CachedResource.h:
              * loader/CachedResourceHandle.h:
              * loader/DocumentLoader.h:
              * loader/FTPDirectoryParser.cpp:
              (WebCore::parseOneFTPLine):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didExplicitOpen):
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::didCancel):
              * loader/WorkerThreadableLoader.h:
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::spaceNeeded):
              * notifications/NotificationPresenter.h:
              (WebCore::NotificationPresenter::):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationController::updateAnimations):
              * platform/LinkHash.cpp:
              (WebCore::cleanPath):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::calculateDrawingMode):
              * platform/graphics/cg/PatternCG.cpp:
              (WebCore::Pattern::createPlatformPattern):
              * platform/graphics/mac/ComplexTextController.cpp:
              (WebCore::ComplexTextController::offsetForPosition):
              * platform/graphics/mac/GraphicsLayerCA.h:
              * platform/graphics/mac/GraphicsLayerCA.mm:
              (WebCore::GraphicsLayerCA::ensureStructuralLayer):
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::doSeek):
              (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
              (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::registerExtendedEncodingNames):
              * platform/text/TextEncodingDetectorICU.cpp:
              (WebCore::detectTextEncoding):
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::calcEffectiveWidth):
              (WebCore::AutoTableLayout::layout):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollByRecursively):
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::hitTestLayer):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::destroy):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::setInnerTextValue):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::stateChanged):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderBase::mapLocalToContainer):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildTextChunks):
              * rendering/TransformState.cpp:
              (WebCore::TransformState::flattenWithTransform):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::dispatchBlurEvent):
              (WebCore::WMLInputElement::suggestedValue):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53811 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ab35bc1d
    • yurys@chromium.org's avatar
      2010-01-25 Yury Semikhatsky <yurys@chromium.org> · 690a3322
      yurys@chromium.org authored
              Unreviewed. Add new inspector test added in r53807 to skip
              list on qt platform.
      
              * platform/qt/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53810 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      690a3322
    • dbates@webkit.org's avatar
      2010-01-25 Daniel Bates <dbates@webkit.org> · 7be46120
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=34073
      
              Fixes misspelled words in comments.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::addChildren):
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper detach]):
              (AXAttributeStringSetElement):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::completeURL):
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::getOwnPropertySlot):
              * bindings/js/JSSVGPODTypeWrapper.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              * bridge/NP_jsobject.cpp:
              (_NPN_SetException):
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaInstance::invokeMethod):
              (JObjectWrapper::JObjectWrapper):
              * bridge/objc/objc_instance.mm:
              (ObjcInstance::setValueOfUndefinedField):
              (ObjcInstance::getValueOfUndefinedField):
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::sortMatchedRules):
              (WebCore::CSSStyleSelector::applyDeclarations):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Document.cpp:
              (WebCore::Document::updateLayoutIgnorePendingStylesheets):
              (WebCore::Document::detach):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * dom/Element.h:
              * dom/MessagePortChannel.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::receivedTarget):
              * dom/Node.cpp:
              (WebCore::Node::isFocusable):
              (WebCore::Node::shadowAncestorNode):
              * dom/Node.h:
              * dom/Position.cpp:
              (WebCore::Position::upstream):
              * dom/Position.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::addCSSColor):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::reconcileTextDecorationProperties):
              (WebCore::StyleChange::extractTextStyles):
              (WebCore::prepareEditingStyleToApplyAt):
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              * editing/Editor.cpp:
              (WebCore::Editor::learnSpelling):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleMessage.prototype._format):
              * loader/Cache.cpp:
              (WebCore::Cache::pruneLiveResources):
              (WebCore::Cache::pruneDeadResources):
              * loader/Cache.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::makePurgeable):
              * loader/CachedResource.h:
              * loader/CachedResourceHandle.h:
              * loader/DocumentLoader.h:
              * loader/FTPDirectoryParser.cpp:
              (WebCore::parseOneFTPLine):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didExplicitOpen):
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::didCancel):
              * loader/WorkerThreadableLoader.h:
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::spaceNeeded):
              * notifications/NotificationPresenter.h:
              (WebCore::NotificationPresenter::):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationController::updateAnimations):
              * platform/LinkHash.cpp:
              (WebCore::cleanPath):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::calculateDrawingMode):
              * platform/graphics/cg/PatternCG.cpp:
              (WebCore::Pattern::createPlatformPattern):
              * platform/graphics/mac/ComplexTextController.cpp:
              (WebCore::ComplexTextController::offsetForPosition):
              * platform/graphics/mac/GraphicsLayerCA.h:
              * platform/graphics/mac/GraphicsLayerCA.mm:
              (WebCore::GraphicsLayerCA::ensureStructuralLayer):
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::doSeek):
              (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
              (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::registerExtendedEncodingNames):
              * platform/text/TextEncodingDetectorICU.cpp:
              (WebCore::detectTextEncoding):
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::calcEffectiveWidth):
              (WebCore::AutoTableLayout::layout):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollByRecursively):
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::hitTestLayer):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::destroy):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::setInnerTextValue):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::stateChanged):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderBase::mapLocalToContainer):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildTextChunks):
              * rendering/TransformState.cpp:
              (WebCore::TransformState::flattenWithTransform):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::dispatchBlurEvent):
              (WebCore::WMLInputElement::suggestedValue):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53809 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7be46120
    • ggaren@apple.com's avatar
      Suggested by Darin Adler. · 3b48e928
      ggaren@apple.com authored
      Fixed a spelling error, tightened up some grammar.
      
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::forgetDOMObject):
      (WebCore::forgetDOMNode):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53808 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3b48e928
    • eric@webkit.org's avatar
      2010-01-25 Yury Semikhatsky <yurys@chromium.org> · ccc79b1a
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Test that Web Inspector doesn't change methods declared by the inspected
              page.
              https://bugs.webkit.org/show_bug.cgi?id=34089
      
              * inspector/inspected-objects-not-overriden-expected.txt: Added.
              * inspector/inspected-objects-not-overriden.html: Added.
      2010-01-25  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Timothy Hatcher.
      
              Instead of adding inspector methods to the inspected global objects
              use private implementation visible from inspector code only.
              https://bugs.webkit.org/show_bug.cgi?id=34089
      
              Test: inspector/inspected-objects-not-overriden.html
      
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53807 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ccc79b1a
    • pfeldman@chromium.org's avatar
      2010-01-25 Pavel Feldman <pfeldman@chromium.org> · 8f872c06
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: don't show headers/content tabs in scripts view.
      
              https://bugs.webkit.org/show_bug.cgi?id=34083
      
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView):
              (WebInspector.ResourceView.prototype.set headersVisible):
              (WebInspector.ResourceView.prototype._selectContentTab):
              (WebInspector.ResourceView.prototype._innerSelectContentTab):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.show):
              (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
              (WebInspector.ResourcesPanel.prototype.showResource):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.show):
              (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
              * inspector/front-end/inspector.css:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53806 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8f872c06
    • philn@webkit.org's avatar
      2010-01-25 Philippe Normand <pnormand@igalia.com> · 0a8a597c
      philn@webkit.org authored
              Rubber-stamped by Xan Lopez.
      
              [Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
              https://bugs.webkit.org/show_bug.cgi?id=34086
      
              * platform/gtk/Skipped: Skipping the test, requires investigation
              on the failure.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53805 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0a8a597c
    • eric@webkit.org's avatar
      2010-01-25 Simon Hausmann <hausmann@webkit.org> · 04744a15
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Reduce the size of the library when compiling for Maemo5
              https://bugs.webkit.org/show_bug.cgi?id=34050
      
              Exclude the Web Inspector's qrc file in the Maemo5 build, just
              like we do for the Symbian build. Saves about ~900k.
      
              * WebCore.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53804 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      04744a15
    • eric@webkit.org's avatar
      2010-01-25 Simon Hausmann <hausmann@webkit.org> · c3ec0eeb
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device
              https://bugs.webkit.org/show_bug.cgi?id=34054
      
              Getting the style from the painter's paint device is a hack that breaks when
              the paint device's style is different than the style that is used when
              calculating the metries earlier when there is no painter available.
      
              This change moves us closer to always using the same style.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::StylePainter::StylePainter):
              (WebCore::StylePainter::init):
              (WebCore::RenderThemeQt::paintButton):
              (WebCore::RenderThemeQt::paintTextField):
              (WebCore::RenderThemeQt::paintMenuList):
              (WebCore::RenderThemeQt::paintMenuListButton):
              (WebCore::RenderThemeQt::paintSliderTrack):
              (WebCore::RenderThemeQt::paintMediaMuteButton):
              (WebCore::RenderThemeQt::paintMediaPlayButton):
              (WebCore::RenderThemeQt::paintMediaSliderTrack):
              (WebCore::RenderThemeQt::paintMediaSliderThumb):
              * platform/qt/RenderThemeQt.h:
              * platform/qt/ScrollbarThemeQt.cpp:
              (WebCore::ScrollbarThemeQt::paint):
              (WebCore::ScrollbarThemeQt::hitTest):
              (WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
              (WebCore::ScrollbarThemeQt::scrollbarThickness):
              (WebCore::ScrollbarThemeQt::thumbLength):
              (WebCore::ScrollbarThemeQt::trackPosition):
              (WebCore::ScrollbarThemeQt::trackLength):
              (WebCore::ScrollbarThemeQt::paintScrollCorner):
              (WebCore::ScrollbarThemeQt::style):
              * platform/qt/ScrollbarThemeQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53803 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c3ec0eeb
    • eric@webkit.org's avatar
      2010-01-25 Simon Hausmann <hausmann@webkit.org> · 09bb5305
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
              https://bugs.webkit.org/show_bug.cgi?id=34053
      
              * platform/qt/QWebPageClient.h: Add function to return the style.
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view.
      2010-01-25  Simon Hausmann  <hausmann@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
              https://bugs.webkit.org/show_bug.cgi?id=34053
      
              * Api/qgraphicswebview.cpp:
              (QGraphicsWebViewPrivate::style): Implement QWebPageClient::style() and return the graphics
              widget's style.
              * Api/qwebpage.cpp:
              (QWebPageWidgetClient::style): Implement QWebPageClient::style() and return the widget's style.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53802 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      09bb5305
    • hausmann@webkit.org's avatar
      [Qt] Clean up code to determine palette from page client in RenderThemeQt · 35dbea40
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34052
      
      Patch by Simon Hausmann <hausmann@webkit.org> on 2010-01-25
      Reviewed by Kenneth Christiansen.
      
      Use the RenderTheme's associated page instead of going through the
      render tree and the document.
      
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
      (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
      * platform/qt/RenderThemeQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53801 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      35dbea40
    • hausmann@webkit.org's avatar
      [Qt] Fix the build on Maemo5. · 25a17af6
      hausmann@webkit.org authored
      Reviewed by Laszlo Gombos.
      
      https://bugs.webkit.org/show_bug.cgi?id=34051
      
      * WebKit.pri: Disable the use of uitools, just like it's done for Symbian.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53800 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      25a17af6
    • eric@webkit.org's avatar
      2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com> · 7a335a35
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Phone backup support for QtWebkit for Symbian devices.
              https://bugs.webkit.org/show_bug.cgi?id=34077
      
              * WebCore.pro:
      2010-01-25  Janne Koskinen  <janne.p.koskinen@digia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Phone backup support for QtWebkit for Symbian devices.
              https://bugs.webkit.org/show_bug.cgi?id=34077
      
              * symbian/backup_registration.xml: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53799 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a335a35
    • yurys@chromium.org's avatar
      2010-01-25 Yury Semikhatsky <yurys@chromium.org> · bc577a80
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Update inspector test expectations. Line number and source
              name are present only in Chromium when console message is
              logged before document load is completed.
      
              https://bugs.webkit.org/show_bug.cgi?id=34078
      
              * platform/chromium/inspector/console-log-before-inspector-open-expected.txt: Added.
              * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
              * platform/mac/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
              * platform/win/inspector/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53798 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bc577a80
    • eric@webkit.org's avatar
      2010-01-25 Benjamin Poulain <benjamin.poulain@nokia.com> · 0035fbd8
      eric@webkit.org authored
              Reviewed by Antti Koivisto.
      
              Do not render the full frame when there is some elements with fixed positioning
              https://bugs.webkit.org/show_bug.cgi?id=33150
      
              Do not render the full frame when there is some elements with fixed positioning
              https://bugs.webkit.org/show_bug.cgi?id=33150
      
              * page/FrameView.cpp:
              (WebCore::FrameView::useSlowRepaints):
              (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
              (WebCore::FrameView::registerFixedPositionedObject):
              (WebCore::FrameView::unregisterFixedPositionedObject):
              (WebCore::FrameView::scrollContentsFastPath):
              * page/FrameView.h:
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::scrollContents):
              (WebCore::ScrollView::scrollContentsFastPath):
              * platform/ScrollView.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::styleWillChange):
              (WebCore::RenderObject::destroy):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53797 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0035fbd8
    • eric@webkit.org's avatar
      2010-01-25 Chris Jerdonek <cjerdonek@webkit.org> · 62304ffe
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Improved prepare-ChangeLog so that it preserves the relative
              indentation of a git commit message.
      
              https://bugs.webkit.org/show_bug.cgi?id=34058
      
              * Scripts/prepare-ChangeLog:
                - Also adjusted the script so that it does not add white
                  space characters to empty lines.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53796 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      62304ffe
    • pfeldman@chromium.org's avatar
      2010-01-24 Pavel Feldman <pfeldman@chromium.org> · d6b791db
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
      
              https://bugs.webkit.org/show_bug.cgi?id=33904
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/SourceFrame2.js:
              (WebInspector.SourceFrame2):
              (WebInspector.SourceFrame2.prototype.addMessage):
              (WebInspector.SourceFrame2.prototype.clearMessages):
              (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount):
              (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource):
              (WebInspector.SourceFrame2.prototype._addMessageToSource):
              (WebInspector.SourceFrame2.prototype.resize):
              * inspector/front-end/TextEditor.js:
              (WebInspector.TextEditor):
              (WebInspector.TextEditor.prototype.setDivDecoration):
              (WebInspector.TextEditor.prototype._lineHeight):
              (WebInspector.TextEditor.prototype._highlightChanged):
              (WebInspector.TextEditor.prototype.packAndRepaintAll):
              (WebInspector.TextEditor.prototype._updateSize):
              (WebInspector.TextEditor.prototype._repaintAll):
              (WebInspector.TextEditor.prototype._paint):
              (WebInspector.TextEditor.prototype._paintLinesContinuation):
              (WebInspector.TextEditor.prototype._mouseOut):
              (WebInspector.TextEditor.prototype._updateDivDecorations):
              (WebInspector.TextEditor.prototype._positionDivDecoration):
              (WebInspector.TextEditor.prototype._paintSelection):
              (WebInspector.TextEditor.prototype._replaceSelectionWith):
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.html:
              * inspector/front-end/textEditor.css: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53795 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d6b791db
    • pfeldman@chromium.org's avatar
      2010-01-24 Pavel Feldman <pfeldman@chromium.org> · dc7fa5c3
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Replace split pane with tabbed pane in resource
              contents view.
      
              https://bugs.webkit.org/show_bug.cgi?id=32453
      
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView):
              (WebInspector.ResourceView.prototype.attach):
              (WebInspector.ResourceView.prototype.show):
              (WebInspector.ResourceView.prototype._selectTab):
              (WebInspector.ResourceView.prototype._selectHeadersTab):
              (WebInspector.ResourceView.prototype._selectContentTab):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.show):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53794 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dc7fa5c3
    • rolandsteiner@chromium.org's avatar
      build fix: rubber-stamped by Eric Seidel. · a38c841b
      rolandsteiner@chromium.org authored
      Fix expected baselines for ruby layout tests on Windows.
      
      * platform/win/fast/ruby/ruby-empty-rt-expected.txt:
      * platform/win/fast/ruby/ruby-length-expected.txt:
      * platform/win/fast/ruby/ruby-run-break-expected.txt:
      * platform/win/fast/ruby/ruby-runs-expected.txt:
      * platform/win/fast/ruby/ruby-runs-spans-expected.txt:
      * platform/win/fast/ruby/ruby-simple-expected.txt:
      * platform/win/fast/ruby/ruby-simple-rp-expected.txt:
      * platform/win/fast/ruby/ruby-trailing-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
      * platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
      * platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53793 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a38c841b
    • eric.carlson@apple.com's avatar
      2010-01-24 Eric Carlson <eric.carlson@apple.com> · b1caeb4d
      eric.carlson@apple.com authored
              Reviewed by Dan Bernstein.
      
              Media element duration changes to zero after playing in reverse
              https://bugs.webkit.org/show_bug.cgi?id=34041
      
              Test: media/video-reverse-play-duration.html
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when 
              playing in reverse, so don't reset duration in that case.
      
      2010-01-24  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Media element duration changes to zero after playing in reverse
              https://bugs.webkit.org/show_bug.cgi?id=34041
      
              * media/video-reverse-play-duration-expected.txt: Added.
              * media/video-reverse-play-duration.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53792 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b1caeb4d
    • rolandsteiner@chromium.org's avatar
      Bug 28420 - Re-enable ruby Windows layout tests · b5df1379
      rolandsteiner@chromium.org authored
      (https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5b)
      
      Reviewed by Maciej Stachowiak.
      
      After creating new Latin-character-only layout tests for ruby
      (https://bugs.webkit.org/show_bug.cgi?id=31865) and resolving the issue
      that caused layout tests to fail then due to the addition of the ruby
      layout tests (cf. https://bugs.webkit.org/show_bug.cgi?id=31200, problem
      not actually caused by ruby), the ruby layout tests should als be
      un-skipped for the Windows platform.
      
      * platform/win/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53791 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b5df1379