GitLab

Update: The server has started sending updates to Google Chrome builds for all supported lists. See: http://b/33182208

BUG=543161

Review-Url: https://codereview.chromium.org/2536913002
Cr-Commit-Position: refs/heads/master@{#435673}

The map lookup was added by http://crrev.com/434349, but caused a
5-10% regression in CalcDrawPropsTests cc_perftests. This CL sets
the effect tree index on the surface during the surface update step
(when EffectNode::render_surface gets updated).

BUG=670074
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2540333002
Cr-Commit-Position: refs/heads/master@{#435672}

Remove bad Mac10.10 baseline for svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg.

Originally landed in: https://codereview.chromium.org/2538943002

The platform/mac/ baseline is correct (matches the actual result on the bot), so deleting this file should suffice.

TBR=liyuqian@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2542843005
Cr-Commit-Position: refs/heads/master@{#435671}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/228237cf..d7fb769f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2540383004
Cr-Commit-Position: refs/heads/master@{#435670}

The setExperimentalOptions() method is considered to be an experimental. Its behavior may change in the future. For that reason, it is moved to ExperimentalCronetEngine.Builder instead of being in CronetEngine.Builder.

BUG=629299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2541593002
Cr-Commit-Position: refs/heads/master@{#435669}

Mark http/tests/media/video-buffered-range-contains-currentTime.html as [ Failure Timeout ] on Mac10.9.

Sometimes it doesn't time out, and fails like on other platforms.
Expand the expectation to allow either outcome.

BUG=646644
TBR=rockot@chromium.org,liberato@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2549603002
Cr-Commit-Position: refs/heads/master@{#435668}

This is cleaner than using
ChromePermissionMessageRule::PermissionIDSetInitializer (and resolves
TODO associated with said class).

Also, avoids "Single-parameter constructors should be marked explicit."
presubmit warning when changing chrome_permission_message_rules.cc file.

BUG=None

Review-Url: https://codereview.chromium.org/2540613003
Cr-Commit-Position: refs/heads/master@{#435667}

BUG=655247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2539163003
Cr-Commit-Position: refs/heads/master@{#435666}

Mark virtual/mojo-loading/http/tests/xmlhttprequest/workers/shared-worker-response-type-blob-sync.html as flaky timeout.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fmojo-loading%2Fhttp%2Ftests%2Fxmlhttprequest%2Fworkers%2Fshared-worker-response-type-blob-sync.html&testType=webkit_tests

BUG=659917
TBR=yhirano@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2548563002
Cr-Commit-Position: refs/heads/master@{#435665}

This allows the Browser Task Scheduler to initialize during
CreateThreads since SetupMetrics() ultimately requires use of the
blocking pool. The blocking pool has to be redirected by the Browser
Task Scheduler before this point

BUG=662052

Review-Url: https://codereview.chromium.org/2514373003
Cr-Commit-Position: refs/heads/master@{#435664}

The CL crrev.com/2480353006 introduced a bug by not changing focus on gesture
generated context menus. This CL adds back the logic changing focus logic.

BUG=668034

Review-Url: https://codereview.chromium.org/2544653002
Cr-Commit-Position: refs/heads/master@{#435663}

When Contextual Cards integration is enabled we now check for server
diagnostic data in the response and output it to the log when on a
debug build.

BUG=644934

Review-Url: https://codereview.chromium.org/2542813002
Cr-Commit-Position: refs/heads/master@{#435662}

This CL lands server changes 140349928 by alyssar and 140661724 by bnc.

BUG=624095, 488484

Review-Url: https://codereview.chromium.org/2544813002
Cr-Commit-Position: refs/heads/master@{#435661}

Tab switcher sometimes hides one tab stack incorrectly if sufficient
time has not elapsed between creating a new tab and tapping on tab
switcher. Cancelling the unfinished animation before starting a new
animation fixes this bug.

BUG=571364

Review-Url: https://codereview.chromium.org/2546603002
Cr-Commit-Position: refs/heads/master@{#435660}

- Fixed the animation so that the toolbar animates in when it's locked
by an object

BUG=659752

Review-Url: https://codereview.chromium.org/2542803002
Cr-Commit-Position: refs/heads/master@{#435659}

Ash has not shipped on Windows for years so we're removing support.

BUG=666775
TEST=bots

Review-Url: https://codereview.chromium.org/2546783003
Cr-Commit-Position: refs/heads/master@{#435658}

In preparation of moving Task Scheduler initialization to the content
CreateThreads phase, metrics has to be initialized during
PreMainMessageLoopRun.

The only reference to metrics during PreCreateThreads was in the
IO Thread state initialization to set up a IO thread to UI thread
forwarder that reported network connection state (e.g. cellular or not).

This change moves that initialization to be called on demand as the
callback is not needed until the first network URL request is satisfied.
This happens after CreateThreads and generally after PreMainMessageLoopRun.

BUG=662052

Review-Url: https://codereview.chromium.org/2517363002
Cr-Commit-Position: refs/heads/master@{#435657}

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212

Review-Url: https://codereview.chromium.org/2540263003
Cr-Commit-Position: refs/heads/master@{#435656}

It's common to add --mash to the /etc/chrome_dev.conf when working on a
Chrome OS device. However, that can lead to two copies of --mash if you run
an autotest on the device that also passes --mash. This makes Chrome crash.

Ignore duplicate --mash flags.

BUG=669705
TEST=Run chrome --mash --mash, doesn't crash.

Review-Url: https://codereview.chromium.org/2545633002
Cr-Commit-Position: refs/heads/master@{#435655}

BUG=582315

Review-Url: https://codereview.chromium.org/2256913002
Cr-Commit-Position: refs/heads/master@{#435654}

Some useful subresources could be fetched by webpages via XMLHttpRequest. This
CL adds support of this type of requests to ResourcePrefetchPredictor.

BUG=631966

Review-Url: https://codereview.chromium.org/2539263004
Cr-Commit-Position: refs/heads/master@{#435653}

Skip DevToolsPixelOutputTests.TestLatencyInfoInstrumentation in site_per_process_browser_tests due to flakiness.

Doesn't seem similarly flaky on browser_tests, but further investigation is needed.

BUG=670362
TBR=lukasza@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2538923004
Cr-Commit-Position: refs/heads/master@{#435652}

Due to third-party modifications, some devices access the disk in
Context#bindService(). This call is supposed to be safe to make from
the UI thread, so suppress the StrictMode violation.

BUG=670195

Review-Url: https://codereview.chromium.org/2549473002
Cr-Commit-Position: refs/heads/master@{#435651}

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2542653002
Cr-Commit-Position: refs/heads/master@{#435650}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/852f85163d54..da3aa694af97

$ git log 852f85163..da3aa694a --date=short --no-merges --format='%ad %ae %s'
2016-12-01 simonhatch Dashboard - Also check for "staging_win" when modifying non-telemetry commands.

BUG=668529

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2546653004
Cr-Commit-Position: refs/heads/master@{#435649}

You can now run an alternative window manager from mash_session, mash_init etc by passing --window-manager=<name_of_wm>

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2511233002
Cr-Commit-Position: refs/heads/master@{#435648}

Remove WebContentsObserver from CastMediaBlocker.

BUG=660331

Review-Url: https://codereview.chromium.org/2535343003
Cr-Commit-Position: refs/heads/master@{#435647}

This reverts commit fe899c8e.

BUG=669797
TBR=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2541843005
Cr-Commit-Position: refs/heads/master@{#435646}

Revert of Roll src/third_party/skia/ 71b762f2a..1c038af27 (3 commits). (patchset #1 id:1 of https://codereview.chromium.org/2542133002/ )

Reason for revert:
speculative revert to fix
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/27239

Original issue's description:
> Roll src/third_party/skia/ 71b762f2a..1c038af27 (3 commits).
>
> https://skia.googlesource.com/skia.git/+log/71b762f2aca1..1c038af278a6
>
> $ git log 71b762f2a..1c038af27 --date=short --no-merges --format='%ad %ae %s'
> 2016-12-01 reed Revert "Revert "remove (empty) SkXfermode.h""
> 2016-12-01 halcanary No SkEncodeImageAsKTX for ANDROID_FRAMEWORK
> 2016-11-30 msarett SkColorSpaceXform bug fixes
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> TBR=brianosman@google.com
>
> Committed: https://crrev.com/749c5466102850a151448c59d99be6cffffc0bf5
> Cr-Commit-Position: refs/heads/master@{#435626}

TBR=brianosman@google.com,skia-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670347

Review-Url: https://codereview.chromium.org/2537303006
Cr-Commit-Position: refs/heads/master@{#435645}

"Just ignore popstate events. I got this." - route.js

R=tommycli@chromium.org
BUG=668004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2538393002
Cr-Commit-Position: refs/heads/master@{#435644}

A recent metrics fix (r432864) also mistakenly broke this code by not
passing in a default argument. This CL fixes that problem and adds an
expectation in unit tests.

BUG=662999,596676

Review-Url: https://codereview.chromium.org/2544583003
Cr-Commit-Position: refs/heads/master@{#435643}

https://pdfium.googlesource.com/pdfium.git/+log/c62980ec7539..02759102cf99

$ git log c62980ec7..02759102c --date=short --no-merges --format='%ad %ae %s'
2016-12-01 tsepez Protect against unexpected library create/destroy

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2542803003
Cr-Commit-Position: refs/heads/master@{#435642}

Add ArcAppDialogView for arc app uninstall confirmation. Add Test coverage.

BUG=661076
Test=Add browsertest. Tests passed.
Test=Manual Test.

Review-Url: https://codereview.chromium.org/2529783002
Cr-Commit-Position: refs/heads/master@{#435641}

CastGinRunner is now owned by the gin::PerContextData associated
with a content::RenderFrame. Do not rely on RenderFrameObserver
notifications to manager it's lifetime. Instead, this class will
be deleted when gin::PerContextData is destroyed.

BUG=internal b/32916396

R=slan@chromium.org,alokp@chromium.org

Review-Url: https://codereview.chromium.org/2535313004
Cr-Commit-Position: refs/heads/master@{#435640}

Chrome stores those information in SharedPreferences for all downloads now.
So there is no need to keep those extra fields.

BUG=669702

Review-Url: https://codereview.chromium.org/2544633003
Cr-Commit-Position: refs/heads/master@{#435639}

It used to be exiting the move loop and clearing the move_loop_widget_ before
EndDrag() had a chance to set the window position to manageable again.

This CL adds a maximized browser window waiter, and moves setting the window
position managed logic to ash.

BUG=626761, 331924
TEST=interactive_ui_tests --gtest_filter=TabDragging*

Review-Url: https://codereview.chromium.org/2494713003
Cr-Commit-Position: refs/heads/master@{#435638}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/403eccb0..228237cf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2544003002
Cr-Commit-Position: refs/heads/master@{#435637}

Just a refactor, no changed behavior or new tests.

This is a follow-up on crrev.com/2468233002 (Pull up
clearCacheExceptFrame impl. to ImageDecoder), after a behavior change
for WebP's cache clearing has landed in crrev.com/2499633002 (Always
preserve provided frame in WebP::clearCacheExceptFrame).

Pull up the implementation of clearCacheExceptFrame in WEBPImageDecoder and
GIFImageDecoder to ImageDecoder. This increases code reuse, especially since
PNGImageDecoder can use it for the Animated PNG implementation as well. Child
classes of ImageDecoder only need to override clearFrameBuffer() and / or
frameStatusIsSufficientForSuccessors(), if necessary.

The baseline idea of the implementation is that the provided frame is
always preserved, and that there are two cases in which a previous
frame is also preserved:

1. The provided frame is not yet sufficiently decoded to decode subsequent
frames, as indicated by frameStatusIsSufficientForSuccessors(). We need
to keep the required previous frame to sufficiently decode the provided
frame first.
2. The disposal method of the provided frame is DisposeOverwritePrevious. In
this case, we need to keep the required previous frame in cache to
prevent re-decoding that frame when the provided frame is disposed.

WebP does not know DisposeOverwritePrevious, so the new implementation
is effectively equivalent to the original method, because
frameStatusIsSufficientForSuccessors returns true iff the status is
FrameComplete.

Gif's original implementation is somewhat different, in the sense that
the roles of |clearExceptFrame| and |clearExceptFrame2| are
interchanged. Now, |clearExpectFrame| is always kept and
|clearExceptFrame2| contains any required previous frame. The resulting
behavior is not changed, though, given the following case analysis:

- The provided frame is FrameEmpty. The old implementation would only
  keep the nearest non-empty frame in cache, since the first block is a
  no-op due to the != FrameEmpty condition, and the second block would
  search for the nearest non-empty frame in cache.

  The new patch sets |clearExceptFrame2| to the required previous frame,
  since !frameStatusIsSufficientForSuccessors evaluates to true. The
  second block will find the nearest non-empty frame in cache.
  |clearExceptFrame| is also passed to clearCacheExceptTwoFrames, but
  is ignored since that method checks for FrameEmpty frames.

- The provided frame is FrameComplete or FramePartial, and the disposal
  method is DisposeOverwritePrevious. In the old implementation this
  results in |clearExceptFrame| being set to the required previous
  frame in the first block, and |clearExceptFrame2| is set to the
  provided frame. The second block searches for the nearest non-empty
  frame, starting at |clearExceptFrame|.

  The new implementation stores the required previous frame in
  |clearExceptFrame2| because of the disposal method, and similarly
  searches for the nearest non-empty frame in the second block.

- The provided frame is FrameComplete or FramePartial, and the disposal
  method is *not* DisposeOverwritePrevious. In this case, the old
  implementation only preserves the provided frame since the first block
  is a no-op due to the disposal condition, and the second block is a
  no-op as well since the frames' status is not FrameEmpty.

  The new implementation does not set |clearExceptFrame2| because of the
  disposal condition in the first block, and thus only preserves the
  provided frame.

Review-Url: https://codereview.chromium.org/2516593003
Cr-Commit-Position: refs/heads/master@{#435636}

Rationale:
Current safe browsing code lives in the chrome/ layer, but we
want to make it available in WebView as well (at least the
relevant parts of it). Hence this effort of making a safe
browsing component.

In this patch:
- move IPCs (spellcheck_messages) + add dedicated generator
- isolate and move safe browsing specific constants
- isolate and move safe browsing specific switches
- remove a few unused includes

Note:
To reduce the number of components and keep everything
related in one place the idea is to move the code currently
living in components/safe_browsing_db/ to this safe_browsing/
component in the future.

BUG=488675
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2450993003
Cr-Commit-Position: refs/heads/master@{#435635}

We have already supported globalCompositeOperation, but globalAlpha is
not exposed yet.

This CL expose this attributes. Similar to the globalCompositeOperation,
the implementation is already there, we just need to expose it in the
.idl file.

The layout test is copied from fast/canvas/2d.composite.globalAlpha.fillPath.html,
with very small tweak.

BUG=659260

Review-Url: https://codereview.chromium.org/2526693003
Cr-Commit-Position: refs/heads/master@{#435634}